GitLab

BUG=100276
R=thestig@chromium.org

Review URL: http://codereview.chromium.org/8551002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110185 0039d316-1c4b-4281-b951-d872f2087c98

Linux directory detection is now done in the driver instead of in the frontend, so let the plugin test script invoke the driver instead of clang -cc1 (else it won't find <string> etc on linux).

Previous attempt at http://codereview.chromium.org/8538027/

BUG=104323
TEST=none
TBR=hans


Review URL: http://codereview.chromium.org/8572021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110184 0039d316-1c4b-4281-b951-d872f2087c98

   
This failure path has not received a lot of testing until now.  Here are
the issues addressed by this patch:
    
- We usually check the return value of step() calls.  However, we do not
check the return value of prepare() calls, which are more likely to fail.
If they do fail, we will DCHECK() or go on to dereference an invalid
pointer in step().  This patch checks the return value of one particular
prepare statement, the one in CheckIntegrity().
    
- Disable DCHECKs on sqlite errors, DirectoryManager open failure,
and SyncManager initialization failure.  This will allow us to test these
error paths.
    
- Be careful in ShutdownOnSyncThread().  The directory will not be fully
intialized during shutdown if the database load failed.

- Add a ProfileSyncService unit test that simulates a load from an
unreadable database.  The harness had to be modified slightly to make
this possible.

- Remove a setup_for_test_mode_ flag in SyncManager::SyncInternal::Init.
I don't know what the original intent of this flag was.  However, I do
know that it prevents me from properly simulating a database load failure
and removing it seems to have no ill effects.

- Do not delete the database from DirectoryBackingStore.  If this code
were to get executed it would put us into an inconsistent state.  See
issue 103824.  However, it's unlikely this code would get executed.  If
the database were actually corrupt, we would DCHECK or de-reference an
invalid pointer on our way to this code because we don't check the
return value of the attempt to prepare an SQL statement in
DirectoryBackingStore::CheckIntegrity().
    
- Modify the DirectoryBackingStoreTest.Corruption unit test to expect the
new behaviour.

- Disable sync when backend initialize fails.  Such a failure could
be due to bad local state.  We don't know the actual cause because the
information is not available from the ProfileSyncService callback.  The
safe course of action is to clear our local sync state and try again
later.  It's the easiest way to get back to the most well travelled sync
initialization path.

BUG=103307, 103824
TEST=DirectoryBackingStoreTest.Corruption, ProfileSyncServiceTest.CorruptDatabase

Review URL: http://codereview.chromium.org/8496002

TBR=rlarocque@chromium.org
Review URL: http://codereview.chromium.org/8570016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110182 0039d316-1c4b-4281-b951-d872f2087c98

r=rvargas
bug=102940
Review URL: http://codereview.chromium.org/8487004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110181 0039d316-1c4b-4281-b951-d872f2087c98

Initialization of the profiler is supposed to happen while
single threaded.  The tests however often skip affirmative
initialization, and rely on lazy initialization.  This
CL tightens up that process, to reduce changes of races
(even benign races) during testing.

I also added a suppression for examination of the state,
which is always a benign race.  At initialization time
we rely on a lock (now) to ensure race freedom (if we
get a racy value of state).

r=rtenneti
Review URL: http://codereview.chromium.org/8570007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110180 0039d316-1c4b-4281-b951-d872f2087c98

This solves the problem when chrome.windows.create() is used to create a panel with a tabid. Panel was watching for NOTIFICATION_TAB_ADDED, which is only sent upon browser navigation. As there is no navigation when existing tab contents are used, the Panel does not set up auto-resize in this scenario.

BUG=None
TEST=PanelBrowserTest.CreateWithExistingContents

Review URL: http://codereview.chromium.org/8539025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110179 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/8571015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110178 0039d316-1c4b-4281-b951-d872f2087c98

   
This failure path has not received a lot of testing until now.  Here are
the issues addressed by this patch:
    
- We usually check the return value of step() calls.  However, we do not
check the return value of prepare() calls, which are more likely to fail.
If they do fail, we will DCHECK() or go on to dereference an invalid
pointer in step().  This patch checks the return value of one particular
prepare statement, the one in CheckIntegrity().
    
- Disable DCHECKs on sqlite errors, DirectoryManager open failure,
and SyncManager initialization failure.  This will allow us to test these
error paths.
    
- Be careful in ShutdownOnSyncThread().  The directory will not be fully
intialized during shutdown if the database load failed.

- Add a ProfileSyncService unit test that simulates a load from an
unreadable database.  The harness had to be modified slightly to make
this possible.

- Remove a setup_for_test_mode_ flag in SyncManager::SyncInternal::Init.
I don't know what the original intent of this flag was.  However, I do
know that it prevents me from properly simulating a database load failure
and removing it seems to have no ill effects.

- Do not delete the database from DirectoryBackingStore.  If this code
were to get executed it would put us into an inconsistent state.  See
issue 103824.  However, it's unlikely this code would get executed.  If
the database were actually corrupt, we would DCHECK or de-reference an
invalid pointer on our way to this code because we don't check the
return value of the attempt to prepare an SQL statement in
DirectoryBackingStore::CheckIntegrity().
    
- Modify the DirectoryBackingStoreTest.Corruption unit test to expect the
new behaviour.

- Disable sync when backend initialize fails.  Such a failure could
be due to bad local state.  We don't know the actual cause because the
information is not available from the ProfileSyncService callback.  The
safe course of action is to clear our local sync state and try again
later.  It's the easiest way to get back to the most well travelled sync
initialization path.

BUG=103307, 103824
TEST=DirectoryBackingStoreTest.Corruption, ProfileSyncServiceTest.CorruptDatabase

Review URL: http://codereview.chromium.org/8496002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110177 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=tfarina@chromium.org

Review URL: http://codereview.chromium.org/8570013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110176 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8523008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110175 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://bugs.webkit.org/show_bug.cgi?id=72188

I've refactored backer's swizzle/flip code as it was needed by compositor_cc as well as compositor_gl.

BUG=None
TEST=compositor_unittests

Review URL: http://codereview.chromium.org/8463024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110174 0039d316-1c4b-4281-b951-d872f2087c98

These updates keep CF casts between CFTypeRef and specific CoreFoundation types consistent across the project.

BUG=104200

Review URL: http://codereview.chromium.org/8528013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110173 0039d316-1c4b-4281-b951-d872f2087c98

The leaks were fixed in crrev.com/110013
The user-after-free was fixed in crrev.com/109815

TEST=valgrind won't report errors
BUG=104029


Review URL: http://codereview.chromium.org/8571012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110171 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles

R=eroman


Review URL: http://codereview.chromium.org/8572018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110168 0039d316-1c4b-4281-b951-d872f2087c98

This change updates strings used by the Spelling UI and moves the local suggestion above the one from the Spelling service.

BUG=103840
TEST=right click on a misspelled word.

Review URL: http://codereview.chromium.org/8463008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110167 0039d316-1c4b-4281-b951-d872f2087c98

Also a harder one of a CancelableTask timeout task, which was replaced
with a callback-owned flag.


Review URL: http://codereview.chromium.org/8548003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110166 0039d316-1c4b-4281-b951-d872f2087c98

This will drop the frequency of update error 6 (SYSTEM_LEVEL_INSTALL_EXISTS). There's no good reason to block updates in this case, only new installs.

BUG=103374
TEST=Install user-level Chrome, Install system-level Chrome, Update the user-level Chrome. Expect the update to succeed.


Review URL: http://codereview.chromium.org/8570006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110165 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles and tests pass.

Review URL: http://codereview.chromium.org/8556001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110164 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

R=csilv@chromium.org

Review URL: http://codereview.chromium.org/8553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110163 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104039
R=ben@chromium.org

Review URL: http://codereview.chromium.org/8572016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110162 0039d316-1c4b-4281-b951-d872f2087c98

GlobalErrorBubble.xib Changes: Hooked up the new layoutTweaker_ and buttonContainer_ outlet. Made the GTMWidthBasedTweaker slightly wider so that if the bubble was expanded there would be some extra padding on the left side.

BUG=100854
TEST=Hard coded some long titles for the accept and cancel buttons. Verified that they were no longer clipped. Hard coded short titles and verified that the buttons looked the same as before.


Review URL: http://codereview.chromium.org/8447014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110161 0039d316-1c4b-4281-b951-d872f2087c98

Hopefully you agree that this makes the code a whole lot easier to understand.

BUG=None
TEST=net_unittests


Review URL: http://codereview.chromium.org/8515020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110159 0039d316-1c4b-4281-b951-d872f2087c98

Fixes GetContainerBounds in tab_contents_view_mac.mm to return the position of the view in screen coordinates.

Currently GetContainerBounds would return origin of (0,0) which is inconsistent with GTK and Windows implementation.

BUG=104178

Review URL: http://codereview.chromium.org/8491062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110157 0039d316-1c4b-4281-b951-d872f2087c98

I couldn't figure out a test. The fix makes Panel NSWindow non-opaque, which makes the GL surface behind it visible through 'transparent black hole' that AcceleratedPluginView is cutting for the plugin's redering.

BUG=103303


Review URL: http://codereview.chromium.org/8491063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110156 0039d316-1c4b-4281-b951-d872f2087c98

linux-release bot has gone wacky after a hard drive problem, re-setting expectations for the time being

page_cycler_morejs PERF_REGRESS: times/t:
http://build.chromium.org/f/chromium/perf/linux-release/morejs/report.html?history=150&rev=110120

page_cycler_intl2 PERF_IMPROVE: times/t:
http://build.chromium.org/f/chromium/perf/linux-release/intl2/report.html?history=150&rev=110120

BUG=none
TBR=cmp@chromium.org
Review URL: http://codereview.chromium.org/8574014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110155 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98323,51704
TEST=None


Review URL: http://codereview.chromium.org/8265005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110154 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=this is
Review URL: http://codereview.chromium.org/8564036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110153 0039d316-1c4b-4281-b951-d872f2087c98

This should speed up the certificate extraction significantly.

BUG=102540
TEST=SignatureUtilWinTest.* pass


Review URL: http://codereview.chromium.org/8528043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110151 0039d316-1c4b-4281-b951-d872f2087c98

Bug 99270: Panels: Changing themes sometimes causes title text to become invisible
The fix is to get the title text when we create the title label because PanelBrowserFrameView will be recreated when the theme is changed.

Bug 102730: Panels on Win: Need an explanatory comment in NativePanelTestingWin::DragTitlebar()
Changed the dragging code to use screen's coordinate system to improve code readability and updated the comments.

Bug 102742: Handle closing the Panel by extension while the settings menu is active
Updated the comments.

BUG=99270,102730,102742
TEST=existing tests

Review URL: http://codereview.chromium.org/8539035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110148 0039d316-1c4b-4281-b951-d872f2087c98

:hover rules were more specific than :active rules, so I had to add :not(:active)

also, removed padding-before and after (no idea what that was intended to do but it made the checkmark jiggle around)

BUG=103688
TEST=manual

Review URL: http://codereview.chromium.org/8510078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110146 0039d316-1c4b-4281-b951-d872f2087c98

When a page has an unload handler and we swap it out to make way for a Prerendered tab, we expect a call to the TabContentsDelegate when it closes. For cross-site navigations, we don't get that message as the RenderViewHost is swapped instead of closing.

BUG=103966
TEST=Enable prerender from omnibox (and ensure it's not disabled by field trial) and repeatedly navigate between cnn.com and telegraph.co.uk in the Omnibox. Note in the TaskManager that you do not see zombie Tab processes.


Review URL: http://codereview.chromium.org/8539027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110145 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110144 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70652
R=willchan
TEST=network unittests, browser unit tests

Review URL: http://codereview.chromium.org/8423028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110143 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r7145: (mseaborn) ARM: Remove inline assembly hack for overriding the -march setting
r7146: (mseaborn) Scons: Split up run_dynamic_load_test
r7147: (jvoung) Remove dangling reference to BINUTILS_SB_MODE (affects incremental build).
r7148: (jvoung) Add option to command tester for running a test multiple times. Use that
r7149: (jvoung) Remove a few more references to llvm-gcc from the driver.
r7150: (robertm) Some improvements found while setting the TC up with sehr.
r7151: (robertm) roll tools deps to pull in a new qemu tarball
r7152: (robertm) Conditionally disabled one more ARM tests which will start failing when
r7153: (robertm) More changes to new arm trusted TC script:
r7154: (chrome-admin) Update .DEPS.git
r7155: (sehr) Wrap IRT entries by shims for pnacl ABI conformance.
r7156: (mcgrathr) Maximize RLIMIT_AS limit before allocating address space
r7157: (jasonwkim) First step to get PNaCl toolchain compiling for CrOS
r7158: (pdox) * Split nacl_startup.bc into crti (_init/_fini, bitcode) and crtbegin/crtend (EH initialization, native code).

BUG=none
TEST=nacl_integration

Review URL: http://codereview.chromium.org/8528040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110142 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8537003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110141 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101774
TEST=NONE


Review URL: http://codereview.chromium.org/8564015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110140 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8565023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110139 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104203
TEST=compare 'Entries' count on about:sync to number of SyncThread>SyncThread Notify tasks in tracker2/profiler.  The entries count should be much smaller.


Review URL: http://codereview.chromium.org/8533024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110138 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104272

Review URL: http://codereview.chromium.org/8555032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110137 0039d316-1c4b-4281-b951-d872f2087c98

This changes the NaCl startup dance so that the IRT file is opened
just once at browser startup.  That file descriptor is kept around and
passed repeatedly to each NaCl process launched.  This ensures that
when autoupdate replaces the file on disk with a new version, we
continue to use the original file that corresponds to the old browser
version that's still running.

We also eliminate the cases for not having an IRT file, which is now a
hard error (i.e. prevents NaCl launches).  It's been a hard
requirement for NaCl that the IRT be available since Chromium 14.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=1772
TEST= hand-tested in Chromium build on Linux, Mac, and Windows

R=brettw@chromium.org

Review URL: http://codereview.chromium.org/8397001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110136 0039d316-1c4b-4281-b951-d872f2087c98