GitLab

This is a reland of 236542 and 238454 (runs GN in GYP mode before actually running GYP), plus some additions

Move GYP_DEFINES parsing to Python for GN.

I pass in a GN-compatible list of variable sets on the command line from Python. This allows us to parse chromium.gyp_env and src/*/supplemental.gypi in Python like normal without having to duplicate Python dictionary parsing in GN.

Currently, GN does not produce any files used by the build, these will be added in a second step.

BUG=321352
TBR=bradnelson@google.com

Review URL: https://codereview.chromium.org/101573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238475 0039d316-1c4b-4281-b951-d872f2087c98

The shell is now run on the main (UI) thread along with the NativeViewport stuff.

R=abarth@chromium.org
http://crbug.com/324637

Review URL: https://codereview.chromium.org/100623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238474 0039d316-1c4b-4281-b951-d872f2087c98

Reason: Candidate for Mac 10.6 and 10.7 Break - IOSurfaceReuse

> cc: Defer first OutputSurface creation until client is ready
> 
> Remove the |first_output_surface| which was not used before
> the client signals ready.
> This allows the client to wait before creating a graphics context
> until the gpu thread and client channel are set up.
> 
> BUG=270179
> R=danakj@chromium.org, jamesr@chromium.org, jochen@chromium.org
> 
> Review URL: https://codereview.chromium.org/85693007

TBR=sievers@chromium.org

Review URL: https://codereview.chromium.org/103163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238470 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314791
TEST=No behavior change.
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/101863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238468 0039d316-1c4b-4281-b951-d872f2087c98

TESTS=Please follow steps as outlined in the bug report.
R=cpu@chromium.org, ananta@chromium.org
BUG=318503

Review URL: https://codereview.chromium.org/102403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238467 0039d316-1c4b-4281-b951-d872f2087c98

The change was reverted because swarming didn't work with branded builds,
but r238430 should've fixed that. Relanding. (There are no branded trybots.)

> Revert 238025 "Let test_isolation_mode default to check on mac."
> 
> Failing on "Google Chrome Mac" (http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/15042)
> In the error log, tools/swarming_client/isolate.py says "File /Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/out/Release/Chromium Framework.framework doesn't exist"
> 
> > Let test_isolation_mode default to check on mac.
> > 
> > It was set to noop in https://chromiumcodereview.appspot.com/14055005 due to
> > issues with xcode. Now that xcode is no longer used, it can be set to check
> > again.
> > 
> > BUG=none
> > 
> > Review URL: https://codereview.chromium.org/92303002
> 
> TBR=thakis@chromium.org
> 
> Review URL: https://codereview.chromium.org/98383002

TBR=hashimoto@chromium.org

Review URL: https://codereview.chromium.org/102963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238466 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/102843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238465 0039d316-1c4b-4281-b951-d872f2087c98

Previously the tests were using actual media sources. This change makes
the test more reliable as they no longer depend on system resources.
Also FakeDesktopMediaList has been moved from
desktop_media_picker_controller_unittest.mm to a separate file so it can
be reused

R=mpcomplete@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/100303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238463 0039d316-1c4b-4281-b951-d872f2087c98

The current code posts the events via the Aura code path which does not work on Windows with the glass theme for the system
menu buttons (Min/Max/Restore). These are part of the non client area of the Window and rely on the WM_NCLBUTTONDOWN message
to be defproced which eventually posts a WM_SYSCOMMAND message for the corresponding operation.

Fix is to check if the NativeWindow doing a repost is in the Metro environment for Windows. If yes we continue the current logic
of reposting the events via Aura. If not we post the message natively. The RepostLocatedEvent function internally calls
the RepostLocatedEventWin function to post the function natively. The functionality to check if a window is in metro
has been added to the ViewsDelegate interface and is implemented by Chrome.

Fixes bug https://code.google.com/p/chromium/issues/detail?id=323105

BUG=323105
R=sky@chromium.org

Review URL: https://codereview.chromium.org/100303005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238462 0039d316-1c4b-4281-b951-d872f2087c98

This is to help debuf issues since it will have proper stack traces.

BUG=

Review URL: https://codereview.chromium.org/102373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238461 0039d316-1c4b-4281-b951-d872f2087c98

R=agl@chromium.org
BUG=315828
TEST=none

Review URL: https://codereview.chromium.org/99253006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238460 0039d316-1c4b-4281-b951-d872f2087c98

> Hook up GN to the GYP build system.
> 
> This is a reland of 236542 (runs GN in GYP mode before actually running GYP), plus some additions
> 
> Move GYP_DEFINES parsing to Python for GN.
> 
> I pass in a GN-compatible list of variable sets on the command line from Python. This allows us to parse chromium.gyp_env and src/*/supplemental.gypi in Python like normal without having to duplicate Python dictionary parsing in GN.
> 
> Currently, GN does not produce any files used by the build, these will be added in a second step.
> 
> BUG=321352
> R=bradnelson@google.com
> 
> Review URL: https://codereview.chromium.org/73623005

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/102923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238459 0039d316-1c4b-4281-b951-d872f2087c98

Remove the |first_output_surface| which was not used before
the client signals ready.
This allows the client to wait before creating a graphics context
until the gpu thread and client channel are set up.

BUG=270179
R=danakj@chromium.org, jamesr@chromium.org, jochen@chromium.org

Review URL: https://codereview.chromium.org/85693007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238458 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
BUG=325058
TEST=visual

Review URL: https://codereview.chromium.org/98973004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238457 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
Test=all tests pass.

Review URL: https://codereview.chromium.org/102243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238456 0039d316-1c4b-4281-b951-d872f2087c98

I also added a break below, where it's not needed, for clarity,
and to avoid any future refactoring from introducing a similar bug.

BUG=102485,177475

Review URL: https://codereview.chromium.org/101383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238455 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of 236542 (runs GN in GYP mode before actually running GYP), plus some additions

Move GYP_DEFINES parsing to Python for GN.

I pass in a GN-compatible list of variable sets on the command line from Python. This allows us to parse chromium.gyp_env and src/*/supplemental.gypi in Python like normal without having to duplicate Python dictionary parsing in GN.

Currently, GN does not produce any files used by the build, these will be added in a second step.

BUG=321352
R=bradnelson@google.com

Review URL: https://codereview.chromium.org/73623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238454 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=covered by tests.
R=ben@chromium.org

Review URL: https://codereview.chromium.org/102313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238453 0039d316-1c4b-4281-b951-d872f2087c98

Instead, SequencedWorkerPools should be wrapped in a SequencedWorkerPoolOwner to
avoid leak reports.

BUG=273800
R=ajwong@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/102753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238451 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98892

Review URL: https://codereview.chromium.org/81923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238450 0039d316-1c4b-4281-b951-d872f2087c98

TBR=kinuko

Review URL: https://codereview.chromium.org/102433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238449 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/102593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238447 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/100573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238446 0039d316-1c4b-4281-b951-d872f2087c98

In NativeTextfieldViews, part of text can be selected using touch
scrubbing. After touch scrubbing is finished, touch editing handles
should appear to allow more touch selection manipulation.

BUG=239111

Review URL: https://codereview.chromium.org/93433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238444 0039d316-1c4b-4281-b951-d872f2087c98

Do not allow slashes (\ or /), quotes (" or ') or spaces.

BUG=None
NOTRY=True

Review URL: https://codereview.chromium.org/100623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238443 0039d316-1c4b-4281-b951-d872f2087c98

This reverts https://codereview.chromium.org/101543004/ which was created when
suspected the reason of failure of telemetry tests, but turned out not the real
reason. Reapply.

Reapply the following change:

> Revert "Revert 237280 "Remove TraceController""
>
> This reverts commit 6aa58b85.
>
> Fixed double-close issue when ending recording.
>
> > Revert 237280 "Remove TraceController"
> >
> > Seems to have broken trace-based telemetry benchmarks on android.
> >
> > BUG=323749
> >
> > > Remove TraceController
> > >
> > > TraceController is obsoleted by TracingController.
> > > Changed all remaining clients to use TracingController.
> > >
> > > BUG=none
> > >
> > > Review URL: https://codereview.chromium.org/67683003
> >
> > TBR=wangxianzhu@chromium.org
> >
> > Review URL: https://codereview.chromium.org/89753004
> >
> > git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237452 0039d316-1c4b-4281-b951-d872f2087c98
>
> TBR=wangxianzhu@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238234

TBR=

Review URL: https://codereview.chromium.org/102003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238442 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that a fullscreen RenderWidgetHostViewAura instance does not restore itself on Windows when we switch away to a different
monitor.

We have code in RenderWidgetHostViewAura::OnWindowFocused to handle this case. It does this by comparing the display ids of
the window being activated and the one losing activation. However in desktop Chrome we could lose activation to a non Aura Window.

We handle this case on Windows by getting the cursor position and the display near that and comparing that with the display of the
window losing activation.

Fixes bug https://code.google.com/p/chromium/issues/detail?id=317532

BUG=317532
R=jam@chromium.org, jam

Review URL: https://codereview.chromium.org/100683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238441 0039d316-1c4b-4281-b951-d872f2087c98

R=asvitkine@chromium.org, davidben@chromium.org

Review URL: https://codereview.chromium.org/100133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238440 0039d316-1c4b-4281-b951-d872f2087c98

BUG=318859

Review URL: https://codereview.chromium.org/99913004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238439 0039d316-1c4b-4281-b951-d872f2087c98

Thanks to PVS-Studio for finding this.

BUG=324701

Review URL: https://codereview.chromium.org/99423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238438 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/100103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238437 0039d316-1c4b-4281-b951-d872f2087c98

1. Move WebContentsModalDialog support to ExtensionViewHost, as it is only
used by extension popups.
2. Break reliance on ChromeWebModalDialogManagerDelegate by providing our
own one-line IsWebContentsVisible() implementation.
3. Remove a bunch of OS_ANDROID ifdefs, since Android can use the components
module where web_modal stuff is implemented.

BUG=321341
TEST=browser_tests, esp. DownloadExtensionTest.DownloadExtensionTest_AcceptDanger

Review URL: https://codereview.chromium.org/92743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238436 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/93643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238435 0039d316-1c4b-4281-b951-d872f2087c98

Part of the AppShell extensions system refactor project.

BUG=309909
TEST=browser_tests

Review URL: https://codereview.chromium.org/100653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238431 0039d316-1c4b-4281-b951-d872f2087c98

BUG=324911
NOTRY=true

Review URL: https://codereview.chromium.org/99893005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238430 0039d316-1c4b-4281-b951-d872f2087c98

1) Regular swipe flick (Should type hintText)
2) Long swipe flick (Nothing should display)
3) Composed swipe followed by flick (moveCursor triggered, but no flick)


BUG=324823

Review URL: https://codereview.chromium.org/99923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238429 0039d316-1c4b-4281-b951-d872f2087c98

BUG=157628

Review URL: https://codereview.chromium.org/95693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238428 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/99923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238427 0039d316-1c4b-4281-b951-d872f2087c98

When opting in via GYP_MSVS_USE_SYSTEM_TOOLCHAIN=0, set
environment variables that tell gyp how to find the automatic
toolchain in third_party/win_toolchain.

R=maruel@chromium.org
BUG=323300

Review URL: https://codereview.chromium.org/100613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238426 0039d316-1c4b-4281-b951-d872f2087c98

This sets up (most of) the infrastructure that'll be needed to set up a
PlatformChannel between parent and child processes.

R=darin@chromium.org, darin

Review URL: https://codereview.chromium.org/99473007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238425 0039d316-1c4b-4281-b951-d872f2087c98