- 03 Jul, 2018 40 commits
-
-
Sergey Ulanov authored
Initial implementation of SkFontMgr for Fuchsia that implements minimal SkFontMgr functionality used in Blink. There are still a number of features that don't work properly and will require changes in the system FontProvider to get fixed: 1. Character to font matching (see onMatchFamilyStyleCharacter()). Currently the system API doesn't provide this feature. 2. Style matching according to CSS3: Font style matching rules implemented in Fuchsia's font provider do not match CSS3 rules. 3. Font aliasing: FontProvider supports only 3 Roboto fonts (Roboto, RobotoSlab and RobotoMono) doesn't support any font family aliases. To workaround this issue aliasing implemented directly in FuchsiaFontManager. The new SkFontMgr is not enabled yet because it doesn't work in sandbox. Will enabled it later in a separate CL. Bug: 800156 Change-Id: I98a9bed3f98c492577cc9cf0a81f190c8837da31 Reviewed-on: https://chromium-review.googlesource.com/1114192 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#572360}
-
Ian Clelland authored
The JSON parser was too lenient in accepting whitespace between tokens (allowing any Unicode whitespace characters, not just TAB, CR, LF and Space). Additionally, unescaped ASCII Control characters (0x00 to 0x1f) were allowed inside of strings. This CL fixes both issues, and updates tests accordingly. Change-Id: I71b55a5815f02174a230c900071b4a83b0fc16c5 Reviewed-on: https://chromium-review.googlesource.com/1125035 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#572359}
-
Eric Orth authored
This reverts commit b4426085. Original commit cb8862fc. Patchset 1 is a clean revert of the revert with all changes in subsequent patchsets. Only change from original is to skip logging attempt completions after cancellation. At that point, our NetLog reference should no longer be trusted. Bug: 859422 Change-Id: I39e2dcdf9e415f7f707411773627ab6015e45f57 TBR: isherman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1124770Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#572358}
-
Alexey Kozyatinskiy authored
uiSourceCode may have no attribution, e.g. in case when there is no frames in Node.js environment. addFrameAttribution and cloneInitialFrameAttribution check frame or attribution for existing, let's do the same in removeFrameAttribution. R=einbinder@chromium.org TBR=pfeldman@chromium.org Bug: none Change-Id: I373d4faaa40210a9445a1f3cc4ea1abb72ec72db Reviewed-on: https://chromium-review.googlesource.com/1123708 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#572357}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/da20e836abca..670e331c4d87 git log da20e836abca..670e331c4d87 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 manojgupta@google.com config: Make all asan images use 16gb rootfs. 2018-07-03 mortonm@chromium.org Adjust tester for shill user belonging to daemon-store group. Created with: gclient setdep -r src/third_party/chromite@670e331c4d87 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:774251,chromium:649417 TBR=chrome-os-gardeners@chromium.org Change-Id: I9dbdd16184ca3d45d589c7a3f2eec480db4bf713 Reviewed-on: https://chromium-review.googlesource.com/1124903Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572356}
-
spqchan authored
For site-per-process TBR=alph@chromium.org Bug: 859988 Change-Id: Ibc8965f69b2dd4c542834f2e3a18e6e61cfeff97 Reviewed-on: https://chromium-review.googlesource.com/1125158Reviewed-by:
Sarah Chan <spqchan@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#572355}
-
Jose Dapena Paz authored
A base::span parameter of AttestedCredentialData constructor was populated in VirtualCtap2Device with an initializer list. But GCC cannot resolve that mapping. So replace the initializer list by an explicit declaration of an array. Bug: 819294 Change-Id: Id3f2d7978ab8adff3c5bf3fd8e25c1b16c872470 Reviewed-on: https://chromium-review.googlesource.com/1123823Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#572354}
-
kylechar authored
We want to quantify the impact of this IPC and how long the browser is blocked for. Bug: 859168 Change-Id: I92835fd097869eedde10894c3caaf1c10157c4a3 Reviewed-on: https://chromium-review.googlesource.com/1121055Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#572353}
-
Jun Choi authored
Add end to end tests using VirtualCtap2Device and replace all use of MockFidoDevice in integration tests. Bug: 829413 Change-Id: If483308eda2502efd93ab9996c75f976e89bfd2b Reviewed-on: https://chromium-review.googlesource.com/1117838 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#572352}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ce6b2fbbac20..10e0a3798e47 git log ce6b2fbbac20..10e0a3798e47 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 dtu@chromium.org [pinpoint] Add unit testing and stubs for execution.py Created with: gclient setdep -r src/third_party/catapult@10e0a3798e47 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ie13fe133e5bf40be70ab196ed8b923904abc2fdf Reviewed-on: https://chromium-review.googlesource.com/1124907Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572351}
-
Aleks Totic authored
Fix "Unexpectedly passing" tests. extend_by_character.html is a testharness test, did not need expectations. Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I403480c0766cac166aa9ce2f9ddf778f63fea39e Reviewed-on: https://chromium-review.googlesource.com/1124958 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#572350}
-
Nicolas Pena authored
The test external/wpt/resource-timing/resource_timing.worker.html passes now. Change-Id: I239c1645a3a85c99bfd15c35cc6fb42e8269c2e1 Reviewed-on: https://chromium-review.googlesource.com/1120865Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#572349}
-
Xi Cheng authored
Bug: 851163 Change-Id: I2346efb2fc9c7ac5e0be425ac9484babd6b6544d Reviewed-on: https://chromium-review.googlesource.com/1123657Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#572348}
-
Allen Bauer authored
Bug: 859620 Change-Id: I57b73343549028053aa5833587e28782815971c9 Reviewed-on: https://chromium-review.googlesource.com/1125127Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#572347}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1c14ae2fbe1a..95b0293a29b2 git log 1c14ae2fbe1a..95b0293a29b2 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 tsepez@chromium.org Use more UnowendPtr<> in cfgas_formatstring.h and cfx_break.h 2018-07-03 tsepez@chromium.org Use UnownedPtr<> in cfwl_notedriver.h 2018-07-03 tsepez@chromium.org Test {Byte,Wide}String works with std::begin(). 2018-07-03 art-snake@yandex-team.ru Do data request for CPDF_Stream more smoothly. 2018-07-03 thestig@chromium.org Roll DEPS for catapult to c61a0380 2018-07-03 tsepez@chromium.org Use unowned ptr in cpdf_stream_acc 2018-07-03 thestig@chromium.org Roll third_party/depot_tools/ 869a2857a..5484b866d (244 commits; 34 trivial rolls) 2018-07-03 thestig@chromium.org Roll third_party/googletest/src/ 4bd8c4638..ce468a17c (52 commits) 2018-07-03 thestig@chromium.org Roll tools/memory/ 427f10475..f7b00daf4 (2 commits) 2018-07-03 thestig@chromium.org Roll third_party/jinja2/ d34383206..45571de47 (2 commits) 2018-07-03 thestig@chromium.org Roll base/trace_event/common/ 0e9a47d74..211b3ed9d (3 commits) 2018-07-03 thestig@chromium.org Roll third_party/zlib/ 8c371ad77..39b4a6260 (5 commits) 2018-07-03 thestig@chromium.org Forward declare CPDF_SyntaxParser when possible. 2018-07-03 tsepez@chromium.org Use UnownedPtr<> in cfwl_messagekillfocus.h 2018-07-03 tsepez@chromium.org Use UnownedPtr<> in cfwl_scrollbar.h and cfwl_themebackground.h 2018-07-03 tsepez@chromium.org Use UnownedPtr<> in cxfa_{ffwidgethandler,imagrenderer,loadercontext}.h Created with: gclient setdep -r src/third_party/pdfium@95b0293a29b2 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie9c908a957ef3f29604af01bfc9c37a4022f5c5c Reviewed-on: https://chromium-review.googlesource.com/1124906Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572346}
-
Xianzhu Wang authored
This reverts commit 80efb867. Reason for revert: The new test fast/scroll-snap/animate-fling-to-snap-points.html is very flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=fast%2Fscroll-snap%2Fanimate-fling-to-snap-points.html https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=fast%2Fscroll-snap%2Fanimate-fling-to-snap-points.html Original change's description: > Snap for GestureFling on main thread. > > This patch implements snapping for gesture fling on main thread. > The ScrollManager would implement SnapFlingClient to collect snap > information, schedule animation, and execute the scroll as instructed > by SnapFlingController. > > This patch also updates the interface of > SnapCoordinator::GetPositionForPoint() for it to return an Optional > FloatPoint, clearly indicating whether there exists a snap point for > the current scroll. > > Bug: 778259 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I196e8c58c238cfad2a96e3f6a1c218f2c4f77a3c > Reviewed-on: https://chromium-review.googlesource.com/1083144 > Reviewed-by: Rick Byers <rbyers@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Commit-Queue: Sandra Sun <sunyunjia@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572263} TBR=rbyers@chromium.org,bokan@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org Change-Id: Ie5add53034eb8558bd7df1c4efc17388065cbee5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 778259 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1124910Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572345}
-
Mina Almasry authored
Bug: b/110736115 Test: Run on device Change-Id: I3679b50e77dc6410a26dc8d1d44acb71d589e23f Reviewed-on: https://chromium-review.googlesource.com/1115868 Commit-Queue: Mina Almasry <almasrymina@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#572344}
-
Nate Fischer authored
No change to logic. These trace events were added to help investigate the 8 ms block which wound up caused by class verification. This CL removes these events, because other trace events (which we intentionally leave in the code) are more helpful at diagnosing the issue. R=torne@chromium.org Bug: 838702 Test: N/A Change-Id: Ib0e405fb78df12b159e3bbbf242820650648ebfd Reviewed-on: https://chromium-review.googlesource.com/1123464Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#572343}
-
Orin Jaworski authored
Rich entity search suggestions with description will use a new accessibility label format including the entity name, followed by the description, followed by "search suggestion". Entities without a description will fall back to the simple search suggestion format as before. Bug: 853252 Change-Id: I978ceafc07971704d7fcf0ad3d2e27e5f3ec7763 Reviewed-on: https://chromium-review.googlesource.com/1123158Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#572342}
-
Mathieu Perreault authored
Tiniest change I've ever made. Bug: None Change-Id: I651d74811843e04072764068b9b330248f1c4bc9 Reviewed-on: https://chromium-review.googlesource.com/1125120Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#572341}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2fdaa044. With Chromium commits locally applied on WPT: 98d4a440 "[LayoutNG] Fix hit test clipping by fragmented border with round corner" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20699 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=markdittmer No-Export: true Change-Id: I09a8b4b858b05cb26dbaa908f9fb8ac2c9597ed2 Reviewed-on: https://chromium-review.googlesource.com/1124977 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#572340}
-
Kyle Horimoto authored
This class represents an operation for completing the verification step for the current host device. A HostVerifierOperation instance is meant to be used for a single verification attempt; if verification needs to be retried, a new instance should be created for the next attempt. This class completes the following steps to verify a device: (1) Call FindEligibleDevices(). This step sends a message to the host device, which in turn enables background advertising. (2) Creates a connection to the device using the BLE listener role. (3) Sends an EnableBetterTogetherRequest message to the host device. (4) Waits for an EnableBetterTogetherResponse messages to be returned by the host device. Bug: 824568 Change-Id: I520ff9388334467831342af4d0e270cb4e351eeb Reviewed-on: https://chromium-review.googlesource.com/1119466Reviewed-by:Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#572339}
-
Charlie Harrison authored
Now that we are triggering activation for potentially multiple URLs in the redirect chain, we should be collecting data about which part of the chain caused activation. Bug: None Change-Id: I835a64f6fdb714cd70cf22cee0e83c87d01d4e25 Reviewed-on: https://chromium-review.googlesource.com/1124766Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#572338}
-
Mattias Nissler authored
This adds histogram declarations and corresponding enums for the histograms added per https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1105984 BUG=chromium:853730 TEST=None Change-Id: I64e0f89ce05a4ccd9f11f6290f1b9bdd479c2fbe Reviewed-on: https://chromium-review.googlesource.com/1124690 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#572337}
-
Jonathan Backer authored
Refactors some GLES2Decoder code for reuse by RasterDecoder. This validation avoids NOTREACHED within gles2_cmd_copy_texture_chromium.cc in GetFragmentShaderId. Bug: 854804 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie1edbef68d65449ac2e84949ac7ac0d7b5ebb0cf Reviewed-on: https://chromium-review.googlesource.com/1124962Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#572336}
-
Min Qin authored
Calling stopForeground should reset the fgRequired bit. Hopefully this fixes the crash, which checks whether that big is true when calling stopSelf() BUG=826998 Change-Id: Ib2dee1c5d87f406d4755b924c755697588010658 Reviewed-on: https://chromium-review.googlesource.com/1125080Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572335}
-
Findit authored
This reverts commit cdafb2ec. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 572291 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2NkYWZiMmVjMzJiZDg5OTdmMDYwODI0NDlkZDUxMjAxNDQyNTQ1MmYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/6635 Sample Failed Step: compile Original change's description: > arc: bluetooth: Implement sending indications in GATT server > > - Ensure that CCCD is added such that we can report the value change in > CCCD to Android in OnNotificationStart/Stop() > - Implement SendIndication() such that Android can call it > > Bug: b:78593133 > Test: Pass Android CtsVerifier test on server sending indication/notification > Change-Id: I8b1a4be6596555003d6d447b4518f37632a45370 > Reviewed-on: https://chromium-review.googlesource.com/1119079 > Commit-Queue: Qiyu Hu <qiyuh@google.com> > Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572291} Change-Id: Iddab38063dc9f22869176afb9cd0370d9451ee24 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:78593133 Reviewed-on: https://chromium-review.googlesource.com/1125043 Cr-Commit-Position: refs/heads/master@{#572334}
-
Theresa authored
BUG=859565 Change-Id: I8193ae97172377732919851b17e227ddf1e62c79 Reviewed-on: https://chromium-review.googlesource.com/1124987Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#572333}
-
Manuel Rego Casasnovas authored
In the past we added a use counter to check the usage of percentage rows on grid containers with indefinite height. The name of the use counter is kGridRowTrackPercentIndefiniteHeight, however it was also counting the cases of percentage columns on grid containers with indefinite width. This patch removes the last case from the use counter, as it was wrong. In addition, the patch adds a new unit test for the use counter to verify that is only triggered for percentage rows. JFTR this use counter is related to issue: https://github.com/w3c/csswg-drafts/issues/1921 Change-Id: I2ab2cc28195e0b5e4f51ea37fff4c838e553cb8a Reviewed-on: https://chromium-review.googlesource.com/1124840Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#572332}
-
Sam Maier authored
We are moving to Oreo's implementation, at commit 1488a3a19d4681a41fb45570c15e14d99db1cb66 TBR=agrieve # Mechanical change to cronet Bug: 843745 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic612b7767007993a1b7761418061dbe0346afa7e Reviewed-on: https://chromium-review.googlesource.com/1117637 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#572331}
-
Mark Pilgrim authored
TBR=estade@chromium.org Bug: 844930 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I554e7e68e31fd05a9aaef014886b0149f41cebb8 Reviewed-on: https://chromium-review.googlesource.com/1053869 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#572330}
-
Maks Orlovich authored
... and diagnose attempts to use the TestMockTimeTaskRunner as a target for taskrunnery other than RunsTasksInSequence after it gets destroyed. Sometimes leaky singletons end up capturing the current task runner, and it therefore ends up sticking around between tests. Previously that could leak the TestMockTimeTaskRunner, which was mostly important in kBoundToThread mode, since leaking a TestMockTimeTaskRunner in that case leaks a RunLoop::Delegate, which breaks any further test that needs RunLoop support. Change-Id: I7ba86e02a20a5fa07de40fc5f3a5adb3bee35ab3 Reviewed-on: https://chromium-review.googlesource.com/1118532 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#572329}
-
Cole Winstanley authored
Making GetWindowSize return the desired values when running ChromeDriver on Android. Added a test (testAndroidGetWindowSize) to run_py_tests.py to test this functionality, which should be the same as running a script to get window.innerWidth / window.innerHeight. Bug: chromedriver:1005 Change-Id: Ib30b84e657ef9fb2ab1b5e7a5f5dd9cf452ae98f Reviewed-on: https://chromium-review.googlesource.com/1121335 Commit-Queue: Cole Winstanley <cwinstanley@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#572328}
-
Chris Harrelson authored
This (a) avoids extra cost in copy constructors for HitTestResult (which happen often in PaintLayer::HitTestLayer), and (b) is cleaner because the hit testing code on the layout tree doesn't ever call GetHitTestLocation. This improves performance due to fewer copies happening when we need to create temporary outputs. Bug:831762 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2d0716fd74b566d3c18646a8c685d184e49dd7d4 Reviewed-on: https://chromium-review.googlesource.com/1111472Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#572327}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3bc977a42022..d000b0a32ee7 git log 3bc977a42022..d000b0a32ee7 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 jonasolsson@webrtc.org Move RTC_CHECK_OP error message construction out of header file. 2018-07-03 sprang@webrtc.org Add sprang@ as owner for simulcast.cc/h 2018-07-03 mbonadei@webrtc.org Remove usage of //build/config/clang:extra_warnings. Created with: gclient setdep -r src/third_party/webrtc@d000b0a32ee7 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icf645797aedd60ee259ec9629b9159c58060dd81 Reviewed-on: https://chromium-review.googlesource.com/1124900Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572326}
-
Jun Choi authored
Add 'Time out' sheet model to show when Web Authentication request times-out due to inactivity or error. Bug: 849323 Change-Id: Ifda965c3120d4fbd28f46a4f62e88200f316ca0f Reviewed-on: https://chromium-review.googlesource.com/1105284 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#572325}
-
Amirhossein Simjour authored
DismissHandler is set in VrShellImpl to make it possible to close the dialog when native sends the request. Bug: 843325 Change-Id: I2e83840a77fa47cab0275a1710591bae23627b96 Reviewed-on: https://chromium-review.googlesource.com/1125085Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#572324}
-
Klaus Weidner authored
The current implementation had an invalid DCHECK_EQ, there's a valid flow where is_webvr_frame could be true while ShouldDrawWebVr was false. Remove the invalid check and update the comment with a more accurate lifecycle description. Change-Id: I4eb1c7496972334c4d3b8e42fb3ffb352c0ed236 Reviewed-on: https://chromium-review.googlesource.com/1124994Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#572323}
-
Amy Qiu authored
As part of refreshing page sets, the new linkedin page requires logging in before viewing profiles. Create a linkedin login helper and update the credentials.json file. Bug: 852530 Change-Id: Ibce40dc6cf0c3d09f4fed5cd8f34f0d7cf14d8e4 Reviewed-on: https://chromium-review.googlesource.com/1099728 Commit-Queue: Amy Qiu <amyqiu@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#572322}
-
Theresa authored
BUG=844570 Change-Id: I43a3d38a97718309fc781a09609641c9b3bc72d5 Reviewed-on: https://chromium-review.googlesource.com/1125081Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#572321}
-