- 18 Jun, 2019 40 commits
-
-
Fredrik Söderquist authored
The embedding LayoutObjects intrinsic size may be left as the old stale size if the new dimensions are not fully defined - which means that it qualifies as having a size and and aspect ratio (where having the former implies having the latter in most cases). Call IntrinsicSizeChanged() instead of just SetNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation(...), since the former also resets the intrinsic size to 300x150 (incorporating zoom). Clean up HTMLPlugInElement::GetLayoutEmbeddedObject a little bit while at it. Bug: 971647 Change-Id: I5c165d1ae18888b6368c9011bc6752b599629118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660341 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#670024}
-
Takashi Sakamoto authored
- RendererScheduler.TasksWithSafepoints.SafepointCount - RendererScheduler.TasksWithSafepoints.TaskSliceTime - RendererScheduler.TasksWithSafepoints.TaskTime Bug: 804661 Change-Id: Ib4a5fbdca90caddc8b6820216e86333f1316b725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578720Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#670023}
-
Evan Shrubsole authored
Bug: 945486 Change-Id: I6adac460304d7477c548bc5efc062e147cdc99f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660650 Commit-Queue: Evan Shrubsole <eshr@google.com> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670022}
-
Takashi Sakamoto authored
Bug: 953194 Change-Id: I5c9d409288eb2f84d43a373d11170b5c70dd81e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662104Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#670021}
-
Alan Cutter authored
The flag PwaPersistentNotification expired in M76, this CL removes it. Bug: 471623, 974596 Change-Id: Ibd7d16a5b12acb42d4d2c683b18e0e2070fb8dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662098 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#670020}
-
Chih-Yu Huang authored
The codes in media/gpu/linux/ is able to be compiled at linux platform. But we only use it at Chrome OS currently. In order not to confuse developer, This CL moves this code to /media/gpu/chromeos/ folder. BUG=chromium:972585 TEST=Run video_decode_accelerator_tests on Kevin TEST=Open crosvideo.appspot.com on Kevin Change-Id: I78fd374bf2e329bc65994852a918b6f655111ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657877 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#670019}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a07feb5445f0..67fa42fa225f Created with: gclient setdep -r src-internal@67fa42fa225f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com Change-Id: Idd93db08144445cc5c28bf25c3da2ffcceea298e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662958Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670018}
-
Alan Cutter authored
This is a follow up CL to https://chromium-review.googlesource.com/c/chromium/src/+/1662093 which removed the (disabled) PwaImprovedSplashScreen flag. This removes the "splash_screen_url" field in app manifests which was parsed, stored, but never used. TBR: skyostil@chromium.org Bug: 759945 Change-Id: I725bf48e7aae3c12db350bbe2f3d4ae746d15e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662102 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#670017}
-
Dominik Röttsches authored
Tbr: schenney Bug: 785230 Change-Id: I198db0c8cf7d888a2b0b4df443ea1ce7d9f093e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663131Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#670016}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2edb1963..576af29d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib8acc5db4829728a0f703547cbb452ecea33a03e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663047Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670015}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f1dd7a174af8..e7f8c34384ed git log f1dd7a174af8..e7f8c34384ed --date=short --no-merges --format='%ad %ae %s' 2019-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 853ebacf99a4..c211c2f5b59d (17 commits) 2019-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src a2197be6..aad06d1d (843 commits) Created with: gclient setdep -r src/third_party/skia@e7f8c34384ed The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@google.com Change-Id: I299402ce7ff5ae3a549ebb9ced6d5dcc9528c4f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662955Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670014}
-
Gyuyoung Kim authored
Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/module/bluetooth directory. [1] https://github.com/heycam/webidl/issues/365 Bug: 963267 Change-Id: I75c78dd466f0ab75d90550f4f43dc2630037514b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663834Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#670013}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=hychao@chromium.org Change-Id: Ibcbbd7fefada7528724dbd81910a6a987a724876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649364 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#670012}
-
Alex Ilin authored
This CL makes it possible to disable the checkbox for extended Safe Browsing reporting from Java. Bug: 938902 Change-Id: I82eaa03094cd75cd3da4dc3235dfc7bd681d29f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660862 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#670011}
-
Koji Ishii authored
This patch fixes |ClearNeedsLayout| for CR (U+000D) and FF (U+000C). These were overlooked when |ClearNeedsLayout| was moved from |NGInlineItemsBuilder| to |NGLineBreaker| and |NGInlineLayoutAlgorithm|. Bug: 971811 Change-Id: Ie3d9d3d11e35a7ed3458bb8b96d2fa68bf9c37a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663478Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#670010}
-
Raphael Kubo da Costa authored
This CL contains the permission handling parts while not making the Wake Lock API implementation in Blink connect to them yet. * On the Blink side, add WakeLockPermissionDescriptor from the spec, and make the Permissions API support it. It extends PermissionDescriptor with a |type| member indicating the wake lock type. * The two different wake lock types are represented in content/ as PermissionType::WAKE_LOCK_SCREEN, PermissionType::WAKE_LOCK_SYSTEM, CONTENT_SETTINGS_TYPE_WAKE_LOCK_SCREEN and CONTENT_SETTINGS_TYPE_WAKE_LOCK_SYSTEM. The actual policy right now is very simple: * None of the wake lock types show any sort of permission UI. * Screen lock requests are always granted (since they are similar to e.g. screen locks acquired for video playback which currently do not require any user consent). * System locks are currently always denied while we figure out the best way to request permission to the user. Bug: 967669 Change-Id: I9d404ff7c5430ae1e4cec2140ee51abd83ce44ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652939Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#670009}
-
Michael Starzinger authored
R=titzer@chromium.org,jwd@chromium.org BUG=chromium:969997 Change-Id: I687f0280d2900dcc1f01a6ca5802d78b52901ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660337Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#670008}
-
Sam McNally authored
Change-Id: Ia1448bb7943e66099e655779b47cd143f4714cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662101 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#670007}
-
Dominik Röttsches authored
As preparation for ramp up in beta, start exposing the feature on performance bots across all platforms now that the Windows 7 & 8 indexing implementation seems to be solid in terms of indexing performance and scheduling. Bug: 828317 Change-Id: Iae4722f7e19feb4e46f5f5507483e50751e448a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662555Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#670006}
-
Kunihiko Sakamoto authored
This fixes a crash bug where cancellation of font loading causes promise rejection inside a ScriptForbiddenScope, when the loading is cancelled inside Document::Shutdown(). To prevent this, this patch adds an early return to RemoteFontFaceSource::NotifyFinished() when the document is not active. This is a short term fix to be merged for M76. Bug: 960290 Change-Id: I9f8b18fe489c2224ebbf445ad25445b7769c3336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661313 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#670005}
-
Jochen Eisinger authored
Bug: 971854 Change-Id: I6c580687e4f3705469c52f2372810c71635c2feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664072Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#670004}
-
Alan Cutter authored
This parameter is never true. Bug: 904566 Change-Id: Icef0fd3d416f3c41062bea03e05aa09a96055bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638203 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#670003}
-
Clemens Arbesser authored
http://crrev/c/1614967 moved Image fetcher, one of our dependencies, to the lib/ layer, without modifying our DEPS files. This CL adds the missing entries. Change-Id: I0e7425d39e4ad558f6943b34f9c1b6399b912958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660561Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#670002}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d579c0a7d45a..a9b00ac5d588 git log d579c0a7d45a..a9b00ac5d588 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 johnkslang@users.noreply.github.com Merge pull request #1806 from KhronosGroup/nan-clamp 2019-06-18 johnkslang@users.noreply.github.com Merge pull request #1698 from jeffbolznv/private_storage_variables Created with: gclient setdep -r src/third_party/glslang/src@a9b00ac5d588 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I57cc0a084d927f0a82c4912b738c31a957fcf6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662954Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670001}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1dee91aec9a6..61d8ee10b611 git log 1dee91aec9a6..61d8ee10b611 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2ce8c837..6ae0f0cd (669595:669703) 2019-06-17 srte@webrtc.org Adds SortedByReceiveTime to TransportPacketsFeedback. 2019-06-17 terelius@webrtc.org Fix event_log_visualizer help text and default profile. 2019-06-17 sprang@webrtc.org Add TrySendPacket() method to RTP modules. 2019-06-17 eladalon@webrtc.org Add Clone() to Vp8FrameBufferControllerFactory Created with: gclient setdep -r src/third_party/webrtc@61d8ee10b611 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0895508a9ce60390930662bb5edfcb9403a239bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663912Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670000}
-
Mohamed Abdelhalim authored
Replace NavigationController::GetVisibleEntry with NavigationController::GetLastCommittedEntry when it is safe. Bug: 853705 Change-Id: I3aa0fa65b14a4cab401c4a9037c4e8a911072f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631283 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#669999}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2baf86e86ee2..396982cd6b1e git log 2baf86e86ee2..396982cd6b1e --date=short --no-merges --format='%ad %ae %s' 2019-06-18 treehugger-gerrit@google.com Merge "trace_processor_shell: Clean up formatting of --help" Created with: gclient setdep -r src/third_party/perfetto@396982cd6b1e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I9cd4c0ec6231fe0c3cd3d38d9a3e00f876f5dcc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663915Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669998}
-
Mario Sanchez Prada authored
Don't include that internal header from identity_manager.h (which is public) and simply include oauth2_token_service_observer.h instead, which does not pose any problem since the methods that will allow adding / remover O2TS observers will not be exposed publicly anyway. Bug: 967619 Change-Id: I0f31eca66a2ad56669f78bc201c09125364a66a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660344Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#669997}
-
Wei-Yin Chen (陳威尹) authored
A ViewResourceAdapter is used to show the Grid Tab Switcher (GTS) in the background when playing the Tab-to-Grid transition animation. After the animation is done, the Java-side bitmap is released in https://crrev.com/c/1636833 and https://crrev.com/c/1639150, but the native-side bitmap is kept, wasting ~3MB of native memory on high-end phones (assuming downsampling scale = 0.5). The effects on performance (frame rate, max frame interval, etc) are within error margin. Bug: 971281 Change-Id: I9b29a91cb593c46505f1d2be29f7d3dd5e12feb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645458 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#669996}
-
Takuto Ikuta authored
bots are added in https://chrome-internal-review.googlesource.com/c/infradata/config/+/1397329 Bug: 954450, 956776 Change-Id: I1e7d92c4ee23e6d96cc327410b1cb8083ceea101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662248 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#669995}
-
Mario Sanchez Prada authored
Make sure we use identity::ScopeSet everywhere so that we don't need to depend on oauth2_token_service.h anymore, allowing us to remove that include in a follow-up CL. Also, normalize the way we refer to this definition without using the namespace qualifier, instead of having half of the places specifying it and the other half not doing it. Bug: 967619 Change-Id: I86f6426b4489f5ce7e856fe3e1cadc6885c8b336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662554 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#669994}
-
Christopher Cameron authored
Add three very large crash keys (8k each) for - the shader source during -[MTLDevice newLibraryWithSource...] - the vertex and fragment shader source during -[MTLDevice newRenderPipelineStateWithDescriptor...] We are seeing an alarming number of GPU process hangs inside these functions. A theory is that there are particular shaders that cause pathological compile times. This should give is some visibility into the validity of this theory. Bug: 974219 Change-Id: I328fa8ccf732cf2d0d96a58d6d6d68b280322b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662504Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#669993}
-
Julie Jeongeun Kim authored
This CL removes "fetch" prefixes from URLRequest members. It renames types in //services/network/public/mojom/fetch_api.mojom, FetchRequestMode to RequestMode, FetchRedirectMode to RedirectMode and FetchCredentialsMode to CredentialsMode and members in URLRequest, network::ResourceRequest, blink::ResrouceRequest, fetch_request_mode to mode, fetch_redirect_mode to redirect_mode and fetch_credentials_mode to credentials_mode. It also renames their accessors and variables together. TBR=xhwang@chromium.org,blundell@chromium.org Bug: 966705 Change-Id: Ie9d6958c613efa7afeac067fd09c577fcd2612f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660393 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#669992}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b9b4c88672fd..a07feb5445f0 Created with: gclient setdep -r src-internal@a07feb5445f0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com Change-Id: I49871516b3c79a80404bbebd75a8347a77423c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663826Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669991}
-
Sam McNally authored
Change-Id: I00b15eff07ec1867bf2c2fa5bcf27c363ac076e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662982Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#669990}
-
Kouhei Ueno authored
Bug: 972960, 961674 Change-Id: Iff5c464dcc5227f211462f0e1b70c938fab452c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654370 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#669989}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2935638a1b16..f1dd7a174af8 git log 2935638a1b16..f1dd7a174af8 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8c12f564113c..9283b2559c05 (14 commits) 2019-06-18 herb@google.com Remove all global mutexes 2019-06-18 mtklein@google.com enable SkVM JIT testing on x86-64 Linux bots 2019-06-18 mtklein@google.com centralize and force-inline unaligned_{load,store} 2019-06-17 csmartdalton@google.com Add a "preferredInternalSampleCount" cap 2019-06-17 reed@google.com add motion blur params to skottie2movie 2019-06-17 brianosman@google.com Add some precision back to timestamps when using --trace 2019-06-17 brianosman@google.com Shuffle SkSL sources around so compiler and bytecode can be used w/o GPU 2019-06-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). 2019-06-17 benjaminwagner@google.com Omit build number for LenovoYogaC630 os dimension Created with: gclient setdep -r src/third_party/skia@f1dd7a174af8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:974542 TBR=bsalomon@google.com Change-Id: I9ddd27b313a8eb5fc3e590c8fa1e55891b883cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663822Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669988}
-
Alan Cutter authored
This reverts commit 8fa57643. Reason for revert: Broke MSAN build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/13546 AccessibilityFocusRingControllerTest.SetFocusRingCorrectRingGroup ==677==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x55ee18481b14 in ash::AccessibilityFocusRingGroup::UpdateFocusRingsFromInfo(ash::AccessibilityLayerDelegate*) Original change's description: > mash cleanup: Remove accessibility_focus_ring_controller.mojom > > Replace mojom with an abstract singleton controller, c++ struct & enums. > Update impl & tests, expose a protected static helper for simplicity. > Remove an unnecessary test subclass, unit test passes without this. > > Bug: 958129 > Test: Automated; no accessibility focus ring regressions. > Change-Id: I34acd91fa9e093309a89edf74e2395d5de5ec2c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660107 > Auto-Submit: Michael Wasserman <msw@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669869} TBR=sky@chromium.org,msw@chromium.org,tsepez@chromium.org Change-Id: I8a566ffc0cef5bd828c8be3ce1ce5dd1624d8b33 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662985Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#669987}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f6c289da452c..0c9a952c8f7d git log f6c289da452c..0c9a952c8f7d --date=short --no-merges --format='%ad %ae %s' 2019-06-18 a-v-y@yandex-team.ru Fixed symbolize of win traces with breakpad syms performed on linux Created with: gclient setdep -r src/third_party/catapult@0c9a952c8f7d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:797843 TBR=eyaich@google.com Change-Id: Idef6eb6f006a1c663062d63d342d9561092e9cac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663827Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669986}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/83ce6ba1..2edb1963 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic6c88c4611d2e6f62704f39fefb75539e91818cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663041Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669985}
-