GitLab

BUG=357648,162530
TBR=rpaquay@chromium.org for sockets API

Review URL: https://codereview.chromium.org/217263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260465 0039d316-1c4b-4281-b951-d872f2087c98

Currently there is no method to receive the changes of recently closed pages
in chrome.sessions APIs. This callback can give extensions a chance to know
there is a change and update by calling GetRecentlyClosed again.

R=kalman@chromium.org
BUG=353007

Review URL: https://codereview.chromium.org/201393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260464 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357782
TEST=no change

Review URL: https://codereview.chromium.org/216793014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260463 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357715
TEST=none

Review URL: https://codereview.chromium.org/217133007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260462 0039d316-1c4b-4281-b951-d872f2087c98

This change allows CHROME_USER_DATA_DIR to override the default profile location
is Chrome is launched via a start-up script. The behaviour is unchanged if that
environment variable is not set.

BUG=351002

Review URL: https://codereview.chromium.org/190473005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260461 0039d316-1c4b-4281-b951-d872f2087c98

These tests and the feature that they test rely on iOS 7 APIs.
This change skips those tests if the platform is not recent enough.

BUG=348820

Review URL: https://codereview.chromium.org/213703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260460 0039d316-1c4b-4281-b951-d872f2087c98

(C++ files still to do.)

Also, as a drive-by, update the generated copyright notice in
build_gles2_cmd_buffer.py to the correct, current one (no "(c)").

R=darin@chromium.org
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/218193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260459 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 42e7514f.

It is breaking the bots like this:
https://chromegw.corp.google.com/i/clank/builders/clang-builder/builds/3819
Traceback (most recent call last):
...
Exception: The BUILDTYPE environment variable has not been set

The reason is that the downstream clang-builder uses recipes, and recipes don't
set environment variables between steps. The recipe being used is
android_builder which can be checkout as part of the buildbot code in dir:
build/scripts/slave/recipes/android/.

TBR=andrewhayden@google.com
BUG=357190

Review URL: https://codereview.chromium.org/217893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260458 0039d316-1c4b-4281-b951-d872f2087c98

NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
BUG=357915
R=cpu@chromium.org, waffles@chromium.org
TBR=cpu@chromium.org, waffles@chromium.org

Review URL: https://codereview.chromium.org/218693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260457 0039d316-1c4b-4281-b951-d872f2087c98

This CL eliminates almost all usage of Profile in SigninManager:
- It now gets the PrefService from the SigninClient.
- It now gets the URLRequestContext from the SigninClient.
- It has the ProfileOAuth2TokenService passed in explicitly.
- The static method DisableOneClickSignIn() now takes in a PrefService instead
  of a Profile.

The only remaining usage is sending the Profile as a notification source, which
will go away shortly when those notifications are removed.

BUG=334209
TBR=thakis

Review URL: https://codereview.chromium.org/216493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260456 0039d316-1c4b-4281-b951-d872f2087c98

On some Chrome OS devices there are drives that appear removable to the user but are listed in the system as fixed.  This is the case with SD cards on parrot, where they are exposed as a fixed mmcblk device.

This CL creates a new Chrome OS implementation for listing removable drives that uses the chromeos::disks::DiskMountManager, similar to how the Chrome OS ImageBurner is set up.

BUG=352430

Review URL: https://codereview.chromium.org/207383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260455 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348271

1st commit: https://src.chromium.org/viewvc/chrome?view=rev&revision=259808

NOTRY=True

Review URL: https://codereview.chromium.org/208643007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260454 0039d316-1c4b-4281-b951-d872f2087c98

R=wtc@chromium.org
BUG=

Review URL: https://codereview.chromium.org/216573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260453 0039d316-1c4b-4281-b951-d872f2087c98

Prior to this change, Mac handles pinch gestures directly in the UI layer (BrowserWindowController).  Here we instead have the RenderWidgetHost send GesturePinchUpdate events, and when those events go unhandled WebContentsImpl implements the browser zoom behavior (similar to how it does already for ctrl+mousewheel events on other platforms).

This lays the groundwork in the short term for giving the web page a chance to override the pinch behavior.  Longer term this will enable us to hook into the pinch-zoom codepath used for touchscreen so that we can get a similar effect (instead of just browser-zoom - which probably isn't really what the user wants when pinching).

The only observable behavior change in this CL is that pinching outside the content area (eg. in the tabstrip) no longer does anything.  It's not clear what the pinch origin should be in such a case, and it probably doesn't really make sense to try to handle it (pinching is supposed to zoom whatever is under the cursor).

This adds some basic unit test coverage for the pre-existing (but untested) logic for mapping pinch scales to zoom in/out actions.

Depends on blink CL: https://src.chromium.org/viewvc/blink?view=rev&revision=168482

BUG=289887

Review URL: https://codereview.chromium.org/181723006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260452 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260451 0039d316-1c4b-4281-b951-d872f2087c98

Trace-viewer ended up needing charts too so we moved the charts upstream.
This does a deps roll to that fresh version and removes the local copies.

TBR=dsinclair
NOTRY=True

Review URL: https://codereview.chromium.org/218503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260450 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves the OptionsUI browsertest from listening for Signin notifications
to observing the SigninManager as part of eliminating Signin notifications.

BUG=333997

Review URL: https://codereview.chromium.org/217043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260449 0039d316-1c4b-4281-b951-d872f2087c98

There are a few crash reports coming in where the destructor
~ScopedCGLSetCurrentContext is being implicated inside
CompositorSwapBuffers. Reduce the scope of the 
ScopedCGLSetCurrentContext in CompositorSwapBuffers.

At a minimum, this will make the crash reports reveal which
place is causing problems. At a maximum, this may fix the
issue (in particular, LayoutLayers may call displayIfNeeded,
which may mess with the current context, potentially causing
crashes, as ScopedCGLSetCurrentContext does not expect
this).

BUG=245900
NOTRY=true

Review URL: https://codereview.chromium.org/216733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=335933

Review URL: https://codereview.chromium.org/214873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260447 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260446 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r12936: (mseaborn) Remove unused prototype of NaClDescValidationCacheResolve() function
r12937: (teravest) Split NaClChromeMainStartApp() for Chromium IPC.
r12938: (noelallen) Roll bionic toolchain
r12939: (petarj) [MIPS] Implement assembly part in the faulted_thread_queue test
r12940: (jvoung) Fix run.py to return the full 32/64 arch, instead of the short one.
r12941: (jvoung) Disable run.py test under windows coverage.
r12942: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r12943: (kschimpf) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r12944: (kschimpf) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r12945: (noelallen) Roll bionic
r12946: (noelallen) Add GN tool only
r12948: (jvoung) Update TOOL_REVISIONS for PNaCl r12919->r12944
r12949: (thakis) Remove unnecessary preprocessor usage.
r12950: (noelallen) Fix DEPs and cleanup libc warnings
r12951: (dyen) PNaCl toolchain and driver now uses the new toolchain location
r12952: (hidehiko) Extend untrusted Gyp build for targeting x86-32 Non-SFI Mode.

BUG=none
TEST=browser_tests and nacl_integration
R=bradnelson@google.com

Review URL: https://codereview.chromium.org/217533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260445 0039d316-1c4b-4281-b951-d872f2087c98

BUG=345048
TEST=run the new test

Review URL: https://codereview.chromium.org/216513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260444 0039d316-1c4b-4281-b951-d872f2087c98

This adds a PPB_Find_Private function to set the tickmarks on the page.

BUG=303491
TBR=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/195893044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260443 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/213563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260442 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/213473005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260441 0039d316-1c4b-4281-b951-d872f2087c98

- 'stopped' won't appear during initialization, the check doesn't
  work well.
- 'audio' means recognizer has started. This is mostly harmless but
  better to stop when it's not used.
- the recognition pattern has changed to 'hotword: '

BUG=356873
R=xiyuan@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/215573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260440 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes an issue with all taskbar icons flashing on every app list
drag due to a SHChangeNotify being fired. This was being caused an overwrite
of the web app path shortcut which is created for drag and drop to the taskbar.
The fix skips the shortcut creation if it already exists (but still updates the icon).

This CL also extracts a GetIconFilePath function.

BUG=356961

Review URL: https://codereview.chromium.org/213833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260439 0039d316-1c4b-4281-b951-d872f2087c98

This change is to clarify the unit used in cast.streaming APIs for
bitrate. It should be in kilobits per second. And the unit conversion
should be done just before converting to VideoSenderConfig and
AudioSenderConfig which use bits per second as unit.

This will improve the video quality for existing extensions which use
kilobits per second.

BUG=354267
NOTRY=true

Review URL: https://codereview.chromium.org/214663008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260438 0039d316-1c4b-4281-b951-d872f2087c98

Always send an empty X-Privet-Token with /privet/info requests.

BUG=

Review URL: https://codereview.chromium.org/215573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260437 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes a cancelled drag clean up the folder UI. Previously cancelled
drags would not burst the folder background "bubble", leaving the folder name
UI hidden.

This CL extracts an AppsGridViewFolderDelegate from AppListFolderView
in order to facilitate the testing of this functionality.

The bug also mentions a view getting stuck but this patch does not
address that part of the issue.

BUG=352057

Review URL: https://codereview.chromium.org/210583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260436 0039d316-1c4b-4281-b951-d872f2087c98

- Fix error where you couldn't list buckets if you didn't have access to all of them.
- Fix bug where listing with shell completion (page_sets/*) would only give the first file.
- Skip moving files if the destination bucket is the same as the source bucket.
- Remove checks that all files exist. If you use shell completion, you will include files that don't have hash files, just ignore them.


BUG=None.
TEST=None.

Review URL: https://codereview.chromium.org/215423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260435 0039d316-1c4b-4281-b951-d872f2087c98

There's no reason to exclude _linux files on chromeos. The default exclusion
rules in filename_rules.gypi take care of excluding _linux files on non-linux
platforms.

BUG=none
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/218603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260434 0039d316-1c4b-4281-b951-d872f2087c98

Synced Notifications uses the SyncedNotificationAppInfo struct to name
the sending services and supply icons for them.  The first two checkins
in this larger change established the datatype and the sync change
processor for it.  This checkin wires up the data type to the rest of the
Synced Notifications code.

This checkin now uses the SNAI class to provide the bitmap and service name,
and removes the hardcoding to our first service name provider and bitmap.
This checkin also adds code to fetch the bitmaps provided by the SNAI
protobuf.

New unit tests have been added to cover the new functionality.

A lifetime dependency has been set up to ensure that the
SyncedNotificationAppInfoService is always present whenever we have a
ChromeNotifierService.

BUG=280266

Review URL: https://codereview.chromium.org/193773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260433 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=jar@chromium.org

Review URL: https://codereview.chromium.org/213333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260432 0039d316-1c4b-4281-b951-d872f2087c98

BUG=320748

Review URL: https://codereview.chromium.org/191383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260431 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/215443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260430 0039d316-1c4b-4281-b951-d872f2087c98

about:flags now has a disable WebAudio flag on Android for x86, just like for
arm, as expected. I manually tested that the flag does disable WebAudio.

I verified that on desktop (linux), there is no disable (or enable)
flag, as expected. (Desktop always has WebAudio enabled, and there is
no flag to disable it.)

BUG=353809

Review URL: https://codereview.chromium.org/208763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260429 0039d316-1c4b-4281-b951-d872f2087c98

The methods with the 'New' suffix are temporary and will soon be
removed.

BUG=chromium:243605
TEST=manual

Review URL: https://codereview.chromium.org/213413009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260428 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260424 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=170416%3A170423&mode=html

TBR=rafaelw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/218393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260423 0039d316-1c4b-4281-b951-d872f2087c98