- 20 Jan, 2021 40 commits
-
-
Eugene But authored
Change-Id: I64cb7e84946575ebf0116733a1e49bfaf1525d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638782Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#845196}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 89-4380.0-1610362181-benchmark-89.0.4389.4-r1 to 89-4380.0-1610362181-benchmark-89.0.4389.5-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iade4b9eac050dc4fdab6e76f19d4804f8b762ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639158Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845195}
-
Tibor Goldschwendt authored
MV tile button color should follow the NTP theme. However, during refactoring we made the tile button color follow the OS mode. This CL reverts the relevant changes. Bug: 1168368 Change-Id: Ied5b56c5774e359b7c674b54786079bf0ec3a0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638858 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#845194}
-
Titouan Rigoudy authored
This change is a functional no-op. Along the way, I took the opportunity to improve documentation on PolicyContainerHost constructors that are called in this change. Bug: chromium:1126856, chromium:1154729 Change-Id: I28a600c00fbcb107d9c2ed72dd6070bc05fb62ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600744 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#845193}
-
Kevin McNee authored
This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/1986918 which caused a chrome force-signin flow to crash. Bug: 1076696, 1038584 Change-Id: I2148a18bd3d36700ade50b554511d580e2d73164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633805Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#845192}
-
Maria Kazinova authored
forms. __gCrWeb.passwords.getPasswordFormDataAsString method is not supporting forms that are outside the <form> tag properly, this CL fixes it. Change-Id: If8897e966a6d5b62661c8094bb01cb82fdbf9681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640115Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#845191}
-
Elly Fong-Jones authored
This dialog requires its completion callback to be run even when the dialog is closed without either accepting or cancelling it, so wire that up. Bug: 1163052 Change-Id: Ibd7232b5addbf6f30e39050c7e955207670b0153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618097Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#845190}
-
Yue Li authored
Bug: b/175747630 Test: None Change-Id: I6e0c50ffa3a90a8088cfa21f3c1cf128f7fd412f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636877 Auto-Submit: Yue Li <updowndota@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#845189}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101200600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/LTwCHYV_Qb_5UAU6yqK2ddjnDLJwx7QJG5dCp9yUO-UC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138543581,b/172415656,b/177381366,b/177381582,b/177382762,b/177388943,b/177604649,b/177784709,b/177856222 Tbr: media-app@grotations.appspotmail.com Change-Id: I4eb9ad72d9c518f37f467188500176a17a1872a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639517Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845188}
-
Brandon Wylie authored
When going straight to incognito, the search engine logos feature isn't setup correctly. Bug: 1117574 Change-Id: I3a622727b24c06dc3f89f35dc5cf053fdb8d0c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626350 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#845187}
-
minch authored
Update the buttons visibility while initializing the desks bar, regardless of the desk bar's state. Bug: 1167362 Change-Id: I8f4578300ff4259bcba14a4f175c55ed062ccb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635442Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#845186}
-
Mike Chen authored
This is to enable performance measurements of individual optimisations on stack tracing. To provide useful debugging information, Arm's Memory Tagging Extension (MTE) requires capturing stack traces on each allocation, therefore unwinding is a performance-sensitive operation. We're also planning to change Chrome's unwinders for MTE's complementary technologies (PAC and BTI). This test will help us measure the impact of these various flags and changes, check for regressions, and help us find optimizations. Bug: 1137393 Change-Id: I768c2dcf2cacdc5bba2cdec81d973b87ba3d4ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621832 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#845185}
-
Stephen McGruer authored
As part of mandatory code review, all uses of WPT tooling have been migrated from the automatically synced copy in //third_party/blink/web_tests/external/wpt/ to the manual copy in //third_party/blink/tools/blinkpy/third_party/wpt/wpt/. It's time to stop syncing tools again :). Bug: 1165950 Change-Id: I9e05c1a2a8319e6080f6c6a86de89928b3aed6ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633424 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#845184}
-
Dirk Pranke authored
This addresses a 2->3 issue w/ print statements in calculate_package_deps.py. Bug: 1112471 Change-Id: I29e7e778bb8843a14fafea23e40fb754d959b772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638722Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#845183}
-
Elaine Chien authored
Bug: 1159562 Change-Id: Idda5f9cf46d48e128eab05bae1c14febb2979422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638675 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#845182}
-
Zhenyao Mo authored
GPU.BlocklistFeatureTestResults.* GPU.EGLDisplayType GPU.GPUProcessExitCode GPU.BlocklistTestResultsPerEntry GPU.D3D11FeatureLevel GPU.HasDiscreteGpu R=kbr@chromium.org Bug: 1166924, 1165244 Change-Id: Ibb3ad98046b6efe234d04e1d98d160c4a8b60fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631190Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#845181}
-
Viktor Semeniuk authored
This change checks whether remote and local compromised credentials are equal before updating local storage. Bug: 1167109 Change-Id: I61737e97f76dfc5f3c6522a302fce6daaf634f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637693 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#845180}
-
Jan Wilken Dörrie authored
This change handles failures in ECCommutativeCipher::CreateFromKey and ECCommutativeCipher::CreateWithNewKey more gracefully by returning an empty string from the password manager's encryption utils in the case of errors. While rare, errors can happen, currently resulting in browser crashes. All callers already inspect the returned value and return early if it is the empty string. Fixed: 1157004 Change-Id: If78851906529b20173a455b5861d98f0bcaf048c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640054Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#845179}
-
Sami Kyostila authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2d79f95e908d..2c92c33564e4 2021-01-20 fmayer@google.com Merge "Add some docs for GN targets." 2021-01-19 salg@google.com proto/processor: Add event for ContentSettings events 2021-01-19 altimin@google.com Merge "TracedValue: add dchecks that the scope is always correct." 2021-01-19 hjd@google.com Merge "ui: Add CPU by process aggregation" 2021-01-18 lalitm@google.com Merge "Update JankType field to a bitmask" 2021-01-18 treehugger-gerrit@google.com Merge "Implement simple tool to print proto descriptor files" 2021-01-18 treehugger-gerrit@google.com Merge "debian: Add traced_perf into Debian package" 2021-01-18 treehugger-gerrit@google.com Merge "Add random string to heap profile directory." 2021-01-18 midaschieh@google.com Merge "metrics: add hwcomposer metrics" 2021-01-18 ddrone@google.com Merge "Add a trace processor test for extensions" 2021-01-15 primiano@google.com Update changelog w/ tools/record_android_trace 2021-01-15 primiano@google.com Merge "Add tools/record_android_trace" 2021-01-15 altimin@google.com Merge "TracedValue." 2021-01-15 treehugger-gerrit@google.com Merge "perfetto: add ability to limit triggers to n per 24h" 2021-01-15 treehugger-gerrit@google.com Merge "Remove stale comment." 2021-01-15 treehugger-gerrit@google.com Merge "base: fix base::Hash type guard for numerics" 2021-01-15 treehugger-gerrit@google.com Merge "Revert "trace_processor: Report error on traces <1us"" 2021-01-14 adsrini@google.com Merge changes from topics "frametimeline-perfetto", "frametimeline-perfetto-master" 2021-01-14 primiano@google.com Merge "perfetto --save-for-bugreport: update bugreport path" 2021-01-14 skyostil@google.com Merge "tracing: Log more user-friendly warning when tracing is uninitialized" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:176903032 Change-Id: I5c27bd760c932dc86779c4e452500470a58130ee Tbr: perfetto-bugs@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640120 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#845178}
-
Nohemi Fernandez authored
- Shows Sync error state in Settings main page. - Keeps Sync error state as header in Sync page until the error is resolved. - Removes duplicate Sync error state in Settings during advanced sign-in. Bug: 1125631 Change-Id: Ib94bb8843311afd9d6603e9cb2dd5594014f1ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636397Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#845177}
-
Peng Huang authored
Some code which includes gl_surface_egl.h may not want to use chromium gl_bindings.h. But including gl_bindings.h may cause compile errors if the code wants to use os GL EGL headers. Bug: 1157501 Change-Id: I6d7d6f769ba9afdeb4b26fe158053fa8c7e9d638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635078 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#845176}
-
Austin Eng authored
We cannot immediately destroy the context as JS code can still execute after the iframe is removed. Instead we disconnect the context so that new commands do nothing. Now, the context is not destroyed until all WebGPU objects are GC'ed. A future change will improve this to tear down the server GPU objects but keep the client context alive until GC. Bug: 1160459 Change-Id: Iba58279a565d0099bf13420e1743003fc7c7aa23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613517 Auto-Submit: Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#845175}
-
Sylvain Defresne authored
The code to deal with multi-window enabled/disabled was duplicated in CrashRestoreHelper where calling the multi-window enabled code with a session with an empty name was the same as calling code for single window. Refactor the code to avoid the duplication. Change the backup directory used for the saved session when restore is in progress as the single directory approach would not work with multi-profile. Bug: 1165798 Change-Id: Ifa6efe051999b77688a8a6ffdb8b9ed3b185e60e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632677 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845174}
-
danakj authored
When enrollment completes, WizardController may restart chrome. Part of that restart does a fast shutdown on every RenderProcessHost, killing all renderers. However there may be tasks waiting to run that are IPC replies from the webui renderer. Once such task is EnrollmentScreenHandler::DoShowWithPartition(). The OobeConfigurationRollbackTest.TestEnterpriseRollbackRecover test causes this restart to happen. Then as the test is ending, it runs the message loop a number of times. If the renderer's reply happens to be sent before being killed, and then arrives in the browser, the test will run DoShowWithPartition(). This attempts to run JS in the renderer which has been destroyed already. This becomes a crash when we tear down the mojo connection with the renderer-process frame in https://chromium-review.googlesource.com/c/chromium/src/+/2593750. Rather than have CallJS() or some high-level object check if the RenderFrame exists, which would hide logic errors, we inform the EnrollmentScreen from WizardController when it is restarting chrome. Then the EnrollmentScreenHandler can stop trying to talk to non- existent renderer processes. We do this from WizardController because EnrollmentScreen does not know this is happening on its own, as the decision making about this is done up in WizardController. R=achuith@chromium.org Bug: 1158869 Change-Id: I83b6af31a463fa94869035f960b27bd8195a89fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629576Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#845173}
-
Sami Kyostila authored
Perfetto doesn't use a flags or scope parameter with typed trace points, so remove these parameters from the compatibility shim in Chrome too. Bug: 1006541 Change-Id: I7b184de3a0cacba975446da6be8b4ea5316496b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633994 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#845172}
-
Marc Treib authored
aka ButterForPayments stage 1 Bug: 1081749 Change-Id: Iac065ddff2dec907639dc088209c167abe94c50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631489 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#845171}
-
Mitsuru Oshima authored
Bug: 1155308 Change-Id: I129ec6179e1e1c394c47109979421b15b877356b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638423Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#845170}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6f24f9c44a65..7be5f12445fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC cfroussios@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: cfroussios@google.com Change-Id: I277d0fe6e3c55f81833c008dc9a60290d5cd0209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640154Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845169}
-
James Cook authored
We now use SkBitmap and its mojo serializer for image transport. This class is now unused. This CL deletes everything but the bitmap.mojom file itself. I can't delete that because there are [Stable] mojo APIs that have optional Bitmap? deprecated fields. Bug: 1166395 Change-Id: I7ed76babb7e59101a041d97bfd5221da6cd09792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633202Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#845168}
-
Hiroki Nakagawa authored
prerender::mojom::PrerenderMode enum was widely used over processes, but it's now only used in a few classes in the browser process. For code simplification, this CL replaces it with a simple boolean. - PrerenderContents::prerender_mode() always returned kPrefetchOnly, so it's removed. - ChromeNavigationUIData::prerender_mode() is replaced with is_no_state_prefetching() that returns a boolean. Bug: 755921 Change-Id: Ia40856aa57117771a53055f9e9ffbaf51029f42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635543Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#845167}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0c46f3e0..710f03fa Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4e352ecd18d515692affdd55cf75e61c39faa6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639799Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845166}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6eb610f75cad..26fdcbb38b7d 2021-01-20 johnstiles@google.com Implement constant folding for (bool == bool) and (bool != bool). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I8822c81a4bcdf6adfd8d5e2f3d156adc7a797d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639515Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845165}
-
Nicolas Ouellet-Payeur authored
go/win-annotator-rel and go/linux-annotator-rel have been failing for a week or so, due to invalid "chrome_policy" values in network annotations. Fix the annotations directly to make the bots green again. Bug: 1166676 Change-Id: Ib383e109d7a00a62b365d058938f2db1b71362d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633706Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#845164}
-
Hazem Ashmawy authored
This histograms are still relevant and useful to mentor the service performance and to make sure it's running as expected. Thus, I am extending it by 6 months per the public docs: https://chromium.googlesource.com/chromium/src/+/master/tools/metrics/histograms/README.md#how-to-choose-expiry-for-histograms Fixed: 1156193 Test: N/A Change-Id: I1a3fbe5dd39b2eefc8576acce59296cf87ed36fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637707 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#845163}
-
Emircan Uysaler authored
This CL sets the soft limit at 0 when we are in CRITICAL memory pressure. This enforces sync and cleanup in every submit call to reduce memory usage spikes. This CL only affects platforms that have soft limit. That happens if --vulkan-sync-cpu-memory-limit-mb flag is set, which is only enabled on fuchsia. Bug: 1166839 Change-Id: I9d38cba2479a8c912d6b1e1624e9f893be8188de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629573 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#845162}
-
Tibor Goldschwendt authored
Specifically, this CL extends: * NewTabPage.ShoppingTasks.ProductDownloadCount * NewTabPage.RecipeTasks.RecipeDownloadCount * NewTabPage.RecipeTasks.RelatedSearchDownloadCount Fixed: 1167846, 1167845 Change-Id: I38641726241e1522ffd04f6cc6efaf93fce49167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638937 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#845161}
-
Luke Zielinski authored
This rolls up to 79d2debce531d115566192dccf70f5d8fb9ced53. Only one change is pulled in to support Shadow Root in webdriver. Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Iccc7e81c85b3f387e1cca1e2dfd588ec230c61a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636692 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#845160}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611122392-25e28eb139aeca4757479341148e7dbfa12d9c66.profdata to chrome-mac-master-1611142151-b9d265a27dc1ef032fcc18909cf95e9a04349e8f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia3617db9dc1d9c2f405457718a1e1ab06c7e6b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640279Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845159}
-
Caroline Rising authored
Track two sets of read/unread counts, one when the reading list model has loaded and one when building a log for the current session using the DesktopPlatformFeaturesMetricsProvider. Bug: 1163938 Change-Id: I1b23847e7f209cc2a77b57f0e344d7c9b04c546b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621914Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#845158}
-
James Vecore authored
Adds some additional logging for the Bluetooth mac address when sending a file to understand what is causing nearby connections to skip a BT classic connection attempt. Bug: b:177697070 Change-Id: Ife98ad3a60680f22620186049c917781dc0596b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639296 Auto-Submit: James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#845157}
-