- 11 Jul, 2012 34 commits
-
-
sque@chromium.org authored
Rename it so it can contain code to set other power manager settings, not just for screen locker. BUG=chromium-os:32240 TEST=Build successfully. Change-Id: I412b775c8679386262791e84e0b2575fe182872a Signed-off-by:
Simon Que <sque@chromium.org> R=stevenjb@chromium.org Review URL: https://chromiumcodereview.appspot.com/10689101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146031 0039d316-1c4b-4281-b951-d872f2087c98
-
hayato@chromium.org authored
ShutdownTest.SimpleWindowClose BUG=136644 TEST= TBR=ananta Review URL: https://chromiumcodereview.appspot.com/10703136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146030 0039d316-1c4b-4281-b951-d872f2087c98
-
nileshagrawal@chromium.org authored
On android, ENABLE_THEMES and ENABLE_PROTECTOR_SERVICE are not defined. This fixes some link errors for unit_tests. BUG=117407 TEST= Review URL: https://chromiumcodereview.appspot.com/10704148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146028 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
Previous fix r144228 does not fix the crash. It seems the crash is more likely to be caused by user closing the app window in a nested message that runs by synchronous session restore. Add an WebContentsCloseObserver to monitor the app contents and skip focusing logic if it is closed. BUG=134478 TEST=Verify the crash in 134478 no longer happens. Review URL: https://chromiumcodereview.appspot.com/10700145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146027 0039d316-1c4b-4281-b951-d872f2087c98
-
james.wei@intel.com authored
BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10690081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146026 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/10692146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146025 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
If we call DoSeek() without a demuxer we've clearly got issues as we shouldn't be seeking without a demuxer so crashing is preferable. BUG=none TEST=none TBR=acolwell Review URL: https://chromiumcodereview.appspot.com/10694125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146024 0039d316-1c4b-4281-b951-d872f2087c98
-
jennyz@chromium.org authored
BUG=135487 TEST=alt [ and alt ] won't do anything in fullscreen mode. Review URL: https://chromiumcodereview.appspot.com/10700151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146023 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
Bug=None Test=Compiles R=ben,oshima TBR=sadrul Review URL: https://chromiumcodereview.appspot.com/10696130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146022 0039d316-1c4b-4281-b951-d872f2087c98
-
http://git.chromium.org/git/chromiumqinmin@chromium.org authored
remove autofill impl from upstream Autofill involves calls to native view, so the dependency is not correct. If we want to upstream autofill_external_delegate_android, we have to introduce another delegate. Remove the code from upstream for now. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10701058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146021 0039d316-1c4b-4281-b951-d872f2087c98
-
yoshiki@chromium.org authored
BUG=134821, 134820 TEST=both base_unittests:FileUtilTest.*, VerifyPathControlledByUserTest.* and unit_tests:Gdata* pass Review URL: https://chromiumcodereview.appspot.com/10756020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146020 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
This removes the dependency in chrome/browser/ui/views/web_dialog_view.h from chromeos. BUG=125846 R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10695122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146019 0039d316-1c4b-4281-b951-d872f2087c98
-
mihaip@chromium.org authored
BUG=125875 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10758015 TBR=varunjain@chromium.org Review URL: https://chromiumcodereview.appspot.com/10694121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146018 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146017 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
We were expecting to receive GTK+ events in the following order: drag-motion drag-data-received drag-leave but in some cases, we don't get the drag-data-received event (e.g., if the user is moving the mouse quickly). If that happens, don't send a DragLeave event to the renderer since it doesn't think we're in a drag. BUG=129446 TEST=Open 2 chrome windows, quickly drag a file from the desktop over both windows. This should not crash. Review URL: https://chromiumcodereview.appspot.com/10704144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146016 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
TBR= BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10695135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146015 0039d316-1c4b-4281-b951-d872f2087c98
-
pshenoy@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/10681003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146014 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/10689149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146013 0039d316-1c4b-4281-b951-d872f2087c98
-
koz@chromium.org authored
The crashes that it was hoped this patch would prevent didn't stop, and the actual bug was fixed in r145842. BUG=136232 TBR=kalman@chomium.org Review URL: https://chromiumcodereview.appspot.com/10701134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146012 0039d316-1c4b-4281-b951-d872f2087c98
-
varunjain@chromium.org authored
BUG=125875 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10758015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146011 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@chromium.org authored
TEST=passes new webgl conformance test BUG=136538 Review URL: https://chromiumcodereview.appspot.com/10735038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146010 0039d316-1c4b-4281-b951-d872f2087c98
-
achuith@chromium.org authored
BUG=NONE TEST=unit tests. Review URL: https://chromiumcodereview.appspot.com/10704143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146009 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
As long as touch-events are processed correctly for modal windows, the gesture-events should automatically do the right thing. So gesture-events should not need similar treatment. BUG=136360 TEST=ash_unittests Review URL: https://chromiumcodereview.appspot.com/10763004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146008 0039d316-1c4b-4281-b951-d872f2087c98
-
kochi@chromium.org authored
These defined constants are not used in this file. They are defined and used in c/b/chromeos/gdata/gdata_operations.cc. BUG=none TEST=compile Review URL: https://chromiumcodereview.appspot.com/10752021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146007 0039d316-1c4b-4281-b951-d872f2087c98
-
dmichael@chromium.org authored
Connect is called on the thread where Channel::Send will be invoked (and where messages should be dispatched). But Channel might be _created_ on some other thread. Therefore, we need to post data that we read to the thread on which Connect is called. NOT the thread where the Channel was created. This fixes an issue where sync messages were never getting their replies, because the DidRecvMsg task was being run on the thread where ChannelProxy::Send was called, not the Channel thread (which is the IO thread in this case). BUG=116317 TEST= Review URL: https://chromiumcodereview.appspot.com/10698138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146006 0039d316-1c4b-4281-b951-d872f2087c98
-
ericu@google.com authored
Some embedders do not want the additional view added by using ContentView, so we are splitting out ContentViewCore so the functionality can be used without forcing an additional FrameLayout. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10704049 TBR=tedchoc@chromium.org Review URL: https://chromiumcodereview.appspot.com/10693134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146005 0039d316-1c4b-4281-b951-d872f2087c98
-
yusukes@chromium.org authored
- Add a delegate interface for controlling keyboard brightness. - Call the interface on Alt+F6 and Alt+F7. BUG=135482 TEST=added some tests to aura_shell_unittests Review URL: https://chromiumcodereview.appspot.com/10694118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146004 0039d316-1c4b-4281-b951-d872f2087c98
-
jennyz@chromium.org authored
Fix a bug which caused the cutoff the status area right edge in vertical alignment. Adjust ash tray status area and bubble position in vertical alignment. Adjust layout and text color of vertical clock UI. BUG=127577 TEST=Ash tray status and bubble should look right for left/right launcher. Review URL: https://chromiumcodereview.appspot.com/10668009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146003 0039d316-1c4b-4281-b951-d872f2087c98
-
yusukes@chromium.org authored
- F3 and Shift+F3 cycle windows forward and backward, respectively. - F4 opens the app list. BUG=123739 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10735035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146002 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
BUG=123295 TEST=existing unittests Review URL: https://chromiumcodereview.appspot.com/10694111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146001 0039d316-1c4b-4281-b951-d872f2087c98
-
tedchoc@chromium.org authored
Some embedders do not want the additional view added by using ContentView, so we are splitting out ContentViewCore so the functionality can be used without forcing an additional FrameLayout. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10704049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146000 0039d316-1c4b-4281-b951-d872f2087c98
-
posciak@chromium.org authored
This fixes a segfault due to presumably invalid GL bindings. Also add CHECKs verifying we were able to acquire display, which otherwise would end up being cryptic segfaults as well. BUG=136292 TEST=Manual runs on ARM and CrOS x86. Review URL: https://chromiumcodereview.appspot.com/10736006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145999 0039d316-1c4b-4281-b951-d872f2087c98
-
alecflett@chromium.org authored
BUG=129471 TEST= Review URL: https://chromiumcodereview.appspot.com/10759012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145998 0039d316-1c4b-4281-b951-d872f2087c98
-
steveblock@chromium.org authored
Also enable it by default when building with the Android build system. Review URL: https://chromiumcodereview.appspot.com/10702129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145997 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Jul, 2012 6 commits
-
-
zea@chromium.org authored
SyncChanges now require the location they were created as a parameter. This is then used in the case that the change violates and invariant. We display the location and type of erroneous change in about:sync, in addition to disabling the offending datatype. TBR=kalman@chromium.org, mnissler@chromium.org, isherman@chromium.org BUG=135108 TEST=unit_tests Review URL: https://chromiumcodereview.appspot.com/10766016 TBR=zea@chromium.org Review URL: https://chromiumcodereview.appspot.com/10698141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145996 0039d316-1c4b-4281-b951-d872f2087c98
-
rlp@chromium.org authored
Revert 145969 - Removing last usage of default request context. Fixing up login_utils to not need it by adding a notification so that login_utils only accesses it when the request context getter has been initialized. BUG=125292, 127693 TEST=unittest, manual Review URL: https://chromiumcodereview.appspot.com/10657009 TBR=rlp@chromium.org Review URL: https://chromiumcodereview.appspot.com/10735042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145995 0039d316-1c4b-4281-b951-d872f2087c98
-
jyasskin@chromium.org authored
required me to switch it from wrapping a ScriptExecutor to observing one. Also write a simple test to demonstrate how to test ScriptBadgeController. This was the original point of the change. The associated refactoring turned out to be more useful, but was ultimately unnecessary for the test. BUG=133139,136301 Review URL: https://chromiumcodereview.appspot.com/10754004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145994 0039d316-1c4b-4281-b951-d872f2087c98
-
zea@chromium.org authored
SyncChanges now require the location they were created as a parameter. This is then used in the case that the change violates and invariant. We display the location and type of erroneous change in about:sync, in addition to disabling the offending datatype. TBR=kalman@chromium.org, mnissler@chromium.org, isherman@chromium.org BUG=135108 TEST=unit_tests Review URL: https://chromiumcodereview.appspot.com/10766016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145993 0039d316-1c4b-4281-b951-d872f2087c98
-
yzshen@chromium.org authored
BUG=134959 TEST=None Review URL: https://chromiumcodereview.appspot.com/10693130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145992 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
BUG=133141 Review URL: https://chromiumcodereview.appspot.com/10699033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145991 0039d316-1c4b-4281-b951-d872f2087c98
-