GitLab

BUG=358764
TBR=scottmg

Review URL: https://codereview.chromium.org/305653008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273857 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372528

Review URL: https://codereview.chromium.org/302893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273856 0039d316-1c4b-4281-b951-d872f2087c98

The write_file function should only actually update the file contents if the contents have changed to avoid unnecessary rebuilds of targets that depend on the written file.

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/301973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273855 0039d316-1c4b-4281-b951-d872f2087c98

In an effort to simplify zoom, this CL removes ViewMsg_SetZoomLevel and plumbs zoom on WebContentsImpl directly through to HostZoomMap.

At present calls to WebContents::SetZoomLevel() invoke up to three cross-process IPCs, and introduce a synchronization requirement for any caller that needs to block until the results of the operation are visible via WebContents::GetZoomLevel().

This CL simplifies this down to one IPC and removal of the
synchronization requirement. It adds a new IPC message to signal changes in a view's ability to be zoomed, and removes an ViewMsg_SetZoomLevel that was used only by SetZoomLevel().

BUG=none

Review URL: https://codereview.chromium.org/287093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273854 0039d316-1c4b-4281-b951-d872f2087c98

Doing so caused us to ignore stored content settings for pages accessed via https if a page had been accessed, settings changed and then the page accessed again.

BUG=374393
R=xians@chromium.org

Review URL: https://codereview.chromium.org/304183006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273853 0039d316-1c4b-4281-b951-d872f2087c98

Introduce the HistoryClient interface that will abstract the embedder for
the history component. The implementation in //chrome ChromeHistoryClient
owns the HistoryService and implements the KeyedService interface.

BUG=371825
TBR=sky, zea

Review URL: https://codereview.chromium.org/305443004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273846 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the naclports bundled version of libfreetype
by removing the bzip2 dependency.

R=binji@chromium.org, binji

Review URL: https://codereview.chromium.org/308043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273845 0039d316-1c4b-4281-b951-d872f2087c98

Update UMA to track bypasses due to 4xx responses that are missing the proxy's via header and bypasses due to network errors.

BUG=376148

Review URL: https://codereview.chromium.org/298883011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273839 0039d316-1c4b-4281-b951-d872f2087c98

Record word break information for the first 200 characters in a URL or
title, not the first 50 characters.  This is important because we
generally drop URL suggestions that we think do not match at a word
break.

Tested locally on a longer URL from the bug.

TBR=sky
(because this change is trivial)

BUG=291294

Review URL: https://codereview.chromium.org/306963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273837 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273835 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302040
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/296173006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273830 0039d316-1c4b-4281-b951-d872f2087c98

alarm, commands, declartive, storage api and extension_gcm_app_handler.

Also, removed unwanted extension:: namespace prefix.

R=rdevlin.cronin@chromium.org
BUG=376293

Review URL: https://codereview.chromium.org/299393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273829 0039d316-1c4b-4281-b951-d872f2087c98

Revert due to test failure. See http://crbug.com/303491#c97 for details.

> Re-enable PDFExtensionTest.BasicPlugin
> 
> This test was disabled because it was failing. A few changes have been made:
> -The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption.
> -testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091.
> -The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory).
> 
> BUG=303491
> 
> Review URL: https://codereview.chromium.org/290803007

TBR=raymes@chromium.org

Review URL: https://codereview.chromium.org/303163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273828 0039d316-1c4b-4281-b951-d872f2087c98

Adding new-API files to libjingle.gyp to prevent linker errors when
submitting wiring up the API into libjingle.

R=ronghuawu@chromium.org
BUG=webrtc:1788

Review URL: https://codereview.chromium.org/301793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273827 0039d316-1c4b-4281-b951-d872f2087c98

Previously we've abused .volume_id for the purpose, but now we have a
dedicated field for the volume name.

Now the .volume_id field can be arbitrary human unreadable string,
but I'd like to keep it as in the current form since there's also no
other reason to make it cryptic.

BUG=none

Review URL: https://codereview.chromium.org/305053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273826 0039d316-1c4b-4281-b951-d872f2087c98

I recently fixed some places which passed empty URLs around (r272182), and these
tests might have been failing because of the empty URL behavior (empty URLs were
treated as the home page, and maybe the home page is something different on the
official Mac builder than other builders).

Feel free to revert this commit if the tests fail.

R=bartfab@chromium.org
TBR=sky@chromium.org
BUG=314819

Review URL: https://codereview.chromium.org/308083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273825 0039d316-1c4b-4281-b951-d872f2087c98

Reverting due to failing tests. See http://crbug.com/370039#c5 for details.

> Added alternative configuration for the data reduction proxy
> 
> Added a second configuration that can support two http proxies and one https proxy. In the process, added a new DataReductionProxyParams object to encapsulate static configuration details and made DataReductionSettingsAndroid a BrowserKeyedContextService.
> 
> BUG=370039
> 
> Review URL: https://codereview.chromium.org/286013002

TBR=bengr@chromium.org

Review URL: https://codereview.chromium.org/307013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273824 0039d316-1c4b-4281-b951-d872f2087c98

This implements the function which sends certain key events to the PDF plugin.
This allows the document to be scrolled even when it isn't focused.

BUG=303491

Review URL: https://codereview.chromium.org/282113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273823 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a bug in prior commit.

BUG=

Review URL: https://codereview.chromium.org/304953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273822 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes the dependence of GoogleURLTracker(InfoBarDelegate, MapEntry)
on InfoBarService to instead be a dependence on infobars::InfoBarManager. The
only reason that InfoBarManager wasn't sufficient was that
GoogleURLTrackerInfoBarDelegate obtained the WebContents from the
InfoBarService. This flow is replaced by introducing an OpenURL() API on
GoogleURLTrackerNavigationHelper (GoogleURLTrackerNavigationHelperImpl
implements this API by calling through to its WebContents instance, which is
the same instance associated with the InfoBarService).

BUG=373231,373233

Review URL: https://codereview.chromium.org/293503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273821 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves the initialization of the hardware class on ChromeOS out of
MetricsService and into ChromeOSMetricsProvider via ChromeMetricsServiceClient.
MetricsService now pass |OnInitTaskGotHardwareClass()| as the callback to
ChromeMetricsServiceClient::StartGatheringMetrics().
ChromeMetricsServiceClient::StartGatheringMetrics() posts a task to the FILE
thread calling ChromeMetricsServiceClient::InitTaskGetHardwareClass(). The
latter function calls into ChromeOSMetricsProvider when on ChromeOS and
directly calls the callback passed to it on other platforms.

A followup CL will move the rest of the embedder-specific initial metrics
gathering flow out of MetricsService.

BUG=375776

Review URL: https://codereview.chromium.org/301633006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273820 0039d316-1c4b-4281-b951-d872f2087c98

This test was disabled because it was failing. A few changes have been made:
-The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption.
-testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091.
-The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory).

BUG=303491

Review URL: https://codereview.chromium.org/290803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273819 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378933

Review URL: https://codereview.chromium.org/306103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273817 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378516

Review URL: https://codereview.chromium.org/304153007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273816 0039d316-1c4b-4281-b951-d872f2087c98

As it was before r272170.

BUG=378879

Review URL: https://codereview.chromium.org/309483008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273815 0039d316-1c4b-4281-b951-d872f2087c98

Currently we only have testing for success case of the
manifest file. This CL adds a test case for testing when
a file resource is not found, and an entry is not found in
the manifest.

BUG=370895
TEST=Ran browser_tests --gtest_filter=*IrtManifestFile and trybots.

Review URL: https://codereview.chromium.org/303683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273813 0039d316-1c4b-4281-b951-d872f2087c98

It now creates a IViewManagerInit, which has the single method Connect
to connect to the route.

As suggested I disabled all the view_manager_lib_unittests until they
are converted to new connection logic.

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/308803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273812 0039d316-1c4b-4281-b951-d872f2087c98

accelerator_filter_unittest stays in ash because it requires ash.

BUG=375534

Review URL: https://codereview.chromium.org/307533007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273811 0039d316-1c4b-4281-b951-d872f2087c98

Added a second configuration that can support two http proxies and one https proxy. In the process, added a new DataReductionProxyParams object to encapsulate static configuration details and made DataReductionSettingsAndroid a BrowserKeyedContextService.

BUG=370039

Review URL: https://codereview.chromium.org/286013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273810 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343941

Review URL: https://codereview.chromium.org/303143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273809 0039d316-1c4b-4281-b951-d872f2087c98

GNU Gold was only partially respecting the provided order file mainly due to
the lack of the '.text.*' trailing line.

BUG=372323
R=pasko@chromium.org

Review URL: https://codereview.chromium.org/297063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273808 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377338
TBR=sergiu@chromium.org

Review URL: https://codereview.chromium.org/308713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273807 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367701
TBR=yutak@chromium.org

Review URL: https://codereview.chromium.org/301163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273806 0039d316-1c4b-4281-b951-d872f2087c98

Fails TouchEditableImplAuraTest.TouchCursorInTextfieldTest on Win7. See
http://crbug.com/377561#c4 for details.

> Enable touch text selection tests on all Aura platforms
> 
> In order to make touch text selection ready for Windows and other Aura
> platforms, a prerequisite is to enable tests. Following tests are
> enabled:
>  - TouchSelectionControllerImplTest in views_unittests;
>  - TouchEditableImplAuraTest in content_browsertests.
> 
> BUG=377561
> 
> Review URL: https://codereview.chromium.org/304883002

TBR=mohsen@chromium.org

Review URL: https://codereview.chromium.org/304253007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273805 0039d316-1c4b-4281-b951-d872f2087c98

Disabled the test on all platforms now because it fails on ChromeOS now as
well.

BUG=375910
TBR=sergiu@chromium.org

Review URL: https://codereview.chromium.org/304233008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273803 0039d316-1c4b-4281-b951-d872f2087c98

When docking is possible, but main window is undocked, we show toolbox
web contents. This means that undocked DevTools has two web contents
at the same time: one in a separate window, and one near the inspected tab.

BUG=327641

Review URL: https://codereview.chromium.org/294903014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273802 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/304393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273801 0039d316-1c4b-4281-b951-d872f2087c98

These executables are failing on Windows in Debug mode, very likely
because they're missing the Visual Studio runtime DLLs.

BUG=378021
TBR=maruel@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/302003006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273800 0039d316-1c4b-4281-b951-d872f2087c98

'pending version' seems outdated naming and the current spec uses
'installing version' or 'waiting version' instead.
This renames them mechanically.

Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/


BUG=379012
TEST=compile

Review URL: https://codereview.chromium.org/309453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273799 0039d316-1c4b-4281-b951-d872f2087c98

Reverting due to failing memory bots, see http://crbug.com/235263#c42 for
details.

> Add garbage collection for shared extensions on Chrome OS
> 
> Chrome OS specific garbage collection in addition to profile specific
> clean up also cleans up shared location but only once regardless number
> of logged in users.
> 
> BUG=235263
> TEST=unittest
> 
> Review URL: https://codereview.chromium.org/303693011

TBR=dpolukhin@chromium.org

Review URL: https://codereview.chromium.org/306023007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273798 0039d316-1c4b-4281-b951-d872f2087c98