- 20 Nov, 2019 40 commits
-
-
Hazem Ashmawy authored
Show a persistent error message if the user hasn't opted into crash collection: - If "--enable-crash-reporter-for-testing" flag isn't enabled. - AND GMS "Usage & Metrics" collection is not enabled. The UI has to be relaunched in order to update the error status. Bug: 1014825 Test: Check the error after with --enable-crash-reporter-for-testing flag on/off on upstream and downstream SystemWebView Test: Check the error after switching GMS "usage & diagnostics" settings on/off on downstream webview Change-Id: Idc1a74579cef267612bb5c5804f5b988c8c44c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914394 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#717223}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=xiyuan@chromium.org Bug: 1023677 Change-Id: I33792710ba7f52706e8e3eaaf3997dcc43482f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926815 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#717222}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=parastoog@google.com Bug: 1023677 Change-Id: I73531181fb5fd0f23b5620f11f67c89f21d01748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925185 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#717221}
-
Maggie Chen authored
InitializeStaticGLBindings function is mainly for loading dlls which don't call the GPU drivers or use the GPU hardware. This code separation is the pre-work for the GPU watchdog to guard the functions that use the GPU drivers or/and hardware only. Bug:949839 Change-Id: I3f0a2f7eab6b17689dd088208e4298d2d410a52f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854211Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#717220}
-
Wenbin Zhang authored
This CL added the test version check for PRESUBMIT by calling the load_tests() in system_health_smoke_test.py: https://chromium-review.googlesource.com/c/chromium/src/+/1850353 The load_tests() has logic of downloading non-local stories, thus it will fail the PRESUBMIT when the CL author does not have access to the stories. This CL separates the logic of version check and test downloading. Now in PRESUBMIT we only do version check. Bug: chromium:1024912 Change-Id: I40775ec91aebc2179640565f2c1836aee44d176e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918363 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#717219}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=asanka@chromium.org Bug: 1023677 Change-Id: Ifa0d71e864ccb33c4a51f945ead6a9f5ff4312f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925733 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#717218}
-
Olivier Li authored
The feature will soon be flipped to ENABLED_BY_DEFAULT. This will make HistoryServiceBackend's task runner dispatch to the ThreadPool instead of a dedicated base::Thread. The tests need to be prepared to stay functional when that happens. This is done as the last mile of the chrome-wide effort to coalesce as much work as possible to the ThreadPool. Bug: 661143 Change-Id: I3793de26ba54c7818ef3f710dd88c389e5d01297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924624Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#717217}
-
Michael Spang authored
Create new source_sets in each directory with the unit tests for the component that directory implements. This avoids having to add all tests directly ui/events/BUILD.gn. Bug: 1026406 Change-Id: Id3b462f655da31219c08131601e0bab8927bb1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925674 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#717216}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=xdai@chromium.org Bug: 1023677 Change-Id: I2a37dba9dcad0551d09a8d3df6d35403785a3c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927054 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#717215}
-
Gabriel Charette authored
We had landed the previously agreed upon API but recent design discussions have invalidated previous decisions. To stop the bleeding let's at least revert the documentation until we have a fully approved plan. R=altimin@chromium.org, darin@chromium.org Bug: 1026641 Change-Id: Idf0c2deafbd7fcd85541272f04fcd93cc745ce73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926533 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#717214}
-
Kevin Marshall authored
Disables time-multiple-fields-stepup-stepdown-from-renderer-hour.html because it is flaking on the testbot Mac10.13 Tests (dbg). TBR=dpranke@chromium.org Bug: 1026712 Change-Id: I13272a5c6306e66bb3eef26b9ff1572b5c6bc2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926995Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#717213}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=jdoerrie@chromium.org Bug: 1023677 Change-Id: Icb6700d62c0f13d14e1d2b6c1217f4821026dca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926812 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#717212}
-
pwarren authored
This CL extends the expiration milestone of the enable-vaapi-{jpeg,webp}-image-decode-acceleration browser flags until M83. Bug: 1025756 Test: Open chrome://flags and verify the flags are still there. Change-Id: Ice9843b266db49e5b72c86bbbcdb84cd297a2b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924696 Commit-Queue: Paulo Warren <pwarren@google.com> Reviewed-by:Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#717211}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=afakhry@chromium.org Bug: 1023677 Change-Id: I9a73d43c7318398caa8e13e238788e4319f6dedc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926999 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#717210}
-
Josh Nohle authored
In the fake v1 device manager, pass ExternalDeviceInfo vector by const ref. In the fake v2 device manager, expose the Instance-ID-to-device map member variable and the NotifyDeviceSync{Started,Finished} methods. Bug: 951969 Change-Id: I4856da01d885d25c1e48cc166a60d786f54ca713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925213Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#717209}
-
Jeffrey Cohen authored
For all sharing features in the case where the device name is not useful we should fall back to using a common naming scheme. This CL adopts that common naming scheme and moves it and the required helper functions into components for cross platform access. Bug: 1025362 Change-Id: Ibb20dc9db3a99b24f9688fd51838febab0419694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919738 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#717208}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=maxlg@chromium.org Bug: 1023677 Change-Id: I2eeca96350c31893f82ffa31c98777c2bcd42b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926800 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#717207}
-
Amy Huang authored
Bug: 1026283 Change-Id: I7c310bd09cba995ed648d8743aa62f5878698416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924872 Commit-Queue: Amy Huang <akhuang@google.com> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#717206}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=afakhry@chromium.org Bug: 1023677 Change-Id: I257bc3f2ffad224fbb7ab2542d748004a6871a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926924 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/639872c8ef6e..50696684f7a8 git log 639872c8ef6e..50696684f7a8 --date=short --no-merges --format='%ad %ae %s' 2019-11-20 ukai@google.com roll out new goma client binary Created with: gclient setdep -r src/third_party/depot_tools@50696684f7a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1026184 Change-Id: I57864306e1cb8c2b24055363894580abb7ad678c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926385Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717204}
-
Kevin Ellis authored
Bug: 960944 Change-Id: I09c84d7e5b08e1f3d12498d785acf50610b57a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926668Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#717203}
-
Shivani Sharma authored
This CL fixes the Network isolation key unittests so that they work even if append frame origin is enabled by default. Note that there is already tests that explicitly enable the feature, NetworkIsolationKeyWithFrameOriginTest. Also removes a test NetworkIsolationKeyTest.WithFrameOrigin which is redundant with NonEmptyKey, Operators and NetworkIsolationKeyWithFrameOriginTest.WithFrameOrigin Bug: 1026388 Change-Id: I0d395767daab00f074c8284f654a2d5875820bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924965Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#717202}
-
Gavin Williams authored
In order to make settings sliders more functional for users of screen readers we are adding more descriptive ARIA labels. -Update aria-roledescription to describe to users the context of the min and max values of a slider. For reference: Current slider ARIA output: "Slider. 120 percent. Min 60, Max 820" Video: https://bugs.chromium.org/p/chromium/issues/detail?id=1015839#c5 Expected slider ARIA output: "Slider: Slowest to Fastest. 120 percent. Min 60 Max 820" Video: https://bugs.chromium.org/p/chromium/issues/detail?id=1015839#c9 Bug: 1015839 Change-Id: Iff2ea48b9badde05c93534ed1f2d283abef87bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906941 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#717201}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=andrescj@chromium.org Bug: 1023677 Change-Id: I509e52204e61e7c1a65c809e9e512f4255c16f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925294 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd1a4c58..96bd79e5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I21d4e511927355160dd754b22f337b793c2a4060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926667Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717199}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1d181da138a1..bf7aa3c19ee3 git log 1d181da138a1..bf7aa3c19ee3 --date=short --no-merges --format='%ad %ae %s' 2019-11-20 aerotwist@chromium.org Migrates console/ to esm 2019-11-20 aerotwist@chromium.org Revert "Adding run_localization_check.py" 2019-11-20 aerotwist@chromium.org Revert "Do not require arguments to run run_localization_check.py" Created with: gclient setdep -r src/third_party/devtools-frontend/src@bf7aa3c19ee3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9b4c3a7fada1534d48926ed6a7a3354f6da83cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926653Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=michaelbai@chromium.org Bug: 1023677 Change-Id: I847a188ac082fc18e956f13859925b94977310e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926871 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#717197}
-
Lambros Lambrou authored
The host bundle and It2Me native-messaging host already include the icudtl.dat file. This CL adds it to the Me2Me native-messaging host bundle as well. Bug: 1026486 Change-Id: Ifa2d1174f767974b7fcdd3a94a9388a4854ff2e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926993 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#717196}
-
siyua authored
Change how backend cancels ongoing process when user presses the cancel button in the WebAuthn verify pending dialog. This change will explicitly reset the full card request is there is one. Bug: 949269 Change-Id: Icc4cc1597bcf31b0d42879a3cdf826b750ff15f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918139 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#717195}
-
Torne (Richard Coles) authored
WebView defaults to not allowing third party cookies since L, but normal browsers generally allow this. Enable third party cookies in the WebView shell to make it better reflect normal web behaviour. Change-Id: Idc7e8e704a8b28cc83746f895eff976e36524642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926925 Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#717194}
-
Eric Seckler authored
Follow-up from crrev.com/c/1925048. Change-Id: I4be72de71236693451a22877176a514f267e75be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926484Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#717193}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=jdoerrie@chromium.org Bug: 1023677 Change-Id: Ib8783f712c5d2608bf49c85bf4ca74ecae2c1e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926853 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=mmenke@chromium.org Bug: 1023677 Change-Id: I2c79823a1821bca8aa83b2bdb9f3a6fe014c4b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927018 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Jimmy Gong authored
- This fixes a regression in which we did not check if a discovered printer can actually be autoconfigured, which resulted in users not being able to add certain printers - This regression caused a metric to never be counted: Printing.CUPS.AddressResolutionResult - The fix is to always go call on AddDiscoveredPrinter when adding a printer from the nearby printers list. Bug: 1026057 Test: browser test + end to end manual Change-Id: I8b611eb682ef7e04dba452ea2fa232598c95d193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922968 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=xiyuan@chromium.org Bug: 1023677 Change-Id: I727d9518b3df34f7cfed79b09daf24bb7a8864c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926818 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Anqing Zhao authored
Considering base::Callback is to be deprecated, the PolicyRegistrationCallback defined in UserPolicySigninServiceBase should be changed to OnceCallback (not RepeatingCallback) which is recommended. Meanwhile, all references to this type are also updated. Bug: 948098 Change-Id: I06cdc9092380173c4905a94bd07430c6967d1ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924312Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#717188}
-
Anqing Zhao authored
Triggered by similar issue (948098), the PolicyFetchCallback defined in UserPolicySigninServiceBase should be changed to OnceCallback (not RepeatingCallback) because base::Callback is to be deprecated. Meanwhile, all references to this type are also updated. Change-Id: I63fd1511705f6ffadbba196f389c056a62b05eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924513Reviewed-by:
-
Daniel Clark authored
In https://chromium-review.googlesource.com/c/v8/v8/+/1860996, v8::SetSyntheticModuleExport was updated to make it throw an error (per spec) instead of crashing when given invalid input. Since the function is a public API, this required deprecating the existing version and introducing a new version with the correct behavior. This change switches Blink to use the new v8::SetSyntheticModuleExport so that the old version can eventually be removed. There is no behavior change with this CL as Blink always passes a valid value to SetSyntheticModuleExport. Change-Id: Iac832541eef22b88e6a4e199b8089386ba3f121e Bug: 1019269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885023Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#717186}
-
Demetrios Papadopoulos authored
This is in preparation of migrating to Polymer3. Bug: 1022212 Change-Id: Id485f270e70765c16e730c1887f56aec76fbcf22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923493Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#717185}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=xiyuan@chromium.org Bug: 1023677 Change-Id: Ifd428d78f6bd44b8b42298925a769f89dfab49b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926990 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
