- 19 Sep, 2019 40 commits
-
-
Sergey Ulanov authored
Previously FuchsiaVideoDecoder was incorrectly returning false from IsPlatformDecoder(). Change-Id: Ic845733de35a1e411ae54fe6379085c9581ddb5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809981 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697888}
-
Ionel Popescu authored
This CL updates the in-page UI for input type="time" by adding a time icon which will be used in order to open the popup. The new UI is tested by: time-appearance-basic.html The popup support for input type="time" will be added in future CLs. Bug: 1004997 Change-Id: I5dcea5bfd75c2e815565b38d1fa51a73164cb673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810057 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#697887}
-
Chih-Yu Huang authored
This CL adds a fieldtrial testing config for ChromeosVideoDecoder, that plans to turn on for all versions 79+. Bug: 984482 Change-Id: I729bb26bb719e9cc6112c89e363fd44c4b45a52e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810510Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#697886}
-
Peter Kasting authored
Make overrides match superclass access level and order, and make definition order match declaration order. No code change, just reordering. TBR=manukh Bug: none Change-Id: I4b36f022553781573244c99b47351d4a05cbb74f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812378Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#697885}
-
Manu Cornet authored
Add a test to prevent future regressions. Drive-by minor simplification of some shelf layout manager tests. Bug: 998899 Change-Id: I8a56c795a09e637bdf9d16cb1e3afb8a2bae1f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793662 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#697884}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6a17fd7fb73b..2ad535693f0f git log 6a17fd7fb73b..2ad535693f0f --date=short --no-merges --format='%ad %ae %s' 2019-09-19 rmhasan@google.com [Telemetry] Add release typ tag to telemetry's frozen set Created with: gclient setdep -r src/third_party/catapult@2ad535693f0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:999335 Change-Id: I56aa2baf4177f274fb8a230b846c64bbd2b4b467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812338Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697883}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f314a97e3bde..a6dba771b596 Created with: gclient setdep -r src-internal@a6dba771b596 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I2b5128fe7be867022ac350a564ee33536b512c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812348Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697882}
-
Aaron Gable authored
Thus builder existed to allow the mac-rel trybot to mirror something whose configuration didn't quite match that of the Mac10.13 Tests bot. That is no longer necessary (we're running webkit_layout_tests on mac-rel as of crrev.com/c/1793130) so this config can be removed. This change will not land until we're certain that webkit_layout_tests in the commit queue is stable. Bug: 944117 Change-Id: I0c63bd7ca6b83bcb1a91a3b77048a750caf35803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776855 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#697881}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/58f19530fefa..550e29b59884 git log 58f19530fefa..550e29b59884 --date=short --no-merges --format='%ad %ae %s' 2019-09-19 chrome-bot@chromium.org Update config settings by config-updater. 2019-09-19 ahassani@chromium.org cbuildbot: Deprecate FULL_AU_TEST_TYPE 2019-09-18 vapier@chromium.org cbuildbot: move GetTargetChromiteApiVersion out of cros_build_lib 2019-09-18 haddowk@chromium.org vm_test_stages: Increase the moblab_vm timeout 2019-09-18 vapier@chromium.org StringIO: migrate existing users to six.moves.StringIO 2019-09-18 dburger@chromium.org Add nyan_kitty as a chrome pfq important board. 2019-09-18 bmgordon@chromium.org cros lint: Enable new shellcheck checks Created with: gclient setdep -r src/third_party/chromite@550e29b59884 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I51e3449159d970b0dcb7290c22bfe08f507fbb63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812339Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697880}
-
Gyuyoung Kim authored
This CL applies pending_remote to RequestNotifications function in NetworkQualityEstimatorManager interface. Bug: 955171 Change-Id: I902e22e76e2f0b023c726cde648b832317ee8758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810166 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#697879}
-
Aaron Gable authored
These tests are run in 10 shards on other android builders (see config for chromium_gtests_for_devices_with_graphical_output, which runs on android-marshmallow-arm64-rel), but are timing out after an hour on Site Isolation Android, so might as well shard them here too. Bug: 1004551 Change-Id: I2dafbcc04c4f50704b86217b0985f520d18562db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811957 Auto-Submit: Aaron Gable <agable@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#697878}
-
Matt Simmons authored
R=yusufo@chromium.org Bug: 985386 Change-Id: I2b9d7e702bc35f71af58903b3379dcfd761fc06b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812094Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#697877}
-
Zhenyao Mo authored
This reverts commit d5ce90c8. Reason for revert: crbug.com/1005587 Original change's description: > If the backend texture is the same we let skia take care of it > > We are now using SharedImage to hold the image for the video renderer, > https://chromium-review.googlesource.com/c/chromium/src/+/1616978. > That change, together with the change that made the video be deferred, and > therefore, use the paintRecorder, let us safely remove the workaround. > > There was nevertheless the issue of texture lifetime to extend the texture. > If the backend texture is the same in the SkImage and the one contained > in the cache, we will let skia release it. If they are different, cache has > to destroy their own texture, and the one in skia will survive the delete. > > Bug: 974656, 991792, 993774, 994516, 996083, 1004780 > Change-Id: I3bf8c1037b77434a1cf0385872fc7d994886cd30 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789883 > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697370} TBR=dalecurtis@chromium.org,sandersd@chromium.org,fserb@chromium.org,khushalsagar@chromium.org,juanmihd@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 974656, 991792, 993774, 994516, 996083, 1004780, 1005587 Change-Id: Iccd3daa14e8ec0287850ec64eda37bad6e296169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812459Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697876}
-
Gyuyoung Kim authored
This is a reland of 8d32b638 The dependency should be "//third_party/blink/public/mojom:mojom_platform_blink_headers" Original change's description: > Reland "Include *.mojom-forward.h instead of .mojom.h from logging_utils.h" > > This is a reland of be56a0b9 > > Fix the build break caused by the missing dependency. > > Original change's description: > > Include *.mojom-forward.h instead of .mojom.h from logging_utils.h > > > > This CL replaces .mojom.h with .mojom-forward.h to reduce pre-processed > > size of logging_utils.h > > > > This CL has no behavior changes. > > > > Bug: 1001360 > > Change-Id: Idd305572c67e46a5f7a01937ec1d2e31fc62d8ea > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808619 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Kent Tamura <tkent@chromium.org> > > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#697134} > > Bug: 1001360 > Change-Id: I5a8112a21782863c6420eddd2fe717d368419b90 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808953 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#697475} Bug: 1001360 Change-Id: I322956ee2361e6c913bd27e8e80b12cff745ccaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810502Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#697875}
-
Gavin Williams authored
-Use a function to prevent tooltips from showing for account names. We only want tooltips for email addresses. Bug: 836777 Change-Id: I997843b39b2e662195e8e852bde5408504726b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807563Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#697874}
-
Andrew Xu authored
The scrolling offset's upper bound may change after display rotation. As a result, a legal scrolling offset may become illegal due to rotating display. This CL fixes such an issue. Bug: 1000764 Change-Id: I1ddbd3bc2c333afd9364292baa3fb6d9362e7acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811183Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697873}
-
George Zhang authored
Bug: 1002956 Change-Id: Ic36813f80cd7861531212bd46bd0e6d0af36a90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804184 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#697872}
-
Anton Bikineev authored
This completely removes all uses of GarbageCollectedFinalized from Blink. Now finalization of a class dependents on its destructor being non-trivial. Bug: 990913 Change-Id: I8162306fdfab9817cdea54ec9c23e9f6165ce98a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796352 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697871}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e330eace. With Chromium commits locally applied on WPT: 13765318 "[WPT/common/security-features] Introduce iframe-blank source context" bda4c129 "Revert "Re-land: Fix `Referer` for descendant module scripts and worklets"" 55a477b6 "Implement word boundary matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I89053b342c26e455666ae273cb0e06b12d55fabc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811184Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697870}
-
Julie Jeongeun Kim authored
This CL converts DistillabilityServicePtr and DistillabilityServiceRequest to new Mojo types. It uses Remote and PendingReceiver instead of DistillabilityServicePtr and DistillabilityServiceRequest. Bug: 955171 Change-Id: I80b0a36c9c92595e28333ab69e339d2235ec0015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810143Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#697869}
-
Julie Jeongeun Kim authored
This CL converts ContextualSearchJsApiServicePtr and ContextualSearchJsApiServiceRequest to new Mojo types. It uses Remote and PendingReceiver instead of ContextualSearchJsApiServicePtr and ContextualSearchJsApiServiceRequest. Bug: 955171 Change-Id: I2e7c0c5fc10303a949bf57bb1bc1df02f5fa7763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810162Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#697868}
-
Gyuyoung Kim authored
To reduce pre-processed size of fetch_api_request_body_mojom_traits.h and fetch_api_request_headers_mojom_traits.h, this CL replaces .mojom.h with .mojom-forward.h. This CL has no behavior changes. Bug: 1001360 Change-Id: I1360771e268e7e079b9d9f05685c7af138c4f0e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806533Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#697867}
-
Julie Jeongeun Kim authored
This CL converts DistillerJavaScriptServicePtr and DistillerJavaScriptServiceRequest to new Mojo types. It uses Remote and PendingReceiver instead of DistillerJavaScriptServicePtr and DistillerJavaScriptServiceRequest. Bug: 955171 Change-Id: I3ed215819ca30938263d2889f4e668765b7ed59c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810158Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#697866}
-
Alan Cutter authored
This CL is a simple code-shuffle that orders the PageActionIconType enum alphabetically and updates the OmniboxPageActionIconContainerView members to match the enum names consistently. Note that this does not change the order of the icons visually, that is determined by the order they appear in |OmniboxPageActionIconContainerView::Params::types_enabled|. Bug: 788051 Change-Id: I73160acd67aec5fe760b3b5ff64a252aedda1c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808945 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#697865}
-
Julie Jeongeun Kim authored
This CL converts DistillerPageNotifierServicePtr and DistillerPageNotifierServiceRequest to new Mojo types. It uses Remote and PendingReceiver instead of DistillerPageNotifierServicePtr and DistillerPageNotifierServiceRequest. Bug: 955171 Change-Id: I58c338d275c7d0283177a80d9d1da986d8de2304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809130Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#697864}
-
John Lee authored
This CL hides the thumbnails before their data has loaded, and makes sure the thumbnails stay a specific width and height even when its container is animating in and out. Bug: 989131 Change-Id: Ife459fae30b8f894860b81f223d053f5bc470a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809599 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#697863}
-
Joel Hockey authored
If import fails for any reason such as being disallowed by policy, it is helpful to log the result code. TBR=juwa@google.com Bug: 1003944 Change-Id: I38eff42f2981a8c166b1d7f4708879f1f3497de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808949Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#697862}
-
Miyoung Shin authored
This CL converts SerialPortConnectionWatcher{Ptr, Request} in services, extensions and content to the new Mojo type, uses pending_remote<SerialPortConnectionWatcher> in serial.mojom. Bug: 955171 Change-Id: I9de80363a902bb45f0df4f56d9c0be4d78c98f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810500Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#697861}
-
yilkal authored
This CL splits SupervisedUserErrorPage from NetErrorHelper. The splitting enables us to install SupervisedUserErrorPageController for subframes. Bug: 850328 Change-Id: I8cbb71a9d7ee595ecd0653ea3b4ef06a0e78a99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752105 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#697860}
-
Manu Cornet authored
Bug: 996417 Change-Id: I63497b2b03110a68bc5f1b64feaeda8ab8792b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811816Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#697859}
-
Matt Simmons authored
If tab models are restored while the overview is visible, update the tab switcher with the updated list. R=wychen@chromium.org Bug: 990982, 955436 Change-Id: Ia7c63e35624dd37cd7ff0063727ba64d040fe3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769298Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#697858}
-
Akihiro Ota authored
This change: 1. Creates a new class in ChromeVox called PhoneticData. This class stores phonetic disambiguation data and exposes an API that can be called to get the phonetic disambiguation for a character in a provided language. 2. Adds a call in tts_background to the new API when moving through editable text by character. Change-Id: I7631761219812d5588f95930e65231374178f96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772422 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#697857}
-
Miyoung Shin authored
This CL converts FileSystemPtr in content to the new Mojo type. Bug: 955171 Change-Id: I367ee37e060b8f79bd53bfe6e363c4bdb3cbba0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810506Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#697856}
-
Gayane Petrosyan authored
Bug: None Change-Id: I8ad45d279b2e649c6f2a19400367605d6cbfe693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811964Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#697855}
-
Antonio Gomes authored
It is an empty folder now. BUG=787254 R=haraken@chromium.org Change-Id: Ie970a5fc4c92d02a8379df5dd5db7dfd4e6ea992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806848 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#697854}
-
Henrique Ferreiro authored
Convert the implementation and all users of the feed_internals::mojom::PageHandler interface. Bug: 955171 Change-Id: I9d85ac453e31e111596adf469b4cba9cb2867253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807828Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#697853}
-
Julie Jeongeun Kim authored
This CL converts NaClRendererHost and NaClExitControl to new Mojo types. It also updates ProvideExitControl from nacl.mojom and methods and members which implement it. Bug: 955171 Change-Id: Ie6b875e07796b08818825474e8493e5f48072c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810509Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#697852}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b95eac85df9..f314a97e3bde Created with: gclient setdep -r src-internal@f314a97e3bde If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1000513 Change-Id: Ia26f67ed2744f826667db3292755c426a8f22e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812240Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697851}
-
chrome://media-appchrome://media-app-guestTrent Apted authored
Installs these routes as webui with basic structure and no permissions. Code added as a component in //chromeos/components/media_app_ui so that any chrome dependencies are clearly documented. --enable-features=MediaApp is required to enable the app at runtime on ChromeOS. The app is loaded as a guest (currently in an <iframe>) hosted in another chrome:// WebUI host that may be granted privileges in future. Currently the WebUI loaded in the <iframe> uses a chrome:// scheme, but this is not the long-term plan. A js2gtest is added with a test fixture that enables these flags and does integration testing. A build-time flag, enable_cros_media_app determines the bulk of what is served inside the sandboxed guest. When false, it provides a mock that facilitates integration testing even when is_chrome_branded is false. An internal change - https://crrev.com/i/1646974 - provides the content when is_chrome_branded is true (enable_cros_media_app must be set manually in args.gn until that lands). Bug: 996088 Change-Id: Ied7a41795409bdc8c028e63155f37452be84532e Test: MediaAppUIBrowserTest.WebviewHasAppElement Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767457 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#697850}
-
Sarthak Shah authored
This CL adds a flag parameter named "Enable experiment fling animation". This flag will be consumed by Gerrit CL https://crrev.com/c/1773872. Change-Id: I931b6034f76957d868c3e4f95f1cd1d5f7bfd26a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804460Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Sarthak Shah <sarsha@microsoft.com> Cr-Commit-Position: refs/heads/master@{#697849}
-