- 18 Aug, 2020 40 commits
-
-
Peter Boström authored
This prevents dialogs from being instantly accepted on Mac if holding VKEY_RETURN as the dialog pops up. Specifically it addresses a security issue where people can be tricked into holding enter while the site pops up a folder-selector dialog. The attack worked as following. The attacker tricks the victim into holding VKEY_RETURN. While the key is being held, the attacker triggers folder upload, which the OS auto-accepts by holding VKEY_RETURN. Before this change, FolderUploadConfirmationView would trigger on Mac with this VKEY_RETURN. With this change, the victim at least has to re-press VKEY_RETURN, which they are presumably at least more likely to notice. This also adds initialization of the EF_IS_REPEAT flag on Mac from [NSEvent isARepeat]. Hopefully that doesn't have wider negative consequences where ui::Event and NSEvent disagrees on the definition of a repeat event. Bug: 1097724 Change-Id: I3bb0589867cbfa059a2406e73ef43e66b5326fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357520Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#799364}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0c2650ad..df143e8b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I573a2c4de279a1db4890d6bd9050a7cec8f2804b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363189Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799363}
-
Alex Gough authored
Following https://phabricator.services.mozilla.com/D54699 we do not need to supply the handle for the shared memory IPC mechanism to the child until the IPC server has been initialized. Bug: 1092010 Change-Id: Id82f88513b77db159adf96dbac577ed80de1d37a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337394 Auto-Submit: Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#799362}
-
Ankit Kumar 🌪️ authored
Migrate all instances of pp::Point to gfx::Point/gfx::Vector2d at PDFEngine interface. The internals still have pp::Point dependency but the interface is now independent of pp::Point. The internal dependency will be migrated in a subsequent CL. Bug: 1101101 Change-Id: Ib8a729314ec6101183281235d35afc697a243b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326512Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#799361} -
Wei Lee authored
Since we are about to migrate CCA to SWA, we should avoid using chrome.* API so that we can have it work on SWA as well. Therefore, replacing chrome.system.display API by our own mojo API. Bug: 1114967, 980846 Test: Launch CCA without showing error messages Change-Id: I89aaf3f2700adfade8dd8eae32554ac095bb0ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354109Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#799360}
-
Yuke Liao authored
This CL moves interactive_ui_tests out of experimental state so that it's sherrifed to prevent regressions. Bug: 1111979 Change-Id: Icb1f00acb09939b01b2946256bcf334611fba3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363024Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#799359}
-
Olesia Marukhno authored
Bug: 1117550 Change-Id: I7ac6b9323174fa91f33471b7aa9202d2cec0de21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362792Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#799358}
-
Dominic Mazzoni authored
Enabling Switch Access can only be done from a user profile. However, once it's enabled, it needs to be possible for a switch access user to reboot or sign out and still control their device. So, every time a switch access pref is changed in a signed-in user profile, sync that same pref value to the signin profile. That way the next time the user is on the signin screen, switch access continues to work with their same settings. If someone else wants to use the machine and doesn't want switch access enabled, they can turn it off in the quick settings. Bug: 1108808 Change-Id: I136abcddc59f76d7b6ba9c55e2b4cb0607c4ab36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361662 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#799357}
-
Sky Malice authored
TBR: timvolodine@chromium.org Bug: 1117683 Change-Id: Ibb9538fc0530dd48effa973af8628565af639b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363486Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#799356}
-
Shakti Sahu authored
This CL is a precursor to moving ThinWebView to components. Only dependency on chrome layer was TabHelpers which was moved to a ThinWebViewInitializer interface. Bug: 1116770 Change-Id: I24fdd93e35ae24d9bede953e32c68b0fd7024ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358993 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#799355}
-
Lukasz Anforowicz authored
After r797542 (which removed SiteInstanceImpl::GetRequestInitiatorSiteLock) we always use an exact origin (never an approximate site) as |request_initiator_site_lock|. Because of that, this CL renames ..._site_lock to ..._origin_lock. Bug: 918967 Tbr: mmenke@chromium.org (//chrome/renderer/net) Tbr: dbertoni@chromium.org (//extensions/browser) Tbr: chromium-metrics-reviews@google.com (histograms.xml) Change-Id: Ifbe801eafccd641d11cb14ecef83ab097d01eb0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274251Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#799354}
-
Eric Orth authored
Bug: 1093361 Change-Id: Ic580fd7351b0d397a65b8ff882eee58156e287d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342389Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#799353}
-
Caleb Raitto authored
Bug: 973801 Change-Id: Ibe6dcee62b3fcbae9ad6dddcb200cf1df81bd077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350360Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#799352}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1fdcaafe. With Chromium commits locally applied on WPT: 1e2e0f67 "Revert "webrtc: add wpt test that setCodecPreferences changes the sdp"" fc224cf2 "Origin isolation: rename the getter (but leave an alias)" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/x-frame-options NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ieb3516ec564f13f2672622d8416f9678e1dd86b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363588Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799351}
-
Abigail Klein authored
Ensure that the disconnect handler which calls the caption host is bound to the same thread. This fixes a data race bug found by Clusterfuzz. Bug: 1055150, 1116338 Change-Id: Idfaab83da0b918181bb1296c5e753a06bad388cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359405Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#799350}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a5a97b4858fb..59a3c3be94f0 2020-08-18 fmalita@chromium.org SFML [1] backed for SkAudioPlayer/Linux 2020-08-18 brianosman@google.com Tweak viewer's shader panel 2020-08-18 johnstiles@google.com Add support for more basic types in SkSLCPPCodeGenerator. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: Ia68d518ad570adc4513f752b140ab86ac0a1b0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363180 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799349}
-
Christian Biesinger authored
Some tests are already passing in legacy; remove expectation lines for them. R=ikilpatrick@chromium.org Bug: 1083010 Change-Id: I99284a4794e2f547f38ba4fb366a25506a926b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360501 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#799348}
-
Renjie Tang authored
In QUIC with TLS, when 0-RTT keys are available and the session doesn't require confirmation, run crypto callback to notify QuicStreamFactory that the session can be activated. Bug: 1117331 Change-Id: I9863bf2cc03250393f67af2420313dfbf585ffad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363629Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#799347}
-
James Cook authored
Also move it into namespace crosapi. This is more consistent with our current naming conventions. Bug: none Test: compiles Change-Id: I1859bb7f3afde20aca7cf9dd516d06fd62118883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362732Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#799346}
-
Xiaodan Zhu authored
Bug: 1010200 Change-Id: Ie3d552b6108c491e12510fb32f544a0d0f938453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353548Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799345}
-
David Maunder authored
Previously operations were run concurrently which may lead to incorrect results. For example, a delete may follow a save on the queue, but the delete may finish executing first which makes it ineffectual. Bug: 1116506 Change-Id: Ia6136f8fbc9775c89fd1427aa736cdd6d972c662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356830Reviewed-by:
-
Yuke Liao authored
This CL runs interactive_ui_tests on linux-lacros-rel to prevent regressions. Bug: 1116180 Change-Id: I037ef2132bd6cb2cbd741c08c53fd13b5814746d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363367Reviewed-by:
-
mark a. foltz authored
This fixes a potential UAF in PresentationConnectionCallbacks::OnSuccess. Bug: 1116706 Change-Id: I25fc55edf968f41bfedecbeb2054a5eae56d0de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361025Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#799342}
-
ssid authored
Change-Id: Id7450cd05f2e9263e4573a89290519a5649c4f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361538 Auto-Submit: ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#799341}
-
Mike Wasserman authored
Add origin_trial_feature_name to runtime_enabled_features.json5 entry. Pass execution contexts for RuntimeEnabledFeatures checks. Remove superfluous Screen DCHECKS: - Screen IDL properties are RuntimeEnabled - |display_| is only set non-null by runtime-enabled getScreens API - The context for the DCHECK is not plumbed to Screen by that API Add Screen interface implementation TODOs to use a dictionary instead. Skip property tests for proposed window.screen properties: - Filed crbug.com/1117660 for unexpected test breakage - TODO(crbug.com/1116528) comments explain this will be moot Add basic API entrypoint test. Related tests already exist in: third_party/blink/web_tests/external/wpt/screen_enumeration/ third_party/blink/web_tests/external/wpt/fullscreen/api/element-request-fullscreen-options.tentative.html third_party/blink/web_tests/webexposed/global-interface-listing* Bug: 897300 Change-Id: I3083f8f53736027358ef2146cec60186adb8eeca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357632 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#799340}
-
Tommy Li authored
This reverts commit 1b2b4828. Reason for revert: I think this is causing ongoing flakiness: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel?limit=200 OobeInteractiveUITest.SimpleEndToEnd https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyRgsSBUZsYWtlIjtjaHJvbWl1bUBicm93c2VyX3Rlc3RzQE9vYmVJbnRlcmFjdGl2ZVVJVGVzdC5TaW1wbGVFbmRUb0VuZAw Original change's description: > Reland "Oobe: enable child specific signin feature" > > This is a reland of e771c29c > > Original change's description: > > Oobe: enable child specific signin feature > > > > Bug: 1101318 > > Change-Id: I47864f53018fb7b6ca1fd675953247a6dadc1f7c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352824 > > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Commit-Queue: Yunke Zhou <yunkez@google.com> > > Cr-Commit-Position: refs/heads/master@{#798671} > > Bug: 1101318 > Change-Id: I73f8f871c4063b0b8f3718eeb974881728071ff5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360061 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Yunke Zhou <yunkez@google.com> > Cr-Commit-Position: refs/heads/master@{#799026} TBR=xiyuan@chromium.org,antrim@chromium.org,alemate@chromium.org,rsorokin@chromium.org,yunkez@google.com Change-Id: I54a2c5fac3fd9257c24d840da37a8718209fb373 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363650Reviewed-by:
-
Lei Zhang authored
- Reorder overrides that are incorrectly grouped. - Separate a non-overridden method from the overrides group. - Reorder an enum declaration and mention why it is public. Change-Id: I9d359631c8e8be21780a656866a91fac6e62d3c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363634Reviewed-by:
-
Ryan Hansberry authored
(This is reland of crrev.com/c/2322166. It was reverted because of a race access of |[receive|send]_stream_| in [Receive|Send]More() immediately after the stream was reset during [Input|Output]Stream::Close(). This is addressed by posting stream watcher teardown to the dedicated IO sequence. The original CL is in Patchset 1, and the fix is in Patchset 2.) Implement a concrete location::nearby::api::BluetoothSocket, created via a bluetooth::mojom::Socket and Mojo DataPipes supplied by the newly implemented BluetoothClassicMedium::ConnectToService(). Nearby Connections uses this BluetoothSocket to communicate with a remote device. At a high-level, it first exchanges frames to encrypt the connection, then delegates to its caller (e.g., Nearby Share) to authenticate the connection, and finally expects its caller to send and receive application-level messages. The following precautions are taken to handle untrusted bytes received from remote devices: * Nearby Connections (including the code being added in this CL) is hosted in a Nearby utility process. * Whenever Nearby Connections provides bytes received from a remote device to its caller, even after it has been authenticated, the caller must not trust those bytes, and is responsible for first passing those bytes through the trusted NearbyDecoder interface (see go/nearby-chrome-mojo). NearbyDecoder is hosted in the same Nearby utility process. api::BluetoothSocket is a synchronous interface, so this implementation consumes the synchronous signatures of bluetooth::mojom::Socket methods. api::BluetoothSocket's subclasses are also synchronous interfaces, but the Mojo DataPipes they consume only provide asynchronous interfaces. This is reconciled by blocking on the caller thread when waiting (via a mojo::SimpleWatcher) for the DataPipes to become readable or writable (this is expected by the callers of api::BluetoothSocket's subclasses). Mojo DataPipe operations are handled on a separate task runner so that blocking on the calling thread will not deadlock. Please see design doc go/nearby-chrome-bt for more details. Bug: b:154849033, b:158848873 Change-Id: Ie00b18b6675c00e32c47a979f23b5d434941ba6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356271 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:James Vecore <vecore@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#799337}
-
George Steel authored
Add logic to distinguish between transitions which should (base computed style changes) and shouldn't be cancelled when transition is completely unset (as the default is all 0s). Currently, both are still cancelled, the same as the old behaviour, but the histogram kCSSTransitionCancelledByRemovingStyle is now only incremented when transitions are cancelled incorrectly. Add WPT for not cancelling transitions then unsetting transition property, fix web_tests to cancel transitions by setting transition to none instead of unsetting. Bug: 934700 Change-Id: Iaf4bf324e6e2bd6ca22a66fd8ae2320620a874dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363173Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#799336}
-
Peter Boström authored
Bug: 1102894, 1106422 Change-Id: I10d0b758c92760f42a1d8493bc594dabf01d7586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360906 Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
-
David Bienvenu authored
Also make more methods const and miscellaneous cleanup. No functional changes. Change-Id: I92004b1cdcdee52673eb71d52b6d54689d50d85b Bug: 1010217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363072 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
-
Daniel Hosseinian authored
This reverts commit fd6ef652. Reason for revert: This change broke linux-lacros-tester-rel Original change's description: > Add "Save to Drive" deprecation warning under destination select > > Add a deprecation warning message for the "Save to Drive" destination > under the destination select. > > Screenshot of change: https://imgur.com/ix1GjIB > > Bug: 1112581 > Change-Id: Icecc4e90e97f0e4faae0ceca32e19fe10a5de51f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353555 > Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799230} TBR=rbpotter@chromium.org,dhoss@chromium.org Change-Id: I67e541e2ec150dcac2b2de8a075b506201f35c58 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363700Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#799333}
-
Chong Gu authored
Bug: 1058255 Change-Id: Ib01d1967799e93b2c94352060fa4eaefc974602a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363689 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#799332}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/552d3e3d5ee9..577fc0c395d8 2020-08-18 jasonlon@google.com Moved Asynchronicity From Java to C++ for AndroidVoip Demo App If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib1995bc073a694869f60b50470c1b6d50173d6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363635Reviewed-by:
-
Shahbaz Youssefi authored
ANGLE exposes a new extension built on top of EXT_external_objects, namely ANGLE_external_objects_flags. This extension, exposing ANGLE_memory_object_flags, introduces new entry points for texture import similar to those defined in EXT_memory_object. These functions take the VkImageCreateFlags and VkImageUsageFlags values used to create a Vulkan image, instead of assuming all usage bits are specified. This is an optimization particularly on ARM (e.g. some Fuchsia devices) where specifying VK_IMAGE_USAGE_STORAGE_BIT is detrimental to performance as it disables framebuffer compression. Bug: fuchsia:52759 Change-Id: I6068cc2e0f41cc6a16fc31d535ff269b669d0d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340182Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Cr-Commit-Position: refs/heads/master@{#799330}
-
wutao authored
Restrict the ambient mode flag to only Chromium builds and the Canary/Dev channels. Bug: b/148692733 Test: manual Change-Id: I2554d6d1d07b57eafc079722e188cf079031d3ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361284 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#799329}
-
Yuke Liao authored
This CL does 2 things: 1. Disable two more flaky browser test. 2. Refactor the test filters to use wildcard instead listing all tests. Bug: 1111979 Change-Id: I2c69416c3c7d59e0ae14c3ff715cd082df268a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363395 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
-
Li Lin authored
This CL update the strings for reauth and add user. Follow up CLs will update the strings for other use cases. Bug: 921142 Test: unit tests Change-Id: Ib6c1daa363bdd6e901e1f5842bd274c4b6d85e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347003 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799327}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9d0f7dea2a59..0795384a7997 2020-08-18 treehugger-gerrit@google.com Merge "Add size_bytes field to MemoryNode message." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1a57e2054cdef162b39cb429b2be6e022e4df7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363475Reviewed-by:
-
Zhaoliang Ma authored
memcpy is used to copy src a plane to the dst plane, this CL replaces it with libyuv::CopyPlane. Bug: None Change-Id: I6508e2bfecd24e71504d0495ec9f9b5ad8a5b402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360507 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799325}
-
