- 20 May, 2019 40 commits
-
-
Mihai Sardarescu authored
This CL updates the setting earl grey test to run with unified consent feature enabled. It also adds the settings earl grey tests to the list of tests that are run on the unified consent enabled bot. Note: There are a significant number of earl grey tests for settings, so this CL will significantly increase the time it takes to run the tests on the ios-simulator-full-configs bots. However the unified consent enabled bot is temporary and the current plan is to remove it once unified consent feature is enabled by default. Bug: 960260 Change-Id: If16d2d48f739b3e5e405a8b8976b84f75581e665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617443 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#661361}
-
Maksim Ivanov authored
This CL renames variables that have obsolete names like "gaiaAuthHost", now that the "GaiaAuthHost" class doesn't exist anymore and is finally renamed to "Authenticator" everywhere (see crrev.com/c/1605919). Also fixes some comments that were referring to the old "auth host" thing. This is a pure refactoring CL, no functional changes are expected. Bug: 470893 Test: existing tests Change-Id: Ia07803527e0bf9148e021266cb2e2bc9a1fa67ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617832Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#661360}
-
Madeleine Barowsky authored
Marking external/wpt/css/css-scroll-snap/scroll-margin.html as flaky. This was previously disabled for prefix virtual/threaded, but because of a wpt change, we expect the test to flake for all variants. TBR=majidvp@chromium.org Bug: 964239 Change-Id: Iee686a55ff9142a81a495ee211b65cbb5a0aa508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619833Reviewed-by:
Madeleine Barowsky <mbarowsky@chromium.org> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#661359}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6fbc2c914856..fc311e53e3ef Created with: gclient setdep -r src-internal@fc311e53e3ef The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mbarowsky@google.com,sidereal@google.com Change-Id: Ia788396cfd8c470312bf86d397b91f5041803b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619657Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661358}
-
Antonio Gomes authored
... in favor of CrossThreadBindOnce. Reasoning: this method schedules a task that runs once. Hence, coneptually CrossThreadBindOnce is the bind helper to be used. BUG=963574 R=haraken@chromium.org, hiroshige@chromium.org Change-Id: I0c1eede1ecbffeea3a14bacbd81fff40ce702712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619826 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#661357}
-
Lowell Manners authored
Change-Id: Ia76df39e002edc45a9326862db7272a5a21830b3 Bug: 786836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571686 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#661356}
-
Lutz Justen authored
Adds a Chrome OS-only dialog to add Kerberos accounts and displays it in the Kerberos Accounts settings page when the 'Add account' button is clicked there. The dialog is functional, but needs further polish and UX review. The functionality is guarded by the KerberosEnabled policy (off by default, cannot be enabled so far except for dev purposes). BUG=chromium:952238 TEST=Turn on KerberosEnabled policy, e.g. in YAPS or with a json file on the DUT in /etc/opt/chrome/policies/managed/ with contents { "KerberosEnabled": true } (requires writeable rootfs). Note that there's no admin console UI yet. On Chromebook, navigate to chrome:settings/kerberosAccounts, click Add account. Verify that the 'Add Kerberos Account' dialog opens. You might be able to log in with an Active Directory account (e.g. chromeadm-lab.com), but at the time of writing the Kerberos system daemon is not ready, so you should see some error. Change-Id: I94c07c8cbbb59c9b4153929c88a534a9a36210f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596427 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#661355}
-
Jamie Madill authored
This reverts commit 679cb8c1. Reason for revert: Breaking ANGLE tests. https://ci.chromium.org/p/chromium/builders/ci/Linux%20FYI%20dEQP%20Release%20(NVIDIA)/68569 Bug: 965008 Original change's description: > Roll src/third_party/SPIRV-Tools/src 9dfd4b835807..47741f05043a (2 commits) > > https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9dfd4b835807..47741f05043a > > > git log 9dfd4b835807..47741f05043a --date=short --no-merges --format='%ad %ae %s' > 2019-05-17 kpet@free.fr Validate OpenCL memory and addressing model environment rules (#2589) > 2019-05-16 33432579+alan-baker@users.noreply.github.com Validate construct exits (#2459) > > > Created with: > gclient setdep -r src/third_party/SPIRV-Tools/src@47741f05043a > > The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com > > Change-Id: I5d89ae5309cd8d3a201ffb88a62ae722719cf646 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619654 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#661340} TBR=ynovikov@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com,radial-bots+chrome-roll@google.com Change-Id: Icc607f8d6169e4ec358f999e46179fea6239c7bf No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618031Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#661354}
-
Christian Dullweber authored
Wait until BrowsingDataRemover is done before checking whether the ServiceWorker has been removed. Bug: 912313 Change-Id: Ic0e269b27554713a5f5327a33fa894c040e5c9bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617347 Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#661353}
-
Xiaohui Chen authored
Locked fullscreen mode is a special fullscreen mode used for administering quizzes to students on Chrome OS devices (where the user is basically locked inside of one browser window). Assistant is breaking the mode since it allows students to lookup answers to questions. Fix this by disabling the Assistant inside the mode. Bug: 952037 Test: locally build and test with lock screen mode on. Change-Id: I1b9e539374346f247d15ad65e7d11bfe35b4405b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616942Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#661352}
-
Rouslan Solomakhin authored
Before this patch, the logic for payment method change differed between the web-based payment handler and the built-in Google Pay integration on Android, which caused possible differences in logic. This patch passes the same parameters and uses the same code paths for payment method change to the built-in Google Pay integration as to the web-based payment handlers. After this patch, the logic and data for payment method change should be identical between web-based payment handler and the built-in Google Pay integration. Bug: 884680 Change-Id: I8558899a40c75b90eae21a6f4df687175893bb08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613964 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#661351}
-
Rohit Rao authored
This file only uses NSString, so it does not need all of UIKit.h. Switching to Foundation.h makes it easier to compile this file into the EG2 test process. BUG=None Change-Id: Id76cf9ed46263a996a5d696cc9bdf5e04cf38eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619830Reviewed-by:
-
Josh Nohle authored
See design at http://go/cros-devicesync-v2-scheduling Bug: 899080 Change-Id: If465d2b1d4a9088f43fcdc9192d59f3b425270ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606967 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#661349}
-
Daniel Bratell authored
There are currently two GetWebContents and two GetBrowserClient in content/browser. In certain non-default extreme jumbo builds GetWebContents in storage_partition_impl.cc and GetWebContents in network_service_client.cc could end up in the same translation unit and it would not compile. There were also one GetBrowserClient in storage_partition_impl.cc and one in clear_site_data_throttle.cc This renames one of the functions GetWebContents -> GetWebContentsForStoragePartition and one GetBrowserContext -> GetBrowserContextFromStoragePartition Bug: 952723 Change-Id: I85207edde5fcb85eaa6f32cf22ca05a6e324237b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617837 Auto-Submit: Daniel Bratell <bratell@opera.com> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#661348}
-
Mihai Sardarescu authored
This CL updates the bookmarks earl grey test to run with unified consent feature enabled. It also adds the bookmarks earl grey tests to the list of tests that are run on the unified consent enabled bot. This CL also fixes the test testSignInPromoWithWarmStateUsingPrimaryButton that was actually tapping the secondary sign-in button (not the primary one), and thus was a duplicate of testSignInPromoWithWarmStateUsingSecondaryButton. Note: There are a significant number of earl grey tests for bookmarks, so this CL will significantly increase the time it takes to run the tests on the ios-simulator-full-configs bots. However the unified consent enabled bot is temporary and the current plan is to remove it once unified consent feature is enabled by default. Bug: 960260 Change-Id: I6a998fb29b1dd352c37dcc9ace516a0254b804e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617513 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Yi Su authored
This CL moves WKNavigationDelegate.didReceiveServerRedirectForProvisionalNavigation from CRWWebController into CRWWKNavigationHandler. CRWWebController.didReceiveRedirectForNavigation:context is also moved into CRWWKNavigationHandler and temporarily exposed as a public method. It will be removed when WKNavigationDelegate.didCommitNavigation is moved into CRWWKNavigationHandler. Bug: 956511 Change-Id: I27e8d994544a1e54bdf46a39e3114b1195064296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617827Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#661346}
-
Jordan Demeulenaere authored
* Before: https://screenshot.googleplex.com/hmVvTEU3Bg7.png * After: https://screenshot.googleplex.com/Cp3bg0Wqt7m.png Screenshots: Change-Id: I3c3563eb895fde6a0fd86ab25625eb68aa0ce598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617828Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#661345}
-
Tanmoy Mollik authored
This cl is part of the effort to use CoreAccountId instead of std::string to denote account_id. Bug: 959157 Change-Id: I0fd318d8034fb1294336f7534eb672fd1faeb084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611996Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#661344}
-
Eugene But authored
README says: "This directory contains API to search for text on a web page. This directory does not support any UI API except content highlighting." Bug: 942244 Change-Id: I8e683ac1a99783becf39fbc7f8bd61017c017641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619209 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#661343}
-
Vadym Doroshenko authored
This CL reproduces the same behaviour with NewPasswordFormManager as for PasswordFormManager. Bug: 831123 Change-Id: I7ade6f857adfb1d4ec09a8a4333f4e90e9e485b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619688Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#661342}
-
Robbie Gibson authored
There are two areas to improve our flag handling. First, the default iOS keyboard replaces two dashes with an em dash, so typing that in as a flag is difficult. Second, all flags start with dashes, so the code can fallback to add them if they don't exist. Bug: 964930 Change-Id: Ifeee11343381b7a8587499512fab1c3f78ba7548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617839 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#661341}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9dfd4b835807..47741f05043a git log 9dfd4b835807..47741f05043a --date=short --no-merges --format='%ad %ae %s' 2019-05-17 kpet@free.fr Validate OpenCL memory and addressing model environment rules (#2589) 2019-05-16 33432579+alan-baker@users.noreply.github.com Validate construct exits (#2459) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@47741f05043a The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I5d89ae5309cd8d3a201ffb88a62ae722719cf646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619654Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661340}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6e384fef6c0f..27ec91958501 git log 6e384fef6c0f..27ec91958501 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 johnkslang@users.noreply.github.com Merge pull request #1768 from ShabbyX/enable-opt 2019-05-16 johnkslang@users.noreply.github.com Merge pull request #1767 from dneto0/update-spirv-headers Created with: gclient setdep -r src/third_party/glslang/src@27ec91958501 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I25856edfeee1b584aa9a0363f4fb686e13789eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619655Reviewed-by:
-
Clemens Arbesser authored
This fixes a bug where the AA payment request would sometimes show two dividers between sections, resulting in a thicker divider than intended. Before: https://screenshot.googleplex.com/WhYYQmeOTsX.png After: https://screenshot.googleplex.com/noR3SYyy2ts.png Bug: 806868 Change-Id: I94fc47d92c7f46a488d65c64f29e13e137b131d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619790Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#661338}
-
Juan Antonio Navarro Perez authored
This benchmark is no longer used and was replaced by the analyze_metrics_ct.py script. Also removing no longer used dependencies: - LocalTraceMeasurement, a TimelineBasedMeasurement only used by this benchmark; - CTBrowserLessPageSet; and - SharedBrowserlessStory. Bug: 840428 Change-Id: I3f681c168ce3e46a8b51bfc49ae781b3b871add5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619806 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#661337}
-
Robert Sesek authored
This will copy KeystoneRegistration as a versioned framework now, whereas previously the script removed the versioned symlink structure. Bug: 955936 Change-Id: Ida89ce2add6f01712b271f228399817b8b98c19b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603663Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#661336}
-
Bruno Santos authored
This interface will be expanded to proxy calls to IdentityAcessor so that we have more control over what is called and be able to record metrics. Bug: 927809 Change-Id: Ifb33c170b17b8ab7e3dbcb89a5fc47288f73814a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615441Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#661335}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 86c236cc. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" 64cbdf7a "Replace originOffset public member with getOffsetReferenceSpace method" e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" c4fa33ec "CSS: WPT for scroll-padding computed value" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I611f3371be6c1db3395df3709480fd241b005819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619206Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661334}
-
Sergio Villar Senin authored
WebThreadSupportingGC is mostly wrapping blink::Thread. Code should use scheduler::WorkerThread instead. The first step consists in moving MemoryPressureListenerRegistry's RegisterThread/UnregisterThread() to WorkerThread. In order to do that we have to add a new thread creation parameter to decide whether or not the new thread will support garbage collection or not. Bug: 961743 Change-Id: I662cd31f24f8dc2d47697ff026251b80b31cbe32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611985 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#661333}
-
Antonio Gomes authored
This CL is the second step to Onion soup content/renderer/media_capture_from_element/. At this time, html_video_element_capturer_source.cc|h|unittest are moved. It was preceded by the following preparation CLs [1], [2] and [3]. [1] crrev.com/c/1612104 [2] crrev.com/c/1611781 [3] crrev.com/c/1617324 Notes: - CL moves media::AddVideoTrackToMediaStream() to be a helper function in /blink/renderer/modules/mediacapturefromelement/html_media_element_capture.cc. Reason: It was only used there. - After Onion souping html_video_element_capturer_source.cc, the CL removes the respective blink::Platform::CreateHTMLVideoElementCapturer hook. - Some banned base::Bind calls were replaced by their respective Blink counterparts. - The use of base::GenerateGUID was replaced by Blink's CreateCanonicalUUIDString. - Use of ScopedTaskEnvironment is not needed anymore, hence removed. BUG=787261,714018 Change-Id: Ia9f040d7477fedebb3497bcb35fc08de191ef73b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617325Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7676d01d0f8b..5009f37bf713 git log 7676d01d0f8b..5009f37bf713 --date=short --no-merges --format='%ad %ae %s' 2019-05-20 taylori@google.com perfetto-ui: Update npm packages Created with: gclient setdep -r src/third_party/perfetto@5009f37bf713 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If2d57fb8f7bc07213db0ceecc42f5234fd2e79c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619651Reviewed-by:
-
Mihai Sardarescu authored
This CL updates earl grey tests to work with Unified Consent feature enabled on iOS. It also runs all first run ui earl grey tests on the ios_chrome_unified_consent_egtests bot. Bug: 960260 Change-Id: I537e2c3b3c8b096d7ca0acb600eb362cbca38c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609905Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#661330}
-
mrefaat authored
This CL: 1- Replaces TabModelObserver by WebStateListObserving protocol and implements DidRemoveWebState in MainController. 2- Changes the BrowserViewWrangler to take a WebStateListObserving Delegate instead of TabModelObserver, and use a separate observerBridge to track the delegate observer. Bug: 911350 Change-Id: I627df2fe7b76fd298a2c52b5f41e053b2146bc2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600261 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af03ff75d3a7..6fbc2c914856 Created with: gclient setdep -r src-internal@6fbc2c914856 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mbarowsky@google.com,sidereal@google.com Change-Id: I22488da93328a4a24c2c4c318eb357e5b412c91e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619649Reviewed-by:
-
Kent Tamura authored
Add support of disabledFeatures=['shadow'] in a custom element definition. It disables Element.attachShadow(). Specification PR: https://github.com/whatwg/dom/pull/760 The behavior is behind "ElemnetInternals" runtime flag. Bug: 905922 Change-Id: Ib950883b5c995945eb60bf9b92c715ad3996dfa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609022 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#661327}
-
Tsuyoshi Horo authored
I submitted crrev.com/c/1619582 before fixing misspelling. TBR=ksakamoto@chromium.org Bug: 935267 Change-Id: I7611ccabbf05bbc6d7139efde3a1275537abf16c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619592Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#661326}
-
Fredrik Söderquist authored
Change-Id: Ibed70c17d5ba2bb9a9073e5b6174896744064a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619689 Commit-Queue: Daniel Bratell <bratell@opera.com> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#661325}
-
Robbie Gibson authored
This CL adds the G icon as a fallback icon for answers with no more specific icon. It also renames the "currency" imageset to "stock" as that icon is actually used for the stock price suggestion, not the currency conversion suggestion (which uses the "conversion" icon). Bug: 963860 Change-Id: I446a07cbab6b1a5ab0a38629947d09e17522499e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614219 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#661324}
-
Mathias Carlen authored
Before this patch, we kept adding new observers to the list of cache data observers when closing the app (without the app being destroyed). Resuming the activity by triggering another run would reuse the existing profile cache and the default profile image was shown. This patch introduces a destroy() function to the header coordinator so that it can clean up internals when we go out of scope. In particular it removes the profile data observer registered in the constructor. Bug: b/132379462 Change-Id: I96c473b6748bd8b7105cab58bfdb497411e6f93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609779 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#661323}
-
Chromium WPT Sync authored
Using wpt-import in Chromium adf1af3d. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" 64cbdf7a "Replace originOffset public member with getOffsetReferenceSpace method" e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib989922e053045fad4fc79be505077aac5d4d6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619334Reviewed-by:
-
