- 13 Aug, 2014 40 commits
-
-
jbudorick@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/451083004 Cr-Commit-Position: refs/heads/master@{#289313} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289313 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
Convert LowerCaseEqualsASCII to take StringPiece. In the current patch this is generally a NOP but will allow me to delete the other 4 variants in a followup (wanted to do that separately since that will require more review, since callsites will be changed in nontrivial ways). In some cases, LowerCaseEqualsASCII is called with a WebString, which no longer is implicitly converted. I added base::string16(...) around such calls to force the right conversion. It happened in these files: window_container_type.cc savable_resources.cc render_view_impl.cc blink_ax_tree_source.cc password_form_conversion_utils.cc translate_helper.cc chrome_render_view_observer.cc dom_serializer_browsertest.cc R=jamesr@chromium.org Review URL: https://codereview.chromium.org/448143008 Cr-Commit-Position: refs/heads/master@{#289312} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289312 0039d316-1c4b-4281-b951-d872f2087c98
-
jww@chromium.org authored
Currently, if a user clicks 'proceed' through an SSL interstitial, their only way to revoke this decision is to restart their browser session. This commit provides an explicit button in the page info to revoke this decision if the user is using the remember certificate error decisions experiment. Since decisions are remembered across browser restarts for these users, it's important to provide them with a mechanism to revoke their decision later. BUG=262615 NOTRY=true Review URL: https://codereview.chromium.org/418133012 Cr-Commit-Position: refs/heads/master@{#289311} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289311 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
(We weren't do so properly in the "too many handles" case.) R=yzshen@chromium.org Review URL: https://codereview.chromium.org/463883004 Cr-Commit-Position: refs/heads/master@{#289310} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289310 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
I see it sometimes failing on try jobs even with reruns. BUG=128961 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/473493002 Cr-Commit-Position: refs/heads/master@{#289309} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289309 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
> Revert 289067 "Use RE string pattern matching for blacklist stri..." > > Reason for revert: uninitialize memory access > > http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%282%29/builds/29469/steps/memory%20test%3A%20content/logs/stdio > > > Use RE string pattern matching for blacklist strings. > > > > Including cpu_brand, gl_vendor, gl_renderer, gl_extension, driver_vendor, > > and machine_model_name. > > > > BUG=396578 > > TBR=piman@chromium.org > > TEST=gpu_unittests > > > > Review URL: https://codereview.chromium.org/452293002 > > TBR=zmo@chromium.org > > Review URL: https://codereview.chromium.org/465163002 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/468223002 Cr-Commit-Position: refs/heads/master@{#289308} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289308 0039d316-1c4b-4281-b951-d872f2087c98
-
skyostil@chromium.org authored
Since scroll handlers do not block composited scrolling, the existing input latency metric will only report the response time for the compositor when scrolling a page with a handler. This is not accurate for pages that implement scroll-synchronized effects, because the scroll handler needs to be invoked so that the page contents are updated with the new scroll offset. This patch fixes the problem by forwarding latency information from the impl to the main thread when we are scrolling a layer that has an active scroll event handler. In the case the scroll handler is no-op, the latency information will be terminated as a failed commit. Sample trace: https://drive.google.com/file/d/0ByyxMXB38gLDRE40bkU5TVd0U00/edit?usp=sharing BUG=347366 Review URL: https://codereview.chromium.org/365463003 Cr-Commit-Position: refs/heads/master@{#289307} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289307 0039d316-1c4b-4281-b951-d872f2087c98
-
vkuzkokov@chromium.org authored
Issue 387067 can be resolved by having port forwarding socket dependent on all other references to AndroidDeviceManager::Device. This requires for lifetime of AWS to be manageable in the first place. BUG=387067 Review URL: https://codereview.chromium.org/449883002 Cr-Commit-Position: refs/heads/master@{#289306} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289306 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
BUG=252641 TBR=zmo@chromium.org Review URL: https://codereview.chromium.org/472523002 Cr-Commit-Position: refs/heads/master@{#289305} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289305 0039d316-1c4b-4281-b951-d872f2087c98
-
rsorokin@chromium.org authored
session BUG=388279 Review URL: https://codereview.chromium.org/374853002 Cr-Commit-Position: refs/heads/master@{#289304} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289304 0039d316-1c4b-4281-b951-d872f2087c98
-
yoav@yoav.ws authored
BUG=403260 Review URL: https://codereview.chromium.org/468173002 Cr-Commit-Position: refs/heads/master@{#289303} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289303 0039d316-1c4b-4281-b951-d872f2087c98
-
bnc@chromium.org authored
Previously the default setting was to perform TCP preconnect and DNS preresolution on all networks, and do prefetch and prerender on non cellular network only. Changing to kNetworkPredictionOptions has modified this default behavior, disabling preconnect and preresolve on cellular networks by default (the default setting is NETWORK_PREDICTION_WIFI_ONLY). This CL reverts this change, allowing preconnect and preresolve (but not prefetch and prerender) on any network if kNetworkPredicitonOptions == NETWORK_PREDICTION_WIFI_ONLY. In order to do so, the helper functions CanPredictNetworkActions*() are split up into new helper functions, one set for preconnect and preresolve, the other for prefetch and prerender. BUG=334602 Review URL: https://codereview.chromium.org/443413002 Cr-Commit-Position: refs/heads/master@{#289302} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289302 0039d316-1c4b-4281-b951-d872f2087c98
-
ajuma@chromium.org authored
This expands the GPU rasterization device whitelist to include all Android 4.4 devices with Qualcomm GPUs. BUG=None Review URL: https://codereview.chromium.org/463043004 Cr-Commit-Position: refs/heads/master@{#289301} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289301 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#289300} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289300 0039d316-1c4b-4281-b951-d872f2087c98
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia/+log/b62508be81839be96f3d935d1e568e2ff3663670..b2721f7372652496e1b1ec722883904caa8134a8 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel TBR=bsalomon@google.com BUG= Review URL: https://codereview.chromium.org/466383002 Cr-Commit-Position: refs/heads/master@{#289299} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289299 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
See http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/1240 http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/1233 BUG=402212 TBR=rlarocque@chromium.org Review URL: https://codereview.chromium.org/467283002 Cr-Commit-Position: refs/heads/master@{#289298} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289298 0039d316-1c4b-4281-b951-d872f2087c98
-
bauerb@chromium.org authored
BUG=394309 Review URL: https://codereview.chromium.org/468533002 Cr-Commit-Position: refs/heads/master@{#289297} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289297 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#289296} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289296 0039d316-1c4b-4281-b951-d872f2087c98
-
andrewhayden@chromium.org authored
BUG=403222 TBR=toyoshim@chromium.org Review URL: https://codereview.chromium.org/465333002 Cr-Commit-Position: refs/heads/master@{#289295} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289295 0039d316-1c4b-4281-b951-d872f2087c98
-
philipj@opera.com authored
It does nothing as of Blink r178756: https://codereview.chromium.org/414443006 BUG=401887 Review URL: https://codereview.chromium.org/449393002 Cr-Commit-Position: refs/heads/master@{#289294} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289294 0039d316-1c4b-4281-b951-d872f2087c98
-
gab@chromium.org authored
NOTRY=True Review URL: https://codereview.chromium.org/460003002 Cr-Commit-Position: refs/heads/master@{#289293} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289293 0039d316-1c4b-4281-b951-d872f2087c98
-
dnicoara@chromium.org authored
Allow time for display events to settle before querying for new displays. BUG=398234 Review URL: https://codereview.chromium.org/463633005 Cr-Commit-Position: refs/heads/master@{#289292} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289292 0039d316-1c4b-4281-b951-d872f2087c98
-
hirono@chromium.org authored
* Assign correct entry for entry-change event. * Assign totalBytes to processedBytes at the end of zipping. * Determine if entries are movable or not by comparing file system. BUG=None TEST=manually Review URL: https://codereview.chromium.org/466583003 Cr-Commit-Position: refs/heads/master@{#289291} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289291 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
BUG=403325 TEST=None NOTRY=true TBR=kalman Review URL: https://codereview.chromium.org/472493002 Cr-Commit-Position: refs/heads/master@{#289290} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289290 0039d316-1c4b-4281-b951-d872f2087c98
-
bengr@chromium.org authored
This CL ensures that data reduction proxy sessions last no longer than 24 hours. After 24 hours and on restart, a new session ID is used. BUG=402563 Review URL: https://codereview.chromium.org/465823002 Cr-Commit-Position: refs/heads/master@{#289289} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289289 0039d316-1c4b-4281-b951-d872f2087c98
-
grunell@chromium.org authored
* Change UMA stats for capture startup to an enum. It retains the meanings of the current (bool) values 0 and 1. * Add values for fail to create and open stream (device). * Remove |enable_nodata_timer| which doesn't have any use. BUG=399835 Review URL: https://codereview.chromium.org/460993002 Cr-Commit-Position: refs/heads/master@{#289288} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289288 0039d316-1c4b-4281-b951-d872f2087c98
-
pmonette@google.com authored
This is added in a separated CL because the linux trybots have trouble with checked in binaries. NOTRY=TRUE BUG=402455 Review URL: https://codereview.chromium.org/463223002 Cr-Commit-Position: refs/heads/master@{#289287} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289287 0039d316-1c4b-4281-b951-d872f2087c98
-
tommi@chromium.org authored
The problem was that MediaStreamDispatcher::IsAudioDuckingActive could return true incorrectly (i.e. when an input device was open but it was not actually opened with ducking enabled - as specified by the application). The reason for this is that the audio effect state as known by MediaStreamDispatcher reflects what the browser side delivers when an audio track has been opened but the browser side had not taken into account the stream options of the request. BUG=391414 Review URL: https://codereview.chromium.org/464923002 Cr-Commit-Position: refs/heads/master@{#289286} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289286 0039d316-1c4b-4281-b951-d872f2087c98
-
zerny@chromium.org authored
Blink GC plugin: Ensure that left-most vtable is the first thing to be initialized for polymorphic classes with trace methods. This is done by ensuring one of two properties for any polymorphic class with a trace method. 1. If the trace method is virtual, then the left-most base class must define a virtual trace method too. 2. If the trace method is non-virtual, then the left-most base class must define some virtual method. BUG=334149 R=ager@chromium.org Review URL: https://codereview.chromium.org/455263004 Cr-Commit-Position: refs/heads/master@{#289285} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289285 0039d316-1c4b-4281-b951-d872f2087c98
-
joaodasilva@chromium.org authored
Building target "chrome:resources" once works, rebuilding it again fails with this error: ninja:error: expected depfile 'gen/chrome/resources_grit.d' to mention 'gen/chrome/grit/common_resources.h', got 'gen/chrome/grit/renderer_resources.h' Making sure the resources targets have unique names fixes this problem. BUG=None R=phajdan.jr@chromium.org, zerny@chromium.org Review URL: https://codereview.chromium.org/466403002 Cr-Commit-Position: refs/heads/master@{#289283} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289283 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
BUG=None TEST=None Review URL: https://codereview.chromium.org/463733003 Cr-Commit-Position: refs/heads/master@{#289281} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289281 0039d316-1c4b-4281-b951-d872f2087c98
-
dnicoara@chromium.org authored
Revert of Run pkg-config for Udev only if use_udev==1 (patchset #1 of https://codereview.chromium.org/429723002/) Reason for revert: Breaks builds where use_udev==0 since certain targets just assume udev and never check against use_udev. Udev package should be wrapped in a use_udev confitional altogether and all the locations using Udev should check against use_udev. Original issue's description: > Run pkg-config for Udev only if use_udev==1 > > Some embedded platforms do not have udev support. The change will skip > running pkg-config if use_udev=0. > > BUG=none > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288770 TBR=brettw@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/469763002 Cr-Commit-Position: refs/heads/master@{#289280} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289280 0039d316-1c4b-4281-b951-d872f2087c98
-
tnagel@chromium.org authored
BUG=396557 Review URL: https://codereview.chromium.org/424613003 Cr-Commit-Position: refs/heads/master@{#289279} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289279 0039d316-1c4b-4281-b951-d872f2087c98
-
skyostil@chromium.org authored
Pass systrace categories to chrome_profiler as a comma separated single argument instead of one argument per category. This fixes a bug where only the first category was actually enabled. We also set the output format to JSON because it's not necessary to wrap the resulting systrace into a HTML container as we end up zipping the result anyway. TEST=tools/perf/run_benchmark smoothness.key_mobile_sites --browser=android-chrome --page-filter=linked --profiler=android-systrace Review URL: https://codereview.chromium.org/457823004 Cr-Commit-Position: refs/heads/master@{#289277} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289277 0039d316-1c4b-4281-b951-d872f2087c98
-
ppi@chromium.org authored
http://crrev.com/287864 fixed an issue where a renderer that was killed in background and later reloaded was being respawned with incorrect process visibility, causing it to be killed on Android. The fix skipped resetting the |is_hidden_| flag of RenderWidgetHost, so that RenderWidgetHost crashing in background would retain its visibility status and trigger the ::Show() paths correctly when recreating the View in foreground, fixing the process visibility issues. Unfortunetely, this wasn't that good of an idea. It turns out that while it is the RenderWidgetHost that is the authoritative source of visibility truth that views rely on, it is the view that is responsible for providing signals (WasShown / WasHidden) to the widget host. That means that after a renderer crashes and the view is destroyed, RenderWidgetHost has no way to track its visibility anymore and all bets are off. It turns out that view implementations on Aura and Mac relied on the RenderWidgetHost visibility being reset upon crash (http://crbug.com/401859). Hence, this patch undoes the original "fix" and instead ensures that resetting the |is_hidden_| flag issues a notification for the RenderProcessHost, so that the process visibility signal that we attempted to fix with the original patch is still working. Regression test for http://crbug.com/399521 is in Chrome for Android repo (BindingManagerIntegrationTest). BUG=399521 BUG=401859 Review URL: https://codereview.chromium.org/459613007 Cr-Commit-Position: refs/heads/master@{#289276} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289276 0039d316-1c4b-4281-b951-d872f2087c98
-
jitendra.ks@samsung.com authored
This patch returns the bitmap of the current tab favicon. BUG= Review URL: https://codereview.chromium.org/364793005 Cr-Commit-Position: refs/heads/master@{#289275} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289275 0039d316-1c4b-4281-b951-d872f2087c98
-
henrika@chromium.org authored
The existing DVLOG creates a huge amount of log output when using a */media/*=1 filter. TBR=xians1 BUG=none Review URL: https://codereview.chromium.org/465313002 Cr-Commit-Position: refs/heads/master@{#289274} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289274 0039d316-1c4b-4281-b951-d872f2087c98
-
yukishiino@chromium.org authored
XLookupString depends on user's locale settings (LC_CTYPE). The returned string is encoded in LC_CTYPE, and if the string cannot be respresented in LC_CTYPE, it becomes an empty string. i.e. users cannot input characters. This CL introduces our own map from KeySym (virtual key code in X) to Unicode character. This map works independent from user's locale. BUG=395019 TEST=Done manually. R=sadrul@chromium.org, wez@chromium.org Review URL: https://codereview.chromium.org/430463005 Cr-Commit-Position: refs/heads/master@{#289272} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289272 0039d316-1c4b-4281-b951-d872f2087c98
-
tzik@chromium.org authored
Clear trivially solvable dirty flag in earlier phase than before, so that consecutive local changes doesn't conflict to each other. BUG=344769 TEST=unit_tests --gtest_filter=DriveBackendSyncTest.* Review URL: https://codereview.chromium.org/443793003 Cr-Commit-Position: refs/heads/master@{#289271} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289271 0039d316-1c4b-4281-b951-d872f2087c98
-
wittman@chromium.org authored
Allow enhanced bookmarks external component extensions to be disabled/uninstalled. This facilitates ongoing development and testing of multiple versions of extensions that are ultimately released as external component extensions. BUG=401315 Review URL: https://codereview.chromium.org/445233002 Cr-Commit-Position: refs/heads/master@{#289270} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289270 0039d316-1c4b-4281-b951-d872f2087c98
-