- 20 Jul, 2017 13 commits
-
-
Yipeng Wang authored
TBR=yfriedman Bug: 683256 Change-Id: Ieb2a761814449dc4c7e0f374846e676d925d20c6 Reviewed-on: https://chromium-review.googlesource.com/577951 Commit-Queue: Yipeng Wang <yipengw@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#488064}
-
Jinsuk Kim authored
The test passes fine on the release build but shows flakiness on the debug build whose trybot result I'm trying to stablize. It takes a bit longer to get the test page fully loaded on the debug build, therefore the test often timed out before proceeding to the next step. This CL ensures the scale factor gets matched by waiting for the tab to be created before the test is performed. Local tests shows 100% pass, compared to about 50% failures before the patch. BUG=737910, 746476 Change-Id: If270b2c5dba122c899cba0f050ca808878773048 Reviewed-on: https://chromium-review.googlesource.com/559330Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#488063}
-
Scott Little authored
This reverts commit 6d414319. Reason for revert: Broke compile for ChromeOS, e.g. https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29 Original change's description: > Make PaintFlags a separate object from SkPaint > > In order to add serialization for PaintFlags internals, store the > SkPaint internals directly in PaintFlags instead of storing in > an SkPaint itself. > > Bug: 737629 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I865752e0adc709595e0d3ed079d3158f5fb17084 > Reviewed-on: https://chromium-review.googlesource.com/575511 > Reviewed-by: Justin Novosad <junov@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Vladimir Levin <vmpstr@chromium.org> > Commit-Queue: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488046} TBR=msw@chromium.org,vmpstr@chromium.org,enne@chromium.org,junov@chromium.org Change-Id: I164b5e02e4df088db2e02a08c73193dab88b5eeb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 737629 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/578151Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#488062}
-
Erik Jensen authored
Change-Id: I7925d5124f9ea0b7c6405921f59cdfc3a8c8098e Reviewed-on: https://chromium-review.googlesource.com/575733Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#488061}
-
Sunny Sachanandani authored
This regressed some benchmarks and also accounts for a few percent of power consumption. Revert "cc: Add crash key for debugging BeginMainFrame renderer hang." This reverts commit 7a4f2242. Revert "cc: Dump more state in begin main frame hang crash key." This reverts commit 057d5553. TBR=brianderson,rsesek,alokp,scottmg,brucedawson BUG=622080,744740,742471 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib96e7ca083c4ce3a22890b8d6e822f57dd391ef7 Reviewed-on: https://chromium-review.googlesource.com/578066 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#488060}
-
Bill Orr authored
OnAndroid, VSync processing may be paused for the browser compositor, which has the effect of not sending down OnBeginFrame events to the render process, essentially pausing both browser and renderer compositing. Sometimes the renderer compositor can get into a bad state where the main thread is blocked waiting on a completion (ProxyMain::BeginMainFrame::commit), but we don't meet the conditions for ACTION_ACTIVATE_SYNC_TREE, so the completion is never triggered. The fix is to plumb paused state from the browser to the renderer process, so ACTION_ACTIVATE_SYNC_TREE can be force activated (when paused), and we can unblock the main thread. BUG=738443 Change-Id: I401d67bdd0f1054d5594575c8800d01a53e67f2b Reviewed-on: https://chromium-review.googlesource.com/567029Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#488059}
-
hubbe authored
account. Weighting by size means that large entries will get thrown out of the cache sooner and the end result is that the cache will have more, but smaller entries. Design doc: https://docs.google.com/document/d/1N07uwDiOipRcMG3SanxR8X8flvxrh9Axi1SLpfRNKCY/edit BUG=700102, 736437 Review-Url: https://codereview.chromium.org/2918893002 Cr-Commit-Position: refs/heads/master@{#488058}
-
Suchit Agrawal authored
Create new BUILD.gn file for media/renderers and moved respective media component changes from media/BUILD.gn file to new BUILD.gn file. Bug=613033 Signed-off-by:
Suchit Agrawal <a.suchit@samsung.com> Change-Id: Ibb763bfe7db56b197fb0e0be3b280900caa79b82 Reviewed-on: https://chromium-review.googlesource.com/577336Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org> Cr-Commit-Position: refs/heads/master@{#488057}
-
Chris Cunningham authored
Trying to track down a crash that may be caused by re-initializing the renderer while rendering is still ongoing. The previous CHECK was made impossible to hit by later changes to support track enable/disable. Also added a check on the size of buffered_ in audio_clock.cc. We do not enforce a limit on the size of buffered_, but typical playbacks should not exceed a handful of elements. Perhaps some bug is causing entries to accumulate. BUG=674856 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifc771c018b8e995bd236f2126c16dc60b2f42f49 Reviewed-on: https://chromium-review.googlesource.com/578441 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
-
Lei Zhang authored
Change-Id: Ifd8d1d860e59357ec7866d23ab8adb73856ebfdb Reviewed-on: https://chromium-review.googlesource.com/577168Reviewed-by:
Wu-Cheng Li <wuchengli@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#488055}
-
Peter Kasting authored
This makes a test run two seconds faster and is probably less flaky too. Bug: none Change-Id: I04aa131908a23f30767383e011e094b3e9493930 Reviewed-on: https://chromium-review.googlesource.com/578395Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#488054}
-
Wez authored
Change-Id: Iad67d881b423d6b7ae8e033a4745dd66cd038046 Reviewed-on: https://chromium-review.googlesource.com/570121 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#488053}
-
Cooper Knaak authored
Remove the event constants for "opened reading list item" and "added item to reading list". Originally used for in-product help, it was realized on further review that these events aren't useful in determining who should be shown in-product help relating to the reading list. R=edchin@chromium.org, gchatz@chromium.org, nyquist@chromium.org Bug: 738164 Change-Id: I95fb3222b62fe6d54cc2914f7d1a63480cece5f9 Reviewed-on: https://chromium-review.googlesource.com/571300Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Reviewed-by:
Ed Chin <edchin@chromium.org> Commit-Queue: Cooper Knaak <cooperknaak@google.com> Cr-Commit-Position: refs/heads/master@{#488052}
-
- 19 Jul, 2017 27 commits
-
-
Christopher Cameron authored
TBR=hubbe Bug: 746363 Change-Id: I4aa238b281a7bd3cfd85b144109fd01a2de1fac8 Reviewed-on: https://chromium-review.googlesource.com/577721 Commit-Queue: ccameron chromium <ccameron@chromium.org> Reviewed-by:
ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#488051}
-
Steven Holte authored
Bug: 745939 Change-Id: Iba676c4a1dec33473f067a0bdf4074dc6b15c435 Reviewed-on: https://chromium-review.googlesource.com/577011 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#488050}
-
chrome://inspectReilly Grant authored
Recently chrome://inspect started to open USB devices multiple times while probing for ADB devices. On Chrome OS this causes a problem because the permission_broker will disconnect the previous connection in favor of the new connection. This caused an endless cycle of connection failures. This patch maintains a list of the devices that are currently open and refused to reopen them during probing until the previous connection is fully closed. Bug: 725320 Change-Id: Id9b01d8d14c55ee2576499e2f1c778fea6c7dedc Reviewed-on: https://chromium-review.googlesource.com/572300 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#488049}
-
Brian Salomon authored
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1761b6a028616327aa54efcff14b6df1e0761687 TBR=ericrk@chromium.org Change-Id: I1761b6a028616327aa54efcff14b6df1e0761687 Reviewed-on: https://chromium-review.googlesource.com/578499Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Commit-Queue: Brian Salomon <bsalomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#488048}
-
Eric Stevenson authored
Bug: 695304 Change-Id: I15980a86da734d08b783807efa722460ac75e29e Reviewed-on: https://chromium-review.googlesource.com/576467Reviewed-by:
-
Adrienne Walker authored
In order to add serialization for PaintFlags internals, store the SkPaint internals directly in PaintFlags instead of storing in an SkPaint itself. Bug: 737629 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I865752e0adc709595e0d3ed079d3158f5fb17084 Reviewed-on: https://chromium-review.googlesource.com/575511Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#488046}
-
Eric Roman authored
* Order event files from oldest to newest * Remove the --num_files switch * Don't fail if end_netlog.json is missing (since it probably will be when using this) Bug: 744815 Change-Id: I26307d3c293eb445b7e3456d6b359f8ef05a0204 Reviewed-on: https://chromium-review.googlesource.com/578484 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#488045}
-
Sebastien Marchand authored
Version 0.8.32.0 [0cc169a1af] Fix some VS2017 issues, adds support for the 10.0.15063.468 Windows SDK. [e94470d3ee] Adds the afl instrumenter. Bug: 705133 Change-Id: If22afa4cdbb45ff25adee5fab614208eb6321c69 Reviewed-on: https://chromium-review.googlesource.com/577378Reviewed-by:Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#488044}
-
Michael Giuffrida authored
Bug: 742641 Change-Id: Id786af8e12352e6a01f63fd52235f48c167571e5 Reviewed-on: https://chromium-review.googlesource.com/578323Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#488043}
-
robertshield authored
BUG=695285,280619 Review-Url: https://codereview.chromium.org/2950203002 Cr-Commit-Position: refs/heads/master@{#488042}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7e56993a. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/343 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dom-dev@chromium.org: external/wpt/html hta@chromium.org: external/wpt/webrtc TBR=qyearsley@chromium.org No-Export: true Change-Id: I93912b916565eb161a315737accd5e5291efaace Reviewed-on: https://chromium-review.googlesource.com/577920 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488041}
-
Sammie Quon authored
Related to https://chromium-review.googlesource.com/c/575022, some of the added icons there are different size than the rest (20 vs. 16 for 1x). Revert those changes for now as they will cause a paint vector icon crash. New icons with the right size have been added. Test: manual Bug: 742524 Change-Id: I9d76ecb60b5cff8eec33b84670f345d1efc000a7 Reviewed-on: https://chromium-review.googlesource.com/577061 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#488040}
-
Michael Giuffrida authored
fileSystem's "default_parent" entry has the same fields as some of its children, so those children's fields don't need to be manually specified. See chrome/common/extensions/api/_features.md and crrev.com/2939833002. Bug: 729713 Change-Id: I1eed160c01fb139d1c1b75217e10a343a6308f24 Reviewed-on: https://chromium-review.googlesource.com/575912 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#488039}
-
Taylor Brandstetter authored
This CL ensures that it won't be possible for "RTCPeerConnection.iceGatheringState" to return a new value until the "icegatheringstatechange" event has been dispatched. This is something the WebRTC specification guarantees. This was previously fixed for iceConnectionState: https://codereview.chromium.org/1523213002 This CL extends that logic to iceGatheringState. This CL also ensures that the special "null" candidate (used as another indication that gathering is complete) is emitted at the proper time. To do this, the responsibility for creating this special candidate is moved from the content layer to the Blink layer. Lastly, this CL updates the "setConfiguration" test, resolving a TODO. Bug: 742859 Change-Id: I55fb605913314ff5e780fa3ca30112180bdc7f37 Reviewed-on: https://chromium-review.googlesource.com/575849 Commit-Queue: Taylor Brandstetter <deadbeef@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#488038}
-
Ben Goodger authored
R=rockot@chromium.org Change-Id: I08ac6c9832663af5145fb6939677601eb3ceb7f0 Reviewed-on: https://chromium-review.googlesource.com/576548 Commit-Queue: Ben Goodger <ben@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#488037}
-
Christian Biesinger authored
Move LineContext to FlexLayoutAlgorithm.h and rename it to FlexLine to be more clear on what it represents. This change also now uses that struct as the out parameter for ComputeNextFlexLine, replacing several individual variables. This will enable moving more functionality to FlexLayoutAlgorithm with the ultimate goal (besides making the code easier to understand) of reusing it for LayoutNG. R=eae@chromium.org Change-Id: I1cc1f9a9090fbb7d3a3c10537133c698f875a01d Reviewed-on: https://chromium-review.googlesource.com/576893 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#488036}
-
ekaramad authored
[refactor] - Rename and Move WebWidget::CaretOrSelectionRange to WebInputMethodController::GetSelectionOffsets Reasons for move: 1- This is a frame concept given (the two nontrivial calls are from render_frame_impl.cc and frame_input_handler_impl.cc). 2- It cleans up WebViewImpl/WebFrameWidgetImpl (and helps with the split) 3- The logic is simply calling the corresponding method on InputMethodController of the focused LocalFrame. 4- Jumping from RenderFrameImpl to RenderWidget for getting selection is futile and expecting a focused frame is incorrect. Note that GestureManager::HandleGestureLongPress first passes the hit test result to SelectionController and then to MouseEventManager where the former generates selection updates and the latter updates frame focus. Therefore, right now, long pressing text on an unfocused OOPIF will lead to an empty selection update which is incorrect. Reason for rename: 1- The method calls GetSelectionOffsets on InputMethodController (core) and it makes sense to make the wrapper variant have the same name. This CL also adds a small change to TextSelectionControllerClientChildFrame to use selection range instead of selection bounds (now that the update is fixed after the refactor). BUG=629721, 723790 Review-Url: https://codereview.chromium.org/2910223003 Cr-Commit-Position: refs/heads/master@{#488035}
-
Steven Holte authored
Reland of acab8963, with test fix to wait until time changes to RegisterExtraSyntheticTrial, so that it doesn't flakily get collected into the proto. TBR=olivierrobin Bug: 507665 Change-Id: I735ec46b29611899090ccfc6af6df058e34762dd Reviewed-on: https://chromium-review.googlesource.com/578087 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
sebsg authored
Also change section metrics from CreditCards to PaymentMethod (Now include payment apps). Which removes the need for the hadInitialFormOfPayment metrics. Bug: 740546 Change-Id: If2e67b66e4c309654ae1ade64d51f1d070e13d1a Reviewed-on: https://chromium-review.googlesource.com/565340Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#488033}
-
Scott Little authored
This reverts commit c8bf13e0. Reason for revert: It broke compile on a bunch of ChromiumOS bots, e.g. https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full Original change's description: > reland: shelf: Add a back button to the shelf. > > This is in preparation for removing title bars work. See mocks in the bug and screenshots for more details. > This approach of adding a back button expands the current app list button to be modal and have two functionalities > depending on which side is pressed. The alternative (seperate back button) is IMO very difficult to achieve what > is shown in the mocks (namely the color in between and animation (not in this CL) of said color in between). The > exact functionality of the back button is not 100% defined yet, this CL just sends a VKEY_BROWSER_BACK event in the > meantime. > > Screenshots: > https://screenshot.googleplex.com/ZVNP0aq0cc3 > https://screenshot.googleplex.com/fDcGTuoyZg5 > https://screenshot.googleplex.com/ZFBzk72LLVt > > Test: ash_unittests --gtest_filter="AppListButtonInkDropTest.*" > Bug: 721940 > Change-Id: I691c9fc15294d48a7a0da88ba78550e013d9b869 > Reviewed-on: https://chromium-review.googlesource.com/572434 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#487491} > Reviewed-on: https://chromium-review.googlesource.com/576656 > Cr-Commit-Position: refs/heads/master@{#488025} TBR=msw@chromium.org,oshima@chromium.org,sammiequon@chromium.org Change-Id: Ia137671938e7b2110c5cef0bd04fee4ecd46e232 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721940 Reviewed-on: https://chromium-review.googlesource.com/578611Reviewed-by:
-
Becky Zhou authored
+ Make DateDividedAdapter support multiple header items so that privacy disclaimers and clear browsing data button can be seperate items in recycler view to support show/hide animation. + Hide info button when info header is not visible on scrolling down in both history and downloads. + Remove header when history items are all deleted. BUG=689322 Change-Id: Idbcae648ba277eb82b87bbe5a0667373bb09fc1a Reviewed-on: https://chromium-review.googlesource.com/560672 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#488031}
-
David Bokan authored
This was previously landed in: https://chromium-review.googlesource.com/c/562018/ but was reverted in: https://chromium-review.googlesource.com/c/574547/ due to a a Clusterfuzz bug. Turns out that calling UnregisterScrollbar can erase the references we're holding in scrollbar_ids and scrollbar_layer_id so we have to refresh those. Bug: 739738 Change-Id: Ic80018212b1370be6a33a39add19da6848b59fb6 Reviewed-on: https://chromium-review.googlesource.com/578428Reviewed-by:
Weiliang Chen <weiliangc@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488030}
-
Selim Gurun authored
Safebrowsing checks can be prevented for certain domains by passing these domains via a whitelisting API. This code lands the plumbing for using that whitelisting code. Bug: 726770 Change-Id: I3e6278afb4900929bef6d05e81fae34529fe920e Reviewed-on: https://chromium-review.googlesource.com/577921Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Selim Gurun <sgurun@chromium.org> Cr-Commit-Position: refs/heads/master@{#488029}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5f09d557a14b..7de63c29970b $ git log 5f09d557a..7de63c299 --date=short --no-merges --format='%ad %ae %s' 2017-07-19 benjhayden Draw hoverable dots in line charts. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I1439fd1b888e6e2a32c4f02b641800232673a4d0 Reviewed-on: https://chromium-review.googlesource.com/578473 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488028}
-
Wez authored
Refactor the DiscardableSharedMemory implementation to put platform- native discardable page management in separate LockPages/UnlockPages functions. This isolates the platform-specific calls from internal details of the DiscardableSharedMemory implementation, in particular the need to allow for the space occupied by the SharedState structure. Also corrects "lock page" platform API errors to return FAILED rather than PURGED result, and adds some DCHECKing for "unlock page" API errors. Bug: 716205 Change-Id: I572d65a0304816305053669ec81c78a3461d8325 Reviewed-on: https://chromium-review.googlesource.com/574901 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
-
Dmitry Gozman authored
Moved all files related to old harness to inspector-protocol/css. BUG=734762 Change-Id: Iee40b4f40ebd4e594e99e6ce1ce00b44e899e316 Reviewed-on: https://chromium-review.googlesource.com/576949 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#488026}
-
Sammie Quon authored
This is in preparation for removing title bars work. See mocks in the bug and screenshots for more details. This approach of adding a back button expands the current app list button to be modal and have two functionalities depending on which side is pressed. The alternative (seperate back button) is IMO very difficult to achieve what is shown in the mocks (namely the color in between and animation (not in this CL) of said color in between). The exact functionality of the back button is not 100% defined yet, this CL just sends a VKEY_BROWSER_BACK event in the meantime. Screenshots: https://screenshot.googleplex.com/ZVNP0aq0cc3 https://screenshot.googleplex.com/fDcGTuoyZg5 https://screenshot.googleplex.com/ZFBzk72LLVt Test: ash_unittests --gtest_filter="AppListButtonInkDropTest.*" Bug: 721940 Change-Id: I691c9fc15294d48a7a0da88ba78550e013d9b869 Reviewed-on: https://chromium-review.googlesource.com/572434 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
