- 06 Nov, 2013 40 commits
-
-
tzik@chromium.org authored
* Implements RemoteToLocalSyncer by the main point * Add necessary functions of MetadataDatabase as skeletons BUG=240165 NOTRY=true Review URL: https://codereview.chromium.org/59193003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233249 0039d316-1c4b-4281-b951-d872f2087c98
-
cimamoglu@chromium.org authored
Review URL: https://codereview.chromium.org/51143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233248 0039d316-1c4b-4281-b951-d872f2087c98
-
mgiuca@chromium.org authored
I found this class quite difficult to understand, mostly due to bad method and variable names. Renamed: CheckTaskbarOrViewHasFocus -> MaybeDismissAppList, RegainNextLostFocus -> ReactivateOnNextFocusLoss, regain_next_lost_focus_ -> reactivate_on_next_focus_loss_, preserving_focus_for_taskbar_menu_ -> taskbar_has_focus_, and rewrote many of the comments for clarity. Factored out most of the logic in MaybeDismissAppList to ShouldDismissAppList, which returns a bool and has minimal side effects. This also introduces a minor behavioural fix: If the focused window is NULL, and reactivate_on_next_focus_loss is true, reactivates instead of dismissing. BUG=307837 Review URL: https://codereview.chromium.org/59063009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233244 0039d316-1c4b-4281-b951-d872f2087c98
-
jun.a.jiang@intel.com authored
Align the interface of TestHarness defined in gpu_tests/webgl_conformance.py with that in third_party/webgl_conformance. BUG=314997 NOTRY=true Review URL: https://codereview.chromium.org/58833003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233243 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
Otherwise, minidump_stackwalk produces far more debug output than actual output. BUG=none R=mark@chromium.org Review URL: https://codereview.chromium.org/59163005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233242 0039d316-1c4b-4281-b951-d872f2087c98
-
chromeos-lkgm@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233241 0039d316-1c4b-4281-b951-d872f2087c98
-
hashimoto@chromium.org authored
BUG=None TEST=unit_tests R=kinaba@chromium.org Review URL: https://codereview.chromium.org/59433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233240 0039d316-1c4b-4281-b951-d872f2087c98
-
fischman@chromium.org authored
When a container's value's dtor might call another method of the container's, one must ensure that the dtor is _not_ run in-line as the result of any of the container's operations. Specifically here the evil chain is: GpuVideoEncodeAcceleratorHost::OnNotifyInputDone() -> frame_map_.erase() VideoFrame::~VideoFrame() RTCVideoEncoder::Impl::EncodeFrameFinished() RTCVideoEncoder::Impl::EncodeOneFrame() GpuVideoEncodeAcceleratorHost::Encode() GpuVideoEncodeAcceleratorHost::frame_map_.insert() aaaaaand, boom! The code at HEAD is invalid for any platform (b/c nothing specs reentrancy for hash_map) but only bit me on Android (where we use stlport unlike other platforms). NOTRY=true Review URL: https://codereview.chromium.org/59863005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233238 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
Review URL: https://codereview.chromium.org/26411002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233237 0039d316-1c4b-4281-b951-d872f2087c98
-
hashimoto@chromium.org authored
BUG=None TEST=unit_tests R=kinaba@chromium.org Review URL: https://codereview.chromium.org/59363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233236 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/59513005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233235 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
Revise the class comment along the way. BUG=284984 TEST=none R=yoshiki@chromium.org Review URL: https://codereview.chromium.org/61463003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233234 0039d316-1c4b-4281-b951-d872f2087c98
-
halton.huo@intel.com authored
Also fix some changes for coding style errors reported by cpplint.py BUG=314517 Review URL: https://codereview.chromium.org/57373004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233233 0039d316-1c4b-4281-b951-d872f2087c98
-
tzik@chromium.org authored
BUG=240165 NOTRY=true Review URL: https://codereview.chromium.org/61203003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233232 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
BUG=307871 R=koz@chromium.org Review URL: https://codereview.chromium.org/60103004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233229 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
Notable changes in this CL: * Rename files that depend on pango to have _pango suffix. * Add a filename gyp rule to exclude _pango* files when use_pango = 0 * Add empty implementations for a few font-related API for ozone. BUG=313793 R=jam@chromium.org, msw@chromium.org, rjkroege@chromium.org Review URL: https://codereview.chromium.org/26541007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233228 0039d316-1c4b-4281-b951-d872f2087c98
-
abarth@chromium.org authored
This CL adds a basic implementation of NativeViewport for Mac OS X. It puts a window on screen and initializes GL for that window using an in-process command buffer. R=ben@chromium.org, ccameron@chromium.org, kbr@chromium.org Review URL: https://codereview.chromium.org/56833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233227 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
AppsGridView is used for folder view and it has a NULL item_list_ initially. This causes a crash when attempting to create pulsing blocks for sync animation. BUG=314855 R=jennyz@chromium.org Review URL: https://codereview.chromium.org/59623005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233226 0039d316-1c4b-4281-b951-d872f2087c98
-
skuhne@chromium.org authored
Fixing problem with user image in settings page when page gets called as visiting window on a multi profile desktop In Multi profile scenarios, a window can visit another users desktop and as such using the current user is incorrect. Instead the user from the current browser's profile should be taken to determine the user image. BUG=315078 TEST=visual Review URL: https://codereview.chromium.org/60443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233225 0039d316-1c4b-4281-b951-d872f2087c98
-
hashimoto@chromium.org authored
BUG=None TEST=unit_tests R=kinaba@chromium.org Review URL: https://codereview.chromium.org/59443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233224 0039d316-1c4b-4281-b951-d872f2087c98
-
mlamouri@chromium.org authored
Hopefully, this might fix a few bugs that we see in Linux/GTK. BUG=309969,311759 Review URL: https://codereview.chromium.org/58793002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233223 0039d316-1c4b-4281-b951-d872f2087c98
-
koz@chromium.org authored
BUG=314526 Review URL: https://codereview.chromium.org/57603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233222 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=None TEST=cc_unittests R=reed@google.com,danakj@chromium.org,thakis@chromium.org Review URL: https://codereview.chromium.org/57153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233221 0039d316-1c4b-4281-b951-d872f2087c98
-
mikhal@google.com authored
Review URL: https://codereview.chromium.org/56333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233220 0039d316-1c4b-4281-b951-d872f2087c98
-
zhchbin@gmail.com authored
BUG=302437 TEST=interactive_ui_tests --gtest_filter=GlobalCommandsApiTest.GlobalCommand Review URL: https://codereview.chromium.org/48953004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233217 0039d316-1c4b-4281-b951-d872f2087c98
-
ernstm@chromium.org authored
R=tonyg@chromium.org,nduca@chromium.org BUG=309953 NOTRY=True Review URL: https://codereview.chromium.org/47953004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233216 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
Don't build or archive pyautolib on official bots. BUG=224072 Review URL: https://codereview.chromium.org/33193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233215 0039d316-1c4b-4281-b951-d872f2087c98
-
DHNishi@gmail.com authored
_permission_features.h: https://gist.github.com/DHNishi/2014be18e7912916ea25 _permission_features.cc: https://gist.github.com/DHNishi/b78bc9588b2d7a46331d BUG=280286 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226826 Review URL: https://codereview.chromium.org/23594008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233214 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233212 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
1774: xcode: Adds generator support for Xcode 5 xctest targets. 1775: xcode & ninja/mac: Use xcrun instead of DEVELOPER_BIN_DIR. 1776: win: Add Visual Studio 2013 to the autodetect list 1777: ninja/win: Add support for 'resource_include_dirs' 1778: ninja/ios: Add storyboard support. 1779: ninja/mac: Let mac_bundle_resources keep file permissions. BUG=315383 R=mark@chromium.org TBR=mark@chromium.org Review URL: https://codereview.chromium.org/59623007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233211 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Various WebGL-related tests started failing on XP and Vista: http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%20Tests%20%282%29&number=31628 http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%20Tests%20%283%29&number=25055 http://build.chromium.org/p/chromium.win/buildstatus?builder=Vista%20Tests%20%281%29&number=41714 http://build.chromium.org/p/chromium.win/buildstatus?builder=Vista%20Tests%20%282%29&number=39756 http://build.chromium.org/p/chromium.win/buildstatus?builder=Vista%20Tests%20%283%29&number=35336 Example: browser\extensions\requirements_checker_browsertest.cc(47): error: Value of: actual_errors Actual: { "WebGL is not supported.", "CSS3d is not supported." } Expected: expected_errors Which is: {} > Simplify GPU blacklist for WinAura > > The gpu is completely blacklisted on all vista and XP machines with aura. All other blacklisting of them is redundant. > > BUG=315199 > > Review URL: https://codereview.chromium.org/58343007 TBR=jbauman@chromium.org Review URL: https://codereview.chromium.org/60833004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233210 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233208 0039d316-1c4b-4281-b951-d872f2087c98
-
hashimoto@chromium.org authored
Failing on check_deps http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/24263 http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%282%29/builds/45411 http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%282%29/builds/19085 http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/20133 > Clamp down various chrome/ DEPS files > > R=thakis@chromium.org > > Review URL: https://codereview.chromium.org/52023003 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/61513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233205 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
R=thakis@chromium.org Review URL: https://codereview.chromium.org/52023003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233201 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
BUG=315397 R=thestig@chromium.org Review URL: https://codereview.chromium.org/60293005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233200 0039d316-1c4b-4281-b951-d872f2087c98
-
tzik@chromium.org authored
* Adding QuotaReservationManager. * Adding Reservation, ReservationPool, OpenFile, ActiveFile as its inner class. TEST=content_unittests:QuotaReservationManagerTest.* BUG=303443 TBR=avi NOTRY=true Review URL: https://codereview.chromium.org/43323002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233199 0039d316-1c4b-4281-b951-d872f2087c98
-
reveman@chromium.org authored
This reduces command buffer flushes by allocating buffer ids in chunks of 64 just as texture ids. BUG=314152 TEST=cc_unittests --gtest_filter=ResourceProviderTest.TextureAllocationChunk Review URL: https://codereview.chromium.org/58603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233196 0039d316-1c4b-4281-b951-d872f2087c98
-
sigbjornf@opera.com authored
With underlying leak cause addressed, the suppression is no longer needed. R=thestig@chromium.org BUG=291240 NOTRY=true Review URL: https://codereview.chromium.org/56983002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233195 0039d316-1c4b-4281-b951-d872f2087c98
-
sorin@chromium.org authored
from v2 to v3. This CL only refactors the ping interceptor so that later on, update checks can be intercepted and canned responses be served back. Since v3 protocol uses http POST, a uniform way to intercept POST requests is needed. The current interceptor works only for pings. Support will be added later on to intercept update checks and respond with specific XML. BUG=314521 Review URL: https://codereview.chromium.org/56023005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233194 0039d316-1c4b-4281-b951-d872f2087c98
-
varkha@chromium.org authored
BUG=294461 Review URL: https://codereview.chromium.org/45343003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233193 0039d316-1c4b-4281-b951-d872f2087c98
-