- 14 Jun, 2018 24 commits
-
-
Noel Gordon authored
Code search for USB_VOLUME_QUERY suggests many uses of child selectors from the #directory-tree. Alternative is to use descendant combinator: #directory-tree [volume-type-icon="xxxxx"] to query for volumes, which is shorter and more idiomatic with the volume code selectors. Unless we need to test a child element for [active], or similar, it is perhaps less confusing to use the descendant combinator [1]. [1] Future changes might clean up the use of child selectors in volume MTP|USB|ETC_VOLUME_QUERY in the relevant test cases. No change in behavior, no new tests. Test: browser_test --gtest_filter="QuickView/FilesApp*" Bug: 851888 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2f64c624e05d0051750ee49ed6e7fabbef43b512 Reviewed-on: https://chromium-review.googlesource.com/1098905Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#567075}
-
Fady Samuel authored
This CL plumbs through additional data when surface synchronization is on on Android for: 1. IME 2. Accessibility 3. OverScrollController 4. view FrameInfo 5. GestureListenerManager Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I812daf08fa00cfba2d92cffaf988604593299c81 Bug: 672962 TBR: yfriedman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1097937 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#567074}
-
Michael Thiessen authored
The icon has been on by default since M67, and the updating of the component is causing bizarre crashes. Bug: 851983 Change-Id: I41267744e87861fdb889ec4f6bdca67327539a25 Reviewed-on: https://chromium-review.googlesource.com/1099875Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#567073}
-
Nigel Tao authored
The externs_list is used by the Closure compiler, to type check imported terms like 'chrome.fileManagerPrivate.foo', and to ensure that when minimizing JS code from 'foo.bar.baz()' to 'a.b.c()', well known names like 'chrome' aren't minimized. However, the files_manager app does not ship Closure-compiled code in production. It ships uncompiled code - the .js files as written by the programmer. Instead, the externs_list is used indirectly by the js_type_check("closure_compile") rules as a lint-style check. Prior to this CL, maintaining the externs_list was therefore ad hoc and indirect. For example, the hand-written and hand-maintained BUILD.gn files would contain rules like: js_library("foo") { deps = [ "../../common/js:elephant", "../../common/js:giraffe", ] externs_list = [ "../../../externs/apple.js", "../../../externs/banana.js", ] } where foo.js might not refer to externs/apple.js any longer, and it might actually depend on externs/pear.js that is only coincidentally satisfied because common/js/giraffe.js happens to list externs/pear.js on its externs_list. This might be true at any particular point in time, but as new code is added, and as existing code is refactored, the externs_list entries become stale. After this CL, each js_type_check("closure_compile") target has an associated js_library("closure_compile_externs") BUILD.gn target. This gives exactly one place to list all the external dependencies of every Closure compilation target. Future commits may re-organize the very fine grained (only 1 .js file per js_library BUILD.gn target) js_library targets into larger units, and in doing so, push duplicated externs_list entries from the leaves of the BUILD.gn dependency tree towards the root. This could arguably help us move towards shipping Closure compiled JS instead of hand-written JS. But the first step is to get a handle on the dependencies (i.e. externs_list entries) in the first place. Test: "ninja ui/file_manager:closure_compile" runs without error Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1a3b029b5223db12abd38077d56914ad9d28a396 Reviewed-on: https://chromium-review.googlesource.com/1092399Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#567072}
-
Helen Li authored
The test_support target should expose //services/network/public/mojom and ../cpp so we can avoid making embedder test targets to explicitly depend on //services/network/public/mojom and ../cpp. See https://chromium-review.googlesource.com/c/chromium/src/+/1095594 for an example. TBR:bauerb@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ib60c096e1c29f90c08204141a43454944c9934ed Reviewed-on: https://chromium-review.googlesource.com/1099138 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#567071}
-
Ben Wells authored
Bug: None Change-Id: I7f4214c2ba46c3e79bed607748e0e3ec045feab8 Reviewed-on: https://chromium-review.googlesource.com/1098745Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#567070}
-
danakj authored
All masks must be PictureLayers, but the type is currently a Layer regardless. This means the Layer API has to include things for masks only, which are virtual and overridden only by PictureLayer. Instead they could just be members of PictureLayer. This changes the type on cc::Layer to hold a PictureLayer as a mask instead, and changes callers to work with PictureLayer types directly. They already had a PictureLayer, because masks must be one, but they had it upcasted to a cc::Layer. This makes the GraphicsLayer::CcLayer() return a PictureLayer* instead of the base class Layer*, which means consumers of GraphicsLayer get to know about PictureLayer. Since we're moving toward a world with only content layers, and hopefully no base class, this follows that pattern of introducing code to the real type sooner rather than later. R=jbroman@chromium.org, pdr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7b0fe935c69e9a0f2ee294c722b2372013617dfc Reviewed-on: https://chromium-review.googlesource.com/1098152Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#567069}
-
Nicholas Verne authored
This is a reland of e9753daf Original change's description: > Supports the new vsh-into-running-container syntax > > It is no longer necessary to use the run_container.sh script every time a > container shell is needed. If the container is already running, vsh now allows > "direct access". > > Bug: 848447 > Change-Id: Ia9aeb120befd016386816cdd16fb3336b45426ff > Reviewed-on: https://chromium-review.googlesource.com/1082055 > Reviewed-by: Timothy Loh <timloh@chromium.org> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#563568} Bug: 848447 Change-Id: I17c73a37a65a8316e62154556ee94fbc37dd703d Reviewed-on: https://chromium-review.googlesource.com/1096875Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#567068}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0db1e01e3f4c..78a0b0424642 git log 0db1e01e3f4c..78a0b0424642 --date=short --no-merges --format='%ad %ae %s' 2018-06-13 benjhayden@chromium.org Refactor Anomaly queries. Created with: gclient setdep -r src/third_party/catapult@78a0b0424642 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I45688b16d5b00c2e090bb5f808f33305b0f37d85 Reviewed-on: https://chromium-review.googlesource.com/1099977Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567067}
-
Sandra Sun authored
This patch supports snapping after animated wheel scroll. More generally, we should snap after a scroll animation if the animation wasn't for snapping itself. Bug: 826416 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic1dba95157bd4d7d36f25b92646c86561b2ecbe9 Reviewed-on: https://chromium-review.googlesource.com/1050398 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#567066}
-
Justin Cohen authored
Bug: 851472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia2adc8be4d6b007eff22acac225c1f6c4952334a Reviewed-on: https://chromium-review.googlesource.com/1099882Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567065}
-
Paul Meyer authored
See spec here: https://wicg.github.io/reporting/#report-types Specifically, some fields in the IDLs were originally not marked nullable, but now are. Bug: 564071, 731810 Change-Id: I731ee46f39920c864856f7eda7f18045f779d1c3 TBR: rbyers@chromium.org Change-Id: I731ee46f39920c864856f7eda7f18045f779d1c3 Reviewed-on: https://chromium-review.googlesource.com/1097602 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#567064}
-
Scott Violet authored
BUG=none TEST=none (comment only change) Change-Id: Icc0531dde3e613b6b87fd13620667659249324c1 Reviewed-on: https://chromium-review.googlesource.com/1097469Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#567063}
-
Ben Wells authored
We are interested in knowing how long it takes users from first setting up a device to setting up Crostini. Bug: 703927 Change-Id: I68d24b4f6f408b3f5dce853dfaaa40c10e1d72be Reviewed-on: https://chromium-review.googlesource.com/1082068Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#567062}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7c525e62d405..fdcfb8b7c23f git log 7c525e62d405..fdcfb8b7c23f --date=short --no-merges --format='%ad %ae %s' 2018-06-13 halcanary@google.com Revert "SkTypes: extract SkTo" 2018-06-12 halcanary@google.com SkTypes: add static back 2018-06-12 bungeman@google.com Remove SkBool8. 2018-06-12 brucewang@google.com Implement DWriteFontTypeface::onGetVariationDesignPosition on win10. 2018-06-12 mtklein@google.com Revert "simplify SkTFitsIn" 2018-06-12 khushalsagar@chromium.org fonts: Fix memory allocation for fallback glyphs. 2018-06-12 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 a8802477752f..7ce4a15115cb (3 commits) 2018-06-12 halcanary@google.com SkTypes: more into SkMacros 2018-06-12 halcanary@google.com SkTypes: templates are usually better than macros 2018-06-12 ethannicholas@google.com renamed SkSL's assert macros 2018-06-12 halcanary@google.com SkMacros split from SkTypes.h 2018-06-12 mtklein@chromium.org avoid immintrin.h in SkNx_sse.h 2018-06-12 benjaminwagner@google.com Add Vulkan jobs for GalaxyS7. 2018-06-12 mtklein@chromium.org remove __cplusplus guard 2018-06-12 mtklein@chromium.org simplify SkTFitsIn 2018-06-12 egdaniel@google.com Add blacklist to failing vulkan gtx660 test. 2018-06-12 halcanary@google.com SkTypes: extract SkTo Created with: gclient setdep -r src/third_party/skia@fdcfb8b7c23f The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:829622 TBR=csmartdalton@chromium.org Change-Id: I896d8a03a7b21a46f08d6c14e79548f5b37148cf Reviewed-on: https://chromium-review.googlesource.com/1098939Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#567061}
-
Xianzhu Wang authored
The previous CL for the bug was reverted because it caused crashes. We may still go through the normal paint path which requires layer states during printing, so for safety don't skip layer state update, but just suppress the DCHECK when printing. Bug: 848730 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9f08af2282c76bb97bd14428eb368791feddbaa8 Reviewed-on: https://chromium-review.googlesource.com/1097558Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567060}
-
Roberto Carrillo authored
R=iannucci,tandrii No-Try: True Bug: 795146 Change-Id: Ib19e24035fcf46d3563ece2eda7271bc1e176a03 Reviewed-on: https://chromium-review.googlesource.com/1100174 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#567059}
-
Hwanseung Lee authored
Rename GetAllData() to GetAllDataForDebugging(). The function is only used for Sync Node Browser of chrome://sync-internals and for unit-tests, it's name should reflect that. Bug: 851859 Change-Id: I5a73bf405a8e0aca55adb4ca39ee7fdfad813c07 Reviewed-on: https://chromium-review.googlesource.com/1097049Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#567058}
-
Naoki Fukino authored
To force migration on Kevin, we are removing "Skip" button from the migration screen. "Skip" should still be available in other boards. Even on Kevin, "Skip" is still available when there is no enough storage to start migration. Bug: 852228 Test: Manually confirmed that Skip button is hidden on Kevin and visible on Eve. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibd5142db654a3797719feab134de0ea2352cc7dc Reviewed-on: https://chromium-review.googlesource.com/1098870Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#567057}
-
Allen Vicencio authored
Implements the functions of SmbShareFinder and adds tests Bug: 757625 Change-Id: I072390d39ff060e36ce748dcf28ed98a090b7096 Reviewed-on: https://chromium-review.googlesource.com/1089852 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#567056}
-
Ryan Tseng authored
* All Mac bots use Mac-10.13 as os. * Android device bots use id:<bot name> as dimensions Bug: 840631 Change-Id: I0ea523e0b4f1f91f20c7f32333ec2db6ab486b03 Reviewed-on: https://chromium-review.googlesource.com/1100070Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#567055}
-
Daniel Cheng authored
Change-Id: Ia31b9004b57f6dff97f93d2280e3b9a23ca6919c Reviewed-on: https://chromium-review.googlesource.com/1100079Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#567054}
-
Wenzhao Zang authored
There's updated spec that moves the position of the current wallpaper info bar to the top of the image list. https://drive.google.com/corp/drive/folders/0B_2Uyb2Rhx2ObU5VTFJVWHR2WW8 Bug: 824453 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I414fb92f75f5b2ffa1b6b732c9be577ed4838107 Reviewed-on: https://chromium-review.googlesource.com/1083138Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#567053}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/789221f1101a..aeb0a6475bcc git log 789221f1101a..aeb0a6475bcc --date=short --no-merges --format='%ad %ae %s' 2018-06-13 peah@webrtc.org AEC3: Increase the range of reported echo path delay metrics 2018-06-13 magjed@webrtc.org Android: Fix VideoTrack behavior for adding/removing VideoSinks 2018-06-13 nisse@webrtc.org Replace all use of rtc::Pathname in generator_unittest.cc. 2018-06-13 danilchap@webrtc.org Introduce list of fields to put into codec agnostic descriptor 2018-06-13 devicentepena@webrtc.org AEC3: Changes to how the reverberation decay is applied. 2018-06-13 jonasolsson@webrtc.org Remove "webrtc_rtp" traces. 2018-06-13 yura.yaroshevich@gmail.com Add ow2_asm license Created with: gclient setdep -r src/third_party/webrtc@aeb0a6475bcc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:850538,chromium:852257 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I96d3ed7b7c4bd9a705edda10c15a74623ce6505c Reviewed-on: https://chromium-review.googlesource.com/1099915Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567052}
-
- 13 Jun, 2018 16 commits
-
-
Sorin Jianu authored
The code now provides as a run action command line argument the Chrome app guid registered with Omaha, as returned by the configurator, like this: --appguid={8A69D345-D564-463c-AFF1-A69D9E530F96} Bug: 687231 Change-Id: I22125e434ffbd4e98de9c3373dcb54ac7f98799a Reviewed-on: https://chromium-review.googlesource.com/1100088Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567051}
-
Xing Liu authored
This CL hides the radio button when there is only default download directory option. Also tweaks the layout a little bit, so the radio button and the text can align with the "Download location" title in the preference UI. Bug: 850586 Change-Id: Id686ee8e8d06bd477606f62741386095fa11c31c Reviewed-on: https://chromium-review.googlesource.com/1098296Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#567050}
-
Ryan Hamilton authored
Change-Id: I3dfc9477e6cd79358656119628ba660d36bf7e70 Bug: 806109 Change-Id: I3dfc9477e6cd79358656119628ba660d36bf7e70 Reviewed-on: https://chromium-review.googlesource.com/1098030Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#567049}
-
Dave Schuyler authored
This CL changes the rich layout images to be centered in a box to the left of the text lines. This allows for answer images and entity images to be different sizes without doing a lot of less readable math. Bug: 798631 Change-Id: I882305ca09353266f02115446f481bff00b00e12 Reviewed-on: https://chromium-review.googlesource.com/1094263Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#567048}
-
jdoerrie authored
This change aims to reduce code duplication in the implementations of BluetoothTest::SimulateLowEnergyDevice for BlueZ and Windows. In order to do so it adds a utility struct and method to BluetoothTestBase, that implementations of SimulateLowEnergyDevice make use of. Bug: 821766 Change-Id: I5283a1eb55e50d68dce2c9810994cf6c4ed80212 Reviewed-on: https://chromium-review.googlesource.com/1096675Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#567047}
-
Justin Cohen authored
crrev.com/c/1090151 moved the null-pointer-arithmetic warning too far back. It's supported by Xcode 10, but not Xcode 9.3. Bug: 850333, 843234 Change-Id: I21935c592ca7b3ba75cb6fc7b7c0686564dd3ec4 Reviewed-on: https://chromium-review.googlesource.com/1099649Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567046}
-
Xianzhu Wang authored
Previously, if a clip was between two transforms, and the clip result was not tight, and the combination of the two transforms didn't change, we missed raster invalidation for the changed effective clip. Now check for change of LocalTransformSpace for clip and effect nodes. Bug: 848782 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1b60ecc2bc79cba69c667e188053b024de670361 Reviewed-on: https://chromium-review.googlesource.com/1094202 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#567045}
-
Matthew Jones authored
In the BottomContainer, in order to handle sitting on top of multiple different UIs, the setTranslationY function is overridden to apply offsets independently of the view's original translation. This was broken because the initialization logic also attempted to apply this offset. This patch updates the incorrect call in the init function and updates the math in setTranslationY. Bug: 851182 Change-Id: Id4955aed45b91cd55a3baf4c70f8087a65123f24 Reviewed-on: https://chromium-review.googlesource.com/1099772Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#567044}
-
Kevin McNee authored
Gesture pinch events have |needs_wheel_event| and |zoom_disabled| as browser side implementation details. There is no need to include these fields when sending the event to the renderer. Bug: 787924 Change-Id: I2a2e4f9376f384801bb2ca73b5a0e20d589e92e1 Reviewed-on: https://chromium-review.googlesource.com/1087433Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#567043}
-
Saman Sami authored
Android does not support partial swaps. Instead, when an empty swap is requested we're supposed to commit overlay planes. Bug: 850546 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: If77156732b4f43872855a8ad676c42a5e9842678 Reviewed-on: https://chromium-review.googlesource.com/1099266Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#567042}
-
Zhiheng Vincent Li authored
Move CastCommandLineHelper.java from internal to upstream and let CastBrowserHelper use it to initialize command line. Bug: b/110021629 Test: cast_shell_junit_tests Change-Id: I9940e95e26be072bc1762e60f6c6ae541277d34c Reviewed-on: https://chromium-review.googlesource.com/1097548Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Cr-Commit-Position: refs/heads/master@{#567041}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4c48b107c6d1..571053a44f87 git log 4c48b107c6d1..571053a44f87 --date=short --no-merges --format='%ad %ae %s' 2018-06-13 hnakashima@chromium.org Mark modified content streams as dirty in CPDF_PageObjectHolder. 2018-06-13 npm@chromium.org Remove CFX_FixedBufGrow from cpdf_renderstatus.cpp 2018-06-13 npm@chromium.org Remove CFX_FixedBufGrow from cpdf_colorspace.cpp 2018-06-13 npm@chromium.org Remove almost all usages of CFX_FixedBufGrow from cpdf_dibsource.cpp 2018-06-13 npm@chromium.org Make CJBig2_Context::GetHuffmanTable return const 2018-06-13 npm@chromium.org Remove CFX_FixedBufGrow from fx_codec_icc.cpp 2018-06-13 art-snake@yandex-team.ru Merge the offset calculation logic within CPDF_HintsTable. Created with: gclient setdep -r src/third_party/pdfium@571053a44f87 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I28c83054cdeb3c8977f25384a0a9fdcfaba05834 Reviewed-on: https://chromium-review.googlesource.com/1099815Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567040}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e09b6845cf72..31d539486159 git log e09b6845cf72..31d539486159 --date=short --no-merges --format='%ad %ae %s' 2018-06-13 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@31d539486159 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I36cd8ade79f1655bde894b6200092132072e55a8 Reviewed-on: https://chromium-review.googlesource.com/1099537Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567039}
-
John Budorick authored
This reverts commit 8dbc0c82. Reason for revert: broke https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/32416 Original change's description: > Remove absolute paths from build files > > This CL removes all absolute paths to src and all usages of the out directory > name from all ninja files on most Linux builds. > > This means it's possible to mount your src directory at different locations and > still have incremental builds work. You can also rename your out directory. > > BUG=None > R=dpranke,caitkp,rockot > > Change-Id: I5ff5b0d2d60110755dde64e876c7f1a09d814b1a > Reviewed-on: https://chromium-review.googlesource.com/1091457 > Reviewed-by: Cait Phillips <caitkp@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567020} TBR=caitkp@chromium.org,rockot@chromium.org,dpranke@chromium.org,thomasanderson@chromium.org Change-Id: Iec959adc2e8c82dd191f382c0cfb197aea406fc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/1099979Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#567038}
-
Nico Weber authored
Bug: 852512 Change-Id: Ie118dcafd7dd46f62f03dbbd95091db24cb7ef26 Reviewed-on: https://chromium-review.googlesource.com/1099646Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#567037}
-
Adolfo Victoria authored
Move the proto parsing utilities into the WeeklyTime classes to make them reusable by policies that use the WeeklyTime protos. Added unit tests for the proto parsing. BUG=chromium:849506 TEST=WeeklyTimeInterval and WeeklyTime unit tests Change-Id: Ic6b327e9b75f6bf9f2c1d1d1a949ed30ec8f18f7 Reviewed-on: https://chromium-review.googlesource.com/1097698 Commit-Queue: Adolfo Higueros <adokar@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#567036}
-