- 11 Jul, 2019 40 commits
-
-
danakj authored
The TextInputClient IPC messages are handled by a channel filter, which observes all incoming IPCs and does not depend on the routing id, so going through RenderWidget and using its routing id is not needed. The TextInputClient functions (incorrectly but...) while the main frame RenderWidget is frozen. We do not want to have the RenderWidget sending any IPCs while frozen and want to CHECK() that, so move TextInputClient out of the way. Also does some cleanups in the TextInputClientObserver class, and removes it from the build outside of mac since it is not used. R=creis@chromium.org, dcheng@chromium.org Bug: 419087 Change-Id: I6e4c5dbf9af9368dd732a79352984d1dd18bdf6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695809Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#676562}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8db211bc8d28..60e2f11eb584 git log 8db211bc8d28..60e2f11eb584 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 cwallez@chromium.org Rename StaticType's kInstance to instance. 2019-07-11 clemendeng@google.com WGL implemetation for OpenGL tutorial 2019-07-11 syoussefi@chromium.org Vulkan: Prepare for variable-stage pipelines 2019-07-11 lujc@google.com Vulkan: Recycle vkFence 2019-07-11 timvp@google.com Vulkan: Clean up deqp_gles3_test_expectations.txt 2019-07-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 8aa9a7bb8f74..c538b5d796fb (2 commits) 2019-07-11 jiajia.qin@intel.com Fix the RTV and SRV conflict 2019-07-11 shrekshao@google.com Add flags to shader translator to emulate gl_BaseVertex and gl_BaseInstance 2019-07-11 kbr@chromium.org Support blitFramebuffer to and from IOSurface-backed textures. Created with: gclient setdep -r src/third_party/angle@60e2f11eb584 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: chromium:981610,chromium:891861 Change-Id: I13773fcaa987c74812105c8fe116a585d07ac2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697077Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676561}
-
Amin Hassani authored
Use this newer DBus in favor of AttemptUpdate D-Bus. In the future we need to move back to AttemptUpdate after it has been modernized with protobuf. Bug: 982438 Test: tryjob Change-Id: If304a96d5f81ec7291b7f3d1bbc5aa245ab92c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687779Reviewed-by:
Xiaochu Liu <xiaochu@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Amin Hassani <ahassani@chromium.org> Auto-Submit: Amin Hassani <ahassani@chromium.org> Cr-Commit-Position: refs/heads/master@{#676560}
-
Becky Zhou authored
Bug: 951955 Change-Id: I64cce0788cf3d8273f8a7edd0fd163cd35b18c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698663Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#676559}
-
A Olsen authored
User-policies are not available at time of sign-in. Device-policies would not have the desired behavior - This should work for all users at a particular domain, regardless of which device they use. So I have re-introduced the feature flag we had earlier. Always parsing these attributes if the feature flag is enabled is the best way forward - then the results of parsing are discarded later if the policy is disabled for that logged in user. Also hardens parsing JS against bad input. Bug: 930109 Change-Id: I761e35b4eac6c2ead62400440aaa583b7e68626d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692987Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#676558}
-
Jun Cai authored
Currently SMS API listens to timeout events from the JNI android SmsRetriever API. This CL updated SmsReceiverImpl to handle timeout using a OneShotTimer per request so that the API uses the timeout value that the user sets up. Bug: 969130 Change-Id: Ie99c2e1650a5689a2dbd65c0708324b71df97639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682329 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#676557}
-
Matthias Körber authored
Change-Id: Iabd6ee61bfed56dca7c074cd41f835bcd18a74d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631706 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#676556}
-
Nate Fischer authored
No change to production logic. Although writing JavaScript console.log() messages (and related methods) to android logcat is a privacy issue if done in production (see https://crbug.com/905251), it's perfectly fine to do during automated tests, where all the web content is written by chromium contributors. This changes onConsoleMessage() to print the actual text passed to console.log() into logcat, including other attributes (ex. source code file the log message came from). This also changes the behavior to log every console message to logcat, rather than the previous implementation which was gated behind the TRACE variable. This is to help catch JavaScript errors (which also generate console messages). Bug: 983005, 964471 Test: used this patch when investigating another test, verified logs in logcat Change-Id: Ied627d106f6ef9af4b05c67556d62d80c6462b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696908Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#676555}
-
David Bokan authored
Turning on FractionalScrollOffsets allows scroll offsets to have floating point precision. This means scroll into view on an element might land mid-pixel. In the case of this test, the height of the element meant that the scroll offset expectations all changed by 0.5. This CL changes the height of the scrolled-into-view element by 1px to avoid landing on a fractional pixel. This causes the test to pass when the fractional scroll offset flag is turned on as well as keeping it passing until we do. Bug: 414283 Change-Id: I4239c8b424df7343cd671a760327093402826aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697304Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#676554}
-
Madeleine Barowsky authored
This change reduces boilerplate by using a CreateDrawImageInternal method that has default arguments for all variables except PaintImage. It also removes the is_decomposable parameter from CreateMatrix since that was never passed as anything other than true. The GpuImageDecodeCache also caps the image filter quality at kMedium_SkFilterQuality, so this removes kHigh_SkFilterQuality as default. Change-Id: I811e6f17ff83f3100d2c3fee470fc91908594639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695970Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#676553}
-
Eric Stevenson authored
212f516e changed the way R.java files work so that all resources are stored in a base R.java file, but accessed through R.java classes that subclass the base R.java. Currently for synchronized proguard, we combine all of the jars produced by the APK's java_library_impl() step. This dedupes class files, but also requires classes with the same name to be identical. With R.java inheritance, each APK will have a base module R.java with different contents, and Chrome will crash at runtime due to missing resources. We can't just rename the base module name in the various APKs that are part of synchronized proguarding because the subclass R.java files can only be included once, and can only have one direct superclass. Instead of creating a more complex R.java class hierarchy, this CL changes the compile_resources() step of the static library APK to generate a base R.java that contains the resources of both Chrome and Webview. Bug: 901465 Change-Id: Iaa2a05c75cd431b95afe6318da8c7982fffbc242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695699 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#676552}
-
Carlos IL authored
The data from this histogram is currently being used for efforts to change the optionally blockable mixed content UI. Change-Id: I43df2f777e6b96bc7b99615e4eb4f8784c1d7b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692450 Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#676551}
-
Danan S authored
Bug: 927957 Change-Id: Ice1b2239f8b8c5444be1c289b41d4fec09f0a3ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692730Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#676550}
-
yilkal authored
Bug: 977019 Change-Id: I4700f1c0a94951bccf0c521dde1b9790705f5f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676875 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Yi Fan authored
Mixer thread somehow gets stuck forever, not able to recover. Using ThreadHealthChecker to workaround Bug: b/136353019 Test: build & run Change-Id: Ifbc0bd1bca1da88124e5fc326e8db296f825a6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697317Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Yi Fan <yfa@chromium.org> Cr-Commit-Position: refs/heads/master@{#676548}
-
Ian Vollick authored
This is a temporary fix until we can convert this dialog to using modal dialog properties (and thereby use the touchless modal dialog presenter). This change was pair-programmed with mahmoudi@ Bug: 982869 Change-Id: If4f24ff1ecdf7584af3ca64983ae6533edf2a3b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696344 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#676547}
-
Matthew Cary authored
base::SharedMemory, which is being deprecated, exposes a utilty method GetHandleLimit() which needs to be moved somewhere. process_metrics.h seems to be a more appropriate place for this anyway over base::SharedMemory. Bug: 795291 Change-Id: I1562cca6445c362654ba4a52195c0ec4d53757ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695284 Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#676546}
-
Abhijeet Kandalkar authored
This CL removes the unused definition of ToElementOrNull as all the occurrences of ToElementOrNull() is already replaced with DynamicTo<Element>. This CL uses To<Element> and CHECK() in place of ToElementOrDie() and removes subsequent definition of ToElementOrDie(). Bug: 891908 Change-Id: I41328a58a8540aa1a981ed3f5609585e92865001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692761Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#676545}
-
Tarun Bansal authored
Add field trial to throttle browser initiated traffic when there are active P2P connections (that may be streaming real time content). The browser initiated traffic is throttled for a limited duration and only if: (i) There are active P2P connections (ii) Traffic annotation tag matches one of the tags specified using finch. (iii) Network is estimated to be congested (currently a simple check that looks for effective connection type). Bug: 913424 Change-Id: I111bbf9eea1243d7f2194bc489034545bd18aee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693394 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#676544}
-
Suman Nelson Kancherla authored
This is a no-op. All that is done is to separate DFM and ArCore install into a separate class and call the install API from consent dialog instead of from ArCoreDevice. Bug: 907591 Change-Id: I742db94cf896a4955d4de1938d7323d19a04664e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694401Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Cr-Commit-Position: refs/heads/master@{#676543}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f3dce1123b38..4cd9767e6565 git log f3dce1123b38..4cd9767e6565 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 capn@google.com Fix reporting VK_ERROR_OUT_OF_HOST_MEMORY Created with: gclient setdep -r src/third_party/swiftshader@4cd9767e6565 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/137093675 TBR=swiftshader-team+autoroll@google.com Change-Id: I93a60bcbad0e4b80b7db6791a3e04ca18c490b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697365Reviewed-by:
-
Doug Arnett authored
Adds DeferAllScript enabled status display and flags link to intervention-internals page. Bug: 965277 Change-Id: I2fc616b3db3e1e12e60972bf8beccaf7ef2625be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696360 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#676541}
-
Francois Doray authored
Crash reports indicate that TabSwitchTimeRecorder::RecordHistogramsAndTraceEvents is occasionnally called with |tab_switch_start_state_| being nullopt. However: - TabWasShown() sets |tab_switch_start_state_| and issues a RecordHistogramsAndTraceEvents() callback. - RecordHistogramsAndTraceEvents() expects |tab_switch_start_state_| to be set, and resets it before returning. - TabWasHidden() invokes RecordHistogramsAndTraceEvents() directly and invalidates previous callbacks issued by TabWasShown(). For the crash to happen, there must be multiple calls to TabWasShown() without the tab being hidden in between, which shouldn't happen. This CL makes the following changes: - Dump without crashing when TabWasShown() is called and |tab_switch_start_state_| is set (indicates that neither TabWasHidden() nor the RecordHistogramsAndTraceEvents() were invoked since the last call to TabWasShown()). - Invalidate previous callbacks issued by TabWasShown(), to prevent the crash from happening. A version of this CL without the call to DumpWithoutCrashing() should be merged to M76 branch before it is promoted to stable. Bug: 981757 Change-Id: Ic67c696022a73eb21c2ad48577f5e22c176f7987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695747Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#676540}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/67a281286c52..944f7dee7dc1 git log 67a281286c52..944f7dee7dc1 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 rsavitski@google.com fix one more instance of uint!=int in test 2019-07-11 rsavitski@google.com rm stray semicolon 2019-07-11 lalitm@google.com Merge "base: add waitable event header" 2019-07-11 lalitm@google.com trace_processor: properly handle and expose parent upids 2019-07-11 lalitm@google.com Merge "trace_processor: add kthreadd process if it doesn't exist" 2019-07-11 treehugger-gerrit@google.com Merge "Add chrome categories to perfetto record page" 2019-07-11 ilkos@google.com Merge "Add original anon and swap value" 2019-07-11 lalitm@google.com Merge "trace_processor: stop making diff tests depend on utid and upid" 2019-07-11 ilkos@google.com Merge "Add android package list proto" 2019-07-11 taylori@google.com Merge "perfetto-ui: Improve horizontal scrolling speed" 2019-07-11 rsavitski@google.com fix test comparison signs for chrome roll 2019-07-11 rsavitski@google.com Merge "args table: correct sort/filter behaviour for int-like & string-like objects" 2019-07-11 khokhlov@google.com Merge "Make JSON exporter compatible with a new version of jsoncpp" 2019-07-11 fmayer@google.com Merge "Roll clang. Make buildtools depend on default_deps." 2019-07-11 fmayer@google.com Add libtinfo5 to kokoro container. 2019-07-11 fmayer@google.com Merge "Use hermetic linker instead of system one." 2019-07-11 eseckler@google.com Merge "startup writers: Commit locally buffered data in batches" Created with: gclient setdep -r src/third_party/perfetto@944f7dee7dc1 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:136635390 TBR=perfetto-bugs@google.com Change-Id: I0dead33b4981e81d3454c210dde8422be865cf1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697366Reviewed-by:
-
Abigail Klein authored
Introduce new text track properties for the window surrounding webvtt captions and wire them to the WebVTT caption display tree HTML element. This looks like an element surrounding the captions cue with 1% padding, rounded corners, and spanning the width of the video. If the user settings do not set the window to be visible, do not give it padding. To test, open a video that has a WebVTT captions file. For example, https://www.iandevlin.com/html5test/webvtt/html5-video-webvtt-sample.html and http://mounirlamouri.github.io/sandbox/webvtt/regions-inline-styling.html are nice examples. To change the window style, open System Preferences > Accessibility > Captions and add a new captions/subtitle style. I explored several options to have the window not span the width of the video, as it seems more visually pleasing, and wouldn't block as much of the video. The options investigated were: 1. Make the window a flexbox element. This would require a refactor of: a. The media controls layout, or b. The algorithm to position the captions above the media controls. 2. Make the window a span surrounding the captions cue (prototype: https://www.software.hixie.ch/utilities/js/live-dom-viewer/?saved=7043). This would mean the window would appear more like a border to the captions cue, rather than a block surrounding the captions, which I believe is the intention. Since caption styles for mac are now behind a feature flag, we can come back to one of these options in a follow-up if we prefer the aesthetic of the captions window not spanning the entire width of the video. Now that the captions cue has 1% padding, the captions cues take up more space, and cues stacked on top of each other will be farther apart when the window is visible. Bug: 897730 Change-Id: I98844d1ca09f350c034156661ccb2f507419fe5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658914Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#676538}
-
Javier Ernesto Flores Robles authored
Dynamic colors are resolved before assignment as a workaround for a bug in MDCButton, where the colors are used in a CALayer which has no traits. Bug: 976640 Change-Id: I4af4322296e21bc39301e749207f0cc720947cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695297 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#676537}
-
Orin Jaworski authored
This CL makes OpenSearch description document fetching more robust by timing out old failed requests and retrying requests that would otherwise silently fail due to network change. Bug: 956689 Change-Id: I26e21194ea8911916b7766b3a6eb47d6d35643c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688437 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#676536}
-
Daniel Nicoara authored
This is disabled by default on regular builds to conserve space. Enable it in tests to gain coverage. Bug: None Test: None Change-Id: I215b80df0c2f7594310e94acb0e6ff313dd659ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678817Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#676535}
-
Alex Moshchuk authored
Bug: 975945 Change-Id: I6a9413d1f89cea042df59a99e5df7c4e72c3dd46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693482Reviewed-by:
-
Shivani Sharma authored
This CL changes the browser test to actually send a user gesture to a frame instead of calling the user activation API UpdateUserActivationState to be sure that the user activation API gets invoked correctly. *OnUserGestureResetSameDocumentEntriesSkipFlag Test: content_browsertests --gtest_filter= Bug: 907167 Change-Id: I4764f084095a162d5a6d0a7f603cdf3201c41d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690707Reviewed-by:
-
Fredrik Söderquist authored
When loading of images is disabled, ResourceFetcher will return an ImageResource{,Content} whose status is "not started". Since this resource will not get a "finished" notification, we didn't update the <img> to show fallback content when the image is first requested. Subsequent loads would yield the fallback correctly because the cached resource was returned. Add a case to ImageLoader::DoUpdateFromElement() to check for this case and call NoImageResourceToLoad(). Bug: 982603 Change-Id: I6377f87a45745c364f92ceb0e8c4dabd4fbc1b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695549Reviewed-by:Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#676532}
-
Scott Haseley authored
Setting expiry to M79 for various TabManager metrics that were previously set to M77, M78, or unset. Bug: 975494, 975864 Change-Id: I8cc98cbb8ef518f5e139dda033a7996db800a133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696530Reviewed-by:
-
Fredrik Söderquist authored
This collection of predicates are pretty intricate, and are a better fit for ImageLoader, so move them there into a new method called ImageIsPotentiallyAvailable(). Bug: 982603 Change-Id: I4825d833809cda7a9daa153a58c18d6fcbd92048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697650Reviewed-by:
-
Rayan Kanso authored
Change-Id: Ie80bd509889ce66372bd95b59cf75a9b7571723a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697251 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#676529}
-
Egor Pasko authored
I found that crazylinker tests are special enough not to be run during regular testing. I fixed a small issue and added a document about a few non-trivial-to-discover ways to test the crazylinker in Chromium checkout. After the fix all the off-CQ testing described in the doc passes on my Nexus5X, with the exception of fuzzers - I did not run those. Applying TBR for docs only. TBR=rmcilroy@chromium.org Bug: 981599 Change-Id: I7ead0ef59c6b402729393ba273798107afefed46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695309Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#676528}
-
Kristina Nelson authored
Previously these histograms were based off another histogram which resulted incorrect description and boolean bucket labels. Bug: 815290 Change-Id: I7fb9ced71e403317592c9f2adb8c6546b0ced4e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690814 Commit-Queue: Kristina Nelson <krstnmnlsn@google.com> Reviewed-by:
-
Chris Blume authored
$ git log 76aabbd35..14eba7add --date=short --no-merges --format='%ad %ae %s' 2019-07-09 chrdavis Fix static const data duplication Change-Id: Iebb764e1af1ed4b7dd904f20e318549049207749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696481Reviewed-by:
Jonathan Wright <jonathan.wright@arm.com> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#676526}
-
jonross authored
The main expectation for scrollbar-layer-placement-negative-z-index-child has been changed: https://chromium-review.googlesource.com/c/chromium/src/+/1694249 However with the test running again it encounters a blurring related to using GPU Raster. Updating the expectations for skia_renderer_gl_blink_web_tests to account for this. We'll need the flag specific rebaseline. TBR=backer@chromium.org TEST=skia_renderer_gl_blink_web_tests Bug: 954328 Change-Id: I0fb92ff7ad7d6f463a28a0d45ae83c7af211011e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697305Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#676525}
-
Adam Langley authored
Several sites have not set a value for userVerification in either create or get calls. This means that they end up with “preferred”, which is generally not what they want. This change adds a warning to the console in this case. The warning can be silenced by explicitly setting userVerification to any valid value. BUG=980972 Change-Id: Ide02de81f654c7101744bbc36d66b7c0dee00cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696170 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#676524}
-
Will Harris authored
This API can't be relied on as it needs the NtMapViewOfSection intercept to be in place, which is not always the case. There were no callers to this API anyway. Also, tidy up the hardcoded values to make them more readable. BUG=None Change-Id: Ib45b524f465a2730f9164eac987ffa8b35181243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696526 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#676523}
-
