GitLab

The toMatrix method of a CSSTransformComponent should return a DOMMatrix
representing the object transformation.
https://www.w3.org/TR/css-typed-om-1/#dom-csstransformcomponent-tomatrix

The skewXSelf and skewYSelf methods used to apply a transformation on a
matrix must be provided with an angle parameter expressed in degrees.
https://www.w3.org/TR/geometry-1/#dom-dommatrix-skewxself
https://www.w3.org/TR/geometry-1/#dom-dommatrix-skewyself

Since the angles passed to the skewXSelf and skewYSelf were in radians,
DOMMatrix returned by the toMatrix method of those two components was incorrect.

R=alancutter@chromium.org

Change-Id: I5edc1cdf1493184584154723508c6e20c212ac92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242008
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786632}

This CL adds a arc_toast_surface_manager for ARC++ toasts. Since the
toasts may contain sensitive information, this CL ensures to hide toasts
in locked-screen.

BUG=b:109717200
TEST=ArcToastSurfaceManagerTest

Change-Id: Ie0802697f76adbfd48ac7f91304e28a79e475bea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214761
Commit-Queue: Toshiki Kikuchi <toshikikikuchi@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786631}

The OnInputMethodOptionsUpdated event is fire when any change is made
to the input method specific settings in pref so that ime extension can
reload options immediately.

We register an observer in input method engine, and whenever we observe
the change, we check settings of which input method is changed and then
fire the event with that input method code.

Test: tested in Chrome on Linux, added browser tests.
Bug: 1042084
Change-Id: I4971b838f3a3b0eff32ad454f19d273e6804ef3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257119
Commit-Queue: Jing Wang <jiwan@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786630}

Set use_real_dbus_clients to true when building for real devices.

chromeos-amd64-generic-rel and chromeos-betty-pi-arc-chrome build chrome
for real devices, but run interactive_ui_tests which relies on fake
D-Bus clients.
Change mb_config.pyl to set use_real_dbus_clients to false for them.

BUG=952745
TEST=chrome binary size reduced by 460KB on eve.

Change-Id: Ibbb08babe5b693447158fc9192d1df854992e29f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282635Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786629}

Use TabModelSelector#isTabStateInitialized instead of
TabModelFilter#isTabModelRestored to determine whether the tab models
are fully restored.

There should be no behavior changes.

Bug: 1065314
Change-Id: I198a44812e51f3a0b85518f92efd861da5e0a517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191734
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786628}

Deleting app shortcuts results in time out on Windows 7 when profile
deletion tests are finished. A suppressor is added to disable them.

Bug: 1073451
Change-Id: Ic8711b6a6821da8b4581613282dd04e80a2f1f4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264434Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786627}

This patch enables EditingNG runtime enabled as "test" to verify wider audience
for preparation of enabling EditingNG as "experimental".

This patch contains lots of web_test expectations updates due by differences
between legacy layout and LayoutNG, e.g. content editable elements are laid out
in LayoutNG.

Test expectations changes are caused by:
  1. Difference of handling of spaces before <br>: (AX
    legacy: keeps them, LayoutNG: removed
    e.g "accessibility/inline-text-box-next-on-line.html"
  2. Difference of List marker in AX tree
    legacy: AXListMarker, LayoutNG: AXListMarker+AXStaticText+AXInlineTextBox
  3. Update test scripts using w3c test for EdigingNG
    - End key implementation
    - A space of soft line wrap; legacy=in tree, LayoutNG=not in tree
  4. Pixel differences (image and paint invalidation)

After this patch, we use "linux_layout_tests_layout_ng_disabled" bot for
verifying content editable in legacy layout.

Summary of test expectations update:
 - linux       18 images
 - mac         34 images
 - mac10.10     9 images
 - mac10.11     0 images
 - mac10.12    11 images
 - mac10.13    16 images
 - mac10.14     2 images
 - win         32 images
 - win7         9 images
 - legacy      39 images

Bug: 707656
Change-Id: I1dfed22f364f6edacb27de001f90609ca3f22c09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710011
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786626}

So far cookies were disallowed when PartitionAlloc Everywhere was
enabled using |#if BUILDFLAG(USE_PARTITION_ALLOC_AS_MALLOC)|. Now that
crrev/c/2275886 added a run-time check for tag, use this mechanism
for cookies as well.

Bug: 998048
Change-Id: Iad5f0b5084670bc9129c36da8464992f679e8aa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287071
Commit-Queue: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786625}

Use existing print preview sidebar variables to set the width the 192px.

Bug: 1059607
Change-Id: I173385684f57ddf204d5bb8c109d5e070381f3ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284966
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786624}

This reverts commit 8d2f4a87.

Reason for revert: Seeing some strange behavior introduced by this CL.

Original change's description:
> Fix propagation of empty AssistantSuggestions in AssistantResponse.
> 
> Bug snuck in with:
> https://chromium-review.googlesource.com/c/chromium/src/+/2257401
> 
> Bug: b:160641054
> Change-Id: Iaa2c2c7ea7a453e871610fa8b268d4492f7a1c56
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284364
> Reviewed-by: Jeroen Dhollander <jeroendh@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Commit-Queue: David Black <dmblack@google.com>
> Cr-Commit-Position: refs/heads/master@{#786029}

TBR=xiaohuic@chromium.org,dmblack@google.com,jeroendh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b:160641054
Change-Id: If7e979bd197e0b105802cae2110ac9272479d5ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289082Reviewed-by: David Black <dmblack@google.com>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#786623}

Bug: none
Test: ./build_ffmpeg.sh
Change-Id: Ia5005852432b21a4f92f3bbc2a4cbf44bef7c8b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288713
Auto-Submit: Wei Lee <wtlee@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786622}

This reverts commit a51d306b.

Reason for revert: Causing https://crbug.com/1095520 and the original
bug isn't severe enough to warrant another fix.
TBR=alancutter@chromium.org

Change-Id: Ibfa7e073f713c3f0b1d29666bddf194553b04ddd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248386
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786621}

I also took this opportunity to silence a clang-tidy warning in values.h. Given that there is already a long comment about why the linter is wrong in this case, it seems only natural to let the linter know about it, too.

Bug: 646113
Change-Id: I59ae89f42731445789638c4c25840249263127fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285305
Commit-Queue: Panos Astithas <pastithas@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786620}

Change-Id: Ib40248adae14cbdcdbf389f5689308110261b555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289373
Auto-Submit: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786619}

Microsoft::WRL::ComPtr<T>::GetAddressOf() is banned due to the ease
of causing memory leaks.

Also replace CopyTo(foo.GetAddressOf()) with As(&foo) since CopyTo(&foo)
does not work if we are copying to different interfaces.

Also replace QueryInterface(foo.GetAddressOf()) with
QueryInterface(IID_PPV_ARGS(&foo)).

Bug: 914910
Change-Id: Iab2499f6c5348afab8e3b5b7a88be7553a035dab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271074Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786618}

This CL introduces a new shell type for ARC++ toasts in remote-shell.
Since the purpose of toasts is a notification for users and the toast
appears and disappears quickly without any user interaction, so toasts
are supposed to be shown over Chrome OS's virtual keyboard.

ARC++ side CL: ag/11272597
design overview: go/vk-overlays-toasts

BUG=b:109717200
TEST=ToastSurfaceTest

Change-Id: I3cec22a031a7046ff63770ff308b6d0695c313e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167792
Commit-Queue: Toshiki Kikuchi <toshikikikuchi@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786617}

Roll Chrome Win32 PGO profile from chrome-win32-master-1594238316-5a06a9d54d894d0a4b76afbfa24ee9bc79afbdb3.profdata to chrome-win32-master-1594241852-dbfc5354e90dfa07f5b39f6ede0ae89c2c21363d.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: Ia62d6239f813a275f1d7566e04e80bcd14809fb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289126Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786616}

This reverts commit d64e736a.

Reason for revert: Caused chrome_all_tast_tests / camera.CCAUISanity.fake failures; e.g. https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/7680

Original change's description:
> Do not expose media devices before a successful getUserMedia()
> 
> This is a spec-compliance change.
> 
> This CL also adds some improvements to the blink MediaDevices unit test.
> 
> Bug: 1101860
> Change-Id: If2e7824df3b3dbd3cdb80f4bcf6b5c417d6f0ef2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279808
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Harald Alvestrand <hta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#786253}

TBR=hta@chromium.org,guidou@chromium.org

Change-Id: I41b676c7d3e437c06d23f2b46270453f1cc81670
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1101860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288282Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786615}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=benmason@chromium.org

Change-Id: Ib08bcf3112a9da19685fc57c9c922465cc023815
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289351Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786614}

Some of these prefs will be directly set in settings while other will be
managed by Nearby's local device manager. The settings added to the
allow list in settingsPrivate will be used directly in settings.

Change-Id: If16722bb8441776a7ff057e01532d19ac2bc7c0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289211
Commit-Queue: James Vecore <vecore@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#786613}

Previously, Supersize-diff of for multi-container .size data does not
assign a container for symbols with name:
  "Overhead: aggregate padding of diff'ed symbols",
which are added as "after" symbols of DeltaSymbols. As a result, when
saving .sizediff files, these symbols cause key error since their
container names of '' do not match an existing (diff) container.

This CL fixes the problem by assigning a container to the above symbols.

This CL also defines "segments" as (container, section) tuples. In .size
files these appear as, e.g., "<0>.text", and serve as grouping keys for
various data.

Bug: 1040645
Change-Id: Ibbd7d96a9b4e413dd782ee8c0dc551e43c7d7f3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288206Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786612}

Bug: 1094768
Change-Id: Ib692acc66b8446cc2606551507caf01b6c7bc313
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289271
Commit-Queue: Owen Rodley <orodley@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Owen Rodley <orodley@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786611}

https://webrtc.googlesource.com/src.git/+log/563d497e009f..18523c34b464

2020-07-08 handellm@webrtc.org Migrate rtc_base to webrtc::Mutex.
2020-07-08 handellm@webrtc.org Migrate modules/desktop_capture and modules/video_capture to webrtc::Mutex.
2020-07-08 handellm@webrtc.org Clarify logging docs.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I4382c2f21c9c978372a8a7dfd7639045ae40676c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289153
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786610}

onInputMethodOptionsChanged event will be fired by input method engine
when any change to the input method settings in pref has been observed.

Changes in third_party/ are auto-generated according to instructions at
https://chromium.googlesource.com/chromium/src/+/master/docs/closure_compilation.md
These two files were not update to date before, so there are some changes
which are irrelevant to input method options changed event.

Bug: 1042084
Change-Id: Iff7ccf76b11d5c196ac3aa2c012b2ef92720bde6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264089
Commit-Queue: Jing Wang <jiwan@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786609}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d60500e69944..8e4267f23771

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC keishi@google.com,jam@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1102962
Tbr: keishi@google.com,jam@google.com
Change-Id: I367c96fa4f83115f1322e37238b90a9fd6a7b86c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289115Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786608}

R=akihiroota@chromium.org, katie@chromium.org

Fixed: 817636
AX-Relnotes: ChromeVox correctly provides spoken feedback when performing a select all (ctrl+a) on a multiline editable text field that contains only a single line.
Change-Id: I4b83cb044c496dab14ba6c43068cb4295ea1bcc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288089Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786607}

R=akihiroota@chromium.org

Fixed: 816631
AX-Relnotes: time and date (Search+a, d) feedback provided in braille as well as speech.
Change-Id: Ic0447e493ef88cca3f494534e8397370abf2d972
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288090Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786606}

[LayoutNG] Make NGInlineCursor::PositionForPointInChild() to work with inline-block that has block children

This patch changes |NGPaintFragment::PositionForPoint()| to work with block
children inline-block to make |NGInlineCursor::PositionForPointInChild()| to
work with it.

Bug: 1096110
Change-Id: Ia7d070fe5287a20868cafd4eac370e83a4d81fa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286092
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786605}

cr-input is mainly used for receiving user keyboard input and comes
with a lot of built-in features to support that. Since the print
preview dropdown does not directly receive keyboard input it makes
sense to replace cr-input with a standard div. This makes customization
of the dropdown cleaner as well.

"input" was removed from all of the element id's to reflect the removal
of cr-input.

Bug: 1059607
Change-Id: Icdbde1ac3e089fc76b35eef2ba67f76a4f649fe3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284866Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786604}

This allows rounded corners to be forced off
when there is a sibling to a webview container window.

Bug: b/155436903
Test: Locally on device
Change-Id: Ida192575a1584192a248ceb1e98b1b54e467e857
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245187
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786603}

QuotaClient will be converted to a mojo interface. Mojo doesn't have a
built-in type for set, and sets can be transmitted cross-process as
vectors. This CL replaces std::set use with std::vector, to facilitate
the conversion.

Bug: 1016065
Change-Id: I4c381b3082b0c4deb5dcea9a0af46cfe94a1e906
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286475Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786602}

Bug: 1102485
Change-Id: I43502e297fa36ea647e894addb09960057115275
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284003
Commit-Queue: dpapad <dpapad@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786601}

The cleanup will take 4 steps:
1. Add definitions to shared library in public repo and update usages
2. Update usages in internal repo
3. Update usages and remove obsolete code in public repo
4. Remove obsolete code in internal repo

This change is step 3.

Bug: b/160241802
Change-Id: Ia723886fa6832cc19eba2b54e5b10a5b8a6c3bb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284359
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786600}

The Gatekeeper config includes all builders under this master, except
for mac-osxbeta-rel. But actually this builder is under chromium.fyi, so
it wouldn't be included anyway.

Bug: 1094768
Change-Id: Ide1321def6f5702c68645a28c14c8da91fe698d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287329Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Owen Rodley <orodley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786599}

ANGLE has provided angle_libjpeg_turbo_dir as a build override for a
long period, but that probably never had any real effect until
crrev.com/c/2282277.

Bug: None
Change-Id: I44228ed1403cc496beeb00410a337f4f7ce538dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285839Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Jiajie Hu <jiajie.hu@intel.com>
Cr-Commit-Position: refs/heads/master@{#786598}

ClientUsageTracker::GetGlobalLimitedUsage() has a bug, exposed by the
tests in https://crrev.com/c/2288502/1. Fortunately, it is only used to
implement UsageTracker::GetGlobalLimitedUsage(), which is only used in
tests.

This CL removes the unused code, and adds UsageTracker unit tests to
prevent bugs similar to the one discovered in GetGlobalLimitedUsage().

Bug: 1103426
Change-Id: Ifb44dbce66579ea9afc420fce0ee2482cafa127d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288502
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786597}

This reverts commit fdc228c7.

Reason for revert: portal-activate-default.html test timeout failure
https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/55803

Original change's description:
> Abstract portal activation handling to avoid hack of making a fake promise.
> 
> This is somewhat verbose, but allows us to avoid the unhandled rejection
> being visible to script without having to make this hack even worse.
> 
> Instead of actually calling activate(), this mirrors the spec structure
> by simply calling to underlying logic, passing a resolver where it makes
> sense and not (in this case, passing a substitute object) where it
> doesn't.
> 
> Bug: 1102081
> Change-Id: I0eecf253928bfce39afcddccf54e9bc6f6c0d549
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285340
> Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
> Commit-Queue: Jeremy Roman <jbroman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#786480}

TBR=jbroman@chromium.org,adithyas@chromium.org

Change-Id: I00da9eee8625ca5da3a09efb7078e22a277dbfd8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1102081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288712Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786596}

Enforce isolated world CSP for fetches from isolated worlds instead of
just bypassing the main world CSP. This also helps fix a bug where a
redirected fetch from a content script doesn't correctly bypass the main
world CSP. Add a regression test for the same.

BUG=934819, 1099975

Change-Id: I3c471464274f1657ef3c08378f06a3963f95a0aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278626
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786595}

When there are multiple running instances of the same
app, left clicking its icon on the shelf will display
an application menu showing an item for each instance
from which users can select which instance to activate.

When the kPerDeskShelf feature in enabled, this list
should be filtered to show only running instances in
the current active desk. This is done via giving the
ShelfItemDelegate a filter_predicate to exclude the
apps belonging to other desks.

BUG=997102
TEST=Manually, browser_tests --gtest_filter=*PerDeskShelfAppBrowserTest.AppMenus*

Change-Id: I8d70586a1ad638a42e6aa71378a55007c6b8dabb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258902
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786594}

The |CtapMakeCredentialRequest| objects are already tweaked for each
authenticator, but it was done just before dispatch. Thus lots of logic
depended on the authenticator-independent |request_|, which wasn't what
was actually sent. Since the tweaks are currently small, that didn't
matter, but hmac_secret will make that more complex.

Instead, perform the tweaks at the beginning of processing and carry
that copy of the request through the functions. The logic becomes
authenticator-specific after a while, so it would be possible to use
|request_| for this. But, in order to avoid having to remember which
functions are request specific and which can use |request_|, just thread
the object everywhere.

Since the |CtapMakeCredentialRequest| is quite a complex object, with a
lot of members to move, the per-authenticator request is held in a
|unique_ptr| so that the moving is trivial.

Change-Id: I807aa44df237440c209d3062621b66e953515854
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258855
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#786593}