- 31 Oct, 2019 17 commits
-
-
Philip Rogers authored
We have an optimization to directly update compositor property node values from blink and skip a PaintArtifactCompositor update. If a blink::PaintPropertyNode is not known to be composited (does not have a direct compositing reason) but does have a cc::PropertyNode, we cannot simply do the direct update because we may need to issue invalidations on the non-composited content that has changed. For example: <div id="a" style="transform, not-directly-composited"> <div id="b" style="transform, composited"></div> </div> If a's transform changes, PaintArtifactCompositor::Update needs to run to notice the change. Because b is composited, there is a compositor property node for a, but we cannot just update it. This regressed in https://crrev.com/692043 which stopped creating a composited layer for some transform ancestors, and without this layer the underinvalidation bug became visible. This change has a few places where direct compositing reasons are now set when they were not before (viewport nodes and scroll offset nodes) to allow for direct updates. Bug: 1017939 Change-Id: Ib8167e981d3d613af44ea40224c5e4328029607e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888374 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#711062}
-
Gavin Williams authored
-Using aria-hidden will force the these text labels to be skipped over when navigating with the screen reader. The preference is to only navigate to the actionable button instead of its text label. -Adding an aria-labelledby and a aria-describedby will make the screen reader read "{printerName}, Button, Save/Setup" when navigated to. Bug: 1014145 Change-Id: I4cca27f8d48297d9de0c1409984b0344503e8bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859689Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#711061}
-
Alex Newcomer authored
We used to rotate the back button and hide apps when the VK was shown, but nowadays we completely hide the shelf behind the VK so this logic is not useful. Race conditions resulted in users seeing the shelf in this state after the vk is no longer visible, so just remove the logic to prevent this behavior. Bug: 1012425 Change-Id: I10dd761a4138373140e9d3c725d1eb4b945d66f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891017 Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#711060}
-
Michael Spang authored
The platform_window target is used from multiple components and should therefore be a component itself. This is needed to avoid ODR violations. One ODR problem that currently can happen is the duplication of the global boolean backing UseTestConfigForPlatformWindows(). Reland with fuchsia_dbg fixes. Bug: 1019015 Change-Id: I6781667889b45ce178d5a5aaa95807d6b0eb94e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891457Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711059}
-
Alice Boxhall authored
TBR=bsazonov@chromium.org Bug: 1014790 Change-Id: I249b7e9f2b49f9ec1b1108a0236178625fc3ce8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891811Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#711058}
-
Alexander Alekseev authored
Accelerometer values affect screen orientation and other visible behavior. Thus it should use USER_VISIBLE priority. Bug: 1004432,1000353 Change-Id: I717f7fb7ce2c4de0372b237f78c9d4493497c69f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891576Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#711057}
-
Daniel Rubery authored
This CL fixes a regression that leads to inconsistent widths for the items on the download shelf. This regression was introduced by https://chromium-review.googlesource.com/c/chromium/src/+/1864876 Fixed: 1017101, 1017921 Change-Id: Id0365810848dcdac59edec49eae1197c02130d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887890Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#711056}
-
Miriam Zimmerman authored
Previously, the blue background of the blue-button was too light, and didn't meet WCAG contrast ratio guidelines. This CL makes it darker. Fixed: chromium:1005543 TEST=Take before/after screenshots, use color contrast checker. Change-Id: I6052f9539bf9d506914e0affc56ddc6bdea704bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888726 Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Auto-Submit: Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#711055}
-
Rafael Cintron authored
Skip WebGPU tests on Win7 as Win7 does not support D3D12. Since WebGPU decoder tests require a GPU in order to run, they are moved to gpu_tests from gpu_unittests. gpu_unittests.exe run on "GPU less" machines. As a side effect of the move, the tests are no longer skipped on Mac. The change also disables the WebGPU tests on Linux since the shared Vulkan shared image extension is not working or being initialized properly on the bots. Bug: 1017035 Change-Id: Ie5426bd0e1e0bb4b570a74b8a75c1f99c80d246d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879655 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711054}
-
Kazuki Takise authored
BUG=b:143501658 BUG=b:143189411 TEST=Manually confirmed PIP dismiss animation works well on an external display Change-Id: I931b18635ed99cfff9c230f69687497a43efb2b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888859Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#711053}
-
Rob Schonberger authored
This CL introduces behavior to delay touches that would be flagged as palm by heuristic, until inference occurs. This is all flagged by a configuration flag. We add a thorough unittest to test behavior: that delay is set, and kept, until Inference. Test that delay is not set when flag is off. Bug: 1009290 Change-Id: I060db0a2dda207537a5cc1f61690d0fafcc2f4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888618Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#711052}
-
Michael Lippautz authored
MatchedPropertiesCache was using weakness to hold alive a cached entry as long as all of its matched properties are alive. Once a single matched property dies the entry was removed. This can be modeled using a custom weakness callback that performs the same logic. Cached entry don't have any outgoing edges except for their cached matched properties, so ephemeron semantic is not required. Using a custom weak callback is also faster because the callback is only executed once and not part of the ephemeron fixed point protocol. The cached entry is unlinked using the weak callback and collected on next GC cylce. After this conversion, custom weakness can be removed from hash traits. Weakness should always go through already supported types (e.g. WeakMember). The reland fixes an issue where the callback was unable to handle entries that are just being created. This reverts commit d2707b61. Bug: 1019191 Change-Id: Iab55a5247d33f50bf60417ba6f15e58dfa3ff08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891171 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#711051}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4e19670d3a93..5bd8cb74a659 git log 4e19670d3a93..5bd8cb74a659 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 hbos@webrtc.org Revert "Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5."" 2019-10-30 minyue@webrtc.org Renaming opus_interface.c to opus_interface.cc. 2019-10-30 danilchap@webrtc.org Split out counting unique rtp timestamps from packet_buffer 2019-10-30 trevor.axiom@gmail.com Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5." 2019-10-30 ilnik@webrtc.org Make update_rect optional in VideoFrame Created with: gclient setdep -r src/third_party/webrtc@5bd8cb74a659 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:396091,chromium:b/143582588,chromium:None,chromium:396091 Change-Id: I95e80b26b566d9d6c5179d95130581fbf0b8c17d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891380Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711050}
-
Daniel Rubery authored
In cases where deep scanning fails, we currently supply a SAFE verdict. If the original verdict from Safe Browsing was UNCOMMON, we will therefore downgrade the warning. This CL preserves the original verdict and returns it in cases where deep scanning fails. It also adds a test implementation of the BinaryUploadService, for easier testing of code using uploads. Fixed: 1017921 Change-Id: I444b301c3fe75ebbe0561bc6b201945242f09dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887736 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#711049}
-
Simeon Anfinrud authored
This works around the clang-format runtime/references rule. If someone forgets to add the `const`, the compiler will hit a static_assert that will point that out, rather than a harder-to- read message that buries the mismatched type in the callback's template parameters. Bug: None Test: cast_base_unittests Change-Id: Ia9610756111b90bb236c98f916a36b2909fd587f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890823Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711048}
-
siyua authored
Upload screenshots in bug comment 38 Bug: 932818 Change-Id: I83e866377cd2907ac26a969ffa91651f56ca872a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891587Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#711047}
-
Daniel Murphy authored
This patch moves the basic leveldb layer (and testing utilities) from the IndexedDB directory to the Storage Service directory. content/browser/indexed_db/leveldb -> components/services/storage/leveldb/ Note: The files left in the IndexedDB leveldb directory are part of the 'transactional' leveldb layer, which will soon live in its own directory in the Storage Service as well, 'transactional_leveldb'. Bug: 1015212 Change-Id: I834b60cb5b8acdc3137a3b5d60efcfdebc5ede2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888381Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#711046}
-
- 30 Oct, 2019 23 commits
-
-
Alice Boxhall authored
This reverts commit 3ef63a6b. Reason for revert: Looks like this has caused a crash, e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8898135829966943488/+/steps/ash_unittests/0/logs/Deterministic_failure:_OverviewSessionWithHomerviewGestureTest.FadeOutExit__x2f_0__status_CRASH_/0 Original change's description: > Implement transitions to home for homerview feature > > Updates how device transitions to home when home button is tapped and > when user clicks in empty space in overview grid when kHomerviewGesture > feature is enabled. > > When overview is active, it should use kFadeOutExit transition (instead > of slide out) - this also fixes a bug where transform was not cleared on > item windows when bounds were updated without animations (which was > causing item window misplacement when the grid was updated while > minimizing active window before exiting overview). > FadeOutWindowsAndMaybeSlideOnExit is updated to take "slide" as an > argument instead of deducing it depending on the animation type, as > OVERVIEW_ANIMATION_EXIT_TO_HOME_LAUNCHER should slide if and only if > using slide out overview exit transition (the animation can also be used > by fade out exit). > > When clicking home with a window active, the top window is minimized > using transform to home screen (the same used during drag from shelf), > while the rest of the windows are minimized with no animations. To make > this easier, WindowTransformToHomeScreenAnimation is moved to a separate > file, and is updated to better handle windows whose origin is not in the > screen origin (which is useful for transforming top windows in split > view). > > Is split view, the top windows are transformed to home screen as the > split view ends. If overview session is active together with split view, > the overview session is ended immediately to avoid showing overview just > after ending split view (during duration of the exit transition). > > BUG=1005366 > > Change-Id: Ic23893866700f5e5580f4445915d815f188e8c0f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885972 > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710953} TBR=xiyuan@chromium.org,tbarzic@chromium.org,xdai@chromium.org Change-Id: Id4020082bc736ec6fc9306fc26c5a7a237cb4c54 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1005366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890392Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#711045}
-
Findit authored
This reverts commit 433bbd52. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 711038 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQzM2JiZDUyMTA0MmRjOTcyMmQ2ZDg2Nzk0MzNjODE0MGRmOWQwNGMM Sample Failed Build: https://ci.chromium.org/b/8898131381528610928 Sample Failed Step: compile Original change's description: > Remove HomeLauncherGestureHandlerObserver > > HomeLauncherGestureHandler currently has two observers: > * AppListControllerImpl, which is also a HomeScreenDelegate > implementation (on which HomeScreenGestureHandler already > depends, so additional observer interface just > obscures/complicates this dependency) > * HomeLauncherStateWaiter which is used by interactive UI/perf tests > to wait for launcher animations to complete > > For the former case, moving the observer methods to HomeScreenDelegate > interface will work fine. > For latter case, the test waiter can register a callback with > AppListControllerImpl to be run when the home launcher animations are > complete - the same way it's done by LauncherStateWaiter, an equivalent > test waiter used in clamshell mode (or for waiting for non-visibility > app list state transitions) > > Change-Id: Ia333bedab2b8683d35da2d00030cf40df2c619f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888652 > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711038} Change-Id: I449d4c15018c05c09953d445a50d1c1dc6f7c1a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890735 Cr-Commit-Position: refs/heads/master@{#711044}
-
Jiawei Li authored
Set the new QueryableData JS bindings feature on. Bug: internal b/138623432 Test: E2E manually test Change-Id: Ia1a3e4f650aeabee3aae90f9e764a63c2d9213b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891738 Auto-Submit: Jiawei Li <lijiawei@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Jiawei Li <lijiawei@chromium.org> Cr-Commit-Position: refs/heads/master@{#711043}
-
Toby Huang authored
Add reminders to mark the crbug as "started" before starting development work and to mark the crbug as "fixed" after landing the CL. Bug: None Change-Id: Id79ff0843679c368773b10d22ea9d72e4b1691d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891730Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711042}
-
Ken MacKay authored
Merge-With: eureka-internal/330177 Bug: internal b/127963522 Bug: internal b/138938216 Change-Id: Ia8b0a705f5ebe8d9b637af85ed537e0c7ac3e0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888114 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711041}
-
Sasha McIntosh authored
Land the JPEG YUV decoding feature behind a flag without affecting testing. Tests will be updated and rebaselined in a follow-up cl. Bug: 919627 Change-Id: I9debcf08e8eca02bebe53ec0f218843cd28da1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887273 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#711040}
-
Kalvin Lee authored
This change adds localization strings for JIS B* papers. Bug: 1017279 Change-Id: I369a016002f29ccbecdf18a9593611fed6084e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891118Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#711039}
-
Toni Barzic authored
HomeLauncherGestureHandler currently has two observers: * AppListControllerImpl, which is also a HomeScreenDelegate implementation (on which HomeScreenGestureHandler already depends, so additional observer interface just obscures/complicates this dependency) * HomeLauncherStateWaiter which is used by interactive UI/perf tests to wait for launcher animations to complete For the former case, moving the observer methods to HomeScreenDelegate interface will work fine. For latter case, the test waiter can register a callback with AppListControllerImpl to be run when the home launcher animations are complete - the same way it's done by LauncherStateWaiter, an equivalent test waiter used in clamshell mode (or for waiting for non-visibility app list state transitions) Change-Id: Ia333bedab2b8683d35da2d00030cf40df2c619f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888652Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#711038}
-
David Benjamin authored
Found with _LIBCPP_DEBUG=0. Bug: 923166 Change-Id: Ifdb0be8031bc95f05ff3d67876407569bac0e106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891235 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#711037}
-
Natalie Chouinard authored
Migrate Update Menu Item preferences to use PrefServiceBridge generic methods, making use of the prefs.h enums. Bug: 1016957 Change-Id: I3b37e1251e5c51d0bc08e4cfd0ae05245c2d052f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885103 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#711036}
-
Sammie Quon authored
I didn't find out the exact cause, but something about the ARC app was updating the backdrop many times during the course of a swipe, and was probably creating a new one which did not have an transform or opacity changes. This happens for regular windows as well, so instead, pause updates during a home launcher drag. Test: manual Bug: 1018125 Change-Id: I1d933921f8c17410fb6a8c81f96c94e93fc59955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884578Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#711035}
-
Yun Liu authored
'network_service_out_of_process_chrome_public_test_apk' and 'network_service_webview_instrumentation_test_apk' also need to excluded.. They will build 'chrome_public_test_apk' and 'webview_instrumentation_test_apk' targets. Bug: 985574 Change-Id: I31dd9baf7446b8e60ced7047006f99d1fcc85818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891122 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#711034}
-
Dan S authored
This reverts commit b3c71165. Reason for revert: <INSERT REASONING HERE> This CL's test breaks on linux-chromeos-google-rel because it relies on a string that is only built in the non-official builds "Chromium". See: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8898136527157394352/+/steps/browser_tests/0/logs/Deterministic_failure:_HotseatShelfAppBrowserTest.EnableChromeVox__status_FAILURE_/0 Original change's description: > Fix the issue of accessibility focus traversal with hotseat > > This CL accomplishes the following things: > > (1) Designate the previous/next focusable widget for navigation widget, > hotseat widget and status area widget. It prevents the accessibility > ring from being trapped in one widget. > > (2) Ensures that the hotseat is shown when the shelf app icon gets > the accessibility focus. > > (3) Implements the test api to facilitate browser tests to access > the shelf widget code. > > Bug: 1010219 > Change-Id: I86dd5cc464430f0a91c8c8a043fcb9fb437d58a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873386 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Andrew Xu <andrewxu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710986} TBR=xiyuan@chromium.org,andrewxu@chromium.org Change-Id: I9365d9456a9f461aa30ec412754eeed16f02150e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1010219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891850Reviewed-by:
Dan S <danan@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#711033}
-
Reilly Grant authored
This change makes SerialPort an ActiveScriptWrappable so that it can be kept alive for as long as the port connection is open. This prevents the streams created by the port from being closed if a page does not keep a reference to the port itself. Bug: 1017289 Change-Id: I23b4da0c5b27d16901d2d7eb7fd1c622a8404f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888513Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#711032}
-
Tarun Bansal authored
Remove gcm_channel_status_request from list of traffic tags throttled when WebRTC calls are active. gcm_channel_status_request is not related to fetching of finch variations seed (which was the original intent). Bug: 1005841 Change-Id: I25506fc832198471251206c33599837eca4f48a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885229Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#711031}
-
Moe Ahmadi authored
Bug: 1018433 Change-Id: I6d7bc590e8cb4d16b7589628744077dfc92c7605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888376 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#711030}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b43d98bf6484..48823c28549d git log b43d98bf6484..48823c28549d --date=short --no-merges --format='%ad %ae %s' 2019-10-30 jbudorick@chromium.org Revert "Add more git tracing." Created with: gclient setdep -r src/third_party/depot_tools@48823c28549d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I384d57ec204bab50837d83ad78d50d9a1431831d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891370Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711029}
-
Yuwei Huang authored
The "Send Feedback" button in the app no longer works and according to the logs it seems we need to add gsf.permission.READ_GSERVICES permission to the Android manifest. I can't build and test the official build locally so I'd like to check this in frst then verify it on the nightly build. Bug: 1019866 Change-Id: Iac01e9db420d95a8c8a7aa952ad9d2ab1ac9b6e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891464 Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#711028}
-
Frank Tang authored
ICU 65-1 release note http://site.icu-project.org/download/65 CLDR 36 release blog http://blog.unicode.org/2019/10/unicode-cldr-version-36-languagelocale.html Most of the test expectation change is due to CLDR 36 update of Grapheme Cluster for Indic languages See the following for related changes in ICU 65.1 in this area: https://unicode-org.atlassian.net/browse/CLDR-10994 https://unicode-org.atlassian.net/browse/ICU-13637 https://github.com/unicode-org/cldr/blob/master/common/properties/segments/readme.txt Bug: chromium:1014272, chromium:1017047 Change-Id: I9fc6d4620bf2a4c189940d06d8c79893502db3dd Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866059Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Doug Turner <dougt@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711027}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the browser process and the assistant service from ChromeOS for the Assistant, AssistantController and the AppListEventSubscriber mojo interfaces to the new mojo types. Bug: 955171 Change-Id: Id57a7b0c80bd7985fff98929d0370af00becf6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883517Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#711026}
-
Robert Kaplow authored
Remove some stale includes for already deleted metrics. Bug: 1016906 Change-Id: I8d6c33953df5caf367a33b9a0260b5a36d6ab754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876787Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#711025}
-
Sasha McIntosh authored
Restructure memory dump metrics to avoid double counting memory. Affected metrics: Memory.Experimental.Gpu2.Small.ServiceTransferCache Memory.Experimental.Gpu2.Small.ServiceTransferCache.AvgImageSize Memory.Experimental.Gpu2.Small.ServiceDiscardableManager Memory.Experimental.Gpu2.Small.ServiceDiscardableManager.AvgImageSize Bug: 963619 Change-Id: Ia1ae23ce99d351807eb1e3f9727882ec2257a153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888095Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#711024}
-
Roberto Carrillo authored
We are currently getting 6 out of 10 shards timing out with ~ 75% - 95% progress. R=agable,martiniss,liaoyuke Bug: 1017486 Change-Id: I5281a459dd87b27f406abbb3cbac3b27aae54544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889397 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#711023}
-