- 04 Nov, 2019 40 commits
-
-
chromium-autoroll authored
Roll silvermont AFDO profile from 80-3940.0-1572255699-benchmark-80.0.3954.0-r1 to 80-3943.1-1572866479-benchmark-80.0.3954.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I4894e1d432e02665320b08a5e48818c83506bb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898687Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712333}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/ee0968eaa398..f16e793858c4 git log ee0968eaa398..f16e793858c4 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 rharrison@google.com Rolling 5 dependencies (#862) 2019-11-04 9856269+sarahM0@users.noreply.github.com Add --emit-line-drective option (#861) Created with: gclient setdep -r src/third_party/shaderc/src@f16e793858c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: Ibfe2bd41baf979c14bf6fe9f78ee08eae5979e05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898129Reviewed-by:
-
Nick Burris authored
This patch adds tests for the specified security restrictions for scroll to text: https://wicg.github.io/ScrollToTextFragment/#should-allow-text-fragment - Test for navigation without a user activation. - Test for window.open() navigation without 'noopener' option. - Test for navigation within an iframe - Test for same document navigations. Tested updated WPT locally with run_web_tests.py --additional-driver-flag= '--enable-blink-features=TextFragmentIdentifiers' Change-Id: Ia70e32a42d629fe6f9ec28b89c3167a1c1efbd8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894302Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#712331}
-
rbpotter authored
Port the patch for iron-iconset-svg to the v3 version, since the added createIcon() function is still needed for Print Preview. Bug: 1012574 Change-Id: I6cc6d73e6088c4f9e01fe439ac43c183ed12fe07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898405 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#712330}
-
Frank Tang authored
Bug: chromium:1020034 Change-Id: I01ba52316734556787f0aa0d76d5225040924056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894668Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712329}
-
Changwan Ryu authored
Clarify that this is allowed. Bug: 918065 Change-Id: Ibb593015218dbb391d2165bc724191a4654ac33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898476Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#712328}
-
Jinsuk Kim authored
This CL collapses the preview tab, upon a click event on its header, down to peek state. Bug: 1019294 Change-Id: I6a9c7198b19efef61b311f6c3ba0bb4cbc7a356d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888854 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#712327}
-
Jiewei Qian authored
AppId is required at AppBrowserController constructor, to allow calculation of constant attributes. - Improves performance by eliminating redundant string comparisons in HasTabStrip method - Be explicit about HasTabStrip conditions, fixes a bug where tab strip shows up for ManifestWebAppBrowserController - Clarify the intention of checking AppId existance is to determine whether a browser shows an installed App. Fixes: 1013008 Change-Id: If275701e2c0068368635c86f8f1c6bcbfd266718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886138Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#712326}
-
Jan Wilken Dörrie authored
This change unifies the various base::make_span(container) utility functions and simply perfectly forwards the argument to the span constructor. Two overloads remain, one that deduces the span's extent automatically and one that let's the caller specify the extent. In order to do so this change introduces an internal::Extent struct, which is inspired by std::extent to deduce the right extent from the passed in argument. This helper is also used to simplify the internal EnableIfSpanCompatibleArray helper. Lastly it adds more tests to make sure make_span deduces the right type and extent. Bug: 828324 Change-Id: Ib55fc25ab2ad4227daf05d427e0aadf77c671817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878367 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#712325}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/79d9e4b8508d..94d6f48ba1b7 git log 79d9e4b8508d..94d6f48ba1b7 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 ehmaldonado@google.com gsutil: Decode output from subprocess. Created with: gclient setdep -r src/third_party/depot_tools@94d6f48ba1b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1007872,chromium:1009819 Change-Id: I8f68653864c496fed49f09f374bb37ca5193e755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898294Reviewed-by:
-
Peter Kasting authored
The old code assumes children might need layout even when not invalid. This was originally added to fix http://crbug.com/8511 . This seems like a bogus fix; if the metrics of something in the nonclient area change in such a way that we actually notice and make it to NonClientView::Layout(), we should have had an opportunity to invalid child layouts as needed. I suspect this doesn't actually happen anymore (some of the rest of that bugfix is already gone), but if it does we should fix in a different way. This also reorders definitions to match declaration order, removes a bunch of section-break comments that are atypical style nowadays, and adds some TODOs for further refactoring. Bug: none Change-Id: Ib386921c85c43ee05473acf1ac1b660a68d28809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823642 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Moe Ahmadi authored
Otherwise signing in could make the user experience worse, if there aren't enough remote suggestions, e.g., a user with local history but a fresh Google account or server's failure to return remote suggestions. Bug: 996516,1021244 Change-Id: I9cbfebadc5a7e7e1d6e204890d668cc8b9f59984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898299Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#712322}
-
Bettina authored
Remove the sparkles in the password check icon and added padding. Light: https://screenshot.googleplex.com/TsGx2ZL9jKd Dark: https://screenshot.googleplex.com/2Y9uM7muff3 Bug: 1017297 Change-Id: I4bafef0a1db1e25d338a3749309a96eeb08e8782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894311Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#712321}
-
Rakesh Soma authored
Bug: 1020797 Change-Id: Ic396db0a772629cca5913db06383f5160ec264bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878043 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#712320}
-
nancy authored
kAppServiceAsh is the flag to integrate AppService in UI app_list. Since it has been enabled for a few months for M78, M79 release, it should not be disabled, so the flag kAppServiceAsh can be removed. BUG=1016159 Change-Id: Ib8bebd845e0dcd1a60f8cd3623d975cfcd40ca0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892979Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712319}
-
Sam Goto authored
This CL refactors our existing code base to enable a **desktop** instance to request an SMS from a **mobile** instance via the chrome SharingService. We introduce a level of indirection, called SmsFetcher, which orchestrates between the local provisioning of SMSes (via the existing SmsProvider interface) and the remote provisioning of SMSes (via a newly introduced API FetchRemoteSMS exposed on ContentBrowserClient). chrome/ implements FetchRemoteSMS via SmsRemoteFetcher, which integrates with the chrome-specific go/unido infrastructure to fetch SMSes from remote devices. The SmsService uses the SmsFetcher (which fetches both local and remote SMSes) as opposed to the SmsProvider (which only fetches local SMSes). From an ownership perspective, the SmsFetcher is owned by the BrowserContext via the SupportsUserData infrastructure. The desktop UI and the go/unido integration is left deliberately unimplemented to keep this CL self-contained. Architectural diagrams, alternatives explored and further considerations are expanded in the design doc attached. Design-Doc: https://docs.google.com/document/d/1da8CjO71DlFbBzDcSosFRXTvDsKII_XMCohpZLQ_QbM/edit# Bug: 1015645 Change-Id: I2f563d27ed1c29d2de8a6bd2eef10865ec41e57f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868049 Commit-Queue: Sam Goto <goto@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#712318}
-
Ankit Kumar 🌪️ authored
Annotation bounds sent from the plugin are relative to user screen coordinates. Currently, the bounds are added with page_bounds which is incorrect. This CL fixes the same. The addition of page_bounds are only required if the bounds are relative to the origin of the page. Bug: 981448 Change-Id: I02e23aaf6c706248fa12a562b112633297421d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894665Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#712317} -
Daniel Cheng authored
For some reason, outputting to stdout is quite slow on Mac. This likely warrants a separate followup, but reducing the size of stdout to be more information-dense seems generally valuable as well. stdout goes from ~21MB to ~430KB, which saves ~7 minutes in on the Mac bots, and ~1 minute on the Windows bots. The output that's lost is generally of low value. One big loss is that stdout from invocations of content_shell are no longer included in the stdout of run_web_tests.py. This means that it's harder to get debug info from LOG(ERROR) for passing tests... hopefully this isn't a common use case. Bug: 1014845 Change-Id: Ib7129ac9207c1641c1264a92b2e93a1be5c9b025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894105Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#712316}
-
Sorin Jianu authored
Send both the updater and Chrome app ids in the "update apps" use case. With this change, --install and --ua commands work as expected, meaning the app ids and the versions are sent during update checks. There is a edge case, not handled currently, where the app id for the updater is not available until the first update check has happened. This is going to be resolved in a future CL which lands as part of fixing this CR bug. R=waffles Bug: 1020285 Change-Id: I2856a795ed61f590f85d792e4d5e1493bd23b84f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894833Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712315}
-
Aaron Leventhal authored
Bug: 1017535 Change-Id: I398c6870ac0f82452baee8aed9d0f273f1e7af1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894292 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#712314}
-
Hazem Ashmawy authored
Add menu option in WebView shell browser to launch developer UI from the current WebView package. Add intent-filter to WebView developer UI MainActivity with a new action "com.android.webview.SHOW_DEV_UI". Fixed: 1014827 Test: Manually inspect and launch dev ui from shell browser menu Test: Build and install SystemWebView and Monochrome switch providers and verify the right UI is launched Test: Build and install tip-of-the-tree SystemWebView and verify that a failure toast is shown Change-Id: Ia00ae05118e2974ac1e6ddd3b95c70717da862a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893864 Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#712313}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2b9317ad76b3..ca585bb45729 git log 2b9317ad76b3..ca585bb45729 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 ivoc@webrtc.org Make some DecisionLogic functions virtual. 2019-11-04 mbonadei@webrtc.org Use template instantiation declaration/definition for RTCStatsMember<T>. 2019-11-04 sprang@webrtc.org Revert "Refactors BitrateProber with unit types and absolute probe time." 2019-11-04 henrika@webrtc.org Adds WebRTC-Audio-AgcMinMicLevelExperiment to AGC1 Created with: gclient setdep -r src/third_party/webrtc@ca585bb45729 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:1018579 Change-Id: Iefde8162a32001cc3e68182af4e30fff0039ffc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898127Reviewed-by:
-
Dzmitry Neviadomski authored
Android system tries to scan test data for media files. These files may appear in file pickers and Image Gallery apps. R=jbudorick@chromium.org Bug: 796640 Change-Id: I1f84f724d33e168f27794cbcf2546afb4fd8e61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897658 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#712311}
-
Peter Kasting authored
This also does some other misc. cleanup. Bug: none Change-Id: Id7ca9b8618da7ca66b6448b77554a24300a339b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894458 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/99086cbb..1776a0ea Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If40afb56035307cd162ed4886301567945f029e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898170Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712309}
-
Avery Musbach authored
There is a part of OverviewItem::OnWindowDestroying that looks exactly like UnpauseOcclusionTracker from the anonymous namespace in overview_window_drag_controller.cc. It comes right after calling OverviewWindowDragController::ResetGesture, which calls UnpauseOcclusionTracker anyway. Bug: None Change-Id: If8070af54b97faf1cb710e7dd06f2395528e13ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898200 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#712308}
-
Thomas Guilbert authored
Clusterfuzz has highlighted an issue which can cause us to return a negative number of frames written, when we underflow. This CL fix the underflow issue by not fulfilling requests if we don't have enough data in |audio_buffer_|, regardless of the amount of data in |resampler_->BufferedFrames()|. This results in some small amount of data being lost. When we reach the end of stream, we play out all remaining data, along with enough silence to fulfill the request. Bug: 1019766 Change-Id: I728caa4afe45fac3f0944ef50bec5c00f9344d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895899 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#712307}
-
Charlene Yan authored
Updates the color picker to have a larger colored circle (less white space) when hovered or selected. Adding top margin to the color picker view so there is more space between them. Bug: 1015634 Change-Id: Ie7cd7b5ec5b32d23e438dc40f563b54f46431f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891790Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#712306}
-
Eric Stevenson authored
Existing code had a typo breaking the default value, but it was never used anyway. Change-Id: Id6e763f735ee06d5493871608a68eaeb4bf0de1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898104 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#712305}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/23c213f71633..ebd3e84c13c3 Created with: gclient setdep -r src-internal@ebd3e84c13c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If8cb6131794ac58e054765fd091bf7a9aa7ef779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898293Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712304}
-
Yi Gu authored
The TODO is no longer valid. Linked bug crbug.com/812652 is closed as wont fix. TBR=smcgruer@chromium.org Bug: None Change-Id: I77b36e713b0d63bb4b73b489f21d5fca3b9d3315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898396Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712303}
-
Sharon Yang authored
Since base::ServiceDirectoryClient is being deprecated, remove the last of the references to this class and replace with sys::ServiceDirectory. Some references to the class are still in startup_context.h/cc because there are external dependencies. Testing: CQ. Bug: 974072 Change-Id: I55f6166792c86459fac7ad46d5cf733060394af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894154 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#712302}
-
Lily Chen authored
Bug: 966576 Change-Id: I31c4130896925fafaf176a3fafe9d4a6604ff08d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894155Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#712301}
-
Antonio Gomes authored
This is the last step to move content/renderer/media/webrtc to Blink. The remaining work happens torwards blink-fy the code now. BUG=787254 R=guidou@chromium.org Change-Id: I6529925d68e5bf0c5177fd64ef8591255e0ffca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890790 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#712300}
-
Dana Fried authored
This is a prerequisite to fix the issue with restored tabs not always creating a renderer in response to incrementing video capture count. Bug: 1020782 Change-Id: Iba656d0fb3810073ea92212b28a309f16dbf922f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896305Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#712299}
-
Matthew Mourgos authored
This ensures that hotseat background blur is disabled when the blur features is disabled. Bug: 1017526 Change-Id: I291a55a3a7b47492b3c12f6f67239224a322ec5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888404Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#712298}
-
Khushal authored
Currently MSAA is controlled using a global switch for all layers which is enabled based on whether currently painted content on any layer has slow paths. Switching this state tears down all tile resources, both on pending and active tree. As such this switching can be quite expensive since we need to re-raster the entire visible viewport and causes jank, because the active tree can not be redrawn until its tiles are ready. For a long scrolling page where only some content of a layer has slow paths, this switching can occur each time this content scrolls in and out of the interest rect. Avoid the above by allow MSAA to be applied on a per layer basis. Since the decision changes only when the painted content of a layer is updated, which should already be invalidated in that case, this avoids any unnecessary raster invalidation. R=ericrk@chromium.org Bug: 1013758 Change-Id: I00678d21abb09b00c1246246076ee1a4e50d1822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891746 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#712297}
-
Matt Jones authored
This patch allows dialogs to show above the bottom sheet if the content is using a custom scrim lifecycle. This implies that the user is allowed to interact with the web page while the sheet is open. Bug: b/143869922 Change-Id: Ie2836b6f6f650df6f6061c0f67b49eede3de57e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897858 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#712296}
-
Simeon Anfinrud authored
Initialize() and Finalize() are no longer needed. We can use the constructor and destructor instead. Bug: Internal b/138210964 Test: cast_base_unittests Test: internal cast tests Change-Id: Iadaf1999e129167fd94f3d504aac914ab3838f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896760 Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712295}
-
Antonio Gomes authored
This CL is a preparation step to being able to move this file to Blink, and then removing the whole directory. Basically: - it removes WebRtcAudioRendererTest inheritance to AudioDeviceFactory, since it is used solely to override AudioDeviceFactory::CreateAudioRendererSink(). Instead of the explicit override, which is called by explicitly by AudioDeviceFactoryTestingPlatformSupport::NewAudioRendererSink(), the CL just creates the needed media::AudioRendererSink instance directly in AudioDeviceFactoryTestingPlatformSupport::NewAudioRendererSink() and return it. - the rest of the CL adapts expectation checks related to WebRtcAudioRendererTest::MockCreateAudioRendererSink() with using AudioDeviceFactoryTestingPlatformSupport::MockNewAudioRendererSink() and some gtest tricks (eg testing::SaveArgs<>, and testing::InvokeWithoutArgs). This way all original checks are kept! R=guidou@chromium.org Change-Id: If517cb2ea413359bcd80ca3e25e3d91b1e3a12ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888555 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#712294}
-
