GitLab

Similar to https://codereview.chromium.org/385743002 , but in a file
that's also built in host targets. Depends on r#294584.

If your bot can't deal with this, please let me know!

BUG=none

Review URL: https://codereview.chromium.org/443483002

Cr-Commit-Position: refs/heads/master@{#294687}

This will make it set up a proxy message pipe, and is a stopgap measure
until we have proper message pipe passing (across multiple
channels/processes).

I don't know what bugs there might be, though I added a basic test
(across a single remote message pipe and back). I should add yet more
tests.

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/566783002

Cr-Commit-Position: refs/heads/master@{#294686}

BUG=278540
NOPRESUBMIT=true
R=isherman@chromium.org, rockot@chromium.org

Review URL: https://codereview.chromium.org/550913003

Cr-Commit-Position: refs/heads/master@{#294685}

Matches what we have in AudioRendererImpl, which is our only other
TimeSource implementation.

TBR=xhwang

Review URL: https://codereview.chromium.org/551273004

Cr-Commit-Position: refs/heads/master@{#294684}

The perf dashboard expects that for values of the form x.y that are per-page,
the computed summary x.y (i.e., the value having that name but not associated
with any particular Page object) will be displayed but the per-page x.y's will
be ignored.

Previously, the per-page x.y's were being named as x: <pagename> in the
buildbot convention; it was the job of the log processing step to make sure
that these extraneous, ambiguously-named values were ignored. The Chart JSON
output formatter, on the other hand, explicitly guards against adding values
with duplicate names, and so extra checks are necessary to throw away such
extraneous values.

This patch adds handling to the Chart JSON output formatter to address this
issue, and updates the tests to check for correctness in this scenario.

R=sullivan,qyearsley,tonyg

Review URL: https://codereview.chromium.org/551063005

Cr-Commit-Position: refs/heads/master@{#294683}

1. add uma metrics related to the new android signin promo
2. add a method to SigninManager to get the finch experiment for promo

Downstream changes at https://chrome-internal-review.googlesource.com/#/c/175857/

BUG=406614
TBR=rogerta@chromium.org

Review URL: https://codereview.chromium.org/568603002

Cr-Commit-Position: refs/heads/master@{#294682}

Also fix some controlled settings indicators.

BUG=409938
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/539383003

Cr-Commit-Position: refs/heads/master@{#294681}

This was added to fix the component build on Linux, but Android doesn't have this library.

R=jamesr@chromium.org
TBR=jamesr

Review URL: https://codereview.chromium.org/567073002

Cr-Commit-Position: refs/heads/master@{#294680}

1- use the correct directory for git commands
2- yasm needs . in the include search path, otherwise I get:
FAILED: python ../../../third_party/yasm/run_yasm.py ./yasm -DPIC -felf64 -m amd64 -I../../.. -Igen -DARCH_X86_64 -w -P ../../../third_party/ffmpeg/chromium/config/Chromium/linux/x64/config.asm -I../../../third_party/ffmpeg/chromium/config/Chromium/linux/x64 -I../../../third_party/ffmpeg/libavcodec/x86 -I../../../third_party/ffmpeg/libavutil/x86 -I../../../third_party/ffmpeg -DPIC -o obj/third_party/ffmpeg/vp8dsp.o ../../../third_party/ffmpeg/libavcodec/x86/vp8dsp.asm
yasm: FATAL: unable to open include file `../../../third_party/ffmpeg/chromium/config/Chromium/linux/x64/config.asm'

BUG=None

Review URL: https://codereview.chromium.org/561193004

Cr-Commit-Position: refs/heads/master@{#294679}

* Switched KernelProxy to use utimens/futimens.
* kernel_intercept.* forwards utime/utimes/futimes -> {,f}utimens.
* Add Node::Futimens
* Override FuseFsNode::Futimens
* Add newlib headers to define utime/utimes/futimes
* Glibc uses at_stim as timespec instead, add define for st_atimensec for
  compatibility with newlib.

BUG=413412
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/565343002

Cr-Commit-Position: refs/heads/master@{#294678}

BUG=none

Review URL: https://codereview.chromium.org/569643003

Cr-Commit-Position: refs/heads/master@{#294677}

For OMA downloads, chrome doesn't handle it correctly as the file needs to be converted to a .fl file and encrypted on the device.
The android DownloadManager provides such covertion.
As a result, we need to provide a way for us to intercept certain OMA downloads

BUG=382698

Review URL: https://codereview.chromium.org/571613002

Cr-Commit-Position: refs/heads/master@{#294676}

Switching for two reasons:

1. Semantics are simpler because, in each of these cases, there was never a
   subsequent iteration - just a check to see if the iterator key matched
   the desired key.
2. The Transaction::Get() call uses the LevelDB filter which (when enabled)
   can significantly reduce disk reads, thus improving performance.

This change, along with enabling the bloom filter, resolves a performance
issue introduced by r273048.

BUG=409520

Review URL: https://codereview.chromium.org/565023002

Cr-Commit-Position: refs/heads/master@{#294675}

We were accessing a NULL RWHV on BrowserPluginGuest::SetFocus. This CL
adds a guard to ensure we only attempt to set focus if we have a View.

BUG=413874

Review URL: https://codereview.chromium.org/564153003

Cr-Commit-Position: refs/heads/master@{#294674}

Enabling a LevelDB feature to improve performance.

BUG=409520

Review URL: https://codereview.chromium.org/562333005

Cr-Commit-Position: refs/heads/master@{#294673}

BUG=410651

Review URL: https://codereview.chromium.org/566893002

Cr-Commit-Position: refs/heads/master@{#294672}

Update proguard.cfg to reflect that @UsedByReflection was moved to base/.
Add --release option to cr_cronet.py tool.

Notes:
- Chromium debug build does not apply proguard at all.
- Chromium instrumentation test does not allow custom proguard config (but it uses proguard config from instrumented app, which is nice).

BUG=390267

Review URL: https://codereview.chromium.org/512953002

Cr-Commit-Position: refs/heads/master@{#294671}

No trybots because it is a documentation-only change.

BUG=137810
R=sbc@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/568153004

Cr-Commit-Position: refs/heads/master@{#294670}

When the DemuxerStream has a pending read, this one
must be completed before invoking the flush callback.

BUG=408189

Review URL: https://codereview.chromium.org/565973003

Cr-Commit-Position: refs/heads/master@{#294669}

Most significant among the changes is improved HTTPS handling.

BUG=412826
TBR=slamm@chromium.org

Review URL: https://codereview.chromium.org/558263002

Cr-Commit-Position: refs/heads/master@{#294668}

PushDataDeps takes a long time even when all files are on the device
because calculating the digests of all the files takes _much_ longer
on a device than it does on a host.

Skipping the push step during test listing -- where the data deps are
unnecessary -- means that we don't try to push files twice in each
gtest run, so we skip all of the device-side MD5 calculations that
would happen in the second run.

BUG=400440

Review URL: https://codereview.chromium.org/560133002

Cr-Commit-Position: refs/heads/master@{#294667}

Remove flags and change trunk channel restrictions to dev in preparation
for launch.

BUG=386830

Review URL: https://codereview.chromium.org/564993002

Cr-Commit-Position: refs/heads/master@{#294666}

BUG=409888
TEST=WindowManagerTest.* SplitViewController.*

Review URL: https://codereview.chromium.org/550043002

Cr-Commit-Position: refs/heads/master@{#294665}

We don't do anything with this rect so remove it.

R=nduca@chromium.org, vmpstr
BUG=413479

Review URL: https://codereview.chromium.org/563963002

Cr-Commit-Position: refs/heads/master@{#294664}

Previously this is only whitelisted on Linux/ChromeOS. This CL relax this to
all platforms.

BUG=413812
TEST=Tested on Windows.

Review URL: https://codereview.chromium.org/567913002

Cr-Commit-Position: refs/heads/master@{#294663}

BUG=409492
R=oshima@chromium.org
TEST=ash_unittests, manually

Review URL: https://codereview.chromium.org/562413002

Cr-Commit-Position: refs/heads/master@{#294662}

Review URL: https://codereview.chromium.org/549433006

Cr-Commit-Position: refs/heads/master@{#294661}

to prevent memory from being freed.

R=mef@chromium.org
BUG=413400

Review URL: https://codereview.chromium.org/566763002

Cr-Commit-Position: refs/heads/master@{#294660}

Skips it during accessibility treatment.

BUG=326793

Review URL: https://codereview.chromium.org/569613003

Cr-Commit-Position: refs/heads/master@{#294659}

This is causing a compile failure in component mode.

TBR=dpranke

Review URL: https://codereview.chromium.org/566023003

Cr-Commit-Position: refs/heads/master@{#294658}

Use are brand-spanking-new options dictionary to be able to configure
the target and max burst size for the pacer. This should allow us to do
some basic experiments to determine if pacing is really helpful and what
the optimal batch size actually is.

Review URL: https://codereview.chromium.org/567853002

Cr-Commit-Position: refs/heads/master@{#294657}

BUG=397741

Review URL: https://codereview.chromium.org/565213005

Cr-Commit-Position: refs/heads/master@{#294656}

After a bunch of testing, it seems like there is a direct linear
relationship between RTT and the optimal playout delay. Packet loss
is also a factor, but since we expect packet loss to be low in
normal networks, perhaps we can make the formula as easy as RTT * 4.

This is disabled by default, the extension needs to set min_latency_ms
in order to activate it.

BUG=405339

Review URL: https://codereview.chromium.org/562653004

Cr-Commit-Position: refs/heads/master@{#294655}

BUG=409897
R=rsesek, DaleCurtis

Review URL: https://codereview.chromium.org/531863002

Cr-Commit-Position: refs/heads/master@{#294654}

Previously TransportFactory interface was responsible for creation
and initialization of several protocol layers, including PseudoTCP and
authentication (TLS). Simplified it so now it only creates raw datagram
transport channel. PseudoTcpChannelFactory is now responsible for
setting up PseudoTcpAdapter and AuthenticatingChannelFactory takes care
of channel authentication. Also added DatagramChannelFactory for
Datagram channels.

This change will make it possible to replace PseudoTcpChannelFactory
with an object that creates SCTP-based channels.

Also fixed a bug in SslHmacChannelAuthenticator. It wasn't working
properly when deleted from the callback. (base::Callback objects
shouldn't be deleted while being called because when deleted they
also destroy reference parameters values they are holding).

BUG=402993

Review URL: https://codereview.chromium.org/551173004

Cr-Commit-Position: refs/heads/master@{#294653}

BUG=399643

Review URL: https://codereview.chromium.org/565963002

Cr-Commit-Position: refs/heads/master@{#294652}

BUG=413637

Review URL: https://codereview.chromium.org/564173002

Cr-Commit-Position: refs/heads/master@{#294651}

See also https://trac.xiph.org/ticket/2048

BUG=355440

Review URL: https://codereview.chromium.org/570443002

Cr-Commit-Position: refs/heads/master@{#294650}

Chrome was modified back in May 2014 to use SCM_CREDENTIALS instead of
--find-inode-switch and we haven't any heard any negative feedback, so
it's time to remove --find-inode-switch entirely.

BUG=357670

Review URL: https://codereview.chromium.org/569533002

Cr-Commit-Position: refs/heads/master@{#294649}

After changes that made Embed() always create a new connection this
test is now redundant with EmbedWithSameViewId*. Additionally it
wasn't properly waiting, leading to use after frees.

BUG=none
TEST=covered by tests
R=aa@chromium.org

Review URL: https://codereview.chromium.org/566463003

Cr-Commit-Position: refs/heads/master@{#294648}