- 29 May, 2020 40 commits
-
-
Nick Diego Yamane authored
DataDevice-related wrappers initialization and ownership, for both standard and GTK's primary selection, are quite confusing and spread over different parts of the backend code. This CL fixes and simplifies it by: - Moving {WaylandData,GtkPrimarySelection}Device ownership to their respective DataManager wrapper class. E.g: WaylandDataDeviceManager owns WaylandDataDevice singleton; - Fix WaylandClipboard initialization whether the compositor happens to advertise GtkPrimarySelectionDeviceManager after wl_seat and wl_data_device_manager; - Use dependency injection to provide DataSources with the correct DataDevice instance at their construction time; - Clean up WaylandConnection by getting rid of the multiple (and almost unused) data device getters from it as well as removing unneeded header includes. Bug: 896640 Change-Id: Ie12964fdf4e7b78bbbd9a11e133ab082613f1c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216320Reviewed-by:Maksim Sisov <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#773235}
-
Anubha Mathur authored
Original change that introduced change to NetworkRequest object: https://chromium-review.googlesource.com/c/chromium/src/+/2142145 DevTools browser_protocol.pdl is getting updated, but is failing this test, so need to disable test temporarily till it gets checked in: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2220495 Bug: 1066579 Change-Id: Ie2a39211993646f67487de2646f6befd0e8af987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220809Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Anubha Mathur <anubmat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#773234}
-
Jeremy Roman authored
Since the AppBannerManager may miss loading (its usual trigger) if loaded in a portal context, also observe portal activation into a tab and trigger the same logic at that point. Android instrumentation test included. Fixed: 1087163 Change-Id: I9e8a888f6f5ce2d3d13d825f62d64d0d164bfc55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219041Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#773233}
-
Robert Flack authored
Requesting pushing whether we have a requestAnimationFrame call or animations to the compositor through AnimationHost requires a commit. This leads to a lot of expensive messages even when nothing is changed on the page. Since this is only used for metrics we should find a more efficient way to track these changes. Bug: 1083244 Change-Id: I093d036dafd0abf9e25b7e1592214a4c672866fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216859Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#773232}
-
Jonathan Mengedoht authored
Bug: 1083113 Change-Id: I8d63bd232a08b2984f13d506f9d4fa0b13b7316a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207179Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#773231}
-
Toni Barzic authored
The plan is for ShelfLayoutManager, which is already observing locale updates, to trickle down the locale update notification down to the shelf components, so they can update themselves before shelf re-layout. I intend to add HandleLocaleChange ShelfComponent once other components are updated, to make sure the possibility of locale change is considered if a new shelf component is added in future. BUG=1076321 Change-Id: I832d14d506ad3f47bd3cf647b70b7bec05e8dc0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2221416 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#773230}
-
Nina Satragno authored
Disable virtual/threaded/synthetic_gestures/synthetic-pinch-zoom-gesture-touchscreen-zoom-in-slow.html Flaky, likely only on linux. TBR=mcnee@chromium.org Bug: 1087471 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Id5c1436d24f28973c96ed14f5927fc85d8429a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220842Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#773229}
-
zhaoyangli authored
Some downstream builders are running the EG1 suite. Creating EG2 suite to use it in the builders. chrome_ios_eg2_test.gni is changed to create the "_deps_group" targets from existing target, so that the flaky suite can include the deps of other test suites as it's deps. Bug: 1052567 Change-Id: I5d51a4914f420990707351c119bbe7f20579f30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220892 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#773228}
-
Andrew Walbran authored
The iDroid:con gamepad has multiple modes. This CL adds mappings for the two modes where it reports as a gamepad. Also use axes_used rather than axes_length for distinguishing modes on Linux. BUG=1073130 Change-Id: I2741de8097155f36eb7b6f60f69fc766b1462707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204184 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#773227}
-
Christopher Cameron authored
Add async swap methods. At present, these just post the passed-in callbacks, but may be made to be more async in the future. Add an origin value that does not cause SkiaRenderer to DCHECK (and is also accurate). Bug: 894929 Change-Id: I97b484da4de6ed98b5b568135fb2c07bed46a690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219561Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#773226}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/461e38761d05..2e69660b3e62 2020-05-29 marinaciocea@webrtc.org [InsertableStreams] Send transformed frames on worker queue. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1086373 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib6e4281ba887b72290fa5f45bb45558cf0226979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222494Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773225}
-
Sébastien Séguin-Gagnon authored
URLBlacklist URLWhitelist EditBookmarks ManagedBookmarks Bug: 1087874 Change-Id: I9015a69a656ec020ae1268fd83b6333fb98f025e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219277 Auto-Submit: sebsg <sebsg@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#773224}
-
Stephen Chenney authored
The previous fix for backgrounds repeating when they shouldn't was too restrictive and still allowed backgrounds to repeat at some zoom levels. Switch from "<" to "<=" to snap the remaining cases. Bug: 1085801 Change-Id: Iedf79fa9980ade753b4ca108d7462b282652eeeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222540 Commit-Queue: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#773223}
-
Dave Tapuska authored
This helper is responsible for propagating pref changes, and its behavior is pretty nicely isolated to the WebContents it is attached to, and so behaves fine across activation etc. Fixed: 1086253 Change-Id: I9871b403d3d92577657f76b1d10c79e8003a5367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2221422Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5666031c614c..1aa58ae23fd7 2020-05-29 primiano@google.com Protozero: remove message finalization listener If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9caecf989c6885b59014cf0fced7568b49744cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2221421Reviewed-by:
-
Aaron Colwell authored
This is a follow-up to http://crrev.com/c/2216913. We are still seeing invalid handles after that change so this CL adds some more debugging info the help figure out what call stacks are creating these invalid handles. I've also added a scoped crash key to capture some RenderFrameHostImpl state since that seems like the most likely caller to be triggering this problem. Bug: 977169, 1086306 Change-Id: I023c159f4e1d2cd9a3fb018a7867dbdb42c2b0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220893 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#773220}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/074414fed53e..df546db4d8f7 2020-05-29 robertphillips@google.com Make GrGLProgram inform GrGLGpu when it changes the bound program 2020-05-29 michaelludwig@google.com Reland "GrClips provided as pointers to GrRTC" 2020-05-29 bsalomon@google.com Remove SkSurface::MakeFromBackendTextureAsRenderTarget from public API 2020-05-29 bungeman@google.com Remove last unistr.h include. 2020-05-29 nifong@google.com Performance test of color conversion 2020-05-29 brianosman@google.com Fix dimensions of color_cube_rt slide 2020-05-29 mtklein@google.com remove old kDCIP3 alias If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1056730 Tbr: westont@google.com Change-Id: I4de6a48c193ea0d9ddaadceee6a9def9395f71e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222490Reviewed-by:
-
Aaron Krajeski authored
Bug: 1003114 Change-Id: Icf3be92cf83a8c7bb4ef2d83879208bdd19a5881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212421 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#773218}
-
Aaron Krajeski authored
Change-Id: I344505d0dee7370ebef2d4de885c53befe9540b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216273Reviewed-by:
-
Chris Fredrickson authored
This reverts commit 15936d15. Reason for revert: Performance regression (https://crbug.com/1087234). Will reland with a fix. Original change's description: > Include image data when reporting UKM from canvas readbacks. > > This cl computes digests of the underlying bytes of canvas images when > HTMLCanvasElement.toBlob, HTMLCanvasElement.ToDataURL, or > HTMLCanvasElement.convertToBlob are called. > > OffscreenCanvas.convertToBlob is not recorded yet, since we do not yet have a > UKM source or Recorder in that context. > > CanvasRenderingContext2D.getImageData and WebGLRenderingContext.readPixels are also not recorded yet. > > Bug: 973801 > Change-Id: Ic2de567b16c98b613c945afa823a078a4740a7a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207979 > Commit-Queue: Chris Fredrickson <cfredric@google.com> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772448} TBR=fserb@chromium.org,asanka@chromium.org,cfredric@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 973801 Change-Id: Id6e0b4349b997b4b8baa17a5925fa9fb0ab721a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218818Reviewed-by:
-
David Van Cleve authored
https://crrev.com/c/2217855 added browser tests confirming that Trust Tokens operations can only be executed in secure contexts; these tests had two bugs. 1. To check if the XHR interface exposed the `setTrustToken` method, the initial CL used `(new XMLHttpRequest).hasOwnProperty('setTrustToken')`, but this always returns false [*]; the fix is to use `in` instead. 2. The iframe test case neglected to provide keys necessary for executing an issuance operation, with the result that the operation would have failed in a secure context, too. This CL changes the iframe test to inspect the associated request for the presence of Trust Tokens parameters. This makes the test slightly more robust because it allows distinguishing between requests that failed because of the secure context check (this results in not executing a Trust Tokens operation, but still sending the request) and requests that passed this check (these requests will receive TrustTokenParams structs en route to the network service). R=csharrison [*] https://developers.google.com/web/updates/2015/04/DOM-attributes-now-on-the-prototype-chain#using_hasownproperty_on_a_dom_object_instance_will_now_return_false Bug: 1087200 Test: Verified all three EXPECTs fail in a secure context. Change-Id: If663e9190321bf5e245f0b042f4442d4de69f10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2221415 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#773215}
-
Patrick Noland authored
This extracts the app menu logic from ToolbarManager into a new, dedicated class and adds unit tests for this logic. MenuButton view logic in ToolbarPhone/MenuButton remains unchanged. Bug: 865801 Change-Id: Iaaef8874da7221dbccdc1f0f55856d37ed929b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181665 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#773214}
-
Annie Sullivan authored
This reverts commit ab09ac50. Reason for revert: Failing on CrOS: https://chromium-swarm.appspot.com/task?id=4c79fabe1fcc8e10 Original change's description: > Second reland of AddLayoutInstabilityTest.OOPIFSubframeWeighting. > > Currently failing on Win7 only, but not possible to debug on CQ (or > locally due to no office access). Disabled on Windows as a result. > > Bug: 943668 > Change-Id: I1800b8afcb9a08353edd74921e94d0a4358ea35d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220487 > Reviewed-by: Steve Kobes <skobes@chromium.org> > Commit-Queue: Annie Sullivan <sullivan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773152} TBR=sullivan@chromium.org,skobes@chromium.org Change-Id: I056718693a3674d351701d043d57544031668787 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 943668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2221426Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#773213}
-
Stephen McGruer authored
This rolls testharness.js, idlharness.js, and testdriver-actions.js from the external copy in external/wpt/resources/ to the internal copy in resources/, bringing us up to WPT SHA 2d15a10a Bug: None Change-Id: I95d4ed0d10ffd5833162e3051c4613428c575757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222443 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#773212}
-
Yunke Zhou authored
Bug: 1019492 Change-Id: I3260aa05f7ac3b426a07a15b290fa46b818c55e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218773 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#773211}
-
Jeffrey Kardatzke authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/f7fcc27f256f..4f220d625fab $ git log f7fcc27f2..4f220d625 --date=short --no-merges --format='%ad %ae %s' 2020-05-21 akhouderchah system_api: hermes: Update string for new kInstallPendingProfile method 2020-05-21 akhouderchah hermes: Expose ProfileClass enum to dbus 2020-04-27 jkardatzke system_api: Add constants for CdmFactoryDaemon 2020-05-21 clarkchung system_api: add information field in probe results Created with: roll-dep src/third_party/cros_system_api Bug: None Change-Id: I018eda8cf097a8f2f549891bb5ba92dd1176e30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220277 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#773210}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d85a68f5582f..252729d2fd72 2020-05-29 chrome-bot@chromium.org Update config settings by config-updater. 2020-05-29 morg@google.com Add more targets for android branch parsing 2020-05-29 navil@google.com chromeos_config: Manually trigger release-basic builds. 2020-05-29 navil@google.com chromeos_config: set debug to true for the release-basic builder. 2020-05-29 chrome-bot@chromium.org Update config settings by config-updater. 2020-05-28 ahassani@chromium.org auto_updater.py: Delete update payload files after use 2020-05-28 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I8196d3336d765c64833e2f3c0cbe8edf681e8841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222489Reviewed-by:
-
Aaron Krajeski authored
If we add full clear operations to our own displaylist they get replayed for pdf printing. This causes a size regression. CanvasResourceProvider::Clear is only called when an new resource provider is created to ensure that it is cleared, partially so that we don't leak data. Having skia do this directly instead of our deferred system seems to have no bad side effects. Bug: 1003114 Change-Id: I1de143ee1de6c448a36a1399fd13e4d7858f6241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220255 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
-
David Black authored
Change is guarded behind a new feature flag. Bug: b:157689497 Change-Id: I51e27a4aaf401d86c469a481dc021b97d1892c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220664Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1c3d8533..f8091017 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6494526954b83f390b08b6e57ce1ed292fdcfeb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220588Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773206}
-
David Black authored
In v1, the timer notification message was the remaining time. Example: 10:00. In v2, the timer notification message is the total time and label. Example: 10m timer · Eggs. Note that the first example uses a NUMERIC format width while the latter uses a NARROW format width for the time string. Bug: b:156641714 Change-Id: Ie8102b5a687630f5bbcb5b5b2efa47bce1536a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220687 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Lukasz Anforowicz authored
This CL postpones expiration of the NetworkService.URLLoader.RequestInitiatorOriginLockCompatibility UMA. Enforcement of |request_initiator_site_lock| hasn't shipped yet (please see https://crbug.com/920634) and having the UMA helps estimate the impact of shipping the enforcement. Fixed: 1084042 Change-Id: Id6600da659141472534ffd4fce164e5893c2eaa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217749 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#773204}
-
Nina Satragno authored
Disable media/controls/video-overlay-cast-dark-rendering.html. It's flaky on all platforms. TBR=steimel@chromium.org Bug: 1084441 Change-Id: Ibe5fd59cff0aa260e04eff7fb04d7d7d297c5cf5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2221423Reviewed-by:
-
ckitagawa authored
Flaking due to a bug. I know the root cause, but will address in a separate CL. TBR=mahmoudi@chromium.org Bug: 1087768 Change-Id: If25f17e5c9e4a6c0e2fdfaa4d1d199f4f78434e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222543 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#773202}
-
Clark DuVall authored
Moving a few more of the easier classes to the component. Will move the unittests for PopupOpenerTabHelper once TabUnderNavigationThrottle has been moved to the component. Bug: 1084013 Change-Id: I9571c53d7aeeea03ed1dbc6d3720841d9c2473a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220710 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Stephane Zermatten authored
This change refactors the code and test to avoid accessing the fields of Selector and use helper functions instead. These changes allows refactoring selectors in a follow-up change without changing the tests. This change also: - renames ElementReferenceProto to SelectorProto, to match the C++ class name, Selector as well as the name of the proto on the backend side. - moves the code from web_controller.cc which extracted CSS selectors from Selector for use with Autofill to selector.h. It makes more sense to have that in selector.h as this code needs to change as selector definitions changes. This change also rejects selectors with unsupported features, when used with autofill. Bug: b/155264465 Change-Id: Ie82e974f87c66a19328f12a0b9bcb9141fb6590e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218207 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#773200}
-
Olesia Marukhno authored
Added two metrics: Permissions.Prompt.TimeToDecision to record how long does it take for the user to make a decision about a permission request (from the permission requested to user clicking on a button in the permission bubble view). Permissions.Chip.TimeToInteraction to record how long does it take for the user to interact (click) on the permission chip after the permission was requested. Bug: 1019129 Change-Id: Id1a8e1e9bb0f3dc51bd5e927509caf23cf59b05a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214392 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#773199}
-
Thomas Lukaszewicz authored
Currently all pending accelerators are registered and unregistered in postorder. This patch changes it so that pending accelerators are registered in preorder and deregistered in postorder. This is an issue as accelerators registered later take priority over accelerators registered earlier. This change gives child views the chance to take priority over parents when registering their accelerators rather than having an ancestor potentially override an accelerator added in the child. Bug: None Change-Id: I06fd3db9dccec3bae61c148b2f18753080246117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219166 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#773198}
-
Wez authored
This is a reland of 4b053da1 Original change's description: > [Fuchsia] Add WebGL MSAA to the allowed list for WebEngine > > Now webgl-antialiasing-mode and webgl-msaa-sample-count can be > specified in WebEngine config. This will allow to control MSAA support > when using WebGL. > > Bug: 766360 > Change-Id: If325bedefb31c1c960868563bcf223ba0bc88999 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220865 > Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: David Reveman <reveman@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773101} Bug: 766360 Change-Id: I763044e3419652f2a5682432ad6f04f5718c658d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218780 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#773197}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f1393e23a22c..461e38761d05 2020-05-29 philipp.hancke@googlemail.com use constants for CN and telephone-event codec names 2020-05-29 dminor@webrtc.org Check that data_ is non-null before memcpy in EnsureCapacityWithHeadroom If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I75b8389ec9875c6e21f5b342491a13c9132c0ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222487Reviewed-by:
-
