- 20 Mar, 2018 40 commits
-
-
Tarun Bansal authored
blink-dev i2s thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/8RBFue7RMXQ/discussion Bug: 735518,782381,816661 Change-Id: Ic7c8a6a0eaf323d3ab736ac8e3ad2d23104ae0cb Reviewed-on: https://chromium-review.googlesource.com/969407Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#544285}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cf4e4370. With Chromium commits locally applied on WPT: 23aafba1 "[url] Properly treat '#' as marking the start of the fragment in data URIs" 84f77307 "Revert "[url] Properly treat '#' as marking the start of the fragment in data URIs"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14221 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=kereliuk No-Export: true Change-Id: If0a39caa04a72a57381b6c4566e91544a6699803 Reviewed-on: https://chromium-review.googlesource.com/969970 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#544284}
-
David Tseng authored
Change-Id: I130db573fcc2ccbda3ce58c9d2bac845218ab1d9 Reviewed-on: https://chromium-review.googlesource.com/961549 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#544283}
-
Sheng-Hao Tsao authored
Jpeg Encode Accelerator (JEA) was implemented and ready to be used from ChromeOS side. This CL adds IPC between ChromeOS and Chromium so that camera HAL in ChromeOS can take advantage of JEA. BUG=819847 TEST=Together with https://chromium-review.googlesource.com/c/chromium/src/+/917932, verified that encoding a YUV image successfully with HW JEA on Chromium side. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I639cdf1c5947c33b0d0f9a5b1b00bd685bb596d8 Reviewed-on: https://chromium-review.googlesource.com/917932 Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#544282}
-
Roman Sorokin authored
RefreshDevicePolicy stores saved device policy in the session manager. E.g. it is unusable for tests to set specific device policies. BUG=chromium:819657 TEST=FakeAuthPolicyClientTest.RefreshDevicePolicyStoresPolicy Change-Id: Id90e090453da27ffa4527ed810bc1f45c5337a3a Reviewed-on: https://chromium-review.googlesource.com/955842Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544281}
-
Zhuoyu Qian authored
This CL introduce "ClipboardCommand.cpp" with moving |ClipboardCommands| member into it. Make EditorCommand simpler for improving code health. Bug: 818552 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Icede39fc714367fe57e886f0f9ef23e1989f7518 Reviewed-on: https://chromium-review.googlesource.com/948243Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544280}
-
https://chromium.googlesource.com/angle/angle.git/+log/daedf4d234eb..aa5d883e0215 $ git log daedf4d23..aa5d883e0 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 courtneygo Update KHR header to avoid compiler issue. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I2cbbe39d7371645a269ced52e15ff38c7a5ef61a Reviewed-on: https://chromium-review.googlesource.com/969948 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544279}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5978d7dd749e..65e67b8ab181 $ git log 5978d7dd7..65e67b8ab --date=short --no-merges --format='%ad %ae %s' 2017-10-09 bhthompson Add HW tests to KBL paladins Created with: roll-dep src/third_party/chromite BUG=chromium:772430 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3aef2ab6b741a4d8b60e18edfeb3a9f46b315339 Reviewed-on: https://chromium-review.googlesource.com/969822 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544278}
-
Oksana Zhuravlova authored
This change moves time.mojom from //mojo/common to //mojo/public/mojom/base. Corresponding typemap and struct traits file were also moved. Unit tests for Time, TimeDelta and TimeTicks were updated to use SerializeAndDeserialize() from //mojo/public/cpp/test_support/test_utils.h and moved to mojo_unittests. Bug: 799482,806965 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I080ca0628167a1be705f923a329b7e0986536b83 Reviewed-on: https://chromium-review.googlesource.com/962872 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#544277}
-
https://skia.googlesource.com/skia.git/+log/cb88470d82d6..ec77963bf32e $ git log cb88470d8..ec77963bf --date=short --no-merges --format='%ad %ae %s' 2018-03-19 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 3761dc7bf..daedf4d23 (3 commits) 2018-03-19 liyuqian Make consistent isRadiusIncreasing decision 2018-03-19 caryclark remove imageinfo flatten altogether 2018-03-19 bsalomon Revert "Revert "New read pixels implementation that is simpler but does all conversions on CPU."" 2018-03-19 bsalomon Remove deprecated versions of YUV texture SkImage factories 2018-03-19 ericrk Allow SkTraceMemoryDump to exclude wrapped objects 2018-03-19 hcm Fix go syntax for Debian compile 2018-03-19 bsalomon Remove SkSurface::MakeFromBackendTexture variant that doesn't take SkColorType 2018-03-19 ethannicholas fix switch fallthrough warning 2018-03-19 liyuqian Fix concentric 2pt conical gradient in GPU where r1 < r0 Created with: roll-dep src/third_party/skia BUG=chromium:795358 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I83f77a4beed619b2bc27becaafe1224131abb3d1 Reviewed-on: https://chromium-review.googlesource.com/969800Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544276}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I7334d112f3aa5619170be0ef8e6e20d268a364cf Reviewed-on: https://chromium-review.googlesource.com/969885Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#544275}
-
Joel Einbinder authored
As a drive-by, adds the light blue hover state to the console sidebar Change-Id: Ie4ac958c8feb6d8907e2574db53a5d89ada54eb2 Reviewed-on: https://chromium-review.googlesource.com/907793Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#544274}
-
Shinya Kawanaka authored
This reverts commit 52e03fa8. Reason for revert: Some mac builders are broken. e.g. https://ci.chromium.org/buildbot/chromium.fyi/Mac%20Builder%20%28dbg%29%20Goma%20Canary/3941 Original change's description: > AppShell: Suppress context menu in webviews > > AppShell doesn't support context menus, but still needs to provide a > WebViewGuestDelegate to handle the context menu. Otherwise, we reach a > NOTREACHED() in WebContentsViewChildFrame::ShowContextMenu(). > > Also removes a WebViewGuestDelegate function that is unused (see > https://codereview.chromium.org/2836973002). > > Bug: 820604 > Change-Id: I0760d397384908a490704f23388e11c4eef113a5 > Reviewed-on: https://chromium-review.googlesource.com/957596 > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544136} TBR=michaelpg@chromium.org,lfg@chromium.org Change-Id: Ib3691d13fb6a787b487c0e11a73e9c0bdaad5b8b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820604 Reviewed-on: https://chromium-review.googlesource.com/969723Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Commit-Queue: Shinya Kawanaka <shinyak@chromium.org> Cr-Commit-Position: refs/heads/master@{#544273}
-
John Chen authored
OOPIF frames do not have names on some versions of Chrome. Recognize such cases and do not raise errors. Bug: b:75302857 Change-Id: Ib5cce47de560d2a1d39c654e1e566572b0f8247e Reviewed-on: https://chromium-review.googlesource.com/969788 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#544272}
-
Sandra Sun authored
After user dragging the scrollbar thumb, we should snap to the closest snap position of the container. Bug: 819769 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9d383d61a4f171d02c339064392216e0f4eae2ca Reviewed-on: https://chromium-review.googlesource.com/953647 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#544271}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3d6608ce..d811a187 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ibb729c6452938284f24893ce3fe82e79b234c68b Reviewed-on: https://chromium-review.googlesource.com/969637Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#544270}
-
Saman Sami authored
CopyOutputRequests must be taken from CompositorFrameSinkSupport before SurfaceAggregator::copy_request_passes_ is populated. This broke at http://crrev.com/99f8d9a. Bug: 823393 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I2ee6130e66be5b0a0943df87cd22b40d4e9217c1 Reviewed-on: https://chromium-review.googlesource.com/969503 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#544269}
-
Dirk Pranke authored
In order to roll GN a0a05a85..ee966518 (r533513:r544233) and pick up the following changes: dcba727e GN: Don't crash when mutating the list in a foreach. 3325da9a GN: Correct Git Bash removal of leading "/" of "//" labels 36773f30 Improved GN code related to resolving paths. 1252d9cd gn clean: Don't delete and recreate the build directory. 2caa6c11 Update GN docs. 6783e46f Correct off-by-one in `Tokenizer::CanIncrement`. 1bcad90d GN: Force normal subprocess task priority on Windows a3ec9fb7 GN: Fix Mac bootstrap compile error bbc17a39 GN: Make sure print function flushes stdout to avoid output delays caused by buffered pipes. 99637d39 Remove reference to deleted sequenced_worker_pool 4416579b Rename buildflag_header targets in base for consistency cf54d20b gn: Write no stamp files for action inputs. 00eba186 Fix gn reference in build.ninja after bootstrapping c986c354 Support for JSON input conversion b46dd8be Only run "gn check" on binary targets. TBR=brettw@chromium.org Change-Id: Ic42ce6dc48e39772fd88f009e7e50459a64e740b Reviewed-on: https://chromium-review.googlesource.com/969982 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#544268}
-
Sunny Sachanandani authored
Background: A sequence (also called stream) has multiple command buffers, and runs tasks like Flush in the order in which they're received. Therefore, sequences are effectively flush ordered internally, but can run out of order with respect to other sequences. SyncPointManager ensures that there are no sync token wait deadlocks by assigning an order number to each IPC message. When a command buffer waits on a sync token, we enqueue the wait, and the order number of the waiting message (Flush) with the releasing command buffer's sequence ("release" sequence). If the releasing command buffer does not retire the sync token, we will still retire it once we go past the waiting order number in the release sequence, or if there are no more messages in the release sequence. This is to handle malicious renderers sending the browser sync tokens that aren't retired, and prevent the browser from hanging forever. It should also prevent deadlocks incorrect client logic. With the scheduler, we prevent a sequence from running if its next message has sync token waits that aren't resolved yet. We do this by adding sync token dependency hints in the Flush message. This is to avoid unnecessary context switching caused by executing a command buffer just to encounter a wait immediately. However, these dependencies are just hints, and we don't rely on them for correctness, i.e. it's possible for the Flush message to contain no hints, but still have sync token waits in the command buffer. In this bug, we encounter a cyclic dependency graph between sequences, where sequence A waits on sequence B with order number X which is less than the order number of B's next task, and sequence B waits on sequence A with an order number P which is greater than the order number of A's next task (which is X). This is caused by a client error that we haven't figured out yet, but we should still be resilient to it. However, this does not work as expected because the scheduler deschedules both sequences, and asks SyncPointManager to notify when the waits are resolved. SyncPointManager cannot resolve cyclic dependencies until one of the sequences runs. The logic to retire pending waits runs either when you start or finish a message with order number X. SyncPointManager doesn't know what the next order number in the task queue is. This worked correctly when we didn't have sync token dependency hints, and we would run one of the sequences in the cycle first. In the above example, the wait from A to B is invalid because B doesn't have a task with order number less than X. Only after starting to run the next task can SyncPointManager know to retire A's pending wait on B. To fix this, SyncPointManager would need the queue of order numbers for each sequence, and use that to invalidate any waits before the next order number. In the above example, A's wait on B would be deemed invalid because SyncPointManager can look ahead and see that the next task order number on B is greater than X. Ironically, the scheduler has this information in its tasks_ list, but doesn't use it because we wanted sync point manager to be the source of truth to support both scheduler and non-scheduler code paths over a year ago. This has been a bug since M63. Maybe we didn't hit it because the client started doing something incorrectly recently. One possibility is that the client is sending sync tokens to another process, but without the synchronous IPC to "verify" or confirm that an order number is assigned before sending it to another process. The short term fix is to add a queue of order numbers to SyncPointOrderData which is SyncPointManager's state about a sequence. Today, we have unprocessed_order_num_ which is the back of this queue, processed_order_num_ which is the last order number popped off the queue, but what we really want is the front of the queue (next task order number) any time a wait is enqueued. Long term, we may want to make the Scheduler the source of truth for sync tokens. Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I87c2680b14ccb04b5ba58ab329db683c400f45b3 Bug: 797137 Reviewed-on: https://chromium-review.googlesource.com/969639 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:Antoine Labour <piman@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#544267}
-
https://pdfium.googlesource.com/pdfium.git/+log/c49f39dff730..b3a5240832fc $ git log c49f39dff..b3a524083 --date=short --no-merges --format='%ad %ae %s' 2018-03-19 ralf.sippl Calculate AP for multi-line markup annotations correctly 2018-03-19 thestig Roll DEPS for Clang to 7d56ff90. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3519f4d3ca31557ab8a613027c610c20d592f60f Reviewed-on: https://chromium-review.googlesource.com/969829Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544266}
-
Zhuoyu Qian authored
This CL introduces Editor::IsCommandEnabled(), so WebLocalFrameImpl can use it instead of Editor::CreateCommand().IsEnabled() to avoid the dependence of Editor::Command in WebLocalFrameImpl.cpp. It's preparation of CL [1], because after that patch, we will not need to use "core/editing/commands" outside "core/editing/". [1]: http://crrev.com/c/958623Signed-off-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#544265}
-
Tatsuhisa Yamaguchi authored
When an archive file (.rar) on Drive cache is already marked as mounted, it doesn't change the cache state but still need the cache file path. Bug: 798024 Test: manually verified as noted in the bug Test: unit_tests --gtest_filter=FileCacheTest.*:FileSystemTest.* Change-Id: I44984dfe4ae4aa25885239b221d723fa3ba70866 Reviewed-on: https://chromium-review.googlesource.com/896765Reviewed-by:
-
Yeol authored
LayoutTestHelper isn't related to layout tests. so it's renamed and moved in core/testing/. Bug: 461929 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Icd3cd98b96bf97538475b43c356a756ba0797cd1 Reviewed-on: https://chromium-review.googlesource.com/914213 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#544263}
-
Istiaque Ahmed authored
Content verification mode is currently dependent on flag + field trial + os + google branded-ness. This means using flags to control verification mode from tests isn't going to produce desired outcome. Provide a way for tests to override this mode instead and use them in browser_tests. Bug: 822970 Test: No visible change. Change-Id: Ie764684d9acd56f3479d8d38f14fd02335160434 Reviewed-on: https://chromium-review.googlesource.com/967055 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544262}
-
Istiaque Ahmed authored
Bug: None Change-Id: I6930083dabdb2596f8760737c8d9d474d41c2d27 Reviewed-on: https://chromium-review.googlesource.com/965621Reviewed-by:
-
Jinsuk Kim authored
Stops the native ContentViewCore from using SupportUserData to manage its lifetime. It was appropriate when |ContentViewCore::FromWebContents| was required. Now that it's gone, it's desirable to manage it in a simpler way (other class as an owner) to make the object implementation lighter. This CL has WebContentsViewAndroid own it, and destroy it together at the end of its life. Alternatively tried to delete ContentViewCore upon |WebContentsObserver::WebContentsDestroyed| that it implements, but it led to a premature destruction that causes many tests fail. Note that |SetContentViewCore(nullptr)| can be called on WCVA while CVC is still alive, but WCVA still keeps the object till its own destruction for this reason. Bug: 789000 Change-Id: I79f08752c645a24a53c58f6ef715f21f24a691dd Reviewed-on: https://chromium-review.googlesource.com/961623 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#544260}
-
Ian Vollick authored
This CL changes the reposition icon, its size, and the color of the shadow. Bug: 799270 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5b4700c80e8731e17627ff3a35aab54b5e74bb40 Reviewed-on: https://chromium-review.googlesource.com/969614 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#544259}
-
Scott Chen authored
The two if-statements removed in this CL are unreachable because the conditions were already checked and returned early upstream in HandleShowSetupUI(). Bug: 800972 Change-Id: I5b3b300aea71a32185cb4ccc2c91548870dd0991 Reviewed-on: https://chromium-review.googlesource.com/969741Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#544258}
-
Dmitry Gozman authored
This field is not reliable in OOPIF world. Instead, we reconstruct frame tree faithfuly based on parents. This is possible due to frames having persistent ids (controlled by 'persistentIds' flag in a trace event). Bug: 820250 Change-Id: I1685f91729edfdeb2559b8a7f014845bed27f0e0 Reviewed-on: https://chromium-review.googlesource.com/967403 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#544257}
-
edchin authored
Bug: 818198 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5ae016579a179f2bbb9f1c9c5f7bd96db2a71f3d Reviewed-on: https://chromium-review.googlesource.com/969924Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544256}
-
Devlin Cronin authored
ExtensionScriptAndCaptureVisibleTest tests whether extensions are allowed to script or capture various urls and tabs (in a simplified unittest). However, the test is a bit hard to read, and the failures are maddeningly unhelpful. Readability: The test has methods for "Allowed" and "Blocked", which are direct inverses of each other, and then tests can use EXPECT_TRUE or EXPECT_FALSE with each. This means the reader has to keep extra state, and increases the likelihood of fragmentation. Failures: If an EXPECT_TRUE(Blocked()) call fails, it only indicates that the allowed state was not both "allowed to script" and "allowed to capture", but does not indicate what the state was. Fix these by introducing an AccessType enum to indicate whether an extension is allowed to script, capture, or both, and comparing the actual result to the expected. This way, if an expectation fails, the actual state is displayed in the failure. Additionally, this gets rid of having the Allowed/Blocked pairs. Finally, improve ScriptAllowedExclusivelyOnTab() to similarly indicate what went wrong, if the assertion fails. This does not introduce any behavior change. Bug: None Change-Id: I1cfbfeb5581cc1f71a72f3cacbc1d48df4c8d015 Reviewed-on: https://chromium-review.googlesource.com/966791 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#544255}
-
Andrew Grieve authored
Reduces Chrome.apk by 65kb, Monochrome by 69kb. Reduces uncompressed classes.dex 860kb / 895kb. Reduces monochrome odex size on Android O by 936kb. Tested locally that pages load (maps and yahoo). Tests have been running with obfuscation enabled for some time. Bug: 620323 Change-Id: Ia2e939968670e6cc427db56469b3020e5ba8b266 Reviewed-on: https://chromium-review.googlesource.com/969120Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#544254}
-
Andrew Grieve authored
Shrinks main dex method count by 21k Bug: 820570 Change-Id: Icff816f23428dca5c6d81e9170d2caf3a1bf40b9 Reviewed-on: https://chromium-review.googlesource.com/966931 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
-
Alexei Filippov authored
When v8 is unable to unwind a JS stack trace it emits a sample with an empty stack. That causes DT frontend to show gaps in stack frames. The patch workarounds these by replacing a missing sample with a neighbor one. It basically reverts https://chromium.googlesource.com/chromium/src/+/357c6a05e490f5e187dbad88aea96722a72c7446 Change-Id: I16f21a06bb33db160213319d38243c77ea497b09 Reviewed-on: https://chromium-review.googlesource.com/967466 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Alexei Filippov authored
- Improve auto selection of process/thread when TracingStartedInPage event is missing. - Allow JS samples be attributed to V8.Execute event. - Allow traces with no Chrome's toplevel event category. Change-Id: I8a46551041020a665edd27ee4a0cb10667076900 Reviewed-on: https://chromium-review.googlesource.com/964932Reviewed-by:
-
Chong Zhang authored
The flag is making the bot to load kernel driver and causes flakiness. We want to match chromium.gpu and chromium.gpu.fyi where they don't specify this flag. Background: The flag was added in Ife4228a86fa055416ec20a8049085bf4c2c33ce0 to fix a DISPLAY issue. The bot seems to be reconfigured since then and we want to drop the flag. Note: We should only need --xvfb inside VMs. Bug: 822479 Change-Id: I4709dbf3ca7e75e0697b5d9bede3af5eab320a04 Reviewed-on: https://chromium-review.googlesource.com/969616Reviewed-by:
-
Quinten Yearsley authored
This is to help make it clearer in the future why wpt-importer uses the fallback TBR reviewer. If it uses the fallback, that would mean that we either need to extend the sheriff calendar, or something has changed in the rotations calendar format, or something else unexpected happened. Change-Id: Ib15db50cbfea198668acbe01285cf12fb9a466ad Reviewed-on: https://chromium-review.googlesource.com/966698Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#544249}
-
Kevin Marshall authored
Enable packaged runs for: * base_unittests * crypto_unittests * ipc_tests * media_unittests * mojo_unittests Bug: 798851 Change-Id: Iab5a5decc6a85b00c89b975735ea961bdb94a6fe Reviewed-on: https://chromium-review.googlesource.com/969300Reviewed-by:
-
Joel Einbinder authored
Change-Id: I6c41493e06e4fe6399f78575f239a835ced14743 Reviewed-on: https://chromium-review.googlesource.com/956345Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
-
Qiang Xu authored
Bug: 799611 Test: manual test Change-Id: I9e1e59119e11f3ec376dc8c71a4938b6ed9d8888 Reviewed-on: https://chromium-review.googlesource.com/969790Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#544246}
-
