- 03 Sep, 2014 40 commits
-
-
divya.bansal authored
Browser should go back to video page(having inline video) through escape key of BT keyboard instead of goig back to main page. BUG=396996 Review URL: https://codereview.chromium.org/439433004 Cr-Commit-Position: refs/heads/master@{#293181}
-
flackr authored
BUG=408962 TEST=SplitSplitViewControllerTest.LandscapeOnly Review URL: https://codereview.chromium.org/535973002 Cr-Commit-Position: refs/heads/master@{#293180}
-
gcasto authored
This requirement only exists on this implementation of PasswordStore. BUG=408783 Review URL: https://codereview.chromium.org/536783002 Cr-Commit-Position: refs/heads/master@{#293179}
-
magjed authored
BUG=410202 TEST=Use Kinect camera on Linux. Go to page https://src.chromium.org/svn/trunk/src/chrome/test/data/webrtc/manual/peerconnection.html. Press button "Get devices". An entry "Microsoft Kinect Camera" should show up in the "Video source" list. Press button "Request GetUserMedia". You should get a stream with size 640x480 in the preview. Review URL: https://codereview.chromium.org/539443003 Cr-Commit-Position: refs/heads/master@{#293178}
-
dhnishi authored
profile is updated. BUG=409093 Review URL: https://codereview.chromium.org/519883002 Cr-Commit-Position: refs/heads/master@{#293177}
-
hubbe authored
Revert of Enable castv2 perf tests again (patchset #1 id:1 of https://codereview.chromium.org/511393007/) Reason for revert: Fails with low event counts on several platforms: crbug.com/410391 Original issue's description: > Enable castv2 perf tests again > > .. and switch evil network profile for bad network profile > > BUG=356842 > > Committed: https://chromium.googlesource.com/chromium/src/+/18b429984ee371349c4f80b215896098ede8d9f3 TBR=miu@chromium.org NOTREECHECKS=true NOTRY=true BUG=356842 Review URL: https://codereview.chromium.org/540433002 Cr-Commit-Position: refs/heads/master@{#293176}
-
spang authored
This crashes inside GbmBuffer::CreateBuffer due to NULL gbm_device. We should check this earlier for a more informative crash. BUG=410002 TEST=run chrome on link_freon NOTRY=true Review URL: https://codereview.chromium.org/532873002 Cr-Commit-Position: refs/heads/master@{#293175}
-
aiolos authored
Revert of Simplify IOSurface CoreAnimation code: Part 2 (patchset #13 id:240001 of https://codereview.chromium.org/490393002/) Reason for revert: crbug.com/410360 (Browser crashing on IOSurfaceLayer release in tab_switching.typical_25) Original issue's description: > Simplify IOSurface CoreAnimation code: Part 2 > > It isn't necessary to mess around with sharing CGLContextObjs anymore, > they were necessary only to share data between the frame subscriber > and the RenderWidgetHostViewMac. Just give each IOSurfaceLayer its > own CGLContextObj, and draw using immediate mode (using shaders > resulted in an increase in startup time). > > BUG=314190 > TBR=pfeldman@chromium.org > R=kbr@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/a83898264f64ad83bb98139e5e0dcb2c77db1997 TBR=kbr@chromium.org,ccameron@chromium.org NOTREECHECKS=true NOTRY=true BUG=314190 Review URL: https://codereview.chromium.org/528403002 Cr-Commit-Position: refs/heads/master@{#293174}
-
asvitkine authored
This can happen, for example, when a user used the --force-fieldtrials= command-line to set a different group than what they have selected from chrome://flags. Includes a test. BUG=409976 Review URL: https://codereview.chromium.org/529183002 Cr-Commit-Position: refs/heads/master@{#293173}
-
cmasone authored
The Mojo code on CrOS needs to accept inbound connections on a unix domain socket, and then 'promote' the resulting sockets to Mojo MessagePipes. This really requires access to the underying file descriptor, so provide a mechanism to accept a connection and get back a SocketDescriptor. BUG=407782 TEST=UnixDomain*SocketTest R=mmenke@chromium.org Review URL: https://codereview.chromium.org/509133002 Cr-Commit-Position: refs/heads/master@{#293172}
-
jmedley authored
BUG=none R= teravest@chromium.org TEST=none NOTRY=true (documentation only change) Review URL: https://codereview.chromium.org/530173003 Cr-Commit-Position: refs/heads/master@{#293171}
-
dcheng authored
BUG=110610 Review URL: https://codereview.chromium.org/535723002 Cr-Commit-Position: refs/heads/master@{#293170}
-
Monica Dinculescu authored
This reverts commit 9ed04f3e258e8f1ffdef74be2418fd87b1a47dfc. Reason for revert: did a bad git merge in the original branch merge. :( BUG=405056 TBR=noms@chromium.org Review URL: https://codereview.chromium.org/533153003 Cr-Commit-Position: refs/heads/master@{#293169}
-
simonb authored
Annotate postCallbackOnMainThread() method with @CalledByNative, and LibInfo fields with @AccessedByNative, for ProGuard. BUG= Review URL: https://codereview.chromium.org/539523003 Cr-Commit-Position: refs/heads/master@{#293168}
-
tsepez authored
This brings in: 5f8a503 Check m_nComponents when using JBIG2Decode 1d7dc1b Add m_pDocument in CPDF_Color and check if page date has been forced clear 49c41ac Tidy up opj_ callback functions in fx_codec_jpx_obj.cpp 9f810e7 Remove the GetValidBpc check in application callers and move it to where m_bpc is assigned. d0c3650 Remove unused fields and stack locals. TBR=thakis@chromium.org TBR=inferno@chromium.org Review URL: https://codereview.chromium.org/535623003 Cr-Commit-Position: refs/heads/master@{#293167}
-
kpschoedel authored
BUG=380349 Review URL: https://codereview.chromium.org/479873002 Cr-Commit-Position: refs/heads/master@{#293166}
-
Adam Langley authored
(By request of the site.) BUG=410377 Cr-Commit-Position: refs/heads/master@{#293165}
-
avayvod authored
When CreateSharedRelro fails, the file descriptor read by LibInfo from the parcel will be null, but the child processes are trying to call its methods anyway. Added a check to avoid NPE. BUG=409826 Review URL: https://codereview.chromium.org/538543002 Cr-Commit-Position: refs/heads/master@{#293164}
-
grt authored
The recipe magic expands the test failure trie using '/' as the separator in contrast to '.', which is the separator in the test case's id. BUG=264859 R=robertshield@chromium.org Review URL: https://codereview.chromium.org/534303002 Cr-Commit-Position: refs/heads/master@{#293163}
-
xians authored
Used 10ms native buffer size for webrtc audio renderer on Linux and Mac. And also remove some useless buffer size uma stat code. BUG=410258 TEST=content_unittests --gtest_filter="*WebRtcAudioRenderer*" Review URL: https://codereview.chromium.org/539453003 Cr-Commit-Position: refs/heads/master@{#293162}
-
robert.bradford authored
This change adds a GetModeSize() method that returns the size of the HDC's output as a convenience. TEST=Boot chrome on link_freon (and attach an external display.) BUG=None Review URL: https://codereview.chromium.org/535963002 Cr-Commit-Position: refs/heads/master@{#293161}
-
abhishek.a21 authored
Changes: 1) Run clang-format through source and header files. 2) Rename data member variables to use unix_hacker_ style. 3) Rename methods to use CamelCase style. 4) Rename file name to test_plugin. BUG=331299 Review URL: https://codereview.chromium.org/469943003 Cr-Commit-Position: refs/heads/master@{#293160}
-
dcheng authored
BUG=110610 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/532833003 Cr-Commit-Position: refs/heads/master@{#293159}
-
earthdok authored
BUG=378909, 381233, 381233 TBR=eugenis@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/536023002 Cr-Commit-Position: refs/heads/master@{#293158}
-
tfarina authored
MessageLoopProxy is deprecated. This basically does a search and replace: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). BUG=391045 TEST=unittests R=sky@chromium.org Review URL: https://codereview.chromium.org/516173002 Cr-Commit-Position: refs/heads/master@{#293157}
-
xians authored
Revert of Reland 501823002: Used native deinterleaved and float point format for the input streams (patchset #4 id:80001 of https://codereview.chromium.org/510073002/) Reason for revert: It is speculated that this CL is blamed for crbug/409819, I temporarily revert it to be able to verify it on canary. Original issue's description: > Used native deinterleaved and float point format for the input streams. > > If we call GetProperty of kAudioUnitProperty_StreamFormat before setting the format, the device will report kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved as the native format of the device, which is the same as the output. > > This patch changes the format to use kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved to open the device, so that we will avoid format flipping back and forth. Hope this optimization will help increase the stability of the input audio on Mac. > > TBR=DaleCurtis@chromium.org > > BUG=404884 > TEST=media_unittests && https://webrtc.googlecode.com/svn-history/r5497/trunk/samples/js/demos/html/pc1.html, https://www.google.com/intl/en/chrome/demos/speech.html > > Committed: https://chromium.googlesource.com/chromium/src/+/2c732c000e18a6decd1da8da24e1f5f9e5f16833 TBR=dalecurtis@chromium.org NOTREECHECKS=true NOTRY=true BUG=404884 Review URL: https://codereview.chromium.org/532303002 Cr-Commit-Position: refs/heads/master@{#293156}
-
wangxianzhu authored
The bug causing failure of the test has been fixed (crbug.com/245441). BUG=394338 TBR=zhaoqin Review URL: https://codereview.chromium.org/537593002 Cr-Commit-Position: refs/heads/master@{#293155}
-
shimazu authored
BUG=390894 TEST=N/A Review URL: https://codereview.chromium.org/509283003 Cr-Commit-Position: refs/heads/master@{#293154}
-
rdevlin.cronin authored
Since the indication of an active script running won't always be tied to the location bar, it doesn't make sense for ActiveScriptController to be owned by LocationBarController. Since the "generated" actions were also only used for display in the location bar, move that logic to the LocationBarController. And, since we're there, also add a bit more testing for LocationBarController. BUG=408676 TBR=avi@chromium.org (for method name change in cocoa) Review URL: https://codereview.chromium.org/527963003 Cr-Commit-Position: refs/heads/master@{#293153}
-
bruening authored
TBR=zhaoqin@chromium.org BUG=NONE NOTRY=true Review URL: https://codereview.chromium.org/539533003 Cr-Commit-Position: refs/heads/master@{#293152}
-
bnc authored
Cleanup: https://crrev.com/516443002/ obsoleted PrerenderCondition* classes. BUG=406583 Review URL: https://codereview.chromium.org/517843005 Cr-Commit-Position: refs/heads/master@{#293151}
-
dyen authored
Newer mobile devices may support the Open GL extension EXT_disjoint_timer_query, these devices can now be traced in Chrome. R=vmiura@chromium.org BUG= https://code.google.com/p/chromium/issues/detail?id=397294 TEST= trybots Review URL: https://codereview.chromium.org/509723002 Cr-Commit-Position: refs/heads/master@{#293150}
-
asvitkine authored
The only user of this interface has been folded into NetworkMetricsProvider. BUG=409872 Review URL: https://codereview.chromium.org/532623003 Cr-Commit-Position: refs/heads/master@{#293149}
-
andresantoso authored
Revert of [fsp] Enable the File System Provider API for extensions. (patchset #2 id:20001 of https://codereview.chromium.org/527663002/) Reason for revert: Speculative revert, failed ChromiumOS browser_tests. [1422/1422] FileSystemProviderApiTest.Extension (11555 ms) 1 test failed: FileSystemProviderApiTest.Extension http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/11812 Original issue's description: > [fsp] Enable the File System Provider API for extensions. > > Previously, only apps were allowed to use this api, however most clients will > be actually written as extensions. > > TEST=browser_tests: *FileSystemProvider*Extension* > BUG=409487 > > Committed: https://chromium.googlesource.com/chromium/src/+/4acb869459901c6fa627473bb15b8a0f6190cc11 TBR=benwells@chromium.org,kalman@chromium.org,mtomasz@chromium.org NOTREECHECKS=true NOTRY=true BUG=409487 Review URL: https://codereview.chromium.org/537603002 Cr-Commit-Position: refs/heads/master@{#293148}
-
Erik Arvidsson authored
BUG=410327 TBR=tkent,rvargas Review URL: https://codereview.chromium.org/539473004 Cr-Commit-Position: refs/heads/master@{#293147}
-
Mikhail Naganov authored
This reverts commit 69538c3b. As described in the bug, the proposed approach is invalid, as Blink's bindings code isn't ready to deal with terminated scripts properly, resulting in random crashes. Hence reverting the patch. BUG=390906 Review URL: https://codereview.chromium.org/534093004 Cr-Commit-Position: refs/heads/master@{#293146}
-
earthdok authored
The bug has long been fixed so can remove this workaround. BUG=353687 TBR=thakis@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/536903003 Cr-Commit-Position: refs/heads/master@{#293145}
-
wangxianzhu authored
The deadlock occurs because we hold lock when posting flush tasks. If MessageLoop::PostTask() also calls TRACE_EVENT and the TRACE_EVENT has never been reached before, the TRACE_EVENT will try to get the category enabled flag which will also need a lock. Copy thread_message_loops into a temporary vector of scoped_refptr<SingleProcessTaskRunner> to avoid lock when calling PostTask(). BUG=397022 TEST=Existing tests and ThreadSanitizer Review URL: https://codereview.chromium.org/491393002 Cr-Commit-Position: refs/heads/master@{#293144}
-
vkuzkokov authored
Rather than being a subscriber to DTAB port forwarding becomes part of it so that DTAB could stop discovering new devices when chrome://inspect is closed. BUG=387067 Review URL: https://codereview.chromium.org/500373004 Cr-Commit-Position: refs/heads/master@{#293143}
-
Mark Mentovai authored
Update rules2 in app_resource_rules.plist.in to a set of rules that ought to work on 10.9.5 and 10.10, with the latest Gatekeeper policy changes. This removes the “nested” tag from the live versioned directory, so that it will be treated as data instead of code. There are problems with “nested” validation of unversioned frameworks. There are other problems with “nested” allowing components to be replaced, although these can be overcome by creatively applying designated requirements to the nested components. The non-“nested” version allows us to not version the frameworks, which would introduce symbolic links and weaken v1 code signature validation as done by pre-10.9 systems because v1 code signatures do not consider symbolic links. This non-“nested” version is also the simplest change to the existing set of resource rules that works. The v2 rules2 dictionary is now identical to the v1 rules dictionary. In order for rules2 to be honored and for a v2 signature to be produced, the app must be signed on 10.9 or later. (This will also produce a v1 signature to be validated on pre-10.9 systems.) BUG=399276 R=rsesek@chromium.org Review URL: https://codereview.chromium.org/533943003 Cr-Commit-Position: refs/heads/master@{#293142}
-