- 15 Sep, 2020 40 commits
-
-
Christian Biesinger authored
This makes it clearer what the code is doing. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1083010 Change-Id: Iba31cde8d7e00771d22f8fc9a43329459e11dc7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409185Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#806979}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Bug: 1018739 Change-Id: I78aa860978a9d6426974b4f057fbc166b892a436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409904 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#806978}
-
David Munro authored
Bug: None Test: None Change-Id: I70aa59a19df3992600237ed5f796f14f0f00bea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409424 Commit-Queue: David Munro <davidmunro@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#806977}
-
Harry Cutts authored
The RDing FootSwitch1F1 (sold under a variety of names) is a single-key keyboard, which shouldn't prevent the virtual keyboard from appearing. Its Vendor and Product IDs were found from a Googler's feedback report. Bug: none Test: none (since I don't have the device) Change-Id: I217eb7aceaf912b79fa5a76d36e1a63979bf1e94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410257 Auto-Submit: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806976}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Bug: 1018739 Change-Id: I1cfbe9630c3ddf03417edd9874bc65f9f30d47d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410118 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#806975}
-
Richard Knoll authored
This enables automatic color contrast checks in these notification views so that we can use any theme color in a follow-up CL: - NotificationControlButtonsView - NotificationHeaderView - NotificationViewMD This will make sure that the text and icons are at least readable even if the colors don't combine well with each other. Note that this will still render the main notification content text too bright as it already expect the background to be set to the native theme color. Bug: 1113313 Change-Id: Ic1bc0816eeb6242b93a1195c2c03aff81726f83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398507 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#806974}
-
Swapnil authored
ForceInstalledMetrics::ReportMetrics is a large method and it would be good to break it down into smaller sub-methods. This CL adds a new method to report time taken during different installation stages for force installed extensions. Bug: 1127836 Change-Id: I36e3d9cc2b9b510dd3516c4f7642ef47809d2ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409937 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#806973}
-
Fargat Sharipov authored
Replace std::string with base::string16 in some places to be able to import from non-ASCII named Firefox profiles. Earlier those profiles were not displayed in the dropdown list in the profile import dialog, this CL fixes that. Bug: 1125904 Change-Id: I117b995101e38c4e7392c186f8c58f166f4b0ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401518 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Auto-Submit: Fargat Sharipov <farhit1@yandex-team.ru> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#806972}
-
Titouan Rigoudy authored
This reduces duplication a bit and provides a clear place to add new mojom dependencies of ResourceRequest. Bug: chromium:1124346 Change-Id: Id16435d8e5c5eb6318b4f0a4e9e1aec4ebbb99d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401471Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#806971}
-
Harald Alvestrand authored
With the implementation of transceiver.stop(), this test is no longer flaky, and isn't believed to time out. Bug: chromium:923244, chromium:893112, chromium:980879 Change-Id: I60e691ed84a219a26980a6c2ba4c3f2294e2bbac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410070 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#806970}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b4dd3b8297a9..594b592fd9d9 2020-09-15 tvanderlippe@chromium.org Remove loadResources from Runtime.js 2020-09-15 mathias@chromium.org Ensure only invalid network requests are highlighted in red 2020-09-15 sigurds@chromium.org Support enable_additional_blink_object_names in e2e tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110817,chromium:1127902 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibce79591dbd8713515c90eda5b75788c997d7849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411961Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806969}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Bug: 1018739 Change-Id: I4eab62eccbe0ef16904dcdb21a89d6f484be00a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409694 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#806968}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1600062449-2fe327552dcb0c48f221a41ff1f1e25d4acb9926.profdata to chrome-win32-master-1600127994-c9f9f16ba321eab4723234f8c655960b2fa4cc9b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4d1f4d91793178a00cf7b469bec6baf9c2cfcd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411362Reviewed-by:
-
Colin Blundell authored
This is an unchanged reland of 3481a5a7 . The test failure that caused this CL to be reverted (https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2212) looks like unrelated pre-existing flake; for example, this run from September 7 has the same failure: https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2123 . I will separately handle marking that test flaky. TBR=jam@chromium.org Original change's description: > [WebLayer] Add ability to override translate target language > > This CL adds the ability to override the target language used by the > translate feature on a per-Tab basis. This is analogous to the > functionality of CCT's TRANSLATE_LANGUAGE intent extra. Once the > override is set, all translate infobars in the given Tab will appear > with the specified language as the target language. Calling > Tab#setTranslateTargetLanguage() with an empty string clears the > override and causes behavior to revert to normal. > > Note that even with the override set the translate infobar will not > appear for pages that are in the user's locale. This is internal > behavior of Chromium's translate component and is common to CCT and > WebLayer. > > I marked the added method as since 86 as this CL will be targeted for > cherrypicking to 86. > > Bug: 1116394 > Change-Id: Ic4f08c16a64a3f0ceebed5feab7cdc9401001279 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397716 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Commit-Queue: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806633} Bug: 1116394 Change-Id: If8d8058584a260171c83687c2dfcf6732a33846c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410478Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#806966}
-
sandromaggi authored
Bug: b/167491545 Change-Id: I9f1229f9e9ff224bd3a685835497bcb8e34e8a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405583 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#806965}
-
Rohit Agarwal authored
Screenshot: https://screenshot.googleplex.com/6boukrmENqmXgtP Bug: 1127852 Change-Id: I672b1b65ddcfbe57d70797c927d5c6c00c1de76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409905Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#806964}
-
Maciek Slusarczyk authored
ChromeOS.SAML.APILogin tracks usage of Gaia vs SAML sign-in. Extending its validity by 6 months to collect additional data. Bug: 1121222 Change-Id: Ie9b2bcbb566217259952a78282c80d9cb6c7af5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407254Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Maciek Slusarczyk <mslus@chromium.org> Cr-Commit-Position: refs/heads/master@{#806963}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a0ee89a93f64..069f3d3b8ab2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1053866,chromium:1099917,chromium:1126827,chromium:912681 Tbr: ricea@google.com Change-Id: If5f33eb8ad140c5fe76b8eeb8c18cf012987e456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411237Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806962}
-
Alice Wang authored
TBR=fgorski@chromium.org Bug: 1128298 Change-Id: I7f9d49815d4ab464f4d43d1db747b379ccd62aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411932Reviewed-by:
-
Bret Sepulveda authored
PermissionRequest:GetEmbeddingOrigin was not implemented for all permission types, which made it difficult to use anywhere except when constructing the prompt strings. This patch moves that construction into UI code where the strings are used, which also simplifies the plumbing in PermissionPromptImpl. This patch also moves the Flash warning to use the new codepath, which allows us to delete PermissionRequest::GetMessageTextWarningFragment. This has a minor visual impact on the permission prompt bubble on Desktop. See the associated bug for screenshots. Bug: 1110905 Change-Id: Icfeedd011d620e467a5dbbf75bea6875f4af9379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379729Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Olesia Marukhno <olesiamarukhno@google.com> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#806960}
-
Olivier Robin authored
The intent is delayed when there is a blocking UI. It is necessary to execute it after Bug: 1125091 Change-Id: I434b36a6fa3cd3301452886cedc9898465a3c60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409300 Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#806959}
-
Christian Dullweber authored
Add a separate data type for account scoped data that is not included in WIPE_PROFILE or ALL_DATA_TYPES. Bug: 1126947 Change-Id: I07618954753a631a6f328dba4513151f9bab4987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404160 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#806958}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cfda0b2aaf01..53913fb84ad3 2020-09-15 treehugger-gerrit@google.com Merge "cppgen: Don't require full submessage definitions in gen headers" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I8a4768ddbf461706e94c2c4ad69200e8898b99a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411953Reviewed-by:
-
Fredrik Söderqvist authored
Bug: 994078 Change-Id: I3ff2e184a6444921b086ce4491e68c0d2092f771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409906 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#806956}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I7872427e715776cad55e12de1ef4c209402334e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411559Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806955}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Id5f802b8179753247b899f383eeac3777db70f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411955Reviewed-by:
-
Matthias Körber authored
This CL adds support for address lines as a special view on street addresses. Change-Id: Ifade7edd874321f7f65788a3091ffdee5199febf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410017Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#806953}
-
Shakti Sahu authored
- Setup video tutorial config class. - Add default preferred language and server endpoint configs. - Add unit test for config. Change-Id: I9f71a85070e34e0d85b2d00d5e6dcec582240056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393940 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#806952}
-
Yoshisato Yanagisawa authored
Made all builders to use the task service account to access Goma. I removed options from lib and made use_luci_auth=true mandatory. Bug: crbug.com/1105814 Change-Id: I8c0dff203a96e34db0b5ec1ac79b70289e2ae9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411561Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#806951}
-
Adam Langley authored
Good to keep things GREASEd. Change-Id: I7eaaa3ea9a6eb4afb248574c39f1da17f5dad246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410929 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#806950}
-
David Jean authored
Change-Id: I0a8fcd590e3a3b0981a45e9305259ceab0d63395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404846 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#806949}
-
Matt Falkenhagen authored
This allows for code simplifications. Change-Id: I39a866969feedb3c93fc936924850d859221b8be Bug: 1127724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407674 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806948}
-
Chris Blume authored
Include What You Use is reporting some missing includes. This CL adds those missing includes. Change-Id: Iff9a529d337db16c8c104a78c2ea32b456777884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408721 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#806947}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/53a7d9430dbb..b4dd3b8297a9 2020-09-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6863a705d9c32690b81aae6b0c2be9aa750f1a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411242Reviewed-by:
-
Richard Knoll authored
This introduces a new NotificationPlatformBridgeDelegator that is responsible for selecting the correct platform bridge for notification events. Bug: None Change-Id: I2aaff169887e281ab46fc51b8297a8cdf610ed9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401161Reviewed-by:
-
Sergey Poromov authored
This reverts commit 746ea10b. Reason for revert: Breaks Chrome OS builds as some internal code (tab_search_browsertest) still refer to kOutOfBlinkCors feature. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/8532 See chrome/browser/resources/tab_search/test... Original change's description: > Reland "OOR-CORS: Remove BlinkCORS supporting code outside Blink" > > This reverts commit efd0a0a1. > > Reason for revert: The failed internal test was fixed in the internal repos by > https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3263707 > > Original change's description: > > Revert "OOR-CORS: Remove BlinkCORS supporting code outside Blink" > > > > This reverts commit 1047b889. > > > > Reason for revert: Build failure on mac-builder-perf: https://ci.chromium.org/p/chrome/builders/ci/mac-builder-perf/220028 > > > > Original change's description: > > > OOR-CORS: Remove BlinkCORS supporting code outside Blink > > > > > > As OOR-CORS was fully launched, this patch removes BlinkCORS > > > supporting code that exists outside Blink. > > > > > > We still have some dead code in Blink, and subsequent cleanup > > > changes will remove them all. > > > > > > Bug: 1053866 > > > Change-Id: Ibe9f913d3cc9f183d6e681516996f1bc6cc58b96 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397458 > > > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > > > Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#805644} > > > > TBR=falken@chromium.org,sky@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,jam@chromium.org,karandeepb@chromium.org > > > > Change-Id: I51b1a274038b33b8db3036fc1a3912c6580c9446 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1053866 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401467 > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > > Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#805662} > > TBR=falken@chromium.org,sky@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,jam@chromium.org,skyostil@chromium.org,karandeepb@chromium.org > > # Not skipping CQ checks because this is a reland. > > Bug: 1053866, 1126827 > Change-Id: I9251c658414ff98e3fc35e8a110366edb30b2d74 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405728 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806906} TBR=falken@chromium.org,sky@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,jam@chromium.org,skyostil@chromium.org,karandeepb@chromium.org Change-Id: I19b61821bb75f486cd549741769a47daad08ea48 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1053866 Bug: 1126827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410125Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#806944}
-
Jinsuk Kim authored
Navigation sheet won't be included in the gesture navigation feature. This CL removes the option from #overscroll-history-navigation in chrome://flags. The sheet is now only used for history popup triggered by long press on back button. Bug: 1126341 Change-Id: Ib4739c30fe5fbbd8d56cb1ae990313f579f60bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400786Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#806943}
-
Camillo Bruni authored
This CL adds test required for landing top-level-await - Add more tests for module evaluation order - Add onunhandledrejection since top-level-await introduces more promises Bug: 1022182 Bug: 1096455c Bug: 1127215 Bug: v8:9344 Change-Id: Ib5502a47e6c0de6143a00f1ae35cde228e13200f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411927Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#806942}
-
Adam Rice authored
This reverts commit 644bba5a. Reason for revert: Causes document leaks. See https://crbug.com/1128269. Original change's description: > [Shared Highlights] Connect selector generation in renderer to Android frontend. > > Connect selector generation in renderer to Android frontend using mojom > interfaces. > This CL add producer interface implemented in the renderer. > When user selects a text, in the renderer side along with saving the > selection frame and range, TextFragmentSelectorGenerator is registered > for the producer interface and bound when user chooses 'Link to Text'. > > See https://screenshot.googleplex.com/0kb39qFn6JP.png for user flow. > > Bug: 1102382 > Change-Id: I4152b07d3058d4109f3919f285b46b9b2dd82f3e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341662 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Gayane Petrosyan <gayane@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Gayane Petrosyan <gayane@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806875} TBR=dcheng@chromium.org,flackr@chromium.org,rockot@google.com,gayane@chromium.org No-Presubmit: true Bug: 1102382, 1128269 Change-Id: I412553feaa3dba7ecefd6a103c2f7ffda94b7c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409739 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#806941}
-
Sylvain Defresne authored
base::Singleton is deprecated in favor of base::NoDestructor. The conversion is straight-forward for this leaky singleton and this allow removing unnecessary scaffolding code. Bug: none Change-Id: I1db6f1fdd00b3532efbaea8367c8563cc5e28740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409495Reviewed-by:
-
