GitLab

BUG=176857
Test=None
R=erg
TBR=sky (For ui/linux_ui/linux_ui.h)

Review URL: https://chromiumcodereview.appspot.com/13497002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192595 0039d316-1c4b-4281-b951-d872f2087c98

Once more with feeling. This time for sure.
I correctly figured out how to do a GOOGLE_CHROME_BUILD since apparantly
this does not get defined in any of the CQ chromeos bots.

BUG=192420
TBR=ben@chromium.org, et. al.

Review URL: https://codereview.chromium.org/13730003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192594 0039d316-1c4b-4281-b951-d872f2087c98

This logic was already added in scoped_ptr::reset() in
https://src.chromium.org/viewvc/chrome?view=rev&revision=185551.
this is a straightforward port of the logic to scoped_array to
prevent any accidental regressions during the transition.

BUG=162971,176091

Review URL: https://codereview.chromium.org/13433007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192590 0039d316-1c4b-4281-b951-d872f2087c98

BUG=225967
TEST=manual, lock screen, go to second terminal, kill render process for lock screen, login screen should be shown


Review URL: https://chromiumcodereview.appspot.com/13520006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192589 0039d316-1c4b-4281-b951-d872f2087c98

Make autofill's Address store country using the country code so that app locale isn't needed for the raw methods.

This is in preparation for removing content::GetContentClient calls outside of content.

BUG=227047
Review URL: https://codereview.chromium.org/13697002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192588 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100083

TEST=Open bookmark manager on a touch device (such as Pixel). Confirm that the vertical splitter can be comfortably moved and tree pane resized for reasonably long folder names to fit.

Repeat with a RTL language, e.g. by running "chrome --lang=IW" confirming that the left and right padding is reversed.

Review URL: https://chromiumcodereview.appspot.com/13606002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192585 0039d316-1c4b-4281-b951-d872f2087c98

By reducing the time waited between sending a Autocomplete request and
SearchProvider sending the request to mocked suggest server.

The speeds up the wall time of running SearchProvider test from 30 seconds to 20 seconds.

BUG=


Review URL: https://chromiumcodereview.appspot.com/13461012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192584 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174233
TEST=unittests. Open Files App and verify Google Drive is available.


Review URL: https://chromiumcodereview.appspot.com/13456002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192583 0039d316-1c4b-4281-b951-d872f2087c98

BUG=226789
TEST=no logic change, simply code refactor, so everything stays the same
Review URL: https://codereview.chromium.org/13400003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192580 0039d316-1c4b-4281-b951-d872f2087c98

This test failed on Vista Tests bot:

http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20(2)/builds/33887/steps/browser_tests/logs/DownloadExtensionTest_OnDeterminingFilename_InterruptedResume

DownloadExtensionTest.DownloadExtensionTest_OnDeterminingFilename_InterruptedResume: 
[0405/091818:ERROR:gl_surface_egl.cc(98)] eglInitialize failed with error
UNKNOWN
[0405/091818:ERROR:gl_surface_win.cc(54)] GLSurfaceEGL::InitializeOneOff failed.
HTTP server started on 127.0.0.1:51868...
sending server_data: {"host": "127.0.0.1", "port": 51868} (36 bytes)
browser\extensions\api\downloads\downloads_api_unittest.cc(3222): error: Value
of: item->GetState()
Actual: 0
Expected: DownloadItem::INTERRUPTED
Which is: 3
browser\extensions\api\downloads\downloads_api_unittest.cc(3223): error: Value
of: item->IsInterrupted()
Actual: false
Expected: true

> Fix DownloadExtensionTest_OnDeterminingFilename_InterruptedResume
> 
> Review URL: https://codereview.chromium.org/12422012

TBR=benjhayden@chromium.org
Review URL: https://codereview.chromium.org/13598016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192579 0039d316-1c4b-4281-b951-d872f2087c98

The lock/unlock button for the managed controls in the history page has been
misplaced by one of the patches. This moves it to somewhere else so it looks
fine again.

R=dubroy@chromium.org
BUG=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/13568003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192577 0039d316-1c4b-4281-b951-d872f2087c98

Fix sizing when auto-scaling a missing resource at a non-integer scale factor.  Matches the rounding rules used by UX when scaling resources at non-integer scale factors.

BUG=223928


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190970

Review URL: https://chromiumcodereview.appspot.com/12939015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192576 0039d316-1c4b-4281-b951-d872f2087c98

A little code cleanup I did while debugging some panel focus issues.

BUG=none

Review URL: https://codereview.chromium.org/12442009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192575 0039d316-1c4b-4281-b951-d872f2087c98

R=vsevik,pfeldman
BUG=227030

Review URL: https://codereview.chromium.org/13674009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192574 0039d316-1c4b-4281-b951-d872f2087c98

The problems were not caused by a bug, but rather a change in the
flexbox spec.

BUG=None
TEST=None, no functional change.
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/13459009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192573 0039d316-1c4b-4281-b951-d872f2087c98

We are introducing a new namespace "root". The "My Drive" root will be represented as
"/special/drive/root".

BUG=174233,218221
TEST=Open options UI


Review URL: https://chromiumcodereview.appspot.com/12790013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192572 0039d316-1c4b-4281-b951-d872f2087c98

New icons from sgabriel@.

BUG=180107
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/13685011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192571 0039d316-1c4b-4281-b951-d872f2087c98

This enables the update logic for /drive/root namespace.

BUG=174233
TESTS=unittests


Review URL: https://chromiumcodereview.appspot.com/13586012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192570 0039d316-1c4b-4281-b951-d872f2087c98

BUG=226014


Review URL: https://chromiumcodereview.appspot.com/13517002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192569 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175683,177443


Review URL: https://chromiumcodereview.appspot.com/13679005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192567 0039d316-1c4b-4281-b951-d872f2087c98

DevTools creates RenderView before browser populates systems settings into
WebContents preferences thus the renderer gets default subpixel antialising
setting.
The fix makes it sending ViewMsg_SetRendererPrefs to the renderer when
the preferences are finally obtained by the browser.

R=pfeldman@chromium.org


Review URL: https://chromiumcodereview.appspot.com/13580007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192566 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192565 0039d316-1c4b-4281-b951-d872f2087c98

TBR=maruel@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/13520009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192564 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/12422012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192563 0039d316-1c4b-4281-b951-d872f2087c98

BUG=222217
TEST=manual
R=nkostylev


Review URL: https://chromiumcodereview.appspot.com/13194004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192562 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation for porting TestKeyboard* tests to Drive.

BUG=224534
TEST=none


Review URL: https://chromiumcodereview.appspot.com/13706002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192559 0039d316-1c4b-4281-b951-d872f2087c98

This is a cleanup after:
https://codereview.chromium.org/12794003/

One test for backend force retry is enough, the other test
(CreateBackend_MissingFile) is converted to be backend implementation specific.

The CreateCacheViaPublicInterface() is called only once, but to eliminate it
there is a need to make the cache_thread_ protected. Also, I am sure the name is
not ideal, please suggest another.

The New Eviction allows not to be very strict about version comparison as stored
in the files on disk, this allows creating the BackendImpl with no flags and
then being able to pass the common integrity check.

BUG=173384


Review URL: https://chromiumcodereview.appspot.com/13517004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192558 0039d316-1c4b-4281-b951-d872f2087c98

SetAccessibleName to label text on SetText.
(this matches TextButtonBase::SetText behavior) 
Call SetText from LabelButton's constructor.

Use LabelButton in AccessibilityEventRouterViewsTest like: 
https://codereview.chromium.org/13584010 Patch Set 4. 

Note: This CL depends on https://codereview.chromium.org/13639003/

BUG=155363, 226814
TEST=LabelButtons have accessibility names. Tests pass. 
R=tfarina@chromium.org,sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13689002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192557 0039d316-1c4b-4281-b951-d872f2087c98

Autogenerated with:
  python tools\swarm_client\isolate_test_cases.py -s out\Release\browser_tests.isolated --gtest_filter=PepperContentSettingsTest.PluginSpecialCases

This should turn browser_tests_swarm completely green on Windows.

TBR=csharp@chromium.org
NOTRY=true
BUG=


Review URL: https://chromiumcodereview.appspot.com/13601007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192556 0039d316-1c4b-4281-b951-d872f2087c98

chromeos: Fix FilePath handling incompatibility between FakeDriveFileSystem::GetEntryInfoByResourceId and GetEntryInfoByPath

ConvertResourceEntryToDriveEntryProto adds extensions like ".gdoc" to hosted documents.
GetEntryInfoByResourceId and GetEntryInfoByPath should handle paths in the same manner.

BUG=None
TEST=unit_tests --gtest_filter="FakeDriveFileSystemTest.GetEntryInfoByResourceId_PathCompatibleWithGetEntryInfoByPath"


Review URL: https://chromiumcodereview.appspot.com/13579005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192555 0039d316-1c4b-4281-b951-d872f2087c98

Create "/drive/root" at DriveResourceMetadata initialization.
"/drive/other" is also created but is empty for now.

BUG=174233
TEST=unittests. Open Files App and verify Google Drive is available.


Review URL: https://chromiumcodereview.appspot.com/13149003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192554 0039d316-1c4b-4281-b951-d872f2087c98

 -- another race in ICU memory allocation (issue 223352)
 -- suppress a test-only race in tracked_objects::ThreadData::ShutdownSingleThreadedCleanup (issue 102327)

BUG=223352,102327,226970
Review URL: https://codereview.chromium.org/13296008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192553 0039d316-1c4b-4281-b951-d872f2087c98

Updated the query stub to filter by search term and added a test for searching
in the history page.

R=dubroy@chromium.org
BUG=196568


Review URL: https://chromiumcodereview.appspot.com/13523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192552 0039d316-1c4b-4281-b951-d872f2087c98

Currently when creating a new managed user we open other tabs in addition to
the managed users settings one, which we don't want to do.

This makes sure that only that tab gets added to the list of URLs to open on
start-up by early-returning from that function.

R=ben@chromium.org
BUG=171370


Review URL: https://chromiumcodereview.appspot.com/13468005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192551 0039d316-1c4b-4281-b951-d872f2087c98

Previously, getFileList() was called directly from testFileDisplay().
This was bad, as it's not guaranteed that the file list is already rendered
by the time testFileDisplay() is called, hence the test was flaky.
We should use waitForFileListChange() instead.

Likewise, doKeyboardTest() and doKeyboardTestWithConfirmation() are fixed
in the same way.

BUG=224534

Review URL: https://chromiumcodereview.appspot.com/13450004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192550 0039d316-1c4b-4281-b951-d872f2087c98

Enable the new elevation for managed users which is tied to a specific WebContents. This replaces the old elevation which was tied to a profile.

BUG=222364
TEST=unit_tests,browser_tests


Review URL: https://chromiumcodereview.appspot.com/13119011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192549 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192546 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=japhet@chromium.org

Review URL: https://codereview.chromium.org/13423005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192545 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements five newly introduced methods on FakeDriveService.
The implementation of ContinueGetResourceList, the remaining method, needs
slightly more changes, so it will be done in another CL.
The new methods will be used for testing of replacing GetResourceList method.

BUG=160932
TEST=Ran unit_tests --gtest_filter=FakeDriveService*


Review URL: https://chromiumcodereview.appspot.com/13608006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192544 0039d316-1c4b-4281-b951-d872f2087c98

Starting with the 10.8 SDK and the iOS 6.0 SDK, enums are declared
strongly typed in C++11 mode, which the old forward-declares weren't
compatible with. This creates a new macro for forward-declaring these
enums in a way that will match the SDK and compilation mode.

BUG=226494

Review URL: https://chromiumcodereview.appspot.com/13455004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192543 0039d316-1c4b-4281-b951-d872f2087c98