GitLab

Makes the debug logging output more consistent

Bug: None
Test: None
Change-Id: Ib6ca05df6e06c7bbb31ffca7c027707af7d67966
Reviewed-on: https://chromium-review.googlesource.com/1134428
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574408}

https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/058708a665cdd9e796581dbcf60a5778d3f5e240..2b76767bf572364d3d647cdd139f2044a7ad06b2

And disable HB_VECTOR_SIZE define now that HarfBuzz has temporarily
completed disabled compiler-assisted vectorisation.

Bug: 860250, 862607
Change-Id: If00101a279b23f5807a85973718183b33647195d
Reviewed-on: https://chromium-review.googlesource.com/1133384Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574407}

Bug: 851656
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I4fc218b0dba1b0dd569088a1665792b933c86ada
Reviewed-on: https://chromium-review.googlesource.com/1133686
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574406}

We don't run ash_unittests with --enable-features=Mash anymore, so
manually turn on the flag to test the feature.

Bug: 840391
Test: ash_unittests
Change-Id: Idb61128d9a65cbc6e93095683247c3e8cd714a9d
Reviewed-on: https://chromium-review.googlesource.com/1134418Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574405}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/0ba35b21089a..e6ce828ef60c


git log 0ba35b21089a..e6ce828ef60c --date=short --no-merges --format='%ad %ae %s'
2018-07-11 thomasanderson@chromium.org Revert "Trigger a buildbot cycle on client.nacl.toolchain"


Created with:
  gclient setdep -r src/native_client@e6ce828ef60c

The AutoRoll server is located here: https://nacl-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None
TBR=mseaborn@chromium.org

Change-Id: I96d892a8a5520b5394bf8929daf655f2ab9f95e9
Reviewed-on: https://chromium-review.googlesource.com/1133873Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574404}

No renaming or functional change. Just moving and grouping things
around. Plus, some clarification/simplification of comments.

Bug: 854229
Change-Id: I1a4fd3cdaf7fd41fd6c30fc199f281b46b061dc2
Reviewed-on: https://chromium-review.googlesource.com/1133715
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574403}

There is no need to remove the IO TaskRunner reference.
The global io thread task_runner is never deleted.
If io TaskRunner is set, just ignore future calls.

BUG=842245

Change-Id: Ifefad6442d8efde238379218e9f11a9f3d99a75a
Reviewed-on: https://chromium-review.googlesource.com/1134197Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574402}

Moves web_contents_delegate_android under embedder_support to
consolidate all the support components for embedders. The package path
is org.chromium.embedder_support.delegate. Now the component
has 4 main targets for embedders:
 - media
 - view
 - content_view
 - web_contents_delegate

Note:

- The choice of 'delegate' in the package name of WebContentsDelegateAndroid
  is just to avoid having WCDA repeated in the path. (import org.chromium
  .embedder_support.web_contents_delegate_android.WebContentsDelegateAndroid
   looked odd to me).
- Got rid of 'android' wherever it is repeated in the path, and the deletion
  won't cause confusion.
  e.g. web_contents_delegate_android_java -> web_contents_delegate_java
- Needs changes in the internal repo as well
  https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/646448


Change-Id: I44c25435c32330439ffa765d80df45b02d0694b1
Reviewed-on: https://chromium-review.googlesource.com/1118926Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574401}

Using wpt-import in Chromium 4df7c6c4.
With Chromium commits locally applied on WPT:
a9045946 "Add a fail-fast for longtask layouttests"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21178

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
domenic@chromium.org, ricea@chromium.org:
  external/wpt/streams

TBR=foolip

No-Export: true
Change-Id: I084c2429c7bc00f6d54eb830a34bcccb62e45c3b
Reviewed-on: https://chromium-review.googlesource.com/1134081
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574400}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values:

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing "static final" values, enum
and some classes in one common @IntDef/@StringDef form:

1. with @IntDef/@StringDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with NUM_ENTRIES declaring number of entries if necessary
4. with comment about numbering from 0 without gaps when necessary
5. with @Retention(RetentionPolicy.SOURCE)
6. without "static final" in the @interface

Additionally there are done some other trivial cleanups.

Change-Id: I8285733bbecf695b133a3865310f9a3cf0c515d6
Reviewed-on: https://chromium-review.googlesource.com/1133983
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574399}

This allows URLDataSources that have been detached from a backend to
still refer to the backend if it still exists, allowing any pending
queries that were issued to that backend and routed to the data source
to resolve back to the backend when they are finished.

BUG=859193

Change-Id: I55eda45be1f24716ad31c7d98ee748a737baca51
Reviewed-on: https://chromium-review.googlesource.com/1131537Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574398}

- Also add tests for displaying extensions, refactoring tests to a loop
instead of writing all possible combinations like before.

Bug: 853339
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I5a02771b339751e44df4ceb1bb6f58a7796968b4
Reviewed-on: https://chromium-review.googlesource.com/1127180
Commit-Queue: Nick Burris <nburris@google.com>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574397}

This fix was suggested by our UX writer jonann@ in b/111006044.

Bug: 824568
Change-Id: If888000ed030b0dd90436729c77cb861a59305f9
Reviewed-on: https://chromium-review.googlesource.com/1133710Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574396}

ChromeActivity should call ToolbarManager's isShowingAppMenuUpdateBadge
so that bottom toolbar has a chance to handle it.

Change-Id: I3ffdd69896ef4e3180328c33d5a5a69d21c5fdc4
Reviewed-on: https://chromium-review.googlesource.com/1132601Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574395}

Change-Id: Ie1fb9b26d0c4b5e4d767033cf50143e3b4612a3f
Reviewed-on: https://chromium-review.googlesource.com/1134422Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Caitlin Sadowski <supertri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574394}

As part of moving previews to an earlier decision point, this CL moves
the triggering of offline previews to be consistent with other preview
types.

Follow-up Cls will move this decision point earlier on the UI thread so
the new offline page implementation will also be able to use it. The
temporary dependency on PreviewsUserData will also not be needed once
the offline tab helper is accessible (the impl is on the UI thread).

Bug: 842233
Change-Id: If2969a109434270659dcf723b39a7627bb8c8ecd
Reviewed-on: https://chromium-review.googlesource.com/1128332Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574393}

This reverts commit 3dcee047.

Reason for revert: Suspect this is causing more flaky failures, see e.g.: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/10567 and build 10568

Original change's description:
> Reland "Fix OOPIF hit testing in layout tests."
> 
> This is a reland of 5e93ea19
> 
> Original change's description:
> > Fix OOPIF hit testing in layout tests.
> >
> > If we haven't received an activated surface yet ensure that we fallback
> > to querying the renderer for the target of input events.
> >
> > BUG=601584
> >
> > Change-Id: Id5dfcdb6bf54b98bebbd2a3b715d77202f402781
> > Reviewed-on: https://chromium-review.googlesource.com/1131219
> > Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#573789}
> 
> TBR=kenrb@chromium.org
> 
> Bug: 601584
> Change-Id: I8a2d207db79cc237e1d5e22e5e9bfffb218486c4
> Reviewed-on: https://chromium-review.googlesource.com/1133718
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574304}

TBR=kenrb@chromium.org,dtapuska@chromium.org

Change-Id: I9fec8992b35943f8dd2d8ce6bafe8ac9feb49411
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 601584
Reviewed-on: https://chromium-review.googlesource.com/1134143Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574392}

https://skia.googlesource.com/skia.git/+log/4ec72f7cc745..80247e594d1f


git log 4ec72f7cc745..80247e594d1f --date=short --no-merges --format='%ad %ae %s'
2018-07-11 caryclark@skia.org Publish docs for rrect, picture, blendmode
2018-07-11 bungeman@google.com Make CR and trailing whitespace errors.
2018-07-11 bsalomon@google.com Reland "Make GPU cache invalidation SkMessageBus messages go to one GrContext."
2018-07-11 bungeman@google.com Remove interal use of SkRefCnt_SafeAssign.
2018-07-11 mtklein@chromium.org collapse parametric_{r,g,b} into parametric, remove _a and gamma_dst
2018-07-11 herb@google.com Revert "Use new SkGlyphIDSet - v2"
2018-07-11 bsalomon@google.com Add gltestpersistentcache config that tests GrContextOption's cache.
2018-07-11 herb@google.com Revert "Use simple buffers instead of vectors"
2018-07-11 bsalomon@google.com Revert "Make GPU cache invalidation SkMessageBus messages go to one GrContext."
2018-07-11 bsalomon@google.com Make GPU cache invalidation SkMessageBus messages go to one GrContext.
2018-07-11 herb@google.com Use simple buffers instead of vectors
2018-07-11 halcanary@google.com Whitespace Fixup
2018-07-11 mtklein@chromium.org also rm Perf-Debian9-GCC-GCE-CPU-AVX2-x86_64-Release-All
2018-07-11 brianosman@google.com Only generate valid premul test data in SRGBReadWritePixels test
2018-07-11 jvanverth@google.com Add more tests for PolyUtils
2018-07-11 mtklein@chromium.org might as well use SkRasterPipeline::gamma too
2018-07-11 ethannicholas@google.com fix for persistent shader cache
2018-07-11 egdaniel@google.com Reland "Reland "Move Vulkan DebugCallback code into tools.""
2018-07-11 timliang@google.com implemented uploading intial texture data for metal gpu backend
2018-07-11 mtklein@chromium.org rm Perf-Win2016-MSVC-GCE-CPU-AVX2-x86_64-Release-All
2018-07-11 robertphillips@google.com Revert "SkDEBUGF: use __VA_ARGS__"
2018-07-11 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 a6a7842fdbf5..5c8113d3c20f (1 commits)
2018-07-11 timliang@google.com refactored where texture descriptors are made for metal gpu backend
2018-07-11 herb@google.com Use new SkGlyphIDSet - v2
2018-07-11 mtklein@chromium.org use from/to_srgb
2018-07-11 halcanary@google.com SkDEBUGF: use __VA_ARGS__
2018-07-11 kjlubick@google.com Adventures with Skia, WASM and a JS API for Pathkit
2018-07-11 caryclark@skia.org propogate simple angles in pathops
2018-07-11 mtklein@google.com Reland "transform paint color to dst colorspace"
2018-07-11 brianosman@google.com Remove clamping of kPlus with F16 configs
2018-07-11 brianosman@google.com Remove old lazy image decoding heuristic logic
2018-07-11 egdaniel@google.com Reland "Reland "Make GrVkBackendContext no longer derive from SkRefCnt.""
2018-07-11 brianosman@google.com Remove unused GrPixelConfig functions


Created with:
  gclient setdep -r src/third_party/skia@80247e594d1f

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=robertphillips@chromium.org

Change-Id: Ief888bfc0922b84d752987ea5ec56c4369912b14
Reviewed-on: https://chromium-review.googlesource.com/1133871Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574391}

This is so that both LegacyNavigationManagerImpl and
WKBasedNavigationManagerImpl can be tested on trybots.

Also fixed broken test setup for
ScriptExecutionTest.UserScriptOnAppSpecificPage and
CRWWebControllerTest.AbortNativeUrlNavigation.

Bug: 862718
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic343aafa9d1db545086fbeb001c5c9dd6253eb52
Reviewed-on: https://chromium-review.googlesource.com/1134406Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574390}

The naming turned out to be confusing.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I16fb06f080caac6ef9356edb187fe8032ef8f9ef
Reviewed-on: https://chromium-review.googlesource.com/1133098Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574389}

Switch COMPONENT to new structure, update and alphabetize owners, and
add missing fields.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:closure_compilation;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5141932b33a41d3aeaad1cc053623f12422e277e
Reviewed-on: https://chromium-review.googlesource.com/1121097Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574388}

https://chromium.googlesource.com/catapult.git/+log/5c0d851abe6e..1af68170e543


git log 5c0d851abe6e..1af68170e543 --date=short --no-merges --format='%ad %ae %s'
2018-07-11 simonhatch@chromium.org Dashboard - Use oauth scopes for /add_histograms
2018-07-11 simonhatch@chromium.org Dashboard - Add some timing around /add_histograms


Created with:
  gclient setdep -r src/third_party/catapult@1af68170e543

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:862730,chromium:862666
TBR=sullivan@chromium.org

Change-Id: If4b4e810ef8ae28ad68c15848c6aebe5ccc3fb56
Reviewed-on: https://chromium-review.googlesource.com/1133869Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574387}

Implement feed storage initialization in C++.

Bug:828938

Change-Id: I33a5a9e2e7dd20c36ec945feab6ea9932e9d94a2
Reviewed-on: https://chromium-review.googlesource.com/1121834Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574386}

1. Improved the xpath generator. The generator will produce even more concise xpaths. This improvement helps to make test recipes readable to humans.
2. Changed the way the extension queries for an iframe's context. Prior to this change, the extension would construct a path from the iframe to the top level frame by making a query at each ancestor frame node. However, InProcessBrowserTest does not need a path to go from the top level frame to a descendant iframe. Therefore, in this change the extension only makes one query at the parent frame node.
3. Moved the frame context query action to the front of the start recording workflow. This move cuts one message roundtrip from the extension's background script to the extension's content script.
4. Made the extension jot down a target element's visibility state when recording an action. Prior to this change, the extension assumes that every target element is visible, enabled and on the top of the page. However, the extension's complex action recording logic sometimes catches actions on invisible or partially obscured elements.
5. Added refined logic to the extension to distinguish between a user typing action and a Chrome autofill action. Prior to this change the extension simply assumes that Chrome always autofills every autofill-able field. If a user types inside an autofillable field, the extension will mistakenly record an autofill action. With this change the extension uses keyboard events to detect when a user types inside a field, eliminating the false positive.
6. Began implementing new features to capture Chrome Password Manager actions.

Bug: 855284
Change-Id: Ic7ff3af95cdc9f308c3ad061a3506fced150b4f8
Reviewed-on: https://chromium-review.googlesource.com/1132540
Commit-Queue: Yiming Zhou <uwyiming@google.com>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574385}

At some dpi scales (150% for example), the tabs are drawn detached from
the toolbar, with a stark one-pixel gap between the tabs and the
toolbar.

This CL draws one extra dip's worth of tab below the bottom of the tab,
which is occluded by the toolbar at integral scales and fills the gap
on non-integral scales.


Bug: 848106
Change-Id: Ib465e8886c49613916bf3f3faff5fc43f36dfb18
Reviewed-on: https://chromium-review.googlesource.com/1121386
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574384}

Views can trigger accessibility events during Widget construction
before the AXRemoteHost starts monitoring the widget. This happens
with the material design focus ring on text fields.

Bug: 862759
Test: added to views_mus_unittests
Change-Id: Ib7de6aa1d09b17fb65ad350abd362ad26b0454ae
Reviewed-on: https://chromium-review.googlesource.com/1134353Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574383}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values:

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing "static final" values, enum
and some classes in one common @IntDef/@StringDef form:

1. with @IntDef/@StringDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with NUM_ENTRIES declaring number of entries if necessary
4. with comment about numbering from 0 without gaps when necessary
5. with @Retention(RetentionPolicy.SOURCE)
6. without "static final" in the @interface

Additionally there are done some other trivial cleanups.

Change-Id: Ie6b59c0f1a8ec6fe50d3177619f0768798f97508
Reviewed-on: https://chromium-review.googlesource.com/1128092
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574382}

Per a suggestion of martinshelton@, this adds a new set of histograms to
track how long users have the Page Info bubble open. This will help us
better understand users who open Page Info but take no actions in it
(e.g., are these opens likely to be more accidental or incidental).

This metric is split by the security level of the page to allow us to
see differences between different security indicators. Two sub-histograms
("Action" and "NoAction") further split up the metric by whether the user
performed an action in the Page Info bubble before closing it (including
actions that cause the bubble to close).

Bug: 859116
Change-Id: I630a1f37ecff13bc7ee44b3e8e5a5c34337c9267
Reviewed-on: https://chromium-review.googlesource.com/1096336
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574381}

Experimental hints are tagged (in the Optimization proto) with an
experiment name. Experimental hints are not enabled unless an
experiment with a matching name is enabled. Experiments are enabled by
turning on the new base::Feature called kOptimizationHintsExperiments,
with the name of the experiment in a parameter called experiment_name.

Bug: 831817
Change-Id: I6141c70f8f3a8f9adb2c9772b747ee2a0c59b227
Reviewed-on: https://chromium-review.googlesource.com/1132491
Commit-Queue: Jeremy Elson <jelson@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574380}

This reverts commit db0cac4e.

Reason for revert: The revert didn't affect anything, so re-landing.

Original change's description:
> Revert "[sampling heap profiler] Support stack collection on Android"
> 
> This reverts commit 52601a56.
> 
> Reason for revert: Speculatively reverting to see if this is confusing crashpad on the Mac somehow. See crbug.com/862466.
> 
> Original change's description:
> > [sampling heap profiler] Support stack collection on Android
> > 
> > BUG=803276
> > 
> > Change-Id: I60d7925104b8614aa68c135d52f6089a76675d22
> > Reviewed-on: https://chromium-review.googlesource.com/1128630
> > Reviewed-by: Siddhartha S <ssid@chromium.org>
> > Commit-Queue: Alexei Filippov <alph@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#573880}
> 
> TBR=alph@chromium.org,ssid@chromium.org
> 
> Change-Id: Ie7b4f8b20cd5526420ef836d3a21dda27d4090bb
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 803276
> Reviewed-on: https://chromium-review.googlesource.com/1132357
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574032}

TBR=dpranke@chromium.org,alph@chromium.org,ssid@chromium.org

Change-Id: I41392b0836e75c25ae6b0b9aa243daeef95b6ee7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 803276
Reviewed-on: https://chromium-review.googlesource.com/1134142Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574379}

This is the 1st CL adding new views. There will be three following CLs
on Autofill Client change, unit-test and metrics, and cocoa implementation.

For details, please refer to design doc go/ib-paradise.

This project is to offer users an option to upload chrome local credit
cards to Google Pay server. This bubble UI is the entry point of the entire
flow. It should be anchored to a credit card icon in the location bar and
be shown from it.

Bug: 852904
Change-Id: Iadc4667598fc0a90a81c23658185045a5aecda8a
Reviewed-on: https://chromium-review.googlesource.com/1128569
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574378}

Apparently this test can still fail on Windows. So re-disabling it until it can be investigated further.

TBR=fsamuel@chromium.org
TEST=SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest

Bug: 848825
Change-Id: I00828a10cfd5c8c111b30f61eb5d8acbf57da2ea
Reviewed-on: https://chromium-review.googlesource.com/1133875Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574377}

The target rtc_p2p from WebRTC, transitively depended on by
jingle_unittests via the target webrtc_overrides, will soon depend on
the implementation of RTC_HISTOGRAM_* macros in WebRTC.

Bug: webrtc:9409
Change-Id: I1f2bf0776d2f7c18c9585fb15d7251f8128ce175
Reviewed-on: https://chromium-review.googlesource.com/1134183
Commit-Queue: Qingsi Wang <qingsi@google.com>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574376}

This test is flaky on android bots, and given that its testing something that
should be explicitly unsupported (passing a negative number to a uint parameter),
I think it's worth removing for now.

Bug: 862647
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I316cb2cc5979aefb7335f715bd1fd2655db097b3
Reviewed-on: https://chromium-review.googlesource.com/1134206Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Lily Houghton <lilyhoughton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574375}

At r573968 the logic was modified to only look for the noSearch property for
subpage wrappers. It should also look for the CSS attribute for the case where
no-search is not part of a binding.

Bug: 862517
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id3f5dbcd86f931cce71f2e3c8a784780f5b34be6
Reviewed-on: https://chromium-review.googlesource.com/1133683Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574374}

- TAP_DOWN is added to CastContentWindow::GestureType
- The gesture detection is attached to the root window and handles
  tap down events. A new JS binding API: onTapDownHandler will be hosted on
  platform
- HandleTapGesture: finger is released after pressed within tap timeout window
  HandleTapDownGesture: finger is pressed

Bug: internal b/75979846
Test: build manually and test whether both tap and tap down handler callback works
Change-Id: Iaefa6df9c7a5284ba27964083fc056bf36cf480a
Reviewed-on: https://chromium-review.googlesource.com/1115418Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Jiawei Li <lijiawei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574373}

This way both legacy and WK based navigation manager implementations are
tested on trybots.

Fixed incorrect test setup in ShowAndClearInterstitialWithNoCommittedItems.
Disabled ShowAndClearInterstitialWithCommittedItem and
ShowAndClearInterstitialWithoutChangingSslStatus because they require
mocking out navigation state, which is not possible now.

Bug: 862718
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id72d1c2837aba7c1ed53f4fd8623e8c286a4a0a2
Reviewed-on: https://chromium-review.googlesource.com/1134086Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574372}

And remove a NOTREACHED that we're hitting. I will supply a test for this
separate, as well as investgating removal of NOREACHED.

BUG=855767
TEST=none

Change-Id: Idf59b80388fefa06317a70055d18db995187c9a0
Reviewed-on: https://chromium-review.googlesource.com/1134352Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574371}

Introduce a base::Feature flag that controls how the
remainder of the Symantec Legacy PKI - that is, certs
issued on/after 2016-06-01 but before 2017-12-01 - are
handled.

Bug: 796230
Change-Id: Iebe9976ace0dfcdfd02f844fdaf497cf67dde704
Reviewed-on: https://chromium-review.googlesource.com/1134037Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574370}

This is a reland of 841c0dde

The updated change uses window.devicePixelRatio to determine the inset.
It also accounts for the absolute position used by the "WithDivs"
variations of this test. One additional device pixel of offset is used
to make this pass on mac_chromium_rel_ng. This is probably necessary
because either window.devicePixelRatio reports 1 incorrectly or the
edge antialiasing covers slightly more than one pixel. This wasn't
investigated.

Original change's description:
> Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest.
>
> Skia currently has a driver workaround that performans antialiased
> rectangle edge equation evalution in the fragment shader rather than
> vertex shader on Adreno 3xx GPUs. This was done because the interpolation
> of values computed in the vertex shader lacks enough precision to pass
> these tests. However, doing so has a negative performance impact. Skia
> tests run with the workaround removed show that in practice the visual
> difference is insignificant. Moreover, cc::GLRenderer also incurs these
> same errors as it uses the same antialiasing approach without the
> workaround and has shipped on Adreno 3xx devices for years with no known
> complaints about antialiasing quality/accuracy. We're better off
> reclaiming the performance and accepting a small hit to antialiasing
> accuracy.
>
> Bug: 847984
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: If1e62e0780a752179a75ddd57ccc7b24128c68ac
> Reviewed-on: https://chromium-review.googlesource.com/1129041
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Cr-Commit-Position: refs/heads/master@{#573695}

Bug: 847984
Change-Id: Ie5e685e8d5e0afbcf4c54ea3186ee68d238464ba
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1132574
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574369}