- 28 Nov, 2017 26 commits
-
-
gogerald authored
Test video: https://drive.google.com/file/d/1oUUkOqj5EJU9XiXUp9fz1FxC6S6knNqW/view?usp=sharing Bug: 785309 Change-Id: I14f7ae6b879bea7f805d7a9de8320231447e9a81 Reviewed-on: https://chromium-review.googlesource.com/788250 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#519488}
-
Fabio Tirelo authored
Registry keys removed or changed by the cleaner will be shown to the user on the Settings page card and need to be provided by the cleaner via the Mojo IPC. Those keys are only used for visualization (no validation will be done by Chrome) and we don't intend to add any sophisticated visualization support (such as expandable trees); because of that, we decided to go with the simplest approach and only transmit lists of strings instead of more structured data. This CL only propagates registry keys to the places they may be used, so most files in this CL are simply adding a new parameter to functions. A follow-up CL will actually use the new parameter in UI code. Bug: 776538 Change-Id: Ifd9faf79eea070d17452356c45ae37482bf77864 Reviewed-on: https://chromium-review.googlesource.com/780287 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#519487}
-
Xianzhu Wang authored
This avoids crash on unexpected null TotalPropertyTreeStateForContents() in https://chromium-review.googlesource.com/c/chromium/src/+/786130 for SPv175/non-RootLayerScrolling. This is separated from that CL which is a pure SPv175 refactor. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5ad8db400838f4e9a5a5f87847e62858c6460759 Reviewed-on: https://chromium-review.googlesource.com/791935 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#519486}
-
François Degros authored
This way, if one of the CHECK_PAGE_IN_CORE fails, we get a more accurate message with a useful line number, and not just a line number within the (now removed) local function CheckPageInCore. Also fixed the way mincore is used. According to mincore's documentation: int mincore(void *addr, size_t length, unsigned char *vec); The vec argument must point to an array containing at least (length+PAGE_SIZE-1) / PAGE_SIZE bytes. On return, the least significant bit of each byte will be set if the corresponding page is currently resident in memory, and be clear otherwise. The settings of the other bits in each byte are undefined; these bits are reserved for possible later use. Change-Id: I47f11e896a21944033314a84c6775d3d2ff70a24 Bug: 788240 Reviewed-on: https://chromium-review.googlesource.com/788473 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#519485}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/ea14a1a965c5..cbe62b9c2d2b $ git log ea14a1a96..cbe62b9c2 --date=short --no-merges --format='%ad %ae %s' 2017-11-21 marpan vp9-svc: Fix to the layer buffer settings. 2017-11-20 vtsyrklevich [CFI] Remove function pointer casts 2017-11-20 jianj vp8 simulcast: fix compile warnings. 2017-11-17 marpan vp9-svc: Enbale scale partition reference frames. 2017-11-17 jianj vp9 svc: fix a few compile warnings. 2017-11-17 kylesiefring Optimize AVX2 get16x16var and get32x16var functions 2017-11-16 paulwilkins Disable allow_partition_search_skip for speed 2. 2017-11-15 paulwilkins Code cleanup. 2017-11-15 paulwilkins Remove decay_accumulator clause from alt ref breakout. 2017-11-15 paulwilkins Add clause to alt ref group breakout. Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Bug: Change-Id: Ie6724cbc3e03f47bf6151e60029bf954d958018d Reviewed-on: https://chromium-review.googlesource.com/792112Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#519484}
-
Jana Iyengar authored
This reverts commit ba355778. Reason for revert: This change causes QUIC to be marked as broken if it happens ip change happens during a handshake, which may be causing QUIC usage to go down. Original change's description: > Default enables option to close QUIC sessions on an IP address change, > when QUIC connection migration is not enabled. > > Bug: 544156 > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester > Change-Id: I6440c4833e798b61d2d83dcef2f1bf24869719be > Reviewed-on: https://chromium-review.googlesource.com/655767 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Commit-Queue: Jana Iyengar <jri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#503577} TBR=pauljensen@chromium.org,rch@chromium.org,jri@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 544156 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I619b6201d33cd4f97bb8be8f1674e319fa9196fe Reviewed-on: https://chromium-review.googlesource.com/759356 Commit-Queue: Jana Iyengar <jri@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Jana Iyengar <jri@chromium.org> Cr-Commit-Position: refs/heads/master@{#519483}
-
John Z Wu authored
The autorelease pool released the mock objects so that nothing was actually being tested. Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I90c575bd82e6662d264c377b7d30a23cfc100e90 Reviewed-on: https://chromium-review.googlesource.com/792006Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#519482}
-
Hans Wennborg authored
TBR=hans Change-Id: Ib55a96609180af705988496d879cf525804e78bc Reviewed-on: https://chromium-review.googlesource.com/792336Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#519481}
-
Mrunal Kapade authored
Following up from https://codereview.chromium.org/2905733003/ Replace with DLOG(INFO) instead. BUG=638849 Change-Id: I773fba7a2b0c09d5e55e645096eb3c3cad698324 Reviewed-on: https://chromium-review.googlesource.com/678056Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Mrunal Kapade <mrunal.kapade@intel.com> Cr-Commit-Position: refs/heads/master@{#519480}
-
Tom Sepez authored
Reason for reversion https://bugs.chromium.org/p/chromium/issues/detail?id=788778 The functionality isn't required -- yet -- and breaks some tests. Try to get the tests working again. Bug: 788778 Change-Id: I1caea69411c3210409b66e083c10221bb3244881 Reviewed-on: https://chromium-review.googlesource.com/790933 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#519479}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/46a672bafa21..77ce4bdc7d9c $ git log 46a672baf..77ce4bdc7 --date=short --no-merges --format='%ad %ae %s' 2017-11-27 tandrii gclient on bots: don't cleanup lock files. 2017-11-27 myjang [depot_tools] Fix timestamp issues related to local auth Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I07dc7dae1b42b3102ab5ec2eeb60966a5661fa26 Reviewed-on: https://chromium-review.googlesource.com/791939Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519478}
-
Tien-Ren Chen authored
In CompositedLayerMapping::UpdateShouldFlattenTransform() we apply different values on the same layer multiple times for different layer configuration. This resulted in unnecessary redraw in the compositor. This CL collapsed the logic so that each layer will be programmed exactly one time. BUG=783614 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id2551e6e49d2555359da9d954b44555cb1f41a63 Reviewed-on: https://chromium-review.googlesource.com/780803 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#519477}
-
Khushal authored
Its possible for the PaintImage for a BitmapImage to be null, if the decode failed for instance. Don't create a StaticBitmapImage with this null PaintImage in these cases. R=pdr@chromium.org Bug: 787708 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iaa5378e0ccd533f2140db295d1af1b52c37c75e1 Reviewed-on: https://chromium-review.googlesource.com/791852Reviewed-by:
-
Eugene But authored
This should help with EarlyPageScriptPerfTest.BareWebViewInjection failure debugging. Bug: 788116 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7d983d9335b800fa0d576322f7bd3f811107ce3e Reviewed-on: https://chromium-review.googlesource.com/790631Reviewed-by:
Menglu Huang <huangml@chromium.org> Reviewed-by:
-
Florin Malita authored
Undistributed shadow DOM v0 light tree nodes don't seem to enforce style calculation. Prior to https://chromium-review.googlesource.com/c/chromium/src/+/767708, this condition was being caught by checking for null style. Add back the style check to handle this case gracefully. BUG=788206 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I859a78206ca61fa58a6f24c6afd84b98004ed757 Reviewed-on: https://chromium-review.googlesource.com/791213Reviewed-by:
-
Dale Curtis authored
Also, just use the kPropProbably expectation which already sets this up correctly. BUG=787514 TEST=none Change-Id: I44f16049ac94f574f272a2e4d9a1061c24181b59 Reviewed-on: https://chromium-review.googlesource.com/792097Reviewed-by:
-
Fady Samuel authored
In order to maximize parallelism, we immediately update a parent's SurfaceLayer when a synchronization event happens (e.g. Resize). However, the Chrome renderer throttles itself (for good reason), and will not always accept resize requests. For example, suppose the following sequence of resizes is issued: 300x300, 400x400, 500x500. Suppose the renderer is busy with 300x300 when 400x400 is requested. The request will not be sent to the renderer until it ACKs the previous resize, 300x300. By the time the 300x300 resize is ACKed, the requested size is now 500x500 and so the renderer picks up that request (RenderWidgetHostImpl::WasResized) and processes the 500x500 request. Thus, the 400x400 request will never complete. However, the parent layer compositor may submit a CompositorFrame depending on 400x400 which will cause Viz to block that frame for the full duration until a deadline fires. This is perceived by the user as jank. The higher the deadline, the more the jank. This CL addresses the jank by immediately dropping the dependency in Viz once Viz knows the intermediate dependency will never arrive. Each resize corresponds to a new LocalSurfaceId allocation. Now that LocalSuraceId allocations are monotonically increasing, Viz can detect when a CompositorFrame arrives for a Surface *newer* than the one a parent is blocking on and immediately remove that dependency. At aggregation time, the latest in-flight surface *older* than the unresolved activation dependency will be used. Thus, gutter will be seen for a frame, but it should be very minor. Bug: 672962 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ida7bde8881ced8d10d1154bea48696ee7db11923 Reviewed-on: https://chromium-review.googlesource.com/789420 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#519472}
-
Nicholas Verne authored
Made windows-only typemap for LOGFONT using the existing IPC ParamTraits. The next CL will remove child_process_messages.h Bug: 775817 Change-Id: Id42bf3df88ab067e1bc440757a70e6821e4f40e8 Reviewed-on: https://chromium-review.googlesource.com/783912 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#519471}
-
Dan Sanders authored
Bug: 622897 Change-Id: I1f19ad0b63a0cf864cde12ceed79e54bb4d1d164 Reviewed-on: https://chromium-review.googlesource.com/780805 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#519470}
-
Xiyuan Xia authored
OnNotificationUpdated could have a notification removed while iterating through |blocked|. Move the iteration lock up to protect the |blocked| iteration to fix the UAF. And fix a remnant naming in notification_list.h. Bug: 788078 Change-Id: Ic6e73fb35682def871f527806b2dee66700f576b Reviewed-on: https://chromium-review.googlesource.com/792011Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#519469}
-
Andrew R. Whalley authored
Bug: Change-Id: I9a6474effacd48e3f4e4230b61960b691335d99b Reviewed-on: https://chromium-review.googlesource.com/792118 Commit-Queue: Andrew Whalley <awhalley@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#519468}
-
Steven Bennetts authored
This histogram will be used to gather active use of chrome.app.window.create with type = panel. Bug: 788033 Change-Id: I7a5703567a18b550275cf12a4b574141c53ff42e Reviewed-on: https://chromium-review.googlesource.com/786785Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#519467}
-
xdai authored
is smaller than the minimum bounds. Bug: 787150 Change-Id: Ib4596276467a62f8b25c192dece808079460b808 Reviewed-on: https://chromium-review.googlesource.com/780660 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#519466}
-
Takumi Fujimoto authored
Enabling the feature by default so that TOT builds will have it enabled as well. The feature is already enabled for all official builds via Finch. Bug: 684642 Change-Id: Ieff6b68115b19bacb655a3a1a63b0311bc9fe79d Reviewed-on: https://chromium-review.googlesource.com/792035Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#519465}
-
Xiaohan Wang authored
Revert commit a62756b1 and reland 3294249d with fix. Original CL description: - DIR_COMPONENT_WIDEVINE_CDM is not used anymore. - Update WidevineCdmComponentInstallerPolicy::GetRelativeInstallDir() to use kWidevineCdmBaseDirectory instead of hardcoded string. TBR=waffles@chromium.org,thestig@chromium.org Change-Id: I802a9575076e4f93e9ac302d40197117108de4d6 Reviewed-on: https://chromium-review.googlesource.com/791934Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Min Qin authored
This CL adds the throttling logic for navigation interception with Network service enabled. This matches the same logic used by DownloadResourceThrottle. It will prompt user for storage permission, and limiting the number of download requests per tab. BUG=715630 Change-Id: I88ad091972739e204ebf9b9720589bc10779eed4 Reviewed-on: https://chromium-review.googlesource.com/773483 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#519463}
-
- 27 Nov, 2017 14 commits
-
-
Stuart Langley authored
This should be the final CL for moving to nullptr in WebKit/Source/* I followed the instructions to run clang tidy at https://chromium.googlesource.com/chromium/src/+/master/docs/clang_tidy.md. I then ran the modernize-use-nullptr check on WebKit/Source/modules using the following command: $LLVM_HOME/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \ -p ../.. \ -clang-tidy-binary $LLVM_BUILD/bin/clang-tidy \ -clang-apply-replacements-binary $LLVM_BUILD/bin/clang-apply-replacements \ -checks=-*,modernize-use-nullptr \ -header-filter=third_party/WebKit/Source/* \ -fix \ third_party/WebKit/Source Then ran "git cl format" on the result. Bug: 778942 Change-Id: I31f0cba131523034a7811bf46f8ef68110d11a3f Reviewed-on: https://chromium-review.googlesource.com/791410Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#519462}
-
Will Chen authored
My previous CL broke the test debugging workflow because it resulted in TestRunner.addResult causing a stack overflow: https://chromium-review.googlesource.com/c/chromium/src/+/780806 This fixes the issue by preserving original console functions when debugging tests. Bug: 788044 Change-Id: I06a93e674ee80d35460f12ba84a4168030c5a029 Reviewed-on: https://chromium-review.googlesource.com/791370Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#519461}
-
Michael Lippautz authored
The stack address might point into the guard page at the end of a NormalPage. In this case the address is outside of the payload of the preceeding object. We assert that this can only be the case if the address is in the allocation point region which is not true in this case. The fix is to simply check for object payload in the beginning of FindHeaderFromAddress. Bug: chromium:788728,chromium:757440 Change-Id: I9cec5e9f0940ed1dcc1823484ced82308b054d8a Reviewed-on: https://chromium-review.googlesource.com/791351Reviewed-by:
-
Gyuyoung Kim authored
Issue 784653 removed isProtocolHandlerRegistered from a test that was ensuring it's not supported. So this CL restores it and removed expected result as well. Bug: 121825 Change-Id: I50609018d2349b584cccc4db1054ff4fe7447e43 Reviewed-on: https://chromium-review.googlesource.com/789712Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#519459}
-
Danyao Wang authored
The last use case of SetWebUsageEnabled(false) is to clear visited site data. It does so by removing the WKWebView due to a bug in WebKit (see crbug.com/557963). This breaks in WKBasedNavigationManager because it relies on WKWebView as the source of truth for session history. This CL fixes the issue by temporarily caching the session history in WebState and restoring it into the navigation manager when web usage is re-enabled. This fixes the LoadIfNecessaryTest.DisableAndReenableWebUsage test. Bug: 781916 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6f7db84504603e624f5befa66ccb41c10433dd69 Reviewed-on: https://chromium-review.googlesource.com/789791 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
Thgough IDL defined unregisterProtocolHandler with 2 arguments, unregister-protocol-handler.html has tested it with 3 parameters. Thus this CL removes the title parameter in the tests. - void unregisterProtocolHandler(DOMString scheme, USVString url); Spec: https://html.spec.whatwg.org/multipage/webappapis.html#custom-handlers Bug: None Change-Id: I544d0027f90a25d517b77633bf50a726ee1b364c Reviewed-on: https://chromium-review.googlesource.com/790018Reviewed-by:
-
David Bokan authored
When the user zooms into the page, scrolling should be proportionally reduced so the page appears to move at the same rate. This is currently done for various kinds of scrolling. An animated scroll that updates an existing scroll animation simply adjusts the animation curve's target delta. However, this path forgot to adjust by the page scale factor like the "new animation" and "non- animated" paths. This CL simply adds that in. Bug: 610021 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ic1a6421131915ad739d39ad3ef36792dd3be53aa Reviewed-on: https://chromium-review.googlesource.com/788134Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#519456}
-
Nicolas Pena authored
This CL takes advantage of the loop through text in LayoutText to store a variable indicating whether text contains only 'whitespace' or not. The main purpose of the loop is to compute widths but this seems like a reasonable place to also store this new information, to avoid an extra iteration over the text. Now, TextRun has a boolean variable indicating whether the text to be painted contains a whitespace or not. For now, the boolean is only changed in InlineTextBox::ConstructTextRun to prevent Font::DrawText from returning true. The return value of this method is only used to determine whether SetTextPainted() is called in GraphicsContext::DrawTextInternal. PaintController::SetTextPainted is the method that triggers First Contentful Paint (caused by text) on PaintTiming. We do not want it to be triggered on trivial whitespace text rendering. Test: Check whether FCP is observed on a document with just <div> </div> Also, this fix should allow landing the test in: https://chromium-review.googlesource.com/c/chromium/src/+/769929 Bug: 785344 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id219eeaced4679eda9c26acde7fd4fdb0cb1e891 Reviewed-on: https://chromium-review.googlesource.com/786336Reviewed-by:
-
Eric Roman authored
Change-Id: Ie06e4592fdee3199466e0249592f64302f0bebd9 Reviewed-on: https://chromium-review.googlesource.com/782770Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#519454}
-
Vladimir Levin authored
This patch renames the async attribute to be the decoding attribute due to discussion on https://github.com/whatwg/html/issues/1920 This also adds wpt test for the decoding attribute R=chrishtr@chromium.org, domenic@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0524b7e3849c9a922f358c0592d34c30a7fd8914 Reviewed-on: https://chromium-review.googlesource.com/770106 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
-
khmel authored
Bug: 788308 Test: Manually in multiple chrome://settings tabs Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3c63ad6e5c6de64054c1cb10db3c744e199cea08 Reviewed-on: https://chromium-review.googlesource.com/791931 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
-
Elliot Glaysher authored
ChromeNativeAppWindowViewsAuraAsh used to directly depend on the TabletModeController instead of the mojom client. This usage needed to be protected under mash. Now that we use TabletModeClient, remove this check so we update more state correctly. Bug: 766759 Change-Id: Ib4ace7c6bc9f1a39cbf08db7a340c58a48dca6df Reviewed-on: https://chromium-review.googlesource.com/764867Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#519451}
-
Owen Min authored
When profile is loaded into memory and auth token verfication failed. All assoicated browser windows will be closed without countdown window notification. Bug: Change-Id: I61bf1cde63fdfe8bfd424b9a0e40b7f001c7f4d8 Reviewed-on: https://chromium-review.googlesource.com/777919Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#519450}
-
Trent Apted authored
I haven't been able to trigger this. I suspect there's some window not owned by Chrome being added as a child window of a window that Chrome does own. E.g. a popup window added via Services or the system "Share" options. This being destroyed could unexpectedly mutate [NSApp windows] while we are iterating over it and cause unstable behavior. Bug: 788271 Change-Id: I2a40507a6b93e1940a295c6edf3f156a4005ffb3 Reviewed-on: https://chromium-review.googlesource.com/788646Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#519449}
-
