- 09 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/81425dcacf74..aa9175d6761d git log 81425dcacf74..aa9175d6761d --date=short --no-merges --format='%ad %ae %s' 2019-10-09 treehugger-gerrit@google.com Merge "proto: Update prefix of GpuLog's Severity enum again" 2019-10-09 tneda@google.com Merge "Fixing main.cc for support passing pid and timestamps to trace_to_profile" 2019-10-09 taylori@google.com Merge "perfetto-ui: Fix small selection and search bugs" 2019-10-09 fmayer@google.com Merge "Add heap graph references." 2019-10-09 taylori@google.com Merge "perfetto-ui: Edit timeRange selection" 2019-10-09 ilkos@google.com Fix duplicate hash callsites returned 2019-10-09 eseckler@google.com Merge "processor: extract a public ReadTrace() function from shell" 2019-10-09 ilkos@google.com Merge "Heap profile callsites metric" 2019-10-09 eseckler@google.com proto: Fix GpuLog Severity 2019-10-08 chiur@google.com Merge "Add message for logging GPU message" 2019-10-08 hjd@google.com Merge "perfetto-ui: Fix ProcessScheduling track for upid = 0" Created with: gclient setdep -r src/third_party/perfetto@aa9175d6761d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:133745684 Change-Id: Ifaab94e5cbce7f89aefbb457129eeb9068a7a9d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849189Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704317}
-
Peter Wen authored
Follow-up for: https://crrev.com/c/1825572 Now that ProcessInitExceptions are no longer checked. Simply raising it is sufficient to prioritize startup errors via PureJavaExceptionHandler. Bug: 1000651 Change-Id: Ia93973e12699bca752a37ce6d2d76d1ebe3b5782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849270 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#704316}
-
BUG=762641 TBR=achuith@chromium.org Change-Id: I5272a1931c1cf787dcd296de78a70c9577efc977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850172Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704315}
-
Rohit Rao authored
If a test is specified with the --run_with_custom_webkit flag, the testrunner script will automatically set up environment variables to load the bundled WebKit frameworks. BUG=934252 Change-Id: I6c8ff3d107981f38c03163c28a56d3ff69855f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849771Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#704314}
-
Zentaro Kavanagh authored
- Adds SupportsAmbientColor() method to PowerManagerClient - Corresponding platform change [1] [1] - https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1825453 BUG=b/138731765 TEST=end to end Change-Id: I43d1532dc121b3edef099dc81bc51964b8d89f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835170 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#704313}
-
Tom Anderson authored
unity_service didn't have any dependencies on GTK, so it doesn't belong there. We want libgtkui to be as small as possible because in the future we want to have alternate implementations of LinuxUi for eg. QT5. BUG=None R=thestig Change-Id: Id056698779a7175c16a6545b8d29e023ef7a8a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846668 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#704312}
-
Robert Ogden authored
Also adds a histogram to track times when the probe succeeds after a reported failure. Bug: 1011510 Change-Id: Ia656320eeaa7edf56eb13153c09aafd643270470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849108Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#704311}
-
shrekshao authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/7c4e67f..2701c13 TBR=kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: I95e43f8b4e0cce63efd944255649c8fd433c291e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849103Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#704310}
-
Leonard Grey authored
Bug: 948878 Change-Id: I79ef6f31524cb6cbca7acab42f5b488e1b2d9524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849123Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#704309}
-
Peter Wen authored
When System#exit is used, it bypasses our normal crash reporting pipeline. Thus ban its usage in favour of simply crashing with an exception. It used to be the case that crashes before native is initialized are dropped. Since we now have PureJavaExceptionHandler this is no longer a concern. Explicit usages of System.exit(0) are allowed since in that case the intent is for a normal exit. Specific instances of System.exit(non-zero) can be allowed in a similar manner as the one allowed in this CL. Bug: 1000651 Change-Id: Ie3042ec2782dd5577636fcaec65de43d8f0990e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850352 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
Lily Chen authored
This is a reland of 8d1685b9 Problem that caused revert fixed by https://crrev.com/c/1849114 TBR=morlovich@chromium.org,mrefaat@chromium.org Original change's description: > Add CookieStore method to fetch all cookies with their access semantics > > This change adds a CookieStore method, > GetAllCookiesWithAccessSemanticsAsync, which returns a list of all > cookies in the CookieStore along with a list of the > CookieAccessSemantics for each returned cookie. These lists will be in > the same order, so that each cookie in the returned list of cookies has > the access semantics at the same index in the other list. > > This is implemented for CookieMonster only, and other CookieStore > implementations will use the default impl which returns UNKNOWN for > all the cookies. A later CL will additionally expose this method > via the CookieManager interface. > > Bug: 978172 > Change-Id: I8463806f5cc6ce6c8d200bec57bbecba5fe3aec6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846071 > Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Commit-Queue: Lily Chen <chlily@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703824} Bug: 978172 Change-Id: I199ce9f779ce1f6a9cfe52393fd50207d2782781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849143Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#704307}
-
Chris Palmer authored
This version calls `RandomValue` less often, which exercises atomics less, so should be faster. Thanks to vtsyrklevich for the idea and technique. Bug: 984742, 1006176, 1005678, 1005677, 1005248, 1005068, 1005066, 1006178, 1006071 Change-Id: I6a60e5a9b18588f56fff5b38a58c511f6ac0c850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817188 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#704306}
-
Bettina authored
This UX is not finalized yet. This is just a placeholder until the UX is finalized. https: //screenshot.googleplex.com/a1HiDCrba5o Bug: 1010764 Change-Id: I1b584cb3364f3b36ac6f25383d095099cb779392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842316 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#704305}
-
Dan Beam authored
* Show X on row hover * Show (X) (background) on icon hover * Reserve space if any 1+ matches are removable Fixed: 1002689 Change-Id: Idd1f4a623e013893d6e376eedaff3ea2ee26fdc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842622 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#704304}
-
Alex Turner authored
Given that memory cache resources are now reported to AdsPLMO, this updates the metrics to include them, versioning those expected to change substantially. Note that the bytes count will now include bytes from the memory cache so some frames that were previously ignored may now have metrics recorded. We only version the Total, PercentNetwork, PercentAds, SameOrigin and PercentSameOrigin suffixes as the effect on other metrics is small. They are versioned by appending a "2" to the name. Bug: 979249 Change-Id: Ia32eda6b8b284128bcd1ae5d3306dcf331aef245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781957 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#704303}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ef4c25e71c32..2d5c8d31972d git log ef4c25e71c32..2d5c8d31972d --date=short --no-merges --format='%ad %ae %s' 2019-10-09 cnorthrop@google.com Vulkan: Fix off by one when flushing staged texture updates 2019-10-09 geofflang@chromium.org Make sure all extension strings start with GL_ 2019-10-09 jmadill@chromium.org Add ANGLE Platform Metal extension. Created with: gclient setdep -r src/third_party/angle@2d5c8d31972d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Id2f4e002dd703ef6c2dcfcd3b7ad32dbec10c28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849590Reviewed-by:
-
Ryan Hamilton authored
This is a partial re-land of http://crrev.com/c/1825657 Change-Id: Idde7813cc214ddf6f2a0f5b15b29bbd909ff5c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849201 Auto-Submit: Ryan Hamilton <rch@chromium.org> Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#704301}
-
Lily Chen authored
This should fix a crashing CHECK in InlineLoginHandlerChromeOS:: CompleteLogin() which was checking for an oauth_code cookie that could not be gotten with the default CookieOptions (under SameSiteByDefaultCookies) but can be gotten using an all-inclusive CookieOptions. Test: On a Linux-Chromeos build, run using --login-manager, custom --user-data-dir, and --enable-features=SameSiteByDefaultCookies. There should not be a crash when adding a user account. Bug: None Change-Id: Idc54e03e704d14391840a42bad6fadc3e2d96f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850051Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#704300}
-
Frank Liberato authored
There's no need to send the texture target into D3D11PictureBuffer since it's not used by the video decoder anyway. The only texture wrapper that cares ignores it anyway. This should be handled by the texture wrappers, since we'll want different targets for copied vs bound pictures. If anything needs the target, then we should let PictureBuffer::target() ask the wrapper for the output texture's target. Change-Id: I65cf50116ae6e3fb2a1a310c0bf01896619e69f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849182Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#704299}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0aff71c3..5c5de38d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4e2b9163f82129645b958d009245919f54069a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850252Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704298}
-
Jazz Xu authored
This issue is caused by an ActionButtonVisibilityUpdate at the end of SetIsPlaying - This will make all buttons invisible at the beginning of a new media session when receiving MediaSessionInfoChanged, then MediaSessionActionsChanged will update button visibility immediately after that, which is causing the flashing issue. Bug: 1011160 Change-Id: I0f08fc77874641fd44025aae1c29f1cebeacdeb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838385Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704297}
-
Henrique Nakashima authored
Resources should not be retrieved using getApplicationContext(). Different activities may have different resources. Change-Id: Idcebd0060b2d19cda81416217be90b4b4a7ccee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846095 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#704296}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/be83c310e3d5..baaf6bec019f git log be83c310e3d5..baaf6bec019f --date=short --no-merges --format='%ad %ae %s' 2019-10-09 ehmaldonado@chromium.org git-cl: Use buildbucket v2 to fetch tryjob results. Created with: gclient setdep -r src/third_party/depot_tools@baaf6bec019f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:976104 Change-Id: Ic419d820ceeb57a97ae9a8718fe74d2942a1c92c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850274Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e74b5c944eda..df24b8a36099 git log e74b5c944eda..df24b8a36099 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 dproy@chromium.org Do not crash update script for missing build Created with: gclient setdep -r src/third_party/catapult@df24b8a36099 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1012741 Change-Id: I7726db1c12040bc89286734931602d3bdd9b003a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849188Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/955f8fd0477e..5963c7cf0a70 git log 955f8fd0477e..5963c7cf0a70 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 ilnik@webrtc.org Count disabled due to low bw streams or layers as bw limited quality in GetStats Created with: gclient setdep -r src/third_party/webrtc@5963c7cf0a70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I4ffd1d44f43c044ba0234ee26cbb4d4f39a93c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849589Reviewed-by:
-
Peter Boström authored
Replaces kHighlightPathKey setting for CustomShapeButton child classes. Bug: chromium:1007546 Change-Id: I5374a57ac2f6ae4963487a34aabca8a7a0613978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848476 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#704292}
-
Maks Orlovich authored
At this point only a few tests and the fuzzer use it, so it's just wasting codespace (mostly with metrics strings + code) Change-Id: I4ab2191be7a1171eb985419d36a0343068383a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849216Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#704291}
-
Xinghui Lu authored
Tested on local build. First focus on a password field and check request outcome is SUCCEEDED. And then open another tab and load the same url, focus on a password field and check request outcome is RESPONSE_ALREADY_CACHED. Bug: 995926 Change-Id: I6870ad6a7b933ec6fd60e74fc0fff50a4bffeccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846552 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#704290}
-
Joshua Peraza authored
Change-Id: I504212d4ad0a51edf6aad8df9f5bde79f84b782d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849267Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#704289}
-
Jaeyong Bae authored
It might make sense to move the static merge functions to autofill_profile_comparator which has functions related to merge logic. Bug: 913940 Change-Id: I737280fa84703280f2f081c4c022b8e167461b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846628 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#704288}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2545d011. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Idce94e2dee2f7fc49217f7d2806495626993a7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850171Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704287}
-
Rohit Rao authored
If --run-with-custom-webkit is passed on the commandline, WebTestSuite (gtest) and ChromeTestCase (egtest) will verify that the custom-built WebKit frameworks were loaded, as opposed to the system-provided frameworks. This will provide a loud warning when the frameworks cannot be loaded, since otherwise tests would pass silently using the system frameworks, which is not what we want. BUG=934252 Change-Id: I684e9ced303d36d1019714e3c807862eb2803f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850011 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Eric Roman authored
Change-Id: Iaf2e31c32df0f73a3cc55c42afef3408387804fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848417 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#704285}
-
Sahir Vellani authored
Remove checks in scrollbar.cc for kScrollbarInjectScrollGestures as it is shipped on-by-default to stable release. Remove the flag and all references to it. Bug: 1010668, 954007 Change-Id: If72137f6e6c1a77247ec354a076826205984fec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842317 Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704284}
-
Sigurdur Asgeirsson authored
Bug: 953031 Change-Id: I1f74e20583840d40ab8d2c99c86f44125bad7143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845966 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#704283}
-
Nate Fischer authored
No change to production logic. This fixes a crash in AwBrowserContextTest. The issue was the second test in the suite (regardless of what that test did) would crash as soon as the setup constructs a TestContentClientInitializer. This is because a posted task created a NetworkConnectionTracker, running after TestContentClientInitializer's destructor nulled it out. It's invalid to re-set a NetworkConnectionTracker without first clearing it, triggering a DCHECK. We avoid this by pumping through the UI thread looper during the test teardown, so we're sure the background task has executed prior to destroying TestContentClientInitializer. This also fixes a memory leak in the test setup/teardown (we need to clean up the AwBrowserProcess instance), although this was unrelated to the bug. Bug: 990547 Test: run_android_webview_unittests --num_retries=0 --gtest_filter=AwBrowserContextTest.* Change-Id: I16d03a1cf6d813b7052b8205d2936864397fc21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849174 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#704282}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=tdresser@chromium.org Bug: 1007760 Change-Id: I52907b719b57b5adef468b020a6ddce0961c4330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849487 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#704281}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e27a503a0a21..2579de4567d5 git log e27a503a0a21..2579de4567d5 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 robertphillips@google.com Tighten up creation of the GrProgramDesc and remove some unnecessary checks 2019-10-09 kjlubick@google.com [canvaskit] Update to build with emscripten 1.38.47 2019-10-09 bungeman@google.com Retain hints when subsetting for PDF. Created with: gclient setdep -r src/third_party/skia@2579de4567d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:1010396 Change-Id: Ibaab7478618e595bb635c1742a31defd34b185b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849180Reviewed-by:
-
Etienne Bergeron authored
The VR code is using the default font "sans-serif". The Font (and FontList) on that platform is the PlatformFontSkia When creating the font with the literal "sans-serif", there is not matched typeface. The function creating the typeface has a fallback path that try "sans" which is the resulting typeface used. see: https://cs.chromium.org/chromium/src/ui/gfx/platform_font_skia.cc?l=53 This CL avoid to use that fallback logic. Instead, we rely on the FontList behavior to use the default system font with the default constructor. R=alcooper@chromium.org Change-Id: I612502f32d77787b8f0346c0fc23cd65b68e3013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847902Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#704279}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b91063d99c88..ce36989ab9e3 Created with: gclient setdep -r src-internal@ce36989ab9e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8c7e4f604307c5350c1629df40369177a905d7dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849186Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704278}
-
