- 19 Feb, 2020 40 commits
-
-
Yutaka Hirano authored
Use weak ptr to avoid use-after-free. Bug: 1053700 Change-Id: I2c9bfc022535923d0a5841775e3a65a1e5e21e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062842 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#742518}
-
Alan Cutter authored
This CL rewrites some of the SystemWebAppManagerBrowserTest code to use web_app::AppRegistrar instead of the Extension interface. This is necessary to migrate web apps off the Extension system. Bug: 1052348, 876576 Change-Id: If75fdbb1c25b089961b40f47a48d09a8f3ffcdd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059356 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#742517}
-
Eriko Kurimoto authored
This CL adds design docs for ES modules for dedicated/shared workers. Bug: n/a Change-Id: I93b1ec931a05ffadb139ca37438a0d95b92ccb53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061917 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#742516}
-
Alan Cutter authored
Prior to this CL, mixed-security content was blocked entirely in standalone PWA windows with scopes. This CL allows those PWAs to display mixed-security content, but when this happens, the window will show the CustomTabBarView with the URL and a "Not Secure" indicator to indicate the presence of mixed content. Screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=432401&signed_aid=JeW6cXlVCQ3bSebdZ-FoJg==&inline=1 This removes a behavioural difference between promoted PWAs and "create shortcut" apps without manifest scopes. Bug: 910016 Change-Id: Ic9b3bbdba14218bb1ad8fd4f2ca8cf47cd4e3a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041380 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#742515}
-
Jiewei Qian authored
This CL is a preparation to perform App (tab) specific setup when the app is launched. WebAppTabHelper will determine the AppId right before the navigation is to be committed. It is okay to do this because DidFinishNavigation is always called right after ReadyToCommitNavigation. So we will end up navigating to the page, thus this change will not lead to behavior differences. Bug: 1024655 Change-Id: I3be85ae7e0ba5b87c25a150207a8b35468a60bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059694 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
After the following change, DevTools support for the XHR replay feature with Blink CORS was partially removed. https://chromium-review.googlesource.com/c/chromium/src/+/2051443 Blink CORS is still alive behind an enterprise policy, but this change will be acceptable. NOTRY=true TBR: jarhar@chromium.org Bug: 958524, 780935 Change-Id: Ieb18c3204efff3eb50ca4fccd21869fb35bd91a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062118Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#742513}
-
Anders Hartvoll Ruud authored
A few token types are not allowed in <any-value>, and therefore ConsumeGeneralEnclosed must return kParseFailure rather than kUnknown if these tokens are observed. Change-Id: Iedcf120739d2a65d24b047286da66f8a435ebf7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057124 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#742512}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f5ddd865. With Chromium commits locally applied on WPT: ec83d167 "Update performance.measureMemory to the latest proposal" d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I051a91661e45232127afecc4762b7ce6c623e075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063751Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742511}
-
Takashi Toyoshima authored
Mark shared-worker-redirect.html tests as [ Failure ]. These tests started showing console error messages for the worker script fetch failures only in Blink-CORS. NOTRY=true Bug: 1050438 Change-Id: I8a11ec7897d0ba9627d51db547fdd40fe4b4197f TBR: elkurin@google.com, nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063559Reviewed-by:
-
Anand K. Mistry authored
This name is constant and needs to be used by both the browser and smbfs. The appropriate place for this is in the mojom file. Bug: 939235 Change-Id: I8710ca0ddf9a0ef9fc1abaa0e1a08b9204687355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062109Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#742509}
-
bttk authored
Bug: 1046181 Change-Id: If3d75174b0d6855b948005c2442528c9de39f557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024567 Commit-Queue: David Trainor <dtrainor@chromium.org> Auto-Submit: bttk <bttk@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#742508}
-
Miyoung Shin authored
This CL converts FrameHostMsg_UpdateFaviconURL to mojo and removes WebLocalFrameClient::DidChangeIcon and WebLocalFrame::IconURLs and WebIconURL class and content::FaviconURL class. Bug: 1040099 Change-Id: I109b0dc165d2a268dacf1c38b26341eafc128382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043181 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#742507}
-
Ben Joyce authored
We migrated to AndroidX, and there was a proguard rule to keep the old version. Need proguard rule to keep the new name space's version. Bug: 1052855 Binary-Size: Added proguard rule to keep AndroidX's AppBarLayout. Change-Id: I56f7a40d7b368e3c5e521324352053c918ac327b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062916 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Mia Glaese <glamia@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#742506}
-
Xianzhu Wang authored
This simplifies the logic to determine 2d translation optimization, especially when to avoid it for transform animations, to ensure that we always use matrix instead of 2d translation when there is transform animation. This is one of the preparation CLs for considering animations in overlap testing for CompositeAfterPaint layerization (crrev.com/c/2057868). Change-Id: I303aadc11b47f56041e4de0b18874eadba720416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059488 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#742505}
-
Demetrios Papadopoulos authored
This CL removes a lot of redundancy from site_settings_page.js both in HTML and in JS. Specifically: 1) Using dom-repeat eliminates redundant HTML code 2) The introduction of the |categoryList| makes populating the |focusConfig| trivial 3) Fetching default values for each permission category type also becomes simpler. Moreover the programmatic approach is more flexible and should make the upcoming "Friendly Privacy Settings" changes easier to implement, by allowing splitting the permissions list in two parts programmatically in JS (no more redundant dom-if expressions). Bug: 1032584 Change-Id: I64b79c2f01e591484f885a984b20d1aa66b58361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058064Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#742504}
-
Hiroki Sato authored
This is a follow-up of httep://crrev/c/1964835. This changes 1. rename DesktopAutomationHandler.onEventFromView to onLiveRegionChanged because this method is now not only from Views but also from ARC's live region change. 2. When LIVE_REGION_CHANGED event is handled, do not uodate focus range. Bug: none Change-Id: I2923e217f0177395bb5e2e4b7b34726a9408ccce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056168 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#742503}
-
David Grogan authored
Purely bookkeeping. Bug: 762679 Change-Id: I0d04bd344603ae55cfd3c68fb5c3f66bf890d4d4 Fixed: 1052683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062891 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#742502}
-
nancy authored
BUG=1016159 Change-Id: I7aa2dd56dd0e9ce50afc8f5162e3f2531247b9b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061916Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/515e6dafedc4..9508452e18f1 git log 515e6dafedc4..9508452e18f1 --date=short --first-parent --format='%ad %ae %s' 2020-02-19 crouleau@chromium.org [Catapult] Make Deep a top-level owner. 2020-02-19 ukai@google.com add new origin trial tokens for chromium-build-stats Created with: gclient setdep -r src/third_party/catapult@9508452e18f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1050215 Tbr: wenbinzhang@google.com Change-Id: I05c2100baf8dda45e726be6d244960182e5acd86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063874Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742500}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6caa2be2..8962e435 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ied1ab5b05b8bd6e4773005c61b9d0a795b07e750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063450Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742499}
-
Oriol Brufau authored
The test was marked as failing but was passing. BUG=868380 Change-Id: Ie54019bf9fbc2e08f6504c47d3751efdae79cf02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062435Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#742498}
-
Anand K. Mistry authored
In certain cases, the smbfs daemon isn't able to resolve some hosts to IP addresses (i.e. multiple networks connected, netbios). Bug: 939235 Change-Id: I638939333b5cd87909bb6738ad963e8f98187564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050001 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Reviewed-by:
-
Alex Danilo authored
The clear button for the search entry field is absolutely positioned and was using display 'block'. Side effect of that is that the ::after tap target is positioned incorrectly relative to the button location. Change the clear cr-button to display 'flex' which lets the tap target pseudo-element center correctly. Moves 3 CSS properties into alphabetical order to satisfy presubmit. Bug: 992823 Change-Id: I7066130f636372d59b956e1061a39ad794dbc354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063193 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#742496}
-
Matt Falkenhagen authored
It no longer runs network service tests. Bug: 1049487 Change-Id: I8ef40b7bce48aac680c51af47c5187890d795b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060357Reviewed-by:
-
Rachel Sugrono authored
Change-Id: Ifb6a94187b2baa612ce9595bf1e2213c7cf13dc5 Bug: 992824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063552Reviewed-by:
-
Alex Danilo authored
For files-ng, when the search box is active it needs to be spaced 16px away from the buttons that follow it on the action bar. Adds a 16px margin when the search box is open. Bug: 992823 Change-Id: If95881c9f8dd29df0e230983768dbfe208371ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062846Reviewed-by:
-
Emily Stark authored
External protocol dialogs display the origin that initiated the external protocol request. The initiating origin helps the user attribute the request to a particular site, so that they can decide if they can trust that site to launch an external application. When the initiating origin was opaque (such as from a sandboxed iframe), the dialog would display no origin or a generic message, so the user didn't have any information for making a trust decision. This CL converts the initiating origin to its precursor origin (the origin that created the initiating origin) when creating the external protocol dialog. Displaying the precursor origin gives the user more useful information for making a trust decision. Bug: 1041749 Change-Id: I0b21d20e13d7d71db361746dbb18df8d980339bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063420 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#742492}
-
Jeremie Boulic authored
cr-link-row closing tag should go on the next line. Bug: 1051364 Change-Id: Iec1ff9adcc55a64c9ada1f18da51d06307423834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059829Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#742491}
-
Isabella Scalzi authored
Now that piexloader supports using a RAW image's "thumbnail", add a Quick View test using a RAW .NEF file containing only a "thumbnail" image. Because the image has an orientation in its metadata, it should render rotated 90 degrees clockwise. Also test that the dimensions shown in the metadata box reflect the rendered orientation of the test image. Bug: 1039141 Change-Id: I9ac567c3b7af79ef68d2d463ab47ad7844c533d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063612 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<PointerEvent> and DynamicTo<PointerEvent> as new downcast helper 2. Use IsA<PointerEvent>(element) in place of IsPointerEvent(element) Bug: 891908 Change-Id: I3c7521aefd080d6a7505212a39d0f99c2ea8b2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019746Reviewed-by: -
Victor Costan authored
This CL is a follow-up from the review on https://crrev.com/c/2052251. Bug: 989611 Change-Id: I251fc8bb4cda138bc0bc94701efc09dc9553650f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058008 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#742488}
-
Joey Scarr authored
Bug: 1007686 Change-Id: I806d9c065a0ddc89d74ab6f9d382388b976d3560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059750 Commit-Queue: Joey Scarr <jsca@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Daichi Hirono <hirono@chromium.org> Cr-Commit-Position: refs/heads/master@{#742487}
-
Alex Danilo authored
Bug: 992823 Change-Id: I43c39021345ef23f4274d203d817e66b11525074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060405 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Alex Danilo authored
Stops the underline being drawn in the cr-input element by setting the input focus color to transparent. Enables the caret to be visible by targeting the input element using the ::part() pseudo-element since the underline and caret are both managed by '--cr-input-focus-color' for -cr-input elements. Bug: 992823 Change-Id: I6f86b723c84662ff5923d50433751b74d7e7ab58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061570 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/123fd97000bb..fa9eff37c38a git log 123fd97000bb..fa9eff37c38a --date=short --first-parent --format='%ad %ae %s' 2020-02-18 shawn.p.huang@gmail.com Disable GL_EXT_semaphore_fd for Mesa version < 19.3.5 on AMD GPUs Created with: gclient setdep -r src/third_party/angle@fa9eff37c38a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1053516 Tbr: cwallez@google.com Change-Id: I624b38c938b8f18e88cec61c39ac56db6f11f33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063096Reviewed-by:
-
matterchen authored
Due to the spec change of not forwarding "active" ports on container start up, we have removed the active state in prefs as it is not required anymore. This change removes the active pref, resulting in changes to fit the new context such as: on deactivate all ports, we just need to remove ports from our lifeline fd map. Bug: 848127 Test: crostini_port_forwarder_unittest.cc Change-Id: I19ad693682122f1edd47c8a21fff5b69780fb4c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063191Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Matthew Chen <matterchen@google.com> Cr-Commit-Position: refs/heads/master@{#742483}
-
Daniele Castagna authored
TextureLayer::SetVertexOpacity is not used anywhere outside tests. This CL removes it. The final goal is to get rid of vertex_opacity in viz:TextureDrawQuad that affects the size of QuadList. Bug: None Change-Id: I584dc3315b7a5d26e57ed067f2974866bef5d284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059788 Auto-Submit: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#742482}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a48a607cba32..333b29e11603 Created with: gclient setdep -r src-internal@333b29e11603 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:149759085 Tbr: jbudorick@google.com Change-Id: I4c5c4eda17ca9541d0ed54e206e39d37ac181c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063095Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742481}
-
Peter Kotwicz authored
This CL: - Daggerizes: - WebappDisclosureSnackbarController - WebappActionsNotificationManager - Moves the management of the following classes out of WebappActivity/WebApkActivity and into WebappActivityCoordinator/WebApkActivityCoordinator - WebappDisclosureSnackbarController - WebappActionsNotificationManager - WebApkUpdateManager - Introduces new class - WebappDeferredStartupWithStorageRegistrar - for getting notified once the WebappDataStorage has been fetched (and potentially created) during deferred startup. BUG=1042147 TEST=WebApkInitializationTest Change-Id: I98ea759d4f1186da4e58d899aab6f3aec2caaecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005976 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#742480}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1fbe7c0bb24b..10e0e6d6c19a git log 1fbe7c0bb24b..10e0e6d6c19a --date=short --first-parent --format='%ad %ae %s' 2020-02-19 tandrii@chromium.org Roll bb tool to @ 37d99607 Created with: gclient setdep -r src/third_party/depot_tools@10e0e6d6c19a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1052637 Tbr: agable@chromium.org Change-Id: I8e0d987ad297d1c4d2067a8c9bac2b0b6c4d6037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063098Reviewed-by:
-
