- 23 Apr, 2020 40 commits
-
-
Garrett Beaty authored
This simplifies the process of updating the buckets by moving the defaults to a common location and highlighting the differences between the versioned and master-only settings. Each file is no longer relying on scoped defaults being set by another file executing it. It also has the benefit of being able to see what is different between the branches by doing a simple diff of the bucket files. Change-Id: Ifc08e477c1d212a68f6cbe016ca93c4f1176501e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158917 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#762073}
-
Lijin Shen authored
1. Fix some typos. 2. Some links are out-of-date. Bug: 775198 Change-Id: I11d56530427d61c727ece0c8632d40b7e8faca9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163627 Auto-Submit: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#762072}
-
Dominique Fauteux-Chapleau authored
This makes OnFileAttached an alternative to legacy policies to configure scanning settings. This is gated by a new feature. Bug: 1067631 Change-Id: Ib97200da493176a7a4254d2f891c1625c85d42cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162268Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#762071}
-
Evan Stade authored
This relands commit c71eaf36. difference to original: leave a temporary ChannelDefinitions.java behind so the clank compile doesn't break. Original change's description: > Componentize ChannelsInitializer > > ChannelDefinitions is made into an abstract class that exposes > functionality to ChannelsInitializer, and defines useful types like > PredefinedChannel. The channel definitions themselves live in the > Chrome subclass, ChromeChannelDefinitions. Some of these definitions > will be duplicated later for WebLayer. > > ChannelsInitializerTest uses ChromeChannelDefinitions so it's left > in //chrome. (We could replace ChromeChannelDefinitions with a > TestChannelDefinitions, but that would reduce coverage of production > code.) > > Both the channel IDs and the channel group IDs will have to be different > for WebLayer. It would be possible to account for this in code by > judiciously prepending "org.chromium.weblayer.", and then keeping > the channel definitions together, but that was both more complicated > and seemed more error prone, as it would mean that the > ChannelDefinitions.ChannelId type would no longer represent the Android > system notification channel identifier. For example, code that used > NotificationManagerProxy.getNotificationChannel() would have to be > careful *not* to pass ChannelDefinitions.ChannelId without adding a > prefix. In Chrome, which has no prefix, this would succeed, but in > to-be-shared code, such as NotificationCompatBuilder, this would succeed > for Chrome and fail for WebLayer. > > Bug: 1069895 > Change-Id: I55890466797aafc34ef8a821a1cb43de8e3d03ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150066 > Commit-Queue: Evan Stade <estade@chromium.org> > Auto-Submit: Evan Stade <estade@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#761922} TBR=dtrainor@chromium.org,peter@chromium.org,xingliu@chromium.org Bug: 1069895 Change-Id: I55cda0a935c2bc204e2ed00d4f6b64997c879843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163407Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#762070}
-
Elly Fong-Jones authored
This change adds a new test that covers the behavior of the button row, as a prerequisite to a refactor of the button row's implementation. This test does overlap with some of the other tests in this suite, especially the button width linking tests. Bug: 1011446 Change-Id: Ib7b60dbed5725f6e26a063bd851911d85cba53ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163394Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#762069}
-
Maggie Chen authored
GpuInfoService is used for GPU info collection and is running on the short-lived info-collection GPU process only. This CL separates GpuInfoService from the regular GpuService because it is not running on the same GPU process. Bug:1048903 Change-Id: I6f11cbfec8b17d4e5c4ac9865b26542aa6dd619d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154388Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#762068}
-
Yulun Wu authored
Enabling shelf controls disables gestures and should hide contextual nudges related to gestures. This CL changes the back gesture nudge controller to observe the shelf config and hide/disable the nudge when shelf controls are enabled. Bug: 1071248 Change-Id: If43f22bb108660f8725b6d660e849d0317ddcd7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161734Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#762067}
-
Dan Harrington authored
And fix a couple things. We should now be able to fetch content from the production server. - Set app_type back to TEST_APP - I've replaced the old test feed query response with a new one from the new server. I've hand-edited the response to remove content that might be copyrighted, but it's unchanged other than that. - Use our proto-printers to simplify the stream_model_update_request_unittest - Add more .sh scripts to translate protos, making them all pipe stdin/stdout. Bug: 1044139 Change-Id: Ib0053471ff732b3f4d6fe6ef653c17c41769ce62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154811Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#762066}
-
Victor Costan authored
Our two flavors of sqlite_shim.c #include rename_exports.h and sqlite_shim_fixups.h. These dependencies need to be recorded in BUILD.gn, so incremental builds work correctly. Change-Id: I13f3eaf26bdfaaf0be2d458eae07e7d9281833ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162046Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#762065}
-
Joe Mason authored
Bug: 1065879 Change-Id: I05ca50043d8efbcdc3ae6d4767fb289162d85198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127911 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#762064}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/dc688a2f5c55..ba47db02daff git log dc688a2f5c55..ba47db02daff --date=short --first-parent --format='%ad %ae %s' 2020-04-23 amaiorano@google.com Kokoro: fix SWIFTSHADER_LESS_DEBUG_INFO not being set Created with: gclient setdep -r src/third_party/swiftshader@ba47db02daff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Iac1d08a428e6a7215b83bcac6dee427ac56f1c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163451Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762063}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0f15c2729b8c..7a0b07a8a543 git log 0f15c2729b8c..7a0b07a8a543 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 brucedawson@chromium.org Fix slash direction sensitivity in git cl owners Created with: gclient setdep -r src/third_party/depot_tools@7a0b07a8a543 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1009104 Tbr: agable@chromium.org Change-Id: I0d1b9ae8a2a295995a46aace214e7b8d93dea047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163453Reviewed-by:
-
George Steel authored
This test was running with an average speed close to its timeout and was occasionally exceeding it, causing flakes. Marking it as slow as per wpt guidelines. Bug: 1073460 Change-Id: I2028d64ed727242ec3873c5172a08ecebbc45a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163395 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#762061}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5d77448b5f68..ee97fa3e34e3 git log 5d77448b5f68..ee97fa3e34e3 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 tvanderlippe@chromium.org Add ts_library definitions and ts-nocheck for Karma tests Created with: gclient setdep -r src/third_party/devtools-frontend/src@ee97fa3e34e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1061125 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id906789ef4e3eadb763e10189e92c2af8f9d3937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163449Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8094fa603805..255d5014a0f2 Created with: gclient setdep -r src-internal@255d5014a0f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1029357,chromium:1072472 Tbr: jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com Change-Id: I02039dfb24274701001f60caa114da3e2c4c0a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163446Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762059}
-
John Lee authored
Screenshots of the more complicated changes: https://imgur.com/a/9rTOCeK Bug: 973674, 686905 Change-Id: Id55a0676982ffc46fca0d4d1edbb33b55e068218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154226 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#762058}
-
Anders Hartvoll Ruud authored
This CL adds tests to ensure that transitions work as expected with @property. The most "unique" case related to @property is perhaps that re-declaring a custom property with a different initial value can actually start a transition. Bug: 973830 Change-Id: Ib97837e6dcf53af7fbfbaa8ff258d3e3041001eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161825 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#762057}
-
Kurt Horimoto authored
This CL updates the app launch confirmation overlays to use the new AlertRequest and AlertConfig objects. This allows for the removal of the app launcher overlay mediator, allowing the app launch confirmation dialog to use the shared AlertOverlayMediator implementation. Bug: 1071543 Change-Id: Ic0548bbdeb728a9465fe013e1201e434413386f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155475 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#762056}
-
Hans Wennborg authored
This removes the dependency on the large logging.h header for code that just wants to use these macros. Bug: 1031540 Change-Id: Iead12cd42ab634abc0ca442a0716999536d83ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161035Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#762055}
-
Toby Huang authored
ChromeManagementAPIDelegate::EnableExtension() is shared by both regular and supervised users. This function calls SupervisedUserService::AddOrUpdateExtensionApproval() which triggers the kSupervisedUserApprovedExtensions syncable pref and the SupervisedUsers.Extensions UMA histogram. Place guards in AddOrUpdateExtensionApproval() and RemoveExtensionApproval() to only permit supervised users. Bug: 1073722 Change-Id: I16d73056d1002ce33d68705e7ceed3f6f961c9df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162134Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#762054}
-
Roman Aleksandrov authored
Bug: 1073854 Change-Id: I0cfca81ac652f3f8f9743efcf3c39371dd860a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162606Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#762053}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7e972be1216d..c9e28b1463c3 git log 7e972be1216d..c9e28b1463c3 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 sgilhuly@chromium.org Use dawn_has_build in dawn_component Created with: gclient setdep -r src/third_party/dawn@c9e28b1463c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1072449 Tbr: cwallez@google.com Change-Id: I883ed41b45f4f621bc0262b21094f86d48e730b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163454Reviewed-by:
-
Robbie McElrath authored
This CL moves all strings referenced by Clank's Site Settings UI to //components/browser_ui in preparation for moving the entire site_settings package to that component. Bug: 1058595 Change-Id: Iaa14adec41f5db6734a5692f0de486e6114d2eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155396 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
Jeremy Roman authored
This is not critical enough to log at the ERROR level for all Chromium builds, and in practice it ends up appearing when a tip-of-tree Chromium build is run under Chrome Remote Desktop. There are already also UMA histograms that gather this in the field. Change-Id: If272b274d6a57f514e11c9b81ba2a0217cc2bbfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156602 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#762050}
-
Olle Liljenzin authored
Reset weak pointers before signaling work is done. Otherwise it will be a race, where the main thread could destruct the factory before the weak pointers get destructed after being dereferenced on the other thread. Bug: 1071409 Change-Id: I8f06592b09bddb325270ef5e09d6c5a1eb2dac19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159708 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5fc5c8128ce0..513720f28ece git log 5fc5c8128ce0..513720f28ece --date=short --first-parent --format='%ad %ae %s' 2020-04-23 scroggo@google.com Move SkFrontBufferedStream into Android-only dir 2020-04-23 mtklein@google.com spill oldest reg 2020-04-23 egdaniel@google.com Set pipeline and related state on d3d command list. 2020-04-23 csmartdalton@google.com Move tessellation wedges to cubic the buffer 2020-04-23 robertphillips@google.com Allow SkThreadPool to be non-borrowing 2020-04-23 csmartdalton@google.com Remove tessellate/GrPathParser 2020-04-23 csmartdalton@google.com Update GrTriangulator to count curves 2020-04-23 westont@google.com [roller] Upgrade to CMake 3.13.5 to unbreak Swiftshader roller. 2020-04-23 senorblanco@chromium.org Dawn: fix SamplerDescriptor params. 2020-04-23 mtklein@google.com general dst() aliasing 2020-04-23 egdaniel@google.com Add GrD3DRootSignature class and support. Created with: gclient setdep -r src/third_party/skia@513720f28ece If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jcgregorio@google.com Change-Id: I43d72e84cbed0036dd95994ffbe4d67f8f82ccb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163447Reviewed-by:
-
Jeremy Roman authored
This reduces noise due to this warning, which can happen on the order of 10 times at browser launch and more times thereafter. Change-Id: Iecdb28d995eb5867a506f84112ef8fcf8794dbce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160037Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#762047}
-
Bin Wu authored
https://quiche.googlesource.com/quiche.git/+log/f738fbde1726..b4810d5b775c $ git log f738fbde1..b4810d5b7 --date=short --no-merges --format='%ad %ae %s' 2020-04-23 wub Add QuicHash(Map|Set) as a general-purpose hash map and set, which doesn't gurantee pointer stability. And switch to QuicHashSet in various places. 2020-04-22 dschinazi Introduce TlsChloExtractor 2020-04-22 renjietang Make transport_params in SessionCache a const reference, because it should always be present. 2020-04-22 dschinazi Make ALPN an array in QuicBufferedPacketStore Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=bnc@chromium.org Change-Id: I57fd95bcc3a33ced3ac829336326d0f34b315302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163365Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#762046}
-
Mason Freed authored
This case was not previously tested. Bug: 1042130 Change-Id: I5874bc08abba57b6d5150ab8ae772ecec6113b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161767 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#762045}
-
James Cook authored
Add a new ShelfItemType for TYPE_LACROS_BROWSER, following the pattern of TYPE_BROWSER_SHORTCUT. Wire it to its own ShelfItemDelegate in //chrome/browser/ui/ash. For now, the icon does nothing when clicked. We need to wire it to upstart to actually start the browser. Bug: 1072472 Test: manually deploy to device, two browser icons appear Change-Id: I12578745f627df4452fcd99fe41716eedfb834d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155991 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#762044}
-
spdonghao authored
Bug: 1071503 Change-Id: Idf2067f16cbdb4970965ddea980b5679621613cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149514Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#762043}
-
Xing Liu authored
Removes unused code for image cache, we use components/image_fetcher now. Bug: 1058534 Change-Id: I2f33cd418249d1770dd44f8cbb381f9c718f8553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162108 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#762042}
-
Tarun Bansal authored
Remove data reduction proxy features that are no longer in use. Change-Id: I1856baf0cb4239a84d30bd7bdfb2268beb0364b8 Bug: 1073611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161584Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#762041}
-
Gabriel Charette authored
Leaving it there resulted in it being picked up on urelated stacks. R=ajwong@chromium.org Bug: 1073500 Change-Id: If8816da156e89122d3c599e1f355e9d6703940b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161465 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#762040}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7fc367463824..bb3010037266 git log 7fc367463824..bb3010037266 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 eseckler@google.com Merge "processor: Migrate more TrackEvent arguments to reflection-based parsing" 2020-04-23 eseckler@google.com Merge "processor: Fix 3 clusterfuzz-found issues related to TrackEvent parsing" 2020-04-23 ilkos@google.com Merge "Add ion_stat to config muxer for memory" Created with: gclient setdep -r src/third_party/perfetto@bb3010037266 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ifc2d084df5f5266d42faa3edb943a4f134cd8e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163448Reviewed-by:
-
Yi Xu authored
fix canvas-getImageData-large-crash.html always passes: it passes regardless if any exception is thrown. Remove test. Bug: 1073721 Change-Id: I5abde013194b45e3804ac2c215c5b2c79614c29a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160346Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#762038}
-
Sergey Kipet authored
Building the Chrome browser configured to engage the Ozone/Wayland as its backend by using the gcc compiler collection is failed due to the 'declaration changes meaning' compile-time error. This CL fixes the error and gets the sources compiled by both modern compilers - clang and gcc. Bug: 1073877 Change-Id: Ib6e480e9b3d1b9dfc3640909b2b3dd1c78cdb7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162865Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#762037}
-
Andrew Grieve authored
Rather than generating a different ${Foo}Jni class for every target when use_hashed_jni_names=true, also have classes use org.chromium.base.natives.GEN_JNI. Then, at the final step, have GEN_JNI forward calls to J.N.$HASH. Makes a bit more work for R8 (it needs to inline all the GEN_JNI methods), but move the "hashed functions" logic to live in one spot at the end of the pipeline. A byproduct of this is that toggling use_hashed_jni_names no long requires all libraries to be recompiled (attached bug) Bug: 1073921 Change-Id: I8df7c751b51d60e878f270c06e2e979dd9dbc821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162109Reviewed-by:Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#762036}
-
Mugdha Lakhani authored
Before this change, the browser process would crash if the SecurityStateClient wasn't set early in the startup path. This change makes having a SecurityStateClient optional for the embedder and defaults to the components logic to get security level. Bug: 1052375 Change-Id: I7336e375908137aed3187debddd3860b7d657e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162985 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#762035}
-
Naomi Musgrave authored
Clean up crypto import, since uses of crypto::ECPrivateKey were removed in change I153949d11b923131b404ee603a6d885aec57706d Bug: 1012226 Change-Id: Ic698f872e6441894e4330fb784609aba72d25ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161827 Auto-Submit: Naomi Musgrave <nmusgrave@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#762034}
-
