- 13 Nov, 2020 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/180faebe8827..bee6408d7b67 2020-11-13 hta@webrtc.org Introduce length checking of all STUN byte string attributes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1144646 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If77a043ede7056b4cae2b7b5a63715db92f56a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537910Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827281}
-
Clemens Arbesser authored
- Persist status message and progress bar between trigger script and regular script. - Stop the trigger script on empty server response. Bug: b/173106457 Change-Id: I843a5c18d09143fffaebf742f50005edb79574f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534934Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#827280}
-
Alexander Cooper authored
Construction logic is defined: https://immersive-web.github.io/layers/#dom-xrwebglbinding-xrwebglbinding Change-Id: I01fa10b1d1413a70150134e2423630dc4d0546a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536038 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#827279}
-
Tanmoy Mollik authored
Refactor BookmarkPersonalizedSigninPromoDismissTest to use AccountManagerTestRule and ChromeActivityTestRule instead of SyncTestRule so that it can be batched easily. Bug: 1145843 Change-Id: Ia005508ccd84c439b04b25a65af0930b5a15ee0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527021 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#827278}
-
Roman Arora authored
Adjust Tab search dark mode colors to meet WCAG requirements. - Selection/Hover colors now match Omnibox colors. - Fix non-existent variable name Screenshots: Before: https://drive.google.com/file/d/1BMIahHv0hNaxuXuAtk228QgGPip9HKJR/view?usp=sharing After: https://drive.google.com/file/d/16fnTW0bLdwRDp2_VCe3IzuOTsOniGL2k/view?usp=sharing Bug: 1110109 Change-Id: I087c49a9b98da70ab59f2e433f1487ec1ac008d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533674Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#827277}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I6aa9bff3c0e77769352cd04ad853c1a179f40807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537750Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#827276}
-
David Bienvenu authored
This completes the conversion of media/filters/*. Bug: 1007805 Change-Id: I86c90287a612b055e780eb175ef7f162d87f420f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532903Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827275}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2b4007e5. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I41177f05638d4efe32258f8a0154b5339927bcda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537875Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827274}
-
Eugene But authored
This is a follow up to crrev.com/c/2533841 Bug: 1103752 Change-Id: I08ec6ffdafb72eb21f2617dd02585694a381ef6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535910Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#827273}
-
Tim Sergeant authored
This adds the Files app to the spot after the Chrome icon, for new users only. There's also some variations of the default pin layout controlled by a Finch experiment, I've moved the Files app up in those layouts for consistency. This change was requested for M88 and will be merged back. Bug: 1148519 Change-Id: Iae54561fec599b813ba97e82a5678fa834a02db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537214Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/master@{#827272}
-
Robbie Gibson authored
This allows other coordinators to use the LocationBarSteadyViewMediator if they want to use the LocationBarSteadyView. Bug: 1094335 Change-Id: I6fd912f8a2d560d7f3928b2201d42c8fff2b937a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526425Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#827271}
-
edchin authored
Design doc: go/bling-phishguard This CL continues work to compile code in iOS that was previously disabled behind PASSWORD_REUSE_DETECTION_ENABLED. Runtime changes are put behind a new feature flag. Bug: 1147962 Change-Id: I102c7c34630e7d3e848f2077b2703d223e4a788c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536936Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827270}
-
Matthias Körber authored
Moves the place in the code where the precedence is granted to mitigate that overall predictions are not cached. Change-Id: Ib768918d2e0267b02846da534d904fa53df5ffbe Bug: 1148782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537835Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#827269}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011130600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/lncFJYEwVu27fQaQFf8XRHbjYztYJXFXPbFvQaiqj_0C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: Ie4c95b099396cd95e10f65b29276ac8c2347fad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537869Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827268}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8bf9368130b8..f1f7c370eb0d 2020-11-13 treehugger-gerrit@google.com Merge "tp: Improve error message for RUN_METRIC substitution" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib2f504c4b531ef214ecd35a78719d16a147ff7de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537911Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827267}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4fb2d48fe563..8bf9368130b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1172908a7cb01fd6467c1a347f7b48ca3b85e851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537877Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827266}
-
Hans Wennborg authored
Due to a diagnostics change, it doesn't pass with tip-of-tree Clang. Delete it for now, and when Clang is updated it can be re-instated with updated expectations. Bug: 1148761 Change-Id: I5812c1a60eeaa19ec49507487402c1df169f2125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537634 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#827265}
-
Kramer Ge authored
This is a reland of 4ff93eee Remove over-constraining DCHECKs and add back egl fence workaround when EGL_ANDROID_native_fence_sync is not supported. Original change's description: > [ozone/wayland] Use linux_explicit_synchronization_protocol for in-fence > > If linux_explicit_synchronization_protocol is implemented by wayland > server, submit access fence together with buffers. Otherwise, wait for > fences in gpu process. It is preferred to defer waiting for buffer > content ready in Wayland server, because waiting for access fences in > client can be time-consuming. > > The access fence for primary plane should be inserted by the buffer queue. > > This is 7/? CL for overlay forwarding using wl_subsurface. > > Change-Id: I8a031c1941591c48eac8a51d12af195c345002e2 > Bug: 1063865 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365994 > Commit-Queue: Kramer Ge <fangzhoug@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Maksim Sisov (GMT+2) <msisov@igalia.com> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822813} Bug: 1063865 Change-Id: I4de88b299d4b8bf26ca1b1b5fa128865a2c9c38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518795Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#827264}
-
Egor Pasko authored
Tbr: agrieve@chromium.org Bug: None Change-Id: I5ef8c82f5ebd116f97baad82e8f2a6f1d582fc8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536460Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#827263}
-
Joanmarie Diggs authored
AXPlatformNodeBase::IsInvisibleOrIgnored is used to determine if, and how an element should be exposed to platform assistive technologies. It was not taking into account if the element in question was focused. As a result, if an author set aria-hidden to "true" on an ancestor of a focused widget, assistive technologies might not be able to obtain the selected text or receive the expected notifications when the text or caret offset changes. Because it is considered an authoring error to "hide" the focused element from assistive technologies, modify IsInvisibleOrIgnored to return false when the node is focused. Ax-Relnotes: Improves accessibility of focused widgets which have been incorrectly marked as hidden due to authoring error. Bug: 1144707 Change-Id: Id97053c1cddf3fa91518aa9950f4bb8ba2ca003a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521570 Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#827262}
-
Igor Tukh authored
PermissionAuditingDatabase is a SQL-based storage for keeping information about the permissions usage. The information is represented in source code with PermissionUsageRecord structure. R=engedy@chromium.org Bug: 169305053 Change-Id: I65da241073a82baac4c02d240da36f6c379b7c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435307 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#827261}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4c630d2bdded..6729bed0d4fd 2020-11-13 alcastano@google.com Introduce abstract class for categorized breakpoints 2020-11-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-13 tvanderlippe@chromium.org Update ESLint and related packages 2020-11-13 tvanderlippe@chromium.org Fix issues discovered by ESLint 7 2020-11-13 kimanh@chromium.org [LMI] Add settings view to linear memory inspector 2020-11-13 jacktfranklin@chromium.org Enable NodeText colours to be configured by parent If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110202,chromium:1142804,chromium:1148733 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I097051436f50fb53774b5ec2491d0c9cd8525f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537862Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827260}
-
Ewann authored
This CL fixes tests impacted by the EnableCloseAllTabsConfirmation feature before submitting the config. It also moves the Confirmation action sheet logic in the button selector, in order to have the possibility to disable the feature after the TabGrid initialisation. Bug: 1119319 Change-Id: I63dc293c538efbe5a3c38c52a41db9ee1a8cde96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526345Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#827259}
-
Xi Han authored
This CL fixes the wrong check of whether native initialization has done. It fixes the missing of Page info on official build, which loads the native library faster than the debug build. Bug: 1137973 Change-Id: I397f2e1ba43a15ff26a1163b8a0acd4c847dccd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535935Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#827258}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/67eb26054d84..c43088c6dc01 2020-11-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from df1edd1738a6 to 67d0fc6389ff (2 revisions) 2020-11-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 142cb87f803d to beec2e4a7c4d (12 revisions) 2020-11-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 4ed9d3498dcf to e4c1a25cc679 (16 revisions) 2020-11-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from a927c079 to 28c8eb1a (519 revisions) 2020-11-13 syoussefi@chromium.org Vulkan: Fix deferred clears vs swap 2020-11-13 syoussefi@chromium.org Sensible default for --emulated-pre-rotation on rotated targets If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: If5b66ec000c47e086fe42599b01d48e7adddc014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537851Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827257}
-
Andres Olivares authored
As part of the TypeScript-ification work done on the Devtools frontend, its public API was changed and this test has to be updated accordingly. This disables it to allow for the change's roll. Bug: chromium:1011811 Change-Id: I88915bc3b94ad83b99463440f17dd618ea04797a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536371Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Andres Olivares <andoli@chromium.org> Cr-Commit-Position: refs/heads/master@{#827256}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d826e462ad73..e2a55140424f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC markusheintz@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1148441 Tbr: markusheintz@google.com Change-Id: Ia3c07a8a22ee2e16c788ac55481d8b59651381f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537858Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827255}
-
Chris Sharp authored
Updated the following policies: ShowAppsShortcutInBookmarkBar SignedHTTPExchangeEnabled SpellcheckEnabled SpellcheckServiceEnabled UserFeedbackAllowed WebRtcAllowLegacyTLSProtocols WPADQuickCheckEnabled Also add some additional values that can be used to verify a description describes the unset state, when possible. Bug: 1139306 Change-Id: Id73b76865d25d7eb1896bf4d75dbaf7bff5a76d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535034Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#827254}
-
arthursonzogni authored
Remove all the uncalled function from the TestRenderFrameHost and the NavigationSimulator. There was this comment on: https://chromium-review.googlesource.com/c/chromium/src/+/2529096/11/content/test/test_render_frame_host.cc#334 removing unused function ensure they won't be called. Bug: 1146469 Change-Id: I8acb24089203a10d3acaac2d2366179d86f1e9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537632Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#827253}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I3beb629a5a0f1fb2b18c23ef060dc686f108934b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537661Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827252}
-
Adithya Srinivasan authored
This reverts commit ef52da93. Reason for revert: Test fails flakily on multiple platforms: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=webcodecs%2Freconfiguring_encooder.html Original change's description: > [webcodecs] Changing encoder parameters without re-initialization > > Bug: 1119892, 1146168 > Change-Id: Ibb548cd1684f22a0e095c0d0d51654bdd2ea59f2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534691 > Commit-Queue: Eugene Zemtsov <eugene@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827150} TBR=sandersd@chromium.org,eugene@chromium.org Change-Id: I20d68788883ac2f7d61cf53e9fa6381220d7aed7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1119892 Bug: 1146168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537879Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#827251}
-
Peng Huang authored
current_frame()->current_render_pass is set in DirectRenderer::UseRenderPass() for rendering a render pass. However it is not set back to nullptr, after rendering the render pass. So the DCHECK() is wrong. Bug: 1147583 Change-Id: I9d52ce734488802619b1d3935b8edb618a3c070e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536590 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#827250}
-
sandromaggi authored
This changes the |ElementFinder::Result| to be split into different data chunks. This refactoring is done for the ElementStore, which is supposed to only store the |ResultData| part (instead of the full |Result|). Bug: b/172328014 Change-Id: I9e0f6aea5b5619feb6e326f6262e0ceaf8176d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519458 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#827249}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605247142-11a98e7e9af1f9b1590d22222c9b4c2fb5a6de28.profdata to chrome-linux-master-1605268075-beb915b3939660700cb86662fda8b7247e8e8c87.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib1e04472f68deac73cc3cefe51f548fb66a8d227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537859Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827248}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4fb2d48fe563..8bf9368130b8 2020-11-13 fmayer@google.com Merge "Actually fix Windows build." 2020-11-13 lalitm@google.com Merge "Add trace metric to know dpu underrun occurs count" 2020-11-13 fmayer@google.com Fix Windows build error. 2020-11-13 fmayer@google.com Do not support Unicode paths on Windows for now. 2020-11-13 delphick@google.com Merge "[metrics] Add modified RAIL mode query" 2020-11-13 fmayer@google.com Fix windows subprocess build error. 2020-11-12 treehugger-gerrit@google.com Merge "Support new libunwindstack errors in traced_perf." 2020-11-12 treehugger-gerrit@google.com Merge "Minor refactor to shorten a method." 2020-11-12 treehugger-gerrit@google.com Merge "base: deflake subprocess tests" 2020-11-12 fmayer@google.com Merge "Fix multithreaded_alloc build." 2020-11-12 marcinoc@google.com Merge "Implement more jank root causes" 2020-11-12 fmayer@google.com Merge "Make Chrome Windows build happy." 2020-11-12 fmayer@google.com Merge "Ignore new buildtools dependencies" 2020-11-12 treehugger-gerrit@google.com Merge "Add missing include." 2020-11-12 hjd@google.com Merge "ui: Clone data before parsing IPC frames" 2020-11-12 treehugger-gerrit@google.com Merge "Add ability to omit protozero dep in protozero_library" 2020-11-12 primiano@google.com Merge "docs: remove [toc], unsupported" 2020-11-12 fmayer@google.com Merge "Test for ParseLines receiving on char at a time." 2020-11-12 lalitm@google.com Merge "tp: explicitly list proto deps instead of --include_imports" 2020-11-12 ddrone@google.com Replace atomic_uint32_t with atomic<uint32_t> 2020-11-12 gijosh@google.com Update local symbolizer to support Windows. 2020-11-12 fmayer@google.com Fix out-of-tree unwindstack build. 2020-11-12 ddrone@google.com Merge "Make EventContext::event() template method" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:152017262 Tbr: perfetto-bugs@google.com Change-Id: I5fbea37520ea5a157133bfaffae763550070f6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537855Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827247}
-
Markus Heintz authored
This reverts commit 7fdaa429. Reason for revert: 1 Test Suite(s) failed. ozone_unittests_headless failed because of: XdgVersionV6Test/WaylandKeyboardTest.EventAutoRepeat/0 XdgVersionStableTest/WaylandKeyboardTest.EventAutoRepeat/0 See https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tester%20%28Ozone%20Headless%29 Original change's description: > Fix auto key repeat event interpretation. > > The original code interprets "rate" (the second argument) in > millisecond units. However, by definition, it is the number of > key events per second. > > Bug: 1141473 > Test: Ran on DUT. Ran unittest locally. > Change-Id: Iccdcd2c1e5fc3160da054617bc3e173bb23e9657 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507412 > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827223} TBR=rjkroege@chromium.org,mukai@chromium.org,hidehiko@chromium.org Change-Id: I3275b8718af2fd956ea32992fd87192bccaadc0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1141473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537676Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#827246}
-
Adithya Srinivasan authored
Bug: 1148771 Change-Id: I676dd86028dbca3f39661aa2b35202facf880281 Tbr: alemate@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536978Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#827245}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1605247142-4988315bd20c8dff060ce85c8c55840f23094b85.profdata to chrome-mac-master-1605268075-3755a079b65652d38832c53840c8030bab959806.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2bc9df067866e8970fac0221a41156695b33d2e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537857Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827244}
-
Corentin Wallez authored
Also changes regenerate_internal_cts_html to have slightly more debug outputs and use `npm script` instead of `npm exec`. Bug: None Change-Id: Ifee95c5388cb562d3a5da4590ae3ef5402853f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534730 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#827243}
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: I3754025e8d935887cdbfa6d2c517c715dabc09d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532080 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#827242}
-