- 05 Jan, 2019 28 commits
-
-
Dan Beam authored
In https://crrev.com/c/1393442, I changed this code: /* Google Blue 900 with 40% opacity. */ box-shadow: 0 0 0 2px rgba(26, 115, 232, 0.4); to box-shadow: 0 0 0 2px rgba(var(--google-blue-900-rgb), 0.4); Unfortunately, the comment read "900", but it was actually "600". So I fixed that (and checked that "26, 115, 232" is google-blue-600 in shared_vars_css.html) and also converted another duplicate Google Blue instance in this file. R=hcarmona@chromium.org BUG=918824 Change-Id: Ifa4795cfe05f00273fe61759138dfbf3b23025af Reviewed-on: https://chromium-review.googlesource.com/c/1396781Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#620142}
-
Zhongyi Shi authored
Original change message: Use PendingStreams to buffer incoming streams. Behavior changes protected by QUIC version 99 Allow QuicSession to buffer frames for incoming streams in a PendingStream until the first byte arrives, if ShouldBufferIncomingStream() returns true. Change QuicSpdySession to return true for v99 unidirectional streams. Merge internal change: 226538637 Bug: 919184, 919073, 919048, 919014, 918890, 918834, 918888, 918832, 918849 Change-Id: I14be0f9d97de31bf6ea0d40afe5e457a318e8f02 Reviewed-on: https://chromium-review.googlesource.com/c/1396312Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#620141}
-
Shakti Sahu authored
This reverts commit 96f52874. Reason for revert: Crash Original change's description: > Added AutoResumptionHandler with task scheduling in native > > Added AutoResumptionHandler to handle downloads auto-resumption in native. > This class will observe all download items and also listen to network changes. > Based on the current network conditions and download network requirements, it > will use a task scheduler to schedule a resumption task with the OS. It is expected > to handle download completions/interruptions etc correctly and based on the state of downloads, > either notify about task completion with cleaning up any already scheduled > tasks or scheduling a new task for resumption when network conditions are met. > > Bug: 910878 > Change-Id: Ia4aabc21e85afee523e78f10956df99e7e02c9dc > Reviewed-on: https://chromium-review.googlesource.com/c/1356311 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619491} TBR=peter@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 910878 Change-Id: I691d3c1d61a3fa4de9ddcd85d4b9f19b7285f3ab Reviewed-on: https://chromium-review.googlesource.com/c/1395830Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#620140}
-
Evan Stade authored
-PDFAnnotationsTest.AnnotationsFeatureEnabled TBR=jamescook@chromium.org Bug: 919256 Change-Id: I967bcd6aae5d70148e5b235e721e351077b9ded4 Reviewed-on: https://chromium-review.googlesource.com/c/1395836Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#620139}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6b46a78785b..a64cf3b1e0f3 Created with: gclient setdep -r src-internal@a64cf3b1e0f3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id1d6a75e3950dbd4ecc78d3662ad6304c238f5c7 Reviewed-on: https://chromium-review.googlesource.com/c/1396688Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#620138}
-
rbpotter authored
- Remove utils functions that are now unused due to deletion of old UI - Remove arrayContains usage in favor of Array.includes - Remove utils unittests. Page range tests have been migrated to chrome/test/data/webui/print_preview/pages_settings_test.js. Bug: 908705 Change-Id: I832bbfd095e8ab671fa71300fef554f49fcf512f Reviewed-on: https://chromium-review.googlesource.com/c/1396682 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#620137}
-
Chris Harrelson authored
The calls to LayoutObject::RecalcVisualOverflow() are for recursion to children, not "adding in" children visual overflow. Change-Id: I8b5e44e49d1e1bea889afd5764d865a4342739dd Reviewed-on: https://chromium-review.googlesource.com/c/1396785Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#620136}
-
John Abd-El-Malek authored
Change-Id: I34c6a44f8da52e5f256e7fa686cc4cb6df69d15b Reviewed-on: https://chromium-review.googlesource.com/c/1396683 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#620135}
-
Dan Beam authored
This CL was generated with: $ eslint --fix $SRC $ git cl format --js Note: I reverted serviceworker_internals.js because of all the existing lint violations / jstemplate cruft; will do separately. BUG=916782 R=nasko@chromium.org Change-Id: If383e822e50d7e2f7140879e9da4a68aa3b6519b Reviewed-on: https://chromium-review.googlesource.com/c/1396708Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#620134}
-
Dmitry Gozman authored
We now buffer all the data to |data_buffer_| similarly to other buffering scenarios, and then use that buffer to create an archive. This removes an unneeded dependency on Resource. Bug: none Change-Id: I940eaf035b0376d76d6502c219a7c40d277f08a1 Reviewed-on: https://chromium-review.googlesource.com/c/1392504Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#620133}
-
Antoine Labour authored
Because client and service may be of different bitness, offsets in command buffers have to fit in a uint32_t, effectively limiting transfer buffers to 4GB. Make this clear in CommandBuffer::CreateTransferBuffer by taking a uin32_t instead of a size_t (fixing callers as appropriate), avoiding potential security issues with silent clamping. Bug: 905509 Change-Id: I8392f2e73e95bf65e08fa9896e2acc53afa0d268 Reviewed-on: https://chromium-review.googlesource.com/c/1396132Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#620132}
-
siyua authored
Bug: 918793 Change-Id: Ia818f785d5ea848a3d8af3c91b8368ee9be6c144 Reviewed-on: https://chromium-review.googlesource.com/c/1396616Reviewed-by:
-
Katie D authored
Autoclick menu allows users to change which type of automatic click action will happen after the autoclick time elapses, directly from the tray. The menu also has a shortcut to jump to the automatic clicks settings page. This is part of the new autoclick feature set. See more UI details at go/cros-dwell-ux. Some UX is still in flux. Assets are not completed and some other TODOs exist, but this menu is hidden behind a flag. All TODOs will be completed before launch! Bug: 894907 Change-Id: I9207f13d75101afdf8bc18ca704000e7a89e9c9a Reviewed-on: https://chromium-review.googlesource.com/c/1391851Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#620130}
-
Dmitry Gozman authored
This brings two benefits: - Dump what we actually call on RenderFrameObservers. - Remove dependency on DocumentLoader::GetRequest which goes away (see the doc linked to bug). Bug: 855189 Change-Id: I7c869d870dcb2d51cddea1998335af0e6162af5e Reviewed-on: https://chromium-review.googlesource.com/c/1390237Reviewed-by:
-
rbpotter authored
- Make DocumentInfo a Polymer element so that its properties can notify paths - Since DocumentInfo is a Polymer element, it can now inherit WebUIListenerBehavior, and take over responsibility for updating various document properties from PreviewArea - Update pages settings and scaling settings to observe only the sub-properties of DocumentInfo that they actually use. Bug: None Change-Id: I7289526b2ad0bdf2fcbd49a956b797ec5525bbcd Reviewed-on: https://chromium-review.googlesource.com/c/1395424 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/599dad1eadaf..1457e48474e7 git log 599dad1eadaf..1457e48474e7 --date=short --no-merges --format='%ad %ae %s' 2019-01-04 vapier@chromium.org cros_extract_deps: sort output 2019-01-04 vapier@chromium.org cros_extract_deps: clean up cli parser a bit Created with: gclient setdep -r src/third_party/chromite@1457e48474e7 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I340c72f4d78eb5543dc4de920119184819383741 Reviewed-on: https://chromium-review.googlesource.com/c/1396685Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#620127}
-
Dmitry Gozman authored
After we started calling CreatePlaceholderDocumentLoader [1] for empty-document navigations, existing logic which checks for placeholder DL handles the case of empty documents as well. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1380552 Bug: none Change-Id: I2b1f9d73e00cd8ed3ab1f3f7f54ea930930c35dd Reviewed-on: https://chromium-review.googlesource.com/c/1390236Reviewed-by:
-
Zhiqiang Zhang authored
There was a crash in SDK before version 16.0.2. This CL works around the issue by generating the low-level message directly. Bug: 711860 Change-Id: I262143fae845ae6e8d4f9042487f554f7f5d94a1 Reviewed-on: https://chromium-review.googlesource.com/c/1396380Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#620125}
-
Takuto Ikuta authored
base::hash_map is alias of std::unordered_map now. I applied following command to make this CL. $ git grep -l 'base::hash_map' | fgrep -v base/ | xargs sed -i -e 's/base::hash_map/std::unordered_set/g' -e 's/\(#include <[a-z_]*>\)/\1\n#include <unordered_map>/' -e 's/BASE_HASH_NAMESPACE/std/' $ git cl format $ # Added IntPairHash and replaced BASE_HASH_NAMESPACE with std in some places. TBR: dcheng@chromium.org Bug: 576864 Change-Id: I38941d9f9bcb05ec474b8dee5230c4c5dcd2211f Reviewed-on: https://chromium-review.googlesource.com/c/1390892 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#620124}
-
Ryan Tseng authored
It looks like someone added these builders to buildbot after I mirrored chromium.clang, but did not add the LUCI entries. This will fix the console. Bug: 919081 Change-Id: I3839c9aad4e4570ba9963546da5d57acd1657dcf Reviewed-on: https://chromium-review.googlesource.com/c/1396492 Commit-Queue: Eric Foo <efoo@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Eric Foo <efoo@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#620123}
-
Daniel Rubery authored
These are multi-part rar archives, and should be inspected as such. Bug: 919157 Change-Id: I53ee4aea51f33d7283772e2987fa2ffd66c92e6d Reviewed-on: https://chromium-review.googlesource.com/c/1396558Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#620122}
-
Peter Kasting authored
This allows shortening a lot of copy-and-pasted code. A few places cannot be converted yet and will be handled in a subsequent CL. Bug: none Change-Id: I3b9dc34f55c287cac09621f251bcaf5221ad8bc4 TBR: kylixrd Reviewed-on: https://chromium-review.googlesource.com/c/1396788Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#620121}
-
Domenic Denicola authored
Follows https://github.com/domenic/async-local-storage/commit/5bf31109f37d1371f619ea33d0e2391f10e8b8f5, and includes web platform test updates. Bug: 918704 Change-Id: Ibc99816d10dba457194ff9e651ead9fc07bd6537 Reviewed-on: https://chromium-review.googlesource.com/c/1393704Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#620120}
-
Chris Harrelson authored
This reduces the size of a LayoutBox or InlineFlowBox without overflow by one pointer. Change-Id: I3461f44950ad29f9ab1c66b10ce0f921ab010c10 Reviewed-on: https://chromium-review.googlesource.com/c/1396332 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Sreerenj Balachandran authored
The Vp9Parser::ParseNextFrame() may get invoked with null decrypt_config, so make sure to not to do the null poitner dereferencing. Change-Id: Idd459377ef78e16b8262e61174165c0dc52d3ead Reviewed-on: https://chromium-review.googlesource.com/c/1396479Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Cr-Commit-Position: refs/heads/master@{#620118}
-
Alex Moshchuk authored
GetRequestInitiatorSiteLock currently calls ShouldLockToOrigin, but that check is redundant for one of its call sites from RenderProcessHostImpl, which only calls GetRequestInitiatorSiteLock for valid, non-empty process locks. This CL moves the ShouldLockToOrigin call to the other call site in RenderFrameHostImpl. This removes GetRequestInitiatorSiteLock's dependency on ShouldLockToOrigin params, which helps prepare for the dynamic isolated origin plumbing to be introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1377616. Bug: 905513 Change-Id: I4f64bd71370f67536c37156274ea578745c56e0e Reviewed-on: https://chromium-review.googlesource.com/c/1396450Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 862839 Change-Id: Ie85e1abe1958665fef83f25c1eb3d437a2555f7b Reviewed-on: https://chromium-review.googlesource.com/c/1396168Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#620116}
-
Chris Harrelson authored
This is merely a performance optimization, with unclear benefits, and adds complication. Change-Id: Ibda65f18145bef919639d89fc0e36647e5aec3e4 Reviewed-on: https://chromium-review.googlesource.com/c/1395816Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#620115}
-
- 04 Jan, 2019 12 commits
-
-
Brandon Jones authored
This is the first step to removing XRDevice entirely. Bug: 916287 Change-Id: Ie5f86738632636927a822c6ccbecba3202446d41 Reviewed-on: https://chromium-review.googlesource.com/c/1383391Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#620114}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/20cbd600de8b..f6b46a78785b Created with: gclient setdep -r src-internal@f6b46a78785b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie31108c237887f2fa455ece6eb1fb3fc02dd1784 Reviewed-on: https://chromium-review.googlesource.com/c/1395827Reviewed-by:
-
Hector Carmona authored
R=dpapad@chromium.org Bug: NONE Change-Id: I73051130e3a8d8f0791ac172666b179a29de4dd9 Reviewed-on: https://chromium-review.googlesource.com/c/1395815Reviewed-by:
-
Sandra Sun authored
Currently, the duration of programmatic smooth scroll curves depend on the distance of the scroll delta. However, it could be considerably long for long pages. This patch sets an upper-limit of 3 seconds for the programmatic smooth scrolls. For shorter scrolls, the duration would still be related to the delta. Bug: 852549 Change-Id: Idbb95a15b7440a16c3e3632f063daa7b7e8fe705 Reviewed-on: https://chromium-review.googlesource.com/c/1396493 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#620111}
-
Ryan Meier authored
Bug: 913227 Change-Id: Ic2e96b96bd9239c39ffe5023d5b6aa7465f91558 Reviewed-on: https://chromium-review.googlesource.com/c/1396496 Commit-Queue: Ryan Meier <rameier@chromium.org> Reviewed-by:
-
Philip Rogers authored
In [1], main thread scrolling reasons were moved from cc::Layer to cc::ScrollNode. That patch missed a case where painted scrollbar layers always set main thread scrolling reasons for non-overlay scrollbars. This is not possible to support with main thread reasons on ScrollNode because it would force main thread scrolling for the entire scroll layer. This functionality is not actually needed anymore because LayerTreeHostImpl::ScrollBegin now falls back to the main thread when touch-dragging a scrollbar. LayerTreeHostImplTestMultiScrollable::ScrollHitTestOnScrollbar tests the main codepath for falling back to the main thread when touch-dragging. I also manually checked that touch-scrolling on the scrollbar and thumb work as expected with this patch. [1] https://crrev.com/617642 Bug: 918699 Change-Id: If8c9cf528639266e49956c5513c2a04b23829622 Reviewed-on: https://chromium-review.googlesource.com/c/1396439Reviewed-by:
-
CJ DiMeglio authored
This CL changes the caption button to use by aria attributes instead of explicitly creating accessibility nodes. It also eliminates some of the duplicate information heard in TalkBack. Bug: 836549 Change-Id: If22a232bc67d2e64148b2cfa5ff48da9bd33e855 Reviewed-on: https://chromium-review.googlesource.com/c/1375396Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#620108}
-
Hector Carmona authored
Bug: 919140 Change-Id: Ifc5c680e5e48afd4b0f75d260cd6c277350d5d7b Reviewed-on: https://chromium-review.googlesource.com/c/1396712Reviewed-by:
-
Caroline Rising authored
Bug: 910739 Change-Id: I3ab7dd42d8f74806f427acea15257879c810787a Reviewed-on: https://chromium-review.googlesource.com/c/1394439Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#620106}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dde2a376f7cd..8061ba857072 git log dde2a376f7cd..8061ba857072 --date=short --no-merges --format='%ad %ae %s' 2019-01-04 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-01-04 benjaminwagner@google.com Add IntelIris655 Win10 jobs. 2019-01-04 kjlubick@google.com [pathkit] Increase test timeouts (for asmjs mostly) 2019-01-04 csmartdalton@google.com ccpr: Rework the path cache to support sporadic flushing 2019-01-04 fmalita@chromium.org [skjson] NaN while parsing long decimals 2019-01-04 kjlubick@google.com [pathkit] Add .ready() to initialize 2019-01-04 ethannicholas@google.com Fixed GL shader link status checks 2019-01-04 kjlubick@google.com [canvaskit] Add .ready() which is a real promise 2019-01-04 reed@google.com change paint serialization to exclude font-related fields Created with: gclient setdep -r src/third_party/skia@8061ba857072 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I34a76f063f20033f4683319ca6f0d1ca942c6b90 Reviewed-on: https://chromium-review.googlesource.com/c/1396363Reviewed-by:
-
Collin Baker authored
FileSelectHelper::OnListDone(), which is called when directory listing is complete, launches an upload confirmation dialog associated with the WebContents the upload request originated from. It does not consider the case where the WebContents has been destroyed. FileSelectHelper already handles the WebContentsDestroyed message, and sets its web_contents_ member to null accordingly. All that needs to be done is cleanup and an early return in OnListDone() if web_contents_ is null. Bug: 916529 Change-Id: Ic362c42a72a2c83bf21ad798d4b05c080c4b972f Reviewed-on: https://chromium-review.googlesource.com/c/1395138Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#620104}
-
James Cook authored
This reverts commit badd8a0f. Reason for revert: Breaks the Wi-Fi network password entry field http://crbug.com/919183 Original change's description: > chromeos: Enable SingleProcessMash (in-proc window service) by default > > Turns on the window service (code in //services/ws) and uses it to back > aura and views (code in //ui/aura/mus and //ui/views/mus). Runs the > window service in-process. > > A label "SingleProcessMash enabled" will appear on the desktop > wallpaper to let developers and QA know the feature is enabled. > The label will be removed in a separate CL before this feature > goes to dev channel. Otherwise there are no visible changes. > > Flips the former "single_process_mash_*" bot configs to > "non_single_process_mash_*" and runs them with the feature disabled. > This should keep the old code paths working until we're sure this > feature will stick. > > TBR=sky@chromium.org > > BUG=918537 > TEST=single_process_mash_* bots > > Change-Id: I58a30fd81ea12645b1aabc049c7e697ef1d9e72a > Reviewed-on: https://chromium-review.googlesource.com/c/1393467 > Reviewed-by: Jun Mukai <mukai@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619508} TBR=jamescook@chromium.org,mukai@chromium.org,sky@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 918537, 919183 Change-Id: Ic3b5f0dd5b941d6383fd7290a0a55b60eedce30d Reviewed-on: https://chromium-review.googlesource.com/c/1396702Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#620103}
-
