- 29 Jan, 2020 40 commits
-
-
Daniel Clark authored
This change implements live-update and double-escape behavior for date and week control popups. When arrow keys are used to change the selection, the changes are immediately reflected on the in-page control (and input events are fired). When the user hits escape, if they have made changes these are reverted without closing the popup. A second escape (or the first one, if no changes were made) closes the popup. Behavior when clicking on a date is not changed; the popup is still submitted immediately (as opposed to other types like datetime-local where the user may want to go on to select other values after clicking the date). Initialization of these controls is changed such that if there is any valid date, one will be selected. This will be the nearest possible date to the value attribute if there is one, otherwise it will be the nearest possible to today's date. This avoids scenarios where we don't paint a focus ring because there is no starting selected date. I've moved the popup submission and cancellation behavior to the top-level key event handler to better match the style of the other refreshed controls. One of my new tests uncovered a potential performance issue where selectNearestValidRangeLookingForward(Backward) could spin for a long time if the min/max attributes were very far from Today. These functions now immediately clamp to within the min/max range to avoid this. Lastly, I'm suppressing a CSS background color animation that the refreshed calendar pickers were erroneously inheriting from the old calendar implementation. A corresponding update will follow to bring live-update and double-escape to the month control. Bug: 1045195 Change-Id: I487bc2cbaefc3056d4ee50898bb6d96f0c9c6182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024158Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#736532}
-
Xida Chen authored
I tried to change the content of the existing test here: https://chromium-review.googlesource.com/c/chromium/src/+/2005813 And that CL was reverted. The lesson learned was: don't modify the content of existing GPU pixel test, because sometimes the bot will still reference to the old result. Bug: None Change-Id: I09fa77648c4f1dd84f3d574030282831ea670181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027175Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#736531}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/740ed473dcba..4356490b7b66 git log 740ed473dcba..4356490b7b66 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 mbonadei@webrtc.org Revert "Reland "Only include overhead if using send side bandwidth estimation."" Created with: gclient setdep -r src/third_party/webrtc@4356490b7b66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I88fe4721d8f7f2467991b0cc05cc5adf4c654028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028650Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736530}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4bf20c76..3796f09f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaa20e55fd945cfd9db2c8793ad0084445c89fe44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028607Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736529}
-
Carlos IL authored
Safe browsing webview tests were flaky with committed interstitials enabled caused by a lack of a reliable way to wait for an interstitial to show. This CL exposes IsShowingInterstitial from security_ interstitial_tab_helper.h and changes the tests to poll it before waiting for the visual state callback. Bug: 1046832 Change-Id: If82f7fbbd9896e4cc3611e48fe945c8581cd847a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027902 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736528}
-
Hongbo Song authored
This CL is to record input delay UKM which is defined as the duration between the hardware timestamp and the start of event processing on the main thread for the meaningful input. UKM Privacy Review: https://docs.google.com/document/d/1VQvmb3x7uGMmt2JvKt3_4zk1SPWHPB3yJSiyec7hY20 Bug: 1042004 Change-Id: I69eb91955f116e1f90b9b72a7d3dd13b449fa4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008436Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Hongbo Song <hbsong@google.com> Cr-Commit-Position: refs/heads/master@{#736527}
-
Avery Musbach authored
Bug: None Change-Id: I465a71521e9c5483c1d8a05c3dee94dd933b54dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024982Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#736526}
-
Xinghui Lu authored
Identity manager will be used to obtain access token in url lookup service. In this CL, identity manager is passed to url lookup service. Its actual usage will be implemented in a follow up CL. Bug: 1041912 Change-Id: Ie8205f587df358906f081134ccbcf96cb2d5929f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018595 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#736525}
-
cfredric authored
All callers pass in an empty NetworkIsolationKey, so this should not change any behavior. Bug: 997047 Change-Id: I2cc555ab5773b1a6a60036cb2eabdadb01723cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013742 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#736524}
-
Yi Gu authored
This test is flaky on CrOS, Linux ASAN and TSAN: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyRQsSBUZsYWtlIjpjaHJvbWl1bUBuZXRfdW5pdHRlc3RzQEhUVFBTRWFybHlEYXRhVGVzdC5UTFNFYXJseURhdGFUZXN0DA&show_all_occurrences=1 TBR=davidben@chromium.org Bug: 1021021 Change-Id: I723564681c23c9f964b5d98064017f69e3abcf00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028729Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736523}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a74b12c57c26..5e883773e98e Created with: gclient setdep -r src-internal@5e883773e98e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1044244 Tbr: jbudorick@google.com Change-Id: If0711a6d131878ebd57df57c972a19b63e8f8be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028021Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736522}
-
Olivier Li authored
This fixes the compilation problems on ios and corrects a couple typos. Compare patch sets 1 and 4 to see the differences between the original commit and the relands. Original change's description: > Basic implementation and tests for HangWatcher. > > This class is a successor to ThreadWatcher which aims to be more > versatile and provide a larger coverage for hang watching. > > Bug: 1034046 > Change-Id: I365fe8824eb34c37c75e6ddf6874ff26ecd494c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008189 > Commit-Queue: Oliver Li <olivierli@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736080} Change-Id: I4785c8c489678fd537a0105d65419673fe383aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026316 Auto-Submit: Oliver Li <olivierli@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#736521}
-
Ovidio Henriquez authored
This change extends the expiration for Web Bluetooth histograms for another year to allow the team to analyze the data gathered from the histograms and determine if the histogram is still worth keeping. Bug: 1036972, 1036971, 1036970, 1036969, 1036968, 1036967, 1036966 Change-Id: Ia5ef38ea195fca1953d88fa11a03c4e667c69d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007938 Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#736520}
-
Lijin Shen authored
Renaming text styles. To avoid a large change list, this CL only renames text styles prefixed by "Black". Bug: 775198 Change-Id: I5e049e5689a0c310fbb93b1c251dbbe1ff98bec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022349Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#736519}
-
Jan Wilken Dörrie authored
After https://crrev.com/i/2475792 removed the last remaining usages of formatUrlForSecurityDisplayOmitScheme from the internal code base this change now removes this deprecated API completely. Bug: 596488 Change-Id: I5c2ba2552ab0dfae0b87527999b2b8fcb858c5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026572 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#736518}
-
Orin Jaworski authored
This CL creates and registers metadata for a new flag called omnibox-suggestion-button-row. Bug: 1046523 Change-Id: I96068d55562147a11f1fcf1524d4bb373a204875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026712 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#736517}
-
Alex Ilin authored
This CL adds a new method ShowReauthPrompt() to SigninViewController. The callers cannot rely on Reauth prompt being displayed in a modal dialog, since for some accounts Reauth is always shown in a popup window. Bug: 1045515 Change-Id: Ida343ffae2cff59b51f4b4c7f12b1e27db3b8297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020764 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#736516}
-
Matt Menke authored
It's flaky, for reasons unknown. Disable it until I can figure out the problem. Disabling instead of reverting to CL that disabled it because the way it's failing indicates it's a test issue, rather than an issue with the code landed with the test. TBR=ericorth@chromium.org Bug: 1042354 Change-Id: I10c2b7c496da9f22726a622be2db932bcb1bef85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028264Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#736515}
-
Yi Gu authored
This test started to be flaky after Jan 23. See bug for details. TBR=sky@chromium.org Bug: 790963 Change-Id: Ib3db249f3e380ac1c27490281242ed9186a7f367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028687Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736514}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/873d0470b40d..b8c0752438c0 git log 873d0470b40d..b8c0752438c0 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 rharrison@google.com Add back in deprecated APIs (#977) Created with: gclient setdep -r src/third_party/shaderc/src@b8c0752438c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I416f8c585a352f3cd58c2340df34c0650b2e7a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028020Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736513}
-
Christopher Cameron authored
The embedded metallib uses MTLLanguageVersion2_1, available only macOS 10.14+. Bug: 1046671 Change-Id: Iac72569f4d9ad25ced7c0284dbbfd790ab3ecd4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028266Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#736512}
-
Daniel Rubery authored
We will be adding more details to the Advanced Protection FAQ page ( https://support.google.com/accounts/?p=ap_faq) about deep scanning. This CL adds a link with "Learn more" on the modal dialog, which links to this FAQ page. Screenshot: https://screenshot.googleplex.com/i5JHn4QZ42z.png Bug: 1020418 Change-Id: I5bccd307f82ea17dc0b77e0c0b9e52fe0d5ea6f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026590 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736511}
-
Jérôme Lebel authored
authentication/signin:signin is the public target to depend on. authentication/signin:signin_headers contains the public headers. authentication/signin:signin_impl contains the sign-in implementation. Related to: crrev.com/c/2025547 Bug: 971989 Change-Id: If7cbaf76df94b4a2647d0f47f56912cd3f36d0de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027809 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#736510}
-
Yi Gu authored
Test is flaky on Linux and Windows: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyWQsSBUZsYWtlIk5jaHJvbWl1bUB1bml0X3Rlc3RzQE1lZGlhTm90aWZpY2F0aW9uU2VydmljZUNhc3RUZXN0LkNvdW50Q2FzdFNlc3Npb25zQXNBY3RpdmUM TBR=takumif@chromium.org Bug: 1034406 Change-Id: I5403d8163546553597490123dce4aec167601cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028265Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736509}
-
Daniel Rubery authored
We currently only report DLP bypasses if they are opened within Chrome (by clicking on the download shelf item, or selecting "Open" from the download item dropdown, for example). We should be reporting any time a user recovers a file that showed a DLP warning. This CL adds code to do that. Bug: 1046527 Change-Id: I2ecf6704d4040ee3bdb39d8e40b49f021eb0ddb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025931Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#736508}
-
Yi Gu authored
This test is flaky on Linux: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyXQsSBUZsYWtlIlJjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BQb2ludGVyTG9ja0Jyb3dzZXJUZXN0V2l0aE9wdGlvbnMuVW5hZGp1c3RlZE1vdmVtZW50DA TBR=mustaq@chromium.org Bug: 1043985 Change-Id: I9c9cd3ade09dab3b601895ad0b8e8f4896745f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028728Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736507}
-
behdad authored
The metric was added in an update before to track the time begin main frame sent to start: https://chromium-review.googlesource.com/c/chromium/src/+/2013461 Bug: chromium:976030 Change-Id: Ib575aef2feb3ed94c6e2cff2b83f2ecc4543c347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028109Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#736506}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8354717302ce..37e7b36a3dc2 git log 8354717302ce..37e7b36a3dc2 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 bsalomon@google.com Make cache RRect blur masks with exact fit textures. 2020-01-29 reed@google.com tweak textbox to use subpixel 2020-01-29 csmartdalton@google.com Preserve triangle winding in GrTessellator 2020-01-29 jlavrova@google.com Memory leak in cache Created with: gclient setdep -r src/third_party/skia@37e7b36a3dc2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1044017 Tbr: reed@google.com Change-Id: I30c50d93c275a0c6ec0dd1c6116661c21ceec318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027905Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736505}
-
Scott Haseley authored
This CL adds the necessary wiring to make devtools aware of postTask to show async callstacks, similar to setTimeout and requestIdleCallback. Bug: 979017 Change-Id: I960b13d1c13f171dbc033b8e79bff3768e65c347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025870Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#736504}
-
David Tseng authored
The Clsoure compiler (which gets run on upload PRESUBMIT) is now flagging many errors in ChromeVox. This is due to the recent work to move us to ES6 styled classes. The errors themselves were mostly there previously and uncaught because Closure is fairly loose in flagging errors given a slightly different js structure. Test: git cl presubmit -u --force Change-Id: I4c09adf0a5fd6e3894f7316dc4d5a9c4bf9a825d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026760Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#736503}
-
Ahmed Fakhry authored
Make the Night Light animation which triggers when the automatic transition happens due to a set schedule run at 15 FPS, and last for a minute. BUG=1044344 TEST=Manual Change-Id: If76477be8674c4e276dfa508f0fda4fe2deb64a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024448 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#736502}
-
Nazih Almalki authored
FinishPaintCurrentFrame and EndWriteSkia (SkiaOutputDeviceBufferQueue) both do a flush right after each other. The CL combines the flush from both, and get it done in FinishPaintCurrentFrame. The FinishPaintCurrentFrame, calls GetEndPaintSemaphore, that is combined with the FinishPaintCurrentFrame, and flushed. EndWriteSkia, Checks if the semaphore has been flushed, if not, it will flush it. Bug: 1043114 Change-Id: I541f0a9b5c31e7bfaee7b83a6be99d98323f0f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024919Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Nazih Almalki <nalmalki@google.com> Cr-Commit-Position: refs/heads/master@{#736501}
-
Kevin Marshall authored
Adds a GN arg "fuchsia_release_channel" which modifies how some released packages are named. This will allow official builders to produce packages named "web_engine_canary", "web_runner_beta", and so on., a necessary step toward running stable and canary releases on Fuchsia side-by-side. Adds test function "ConnectContextProvider()" for sourcing the ContextProvider service directly from a release channel-specific package. Bug: 1029184,1046615 Change-Id: I23845e64d909c9e7665ce3df15458c26e1f27ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006189 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
James Robinson <jamesr@chromium.org> Cr-Commit-Position: refs/heads/master@{#736500}
-
Dominik Röttsches authored
Change-Id: I157f3ca744e16cd13ca3138bd1b5ec69f2324a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027530 Auto-Submit: Dominik Röttsches <drott@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#736499}
-
Daniele Castagna authored
Originally we remapped temperatures to a range [5700, 7500) and then computed RGB scale factors using linear functions. The table that remaps temperatures has been updated with crrev.com/c/2001254 but we didn't update the code to accept the new range [4500, 7500). This CL updates the accepted range and also recomputes GB coefficients used for the linear regression in the interval [4500, 6500]. Bug: 1045647 Test: ash_unittests --gtest_filter=AmbientTemperature.AmbientTemperatureToRGBScaleFactors Change-Id: Ifa19820cd8d6b076dbf6c85841f126bca7ea4585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022246Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#736498}
-
Ionel Popescu authored
As part of https://chromium-review.googlesource.com/c/chromium/src/+/2023361, the default behavior of the color picker was changed to start with the color selection ring focused. This CL updates the test results that were incorrectly changed in that CL. Bug: 1041708 Change-Id: If8af59e69229d39ff5129c10ead7ed8936339f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028294Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#736497}
-
Julian Pastarmov authored
Before the API would return an error now it returns no error and an empty blob instead. BUG=1046705 TEST=uni_tests Change-Id: Id15fa397d9db5dcded5db40caac9a719bc9312ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026971Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#736496}
-
Jarryd authored
Add a method that storage backends can call to let QuotaManager know that a write error will be or has been thrown. This will be used as a hint that the disk storing the user's profile might be full. In combination with Quota's knowledge of disk usage, this function can be used to trigger any actions that the content embedder deems appropriate for storage pressure state, such as notifying the user. Logic for calling this function will be in child CLs. Bug: 997258 Change-Id: Iae7f77f546778f426e13b936f6bfeb6284cab3bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969235 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#736495}
-
rbpotter authored
Split out from https://chromium-review.googlesource.com/c/chromium/src/+/1848495 by dpapad@, since we need to handle <if expr> in imports in order to autogenerate Polymer 3 versions of files that are shared between the browser and OS settings. Bug: 1026426 Change-Id: I3bdaca4c64104232d72b993a4dc82ee18f92676f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025837 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#736494}
-
Xiaocheng Hu authored
This patch caches the pseudo style of custom scrollbar parts on the ComputedStyle of the originating element, so that it's easier to inspect these pseudo styles. Before: Element -> LayoutObject -> PaintLayer -> ScrollableArea -> CustomScrollbar -> ComputedStyle After: Element -> ComputedStyle This is preparation for crrev.com/c/1952189 Bug: 441925 Change-Id: Ibbb4876d4e01af7c37db9b390937af76a217855e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026694Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#736493}
-