GitLab

chrome/browser/bookmarks/bookmark_codec_unittest.cc
chrome/common/accessibility_types.h
Review URL: http://codereview.chromium.org/100108

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14859 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14858 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14857 0039d316-1c4b-4281-b951-d872f2087c98

BUG=10353,10400

Review URL: http://codereview.chromium.org/99158


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14856 0039d316-1c4b-4281-b951-d872f2087c98

24 (12 direct, 12 indirect) bytes in 1 blocks are definitely lost in loss record 54 of 258 
   at malloc (vg_replace_malloc.c:178)
   ...
   by gtk_container_foreach (in /usr/lib/libgtk-x11-2.0.so.0.1200.9)
   by gtk_container_get_children (in /usr/lib/libgtk-x11-2.0.so.0.1200.9)
   by (anonymous namespace)::OnDialogResponse(_GtkDialog*, int, AppModalDialog*) (app_modal_dialog_gtk.cc:24)

Review URL: http://codereview.chromium.org/102007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14855 0039d316-1c4b-4281-b951-d872f2087c98

Revert "Instead of passing down a switch to the renderer, storing a member, etc., just implement --disable-popup-blocking in the browser at the point where we make the final policy decision."

This reverts commit r14851.

As it DID NOT PASS THE TRY BOTS.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14853 0039d316-1c4b-4281-b951-d872f2087c98

- It does not look that is a very good idea what it was doing to boot

TEST=no test required


Review URL: http://codereview.chromium.org/100080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14852 0039d316-1c4b-4281-b951-d872f2087c98

Instead of passing down a switch to the renderer, storing a member, etc., just implement --disable-popup-blocking in the browser at the point where we make the final policy decision.
Review URL: http://codereview.chromium.org/100132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14851 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14850 0039d316-1c4b-4281-b951-d872f2087c98

ISO-8859-1 which confuses editors.
Review URL: http://codereview.chromium.org/99191

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14849 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99190


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14848 0039d316-1c4b-4281-b951-d872f2087c98

This is what tcmalloc uses to hook out-of-memory cases.

Review URL: http://codereview.chromium.org/99090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14847 0039d316-1c4b-4281-b951-d872f2087c98

This is a changelist for http://codereview.chromium.org/75031 by Kent Tamura (tkent@google.com)


Review URL: http://codereview.chromium.org/100111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14846 0039d316-1c4b-4281-b951-d872f2087c98

The style (or at least the GCs) are shared across widgets, so they shouldn't
be modified, or should be restored.  Creating a GC should be cheap enough, I
was overthinking this.

Review URL: http://codereview.chromium.org/100161


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14845 0039d316-1c4b-4281-b951-d872f2087c98

DevTools: keep links on the edited styles so that they are not collected between debugging sessions.

Review URL: http://codereview.chromium.org/100159

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14844 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Open multiple windows, make sure the entries in the Window menu
match the titles of the currently selected tabs.

Review URL: http://codereview.chromium.org/100121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14841 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/102008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14840 0039d316-1c4b-4281-b951-d872f2087c98

1. Split inject.js into injected object and the dispatch.
2. Surround utility function call with try/catch, pass potential exception all way to the client.
3. Fix user and user agent scripts detection
4. Introduce toggleStyle
5. Remove __defineGetter__ from the styles code: make things simple
6. Beautify code.

Review URL: http://codereview.chromium.org/99184

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14839 0039d316-1c4b-4281-b951-d872f2087c98

external V8 strings.

We seem to be occasionally losing the data for our external strings.
The current hypothesis is that there is a reference counting bug in
WebCore somewhere which is leading to premature deletion of the string
data.  This change is an attempt to verify that this is in fact the
case.  By artificially increasing the ref count on the strings, we
should reduce the likelihood of accidental deletion because of ref
counting being slightly off.  If we can confirm that this removes most
of the crashes, we know that the problem is WebCore ref counting
related.

BUG=9746
Review URL: http://codereview.chromium.org/99174

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14838 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99182

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14837 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sgk


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14836 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99179

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14835 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sgk


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14834 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14833 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14832 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14831 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/56076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14829 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14828 0039d316-1c4b-4281-b951-d872f2087c98

BUG=6857


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14827 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a couple of bugs in painting and updating:
- properly size the canvas we draw the child views into so the bottom pixel doesn't bleed
- properly schedule repaints when the presentation changes for the same number of results so that we repaint selection changes.

Back to using system colors. Adds highlight icons.

Review URL: http://codereview.chromium.org/99102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14826 0039d316-1c4b-4281-b951-d872f2087c98

These won't get gated live without a change to all.gyp, so landing them separately.

Review URL: http://codereview.chromium.org/100146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14822 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/101015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14821 0039d316-1c4b-4281-b951-d872f2087c98

creating new tabs.
Review URL: http://codereview.chromium.org/100031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14819 0039d316-1c4b-4281-b951-d872f2087c98

The implementation of buffered data source that uses buffered resource loader
to download a media object and does buffering. This implementation knows
when to do defer loading and when to restarts the loading. The implementation
uses one buffered resource loading for one data source and does no connection
recovery.

Review URL: http://codereview.chromium.org/88047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14818 0039d316-1c4b-4281-b951-d872f2087c98

Added range request support in URLRequestFileJob to respect
"Range" HTTP header. Fail with ERR_REQUESTED_RANGE_NOT_SATISFIABLE
if range is bad.
The following range request modes are supported:
1. Fully specified: bytes=x-y
2. With first byte position only: bytes=x-
3. With suffix length: bytes=-y

Multiple ranges in a single request is not supported as we need to multipart
encoding..

Last review was here: http://codereview.chromium.org/92149

Review URL: http://codereview.chromium.org/102006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14817 0039d316-1c4b-4281-b951-d872f2087c98

One test still needs further investigation, disabling it.

BUG=11142

Review URL: http://codereview.chromium.org/99167

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14815 0039d316-1c4b-4281-b951-d872f2087c98

This picks up the change "Escape double quotes (U+0022)."

BUG=7024
TBR=brettw

Review URL: http://codereview.chromium.org/101012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14814 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14813 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14812 0039d316-1c4b-4281-b951-d872f2087c98

BUG=11133

Review URL: http://codereview.chromium.org/99153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14811 0039d316-1c4b-4281-b951-d872f2087c98