- 12 Jul, 2018 14 commits
-
-
Nico Weber authored
On Windows, the macro already had no effect. Export on template classes doesn't make a lot of sense: The template itself doesn't exist, only its instantiations do. The export is inherited by the instantiations, so if the template had an instantiation in core/platform/modules then that instantiation would be visible outside the respective .so, but without an explicit instantation declaration, clients outside those sos still get their own instantation and that doesn't really do anything. (The bindings generator also uses this macro on explicit template specializations which _are_ instantiations, so the macro does have a useful effect there -- but it looks like the effect there isn't needed since everything builds fine with this patch applied.) While here, also remove a warning suppression pragma for a warning that's been disabled globally since #492411. Bug: 859989 Change-Id: Ib22993d06f3ad62c79e2b53b010614ae6577d227 Reviewed-on: https://chromium-review.googlesource.com/1133329Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#574431}
-
Scott Chen authored
Some files were depending on iron-icons/iron-icons.html to pull in iron-icon/iron-icon.html. Needed to add direct dependency to iron-icon.html, once iron-iconS.html was no longer imported. Bug: 855205 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Icd95f6b178a40d7169611721deef38b04e291257 Reviewed-on: https://chromium-review.googlesource.com/1133588Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#574430}
-
Daniel Park authored
> Creates xml file of new help icon > Removes pngs of the old help_and_feedback icon Bug: 834600 Change-Id: Ieadda6e2771c8a57d1995d047aa418381618aef6 Reviewed-on: https://chromium-review.googlesource.com/1044490 Commit-Queue: Daniel Park <danielpark@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#574429}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c3975e55e146..d64781e17af7 git log c3975e55e146..d64781e17af7 --date=short --no-merges --format='%ad %ae %s' 2018-07-11 ehmaldonado@chromium.org gclient_scm: Fetch refs/changes/* when syncing. Created with: gclient setdep -r src/third_party/depot_tools@d64781e17af7 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:858894 TBR=agable@chromium.org Change-Id: If022f0d17cbb6ad978d73fb45f85215dfca5033e Reviewed-on: https://chromium-review.googlesource.com/1134447Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574428}
-
Scott Violet authored
BUG=862715 TEST=none Change-Id: Ic5ac2f60ad310a0b9bb88e0f9430bbdbcc17397c Reviewed-on: https://chromium-review.googlesource.com/1134467Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#574427}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8dc93fc4..8b17db68 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic70862dc831eeb3ae86a02d13d9929c0a05dca45 Reviewed-on: https://chromium-review.googlesource.com/1134196Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574426}
-
Tien-Ren Chen authored
This is a speculative fix for https://crbug.com/856818 . It is speculated that the clip path of an element become valid without invalidating its cache, resulting in the associated clip nodes not being created, and the newly created mask layer having bad layer state. BUG=856818 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iab7acc4eb8007d03b259e6dab4f036e2b11bd900 Reviewed-on: https://chromium-review.googlesource.com/1130596Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#574425}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/80247e594d1f..fcc10da18eb5 git log 80247e594d1f..fcc10da18eb5 --date=short --no-merges --format='%ad %ae %s' 2018-07-11 mtklein@chromium.org fix color management in sprite blitter Created with: gclient setdep -r src/third_party/skia@fcc10da18eb5 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I5c8bd079d92f8d8598f032067eb6d0c26f20ca2c Reviewed-on: https://chromium-review.googlesource.com/1134446Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574424}
-
proberge authored
When using a settings-toggle-button with a sub-label whose contents can fit into one or two lines depending on screen resolution, there was no way to get consistent vertical padding. This change explicitly sets padding inside of the settings_toggle_button's outerRow element in order to guarantee padding for the item. This has the negative side-effect of causing the settings-toggle-button to expand vertically if the window is resized such that the sub-label text overflows to a new line. Bug: 803683 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iff644e6efb4aa293f4ae41e9035a961578d576f0 Reviewed-on: https://chromium-review.googlesource.com/1133300Reviewed-by:
-
John Rummell authored
When allocating a large buffer (via the fuzzer tests), calling resize() on std::vector<uint8_t> took a long time. This changes the code to use a std::unique_ptr<uint8_t[]> so that allocating a large buffer is much cheaper. BUG=817341 TEST=fuzzer test now runs in 535ms instead of timing out after 25 seconds Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If3a57a325dfab4f15d43a71b935e18c2ce759715 Reviewed-on: https://chromium-review.googlesource.com/1133586 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#574422}
-
rajendrant authored
Report the continuous data use to page load metrics in browser process via the existing renderer -> browser PageLoadMetrics mojo. Bug: 836029 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I1c7b47eb41e13f9b72d087e3ca2c0a7096c11b29 Reviewed-on: https://chromium-review.googlesource.com/1042877Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#574421}
-
Devlin Cronin authored
When transitioning from "on specific sites" to "on click", Chromium should remove specific granted sites from the extension. Do so, and add unittests for the same. Bug: 844128 Change-Id: Icfa6c1f6449e94e30560a10cf43163f2fcedd996 Reviewed-on: https://chromium-review.googlesource.com/1133775Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574420}
-
Tarun Bansal authored
The mojom call is send only when resource loading hints feature is enabled and the connection is slow. This is a reland of the CL that got reverted due to flaky browsertest. This reland is quite similar to the reverted CL, except for some changes in the browsertest. PS#1 is the original CL that got reverted. The fix is to retry fetching of histograms from the renderers. Note that previews_browsertest are currently enabled only on Android. So, it's possible that the same flakiness bug is affecting the browser tests on Linux in this CL. Bug: 854666 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I753e488bef7318e43530a5594a94b24bd09295bb TBR: rkaplow@chromium.org, dcheng@chromium.org, pkasting@chromium.org, kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1131918 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Ken Rockot authored
https://crrev.com/0e45f8023 somehow lost this logic before landing, probably during extensive debugging churn. :{ Without this, it's possible for Mach port transfer to fail when sending to a new process. Seems to have gone undetected in production so far, but https://crrev.com/3e126191 managed to trip over it consistently in ipc_tests. Bug: 753541 Change-Id: I835dc5f26326718af678acd6199c285d709b9040 Reviewed-on: https://chromium-review.googlesource.com/1134079Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#574418}
-
- 11 Jul, 2018 26 commits
-
-
Kyle Horimoto authored
After today's discussions, Bluetooth verification is no longer a step of the MultiDevice setup flow. Bug: 824568 Change-Id: I155ec838c74f427cde820fbbbedcdf3a2a43b85b Reviewed-on: https://chromium-review.googlesource.com/1134474Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#574417}
-
Avi Drissman authored
While the results pane is showing, forward cursor requests to the underlying omnibox. Note that this won't actually show any changes until 851834 is fixed. BUG=836829,851834 Change-Id: I9928fe8f690cc27f1844dbe1c0b3dae08082706d Reviewed-on: https://chromium-review.googlesource.com/1130167 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#574416}
-
Tarun Bansal authored
Change-Id: Ic12456b72ab2730e5ab1dc79ea44386deb90873d Reviewed-on: https://chromium-review.googlesource.com/1134349 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Dirk Pranke authored
This reverts commit cb82e2e4. Reason for revert: Test is failing on multiple builders, e.g.: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ASan%20Tests%20%28sandboxed%29/48812 Original change's description: > Update Chrome callsites that use MainThreadFrameObserver > > MainThreadFrameObserver does not guarantee that a compositor frame was actually > submitted. It however does synchronize the Renderer's main thread, which allows > for syncing Javascript execution in tests. > > This updates two tests in chrome/browser to use RenderFrameSubmissionObserver > for synchronizing on compositor frame submission. As well as InputEventAckWaiter > for synchronizing on input event processing. > > TEST=WebViewTest.InterstitialPageFocusedWidget, > WebViewBrowserPluginSpecificInteractiveTest.EnsureFocusSynced > > Bug: 862683 > Change-Id: Iae40b92dedf656898b9e77c6529ef118d89e0a6e > Reviewed-on: https://chromium-review.googlesource.com/1133960 > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574335} TBR=jonross@chromium.org,fsamuel@chromium.org Change-Id: Ica0e795ebad4dd81248a8e89b6f02c53e972a203 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862683 Reviewed-on: https://chromium-review.googlesource.com/1133779Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#574414}
-
Darren Shen authored
In https://crrev.com/14200002, we handled OnWindowHierarchyChanged in KeyboardController, which calls OnTextInputStateChanged. Originally, the author of the CL wanted to call OnTextInputStateChanged when the keyboard is enabled (so that if there's a focused textfield, we would show the keyboard [*]). However, OnTextInputChanged requires that the keyboard window is attached to a parent, which does not happen until later in the code. Hence, the author moved the OnTextInputStateChanged call to OnWindowHierarchyChanged, where we know for sure that the keyboard window has been attached. However, with recent changes to KeyboardController, we explicitly attach in ActivateKeyboardInContainer, so we can just move the code there without issues. [*] This behaviour is no longer true. OnTextInputChanged can't show the keyboard anymore under those circumstances. It may be possible to remove the OnTextInputChanged call completely. Bug: 845780 Change-Id: I8fb028f3b03435e43c902b40e8ffe48844be1ea3 Reviewed-on: https://chromium-review.googlesource.com/1132259Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#574413}
-
Sonny Sasaka authored
Newblue development needs to see all the discovered devices unfiltered, so this flag is useful for Newblue development and can be removed once Newblue is stable. Bug: 840517 Change-Id: I65c95c567ebfb8dbb6d831bfb1e1219b153346c0 Reviewed-on: https://chromium-review.googlesource.com/1130655 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Cr-Commit-Position: refs/heads/master@{#574412}
-
Yuki Awano authored
- Use three way flag for ChromeVox arc support. This allows developers to easily switch between TalkBack on arc and ChromeVox arc support. - This CL also changes default to disabled (TalkBack on arc). Bug: 855310 Test: None Change-Id: I301657798247da20eaf9ad734987b8d40790af1d Reviewed-on: https://chromium-review.googlesource.com/1130963 Commit-Queue: Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#574411}
-
Aaron Leventhal authored
Fire only 1 set of text removed/inserted events, only on the parent hypertext (not on the static text). This helps avoid redundant live region change announcements. Bug: 778478 Change-Id: Ic68aab54d46c98576169ecb2146cd6414413e6ac Reviewed-on: https://chromium-review.googlesource.com/1134199 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#574410}
-
Fady Samuel authored
Only log an event if the LocalSurfaceId has changed instead of on every submit and receipt of CompositorFrames. Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4814ec0aaa9c204864d5c5df0c4a359d4ef3bb28 Reviewed-on: https://chromium-review.googlesource.com/1134027 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#574409}
-
Mike Wasserman authored
Makes the debug logging output more consistent Bug: None Test: None Change-Id: Ib6ca05df6e06c7bbb31ffca7c027707af7d67966 Reviewed-on: https://chromium-review.googlesource.com/1134428 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#574408}
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/058708a665cdd9e796581dbcf60a5778d3f5e240..2b76767bf572364d3d647cdd139f2044a7ad06b2 And disable HB_VECTOR_SIZE define now that HarfBuzz has temporarily completed disabled compiler-assisted vectorisation. Bug: 860250, 862607 Change-Id: If00101a279b23f5807a85973718183b33647195d Reviewed-on: https://chromium-review.googlesource.com/1133384Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#574407}
-
kristipark authored
Bug: 851656 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I4fc218b0dba1b0dd569088a1665792b933c86ada Reviewed-on: https://chromium-review.googlesource.com/1133686 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#574406}
-
James Cook authored
We don't run ash_unittests with --enable-features=Mash anymore, so manually turn on the flag to test the feature. Bug: 840391 Test: ash_unittests Change-Id: Idb61128d9a65cbc6e93095683247c3e8cd714a9d Reviewed-on: https://chromium-review.googlesource.com/1134418Reviewed-by:
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/0ba35b21089a..e6ce828ef60c git log 0ba35b21089a..e6ce828ef60c --date=short --no-merges --format='%ad %ae %s' 2018-07-11 thomasanderson@chromium.org Revert "Trigger a buildbot cycle on client.nacl.toolchain" Created with: gclient setdep -r src/native_client@e6ce828ef60c The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=mseaborn@chromium.org Change-Id: I96d892a8a5520b5394bf8929daf655f2ab9f95e9 Reviewed-on: https://chromium-review.googlesource.com/1133873Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574404}
-
Hongchan Choi authored
No renaming or functional change. Just moving and grouping things around. Plus, some clarification/simplification of comments. Bug: 854229 Change-Id: I1a4fd3cdaf7fd41fd6c30fc199f281b46b061dc2 Reviewed-on: https://chromium-review.googlesource.com/1133715 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#574403}
-
Min Qin authored
There is no need to remove the IO TaskRunner reference. The global io thread task_runner is never deleted. If io TaskRunner is set, just ignore future calls. BUG=842245 Change-Id: Ifefad6442d8efde238379218e9f11a9f3d99a75a Reviewed-on: https://chromium-review.googlesource.com/1134197Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574402}
-
Jinsuk Kim authored
Moves web_contents_delegate_android under embedder_support to consolidate all the support components for embedders. The package path is org.chromium.embedder_support.delegate. Now the component has 4 main targets for embedders: - media - view - content_view - web_contents_delegate Note: - The choice of 'delegate' in the package name of WebContentsDelegateAndroid is just to avoid having WCDA repeated in the path. (import org.chromium .embedder_support.web_contents_delegate_android.WebContentsDelegateAndroid looked odd to me). - Got rid of 'android' wherever it is repeated in the path, and the deletion won't cause confusion. e.g. web_contents_delegate_android_java -> web_contents_delegate_java - Needs changes in the internal repo as well https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/646448 Change-Id: I44c25435c32330439ffa765d80df45b02d0694b1 Reviewed-on: https://chromium-review.googlesource.com/1118926Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#574401}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4df7c6c4. With Chromium commits locally applied on WPT: a9045946 "Add a fail-fast for longtask layouttests" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21178 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams TBR=foolip No-Export: true Change-Id: I084c2429c7bc00f6d54eb830a34bcccb62e45c3b Reviewed-on: https://chromium-review.googlesource.com/1134081 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#574400}
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values: 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Additionally there are done some other trivial cleanups. Change-Id: I8285733bbecf695b133a3865310f9a3cf0c515d6 Reviewed-on: https://chromium-review.googlesource.com/1133983 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
Chris Hamilton authored
This allows URLDataSources that have been detached from a backend to still refer to the backend if it still exists, allowing any pending queries that were issued to that backend and routed to the data source to resolve back to the backend when they are finished. BUG=859193 Change-Id: I55eda45be1f24716ad31c7d98ee748a737baca51 Reviewed-on: https://chromium-review.googlesource.com/1131537Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#574398}
-
Nick Burris authored
- Also add tests for displaying extensions, refactoring tests to a loop instead of writing all possible combinations like before. Bug: 853339 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5a02771b339751e44df4ceb1bb6f58a7796968b4 Reviewed-on: https://chromium-review.googlesource.com/1127180 Commit-Queue: Nick Burris <nburris@google.com> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#574397}
-
Kyle Horimoto authored
This fix was suggested by our UX writer jonann@ in b/111006044. Bug: 824568 Change-Id: If888000ed030b0dd90436729c77cb861a59305f9 Reviewed-on: https://chromium-review.googlesource.com/1133710Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#574396}
-
Pedro Amaral authored
ChromeActivity should call ToolbarManager's isShowingAppMenuUpdateBadge so that bottom toolbar has a chance to handle it. Change-Id: I3ffdd69896ef4e3180328c33d5a5a69d21c5fdc4 Reviewed-on: https://chromium-review.googlesource.com/1132601Reviewed-by:
-
Caitlin Sadowski authored
Change-Id: Ie1fb9b26d0c4b5e4d767033cf50143e3b4612a3f Reviewed-on: https://chromium-review.googlesource.com/1134422Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Caitlin Sadowski <supertri@chromium.org> Cr-Commit-Position: refs/heads/master@{#574394}
-
Ryan Sturm authored
As part of moving previews to an earlier decision point, this CL moves the triggering of offline previews to be consistent with other preview types. Follow-up Cls will move this decision point earlier on the UI thread so the new offline page implementation will also be able to use it. The temporary dependency on PreviewsUserData will also not be needed once the offline tab helper is accessible (the impl is on the UI thread). Bug: 842233 Change-Id: If2969a109434270659dcf723b39a7627bb8c8ecd Reviewed-on: https://chromium-review.googlesource.com/1128332Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#574393}
-
Dirk Pranke authored
This reverts commit 3dcee047. Reason for revert: Suspect this is causing more flaky failures, see e.g.: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/10567 and build 10568 Original change's description: > Reland "Fix OOPIF hit testing in layout tests." > > This is a reland of 5e93ea19 > > Original change's description: > > Fix OOPIF hit testing in layout tests. > > > > If we haven't received an activated surface yet ensure that we fallback > > to querying the renderer for the target of input events. > > > > BUG=601584 > > > > Change-Id: Id5dfcdb6bf54b98bebbd2a3b715d77202f402781 > > Reviewed-on: https://chromium-review.googlesource.com/1131219 > > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#573789} > > TBR=kenrb@chromium.org > > Bug: 601584 > Change-Id: I8a2d207db79cc237e1d5e22e5e9bfffb218486c4 > Reviewed-on: https://chromium-review.googlesource.com/1133718 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574304} TBR=kenrb@chromium.org,dtapuska@chromium.org Change-Id: I9fec8992b35943f8dd2d8ce6bafe8ac9feb49411 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 601584 Reviewed-on: https://chromium-review.googlesource.com/1134143Reviewed-by:
-
