- 30 Nov, 2017 40 commits
-
-
Mark Pearson authored
chrome/browser/ui/omnibox/ - because I've made a number of changes there myself and am familiar with this code chrome/browser/ui/views/omnibox/OWNERS - because sometimes I review changes outside of this directory that have purely mechanical changes within it and it's annoying that a second omnibox owners approval is needed in these cases. I also know how to pass the buck when I'm in over my head. Bug: Change-Id: I7f9f44d75b5f03e16bd4df4eb1e2414eb37a71fe Reviewed-on: https://chromium-review.googlesource.com/802083Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#520733}
-
Gheorghe Comanici authored
See the corresponding bug for situations where this was problematic. In particular, the omnibox edit model is using this permanent text to generate an AutocompleteInput object that gets sent to the autocomplete controller to generate matches. See link below for details: https://cs.chromium.org/chromium/src/components/omnibox/browser/omnibox_edit_model.cc?l=903 Baseline code does not update this permanent_text and generates an AutocompleteInput object that is inconsistent with the actual page for which suggestions are generated. For more details on what are the consequences of this inconsistency, see examples in the link for the bug. For the choice of permanent text that is used in the added line, see https://cs.chromium.org/chromium/src/chrome/browser/ui/views/omnibox/omnibox_view_views.cc?l=220 Bug: 788162 Change-Id: I10a8f088f9c5ba47dd9f0b652599c53ab3c1ecfa Reviewed-on: https://chromium-review.googlesource.com/797750 Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#520732}
-
Mehran Mahmoudi authored
The TextView in BarBanner for Contextual Search was not vertically aligned, but instead fixed at a vertical position. This CL vertically aligns the TextView. Change-Id: I7ffaf487ab7c93b98f530b49ae72f077237445ca Reviewed-on: https://chromium-review.googlesource.com/795172 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#520731}
-
Michał Pichliński authored
During fallback from ANGLE to SwiftShader it is required to unload ANGLE libraries, otherwise SwiftShader will fail to load its own libGLESv2.dll. Fixed ANGLE platform reset. Fixed order in ShutdownGL. Bug: 760063 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If8797b49f2b5d04cb610302f96c82011dee9b3a9 Reviewed-on: https://chromium-review.googlesource.com/774296 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#520730}
-
Lei Zhang authored
Change-Id: Id2a6ec0f8b3f086d289b932a369eece3615ca2d5 Reviewed-on: https://chromium-review.googlesource.com/798353Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#520729}
-
Sandra Sun authored
The name change was decided here [1]. This patch renames every ScrollBoundaryBehavior in the codebase to OverscrollBehaior. It is a follow-up patch of https://chromium-review.googlesource.com/c/chromium/src/+/737090 [1] https://github.com/WICG/overscroll-behavior/issues/24 Bug: 789590 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I43609da09f707ec0d09cab94c3b005007868a1b1 Reviewed-on: https://chromium-review.googlesource.com/797351Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dimitri Glazkov <dglazkov@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#520728}
-
Dale Curtis authored
Per code inspection and commentary from ffmpeg developers, we need to be using a stride that is aligned to 32 for software video frames. It seems at somepoint we might be able to use av_cpu_max_align(), but even ffmpeg doesn't follow this internally and has exceptions for when H264 content is used, so just leave a TODO for now. BUG=773673 TEST=no more ubsan failure. Change-Id: I012bf7ca5531559df63061fc1edc9fdeaebf4c08 Reviewed-on: https://chromium-review.googlesource.com/801775Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#520727}
-
Scott Graham authored
Previously, when formatting binary operators, gn format would only try to break around the operators, but the determination of whether a list was single or multiline was only determined by the number of elements in the list (and in some cases, the LHS of the assignment). Instead now, check if spliting a single line list into multiline would avoid going past 80 columns. A test run of running this new behaviour on all of chromium/src is at https://chromium-review.googlesource.com/c/chromium/src/+/801660/, and it seems like a universal improvement, fixing a number of misformattings. Bug: 790021 Change-Id: I06ab6f06388dc9429a75407864769484d3fcea41 Reviewed-on: https://chromium-review.googlesource.com/801658Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#520726}
-
Chris Blume authored
The local_id is really the parent_id. And since we will soon be adding a child_id to the mix, we should rename this to clarify. BUG=789259 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I29b48e21de5b1d137a4df4f4d9e9a3169e82c284 Reviewed-on: https://chromium-review.googlesource.com/794374Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#520725}
-
Ian Vollick authored
As of crrev.com/c/741451, SwapBuffers now requires an argument. TBR=cjgrant@chromium.org Bug: None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2bc85fe0d232ca2dac3758bb1ba88d6f329f4021 Reviewed-on: https://chromium-review.googlesource.com/802018 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#520724}
-
khmel authored
Bug: b/69813150 Test: Manually on device. No OOBE OptIn page and ARC starts Change-Id: I915d9d6a426e42b26e2f74decb76eadba3f32081 Reviewed-on: https://chromium-review.googlesource.com/792632 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#520723}
-
Michael Thiessen authored
Not sure what the race here was, but this seems to fix it. This moves animation cancel code from onActivityShown back into onResume. Bug: Change-Id: I0c3735537844c47119bc61bb5be4f8e186d85786 Reviewed-on: https://chromium-review.googlesource.com/802014Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#520722}
-
Victor Costan authored
Bug: Change-Id: I688dbbfbb5dc6cae4b724443060081932231194d Reviewed-on: https://chromium-review.googlesource.com/795189Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#520721}
-
Justin Novosad authored
This change adds a call to ProduceTextureDirectCHROIMIUM to disassociate a mailbox from its texture in case the texture gets recycled by skia, in which case the mailbox name would be leaked. BUG=789742 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic07fc9897a2fa9e42bc5b1202e044c4171ca9f9a Reviewed-on: https://chromium-review.googlesource.com/801496Reviewed-by:
Olivia Lai <xlai@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#520720}
-
Zhenyao Mo authored
This CL was originally reviewed in https://chromium-review.googlesource.com/c/chromium/src/+/773538. Patchset 1 is exactly the same. Later patches are new fixes. BUG=783512 TEST=bots R=piman@chromium.org TBR=sadrul@chromium.org Change-Id: If664ad636da5382fad35a49766e3a3162031f1ab Reviewed-on: https://chromium-review.googlesource.com/801333 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#520719}
-
Tibor Goldschwendt authored
Bug: 788768 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifd74ce6a4384a4585631e15effc09b29d2244949 Reviewed-on: https://chromium-review.googlesource.com/794041 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#520718}
-
Mitsuru Oshima authored
Moved methods that are meaningful for xdg to XdgShellSurface, and ones for remote_shell to ClientControlledShellSurface. Updated the unit test to use the correct ShellSurface instance. I found that a few tests used wrong one (that never actually used in real scenario), so I fixed them. There is one test that was failing because it's testing the scenario that does not exist. I'll fix it in a follow up CL. Bug: 773461 Change-Id: I91124da7c6274cd3dabc2e49e2abca1034dadffd Reviewed-on: https://chromium-review.googlesource.com/770454 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#520717}
-
Michael Giuffrida authored
We normally log a TabMetric UKM when an existing tab is backgrounded. If a new tab is opened in the background, we should log that as well so we have an entry to correlate it with when it is later closed or foregrounded. Similarly, if a tab navigates to a new URL while in the background (e.g. via JavaScript), we should log a new TabMetric to capture that URL. To support testing this, add a version of WebContentsTester::Create that takes a CreateParams so we can specify whether a WebContents (tab) starts hidden. This enables other tests to also override CreateParams fields when necessary. Bug: 784639 Change-Id: I189af4535a238767bb257f39ee97301bac2a4171 Reviewed-on: https://chromium-review.googlesource.com/797930 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#520716}
-
Leo Zhang authored
Add turn on/off translate switch. Read accept_langauges from native and show them in the languages page. For each language item, add a fake option memu. Screenshot: https://screenshot.googleplex.com/0HOVztouukP Bug: 783049 Change-Id: If420d76fe12ecbff277bcd6e4ab7a3a7a3419f63 Reviewed-on: https://chromium-review.googlesource.com/762540 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#520715}
-
Hector Carmona authored
Bug: 789718 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifd5d6153a4ea4e835c9187c8dab0ede871a052c1 Reviewed-on: https://chromium-review.googlesource.com/799031 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#520714}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/0ee7aab89cf2..c3fc7aa9c6bf $ git log 0ee7aab89..c3fc7aa9c --date=short --no-merges --format='%ad %ae %s' 2017-11-30 eakuefner [TBMv2] Deduplicate all diagnostics 2017-11-30 nednguyen Move cache flushing logic out of Browser constructor into PossibleBrowser classes 2017-11-29 eakuefner [TBMv2] Port DeduplicateDiagnostics to Python Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I13b530124363be50acf0c35f52a9fbbcfe6eeaee Reviewed-on: https://chromium-review.googlesource.com/801356 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520713}
-
Ted Choc authored
Lint warning: warning: [JdkObsolete] Vector performs synchronization that is usually unnecessary; prefer ArrayList. None of the usages are used outside of a single function, so no need for any synchronization. BUG= Change-Id: Ic54e896451415531ee4195d4868a55f1bb936df2 Reviewed-on: https://chromium-review.googlesource.com/801262Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#520712}
-
Eric Karl authored
Adds an ImageTransferCacheEntry which transfers raw (SW) image bytes to the GPU process via the TransferCache. Once received by the GPU proc, the image is uploaded and cached. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iec8d1c24c4f7cb2ace1ebcf216812d009d79d732 Reviewed-on: https://chromium-review.googlesource.com/779962 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#520711}
-
Brett Wilson authored
Convert to overloaded variant base::NumberToString Add SECURITY_OWNERS owner for components/network_hints/common/network_hints_messages.cc Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I1bae6619c1da5c1cf32cbbdc2fe82946e355d74f Reviewed-on: https://chromium-review.googlesource.com/799550 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#520710}
-
Khushal authored
The binding of the mojo interface used for recording UKMs by the compositor is incorrect, the interface needs to be bound to a service using the service connector to start the connection. Clone the Connector and pass it to the factory used on the compositor thread to do the binding. Its necessary to clone it for the connector access to be thread-safe. R=piman@chromium.org Change-Id: I1e20e64a6a6500e9c548599f4893d70a028574a7 Reviewed-on: https://chromium-review.googlesource.com/798538Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#520709}
-
Robert Sesek authored
This is a reland of 5bf2df67 Original change's description: > Provide a new //base-level API for crash keys v2. > > The new, preferred crash key API is located at > //components/crash/core/common:crash_key, but not all clients of the > crash key system can have a direct dependency on that. > > In this CL, a new base/debug/crash_logging.h API is created to indirect > to the new v2 API. It is less featured and flexible than the crash > component API. This will fully replace the existing API still located > in that file. > > Bug: 598854 > Change-Id: Ifabd12f80d1a858ff61b999eba956d6cd5113784 > Reviewed-on: https://chromium-review.googlesource.com/795230 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520333} Bug: 598854 Change-Id: Ic2f82fdb887b9950c52f3fb768b0e12498ba792f Reviewed-on: https://chromium-review.googlesource.com/801070 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#520708}
-
Doug Turner authored
On Android WebView, when a cancellation from a navigation throttle occurs we need to broadcast the error so that OnReceivedError can receive them. Bug: None Change-Id: I7c65fe070a702134283b48fc7a57170776111267 Reviewed-on: https://chromium-review.googlesource.com/797995Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#520707}
-
Peiyong Lin authored
PageSignalReceiver dispatches page signals to every PageSignalObserver with WebContents, thus, TabLoader will be notified with WebContents that is not managed by TabLoader, causing crash when TabLoader tries to remove it from notification registrar. This patch adds check inside OnPageAlmostIdle to ignore WebContents that is not managed by TabLoader, as well as a unit test. BUG=788744 Change-Id: If19d3b3ee9d73b932644c0574dc3b381eba3f232 Reviewed-on: https://chromium-review.googlesource.com/801655 Commit-Queue: lpy <lpy@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Cr-Commit-Position: refs/heads/master@{#520706}
-
Matthew Jones authored
This change adds a finch feature that allows the Chrome Home promo dialog to act as an information-only dialog that provides no option to opt out -- it will only display on 'ok' button. This flag acts independently of the other promo flags. The "ChromeHomePromo" flag does not need to be enabled for "ChromeHomePromoInfoOnly" to trigger the promo. This version of the dialog will show on startup if: - Chrome Home is enabled. - Chrome Home has been enabled for < 60 seconds. - The normal promo has not been seen before. Outcome metrics are not recorded in this case. BUG=789685 Change-Id: Ib8378ed86867275519aa78deb4240bd255a57939 Reviewed-on: https://chromium-review.googlesource.com/798122Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#520705}
-
dpapad authored
In other WebUIs the toolbar collapses when the window width fallows below 900px. In MD Extensions, because there is more content on the right of the toolbar, it needs to collapse sooner. Bug: 788979 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I69617f871918ffcc462834827b116aef8f7ca0bf Reviewed-on: https://chromium-review.googlesource.com/801796Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#520704}
-
Dale Curtis authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/18c815f81428..23e0b491fa58 $ git log 18c815f81..23e0b491f --date=short --no-merges --format='%ad %ae %s' 2017-11-30 dalecurtis Fix another 1 << 31 > int32_t::max() with 1u. Created with: roll-dep src/third_party/ffmpeg BUG=788343 TEST=no more ubsan issue. TBR=sandersd Change-Id: I3511f4b657a56251812fec25a4c792578598e676 Reviewed-on: https://chromium-review.googlesource.com/801352Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#520703}
-
Katie Dektar authored
Bug: 790045 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I438b266980762eff52a81968ae9fb53d8acc4f04 Reviewed-on: https://chromium-review.googlesource.com/801335Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Katie D <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#520702}
-
Olivier Robin authored
These fields belong to a form having a action="/search" attribute. This case is explicitely blacklisted from parsing and these fields should not appear in the output. Mark these tests as failing on desktop because pages are loaded via a dataURL and the form action field is not accessible (crbug.com/789944). Bug: 789949 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I925f67e68400700c83114c1487fcc00130209f44 Reviewed-on: https://chromium-review.googlesource.com/800512 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#520701}
-
Nathan Bruer authored
Disbles overrides by default. TBR=pfeldman BUG=754371 Change-Id: Icd88688a94842bd6ff96566d41e07f6615caae32 Reviewed-on: https://chromium-review.googlesource.com/801574 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by:
Blaise Bruer <allada@chromium.org> Cr-Commit-Position: refs/heads/master@{#520700}
-
Will Chen authored
Bug: 667560 Change-Id: Ic335a8364393e85de100e5b82f2d03dd6983ff84 Reviewed-on: https://chromium-review.googlesource.com/801258Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#520699}
-
Hiroshige Hayashizaki authored
Instead, use ScriptSourceLocationType::kExternalFile, Bug: 788828 Change-Id: Ibc69d49e372ff08fd5817163e157503f3e45d1ae Reviewed-on: https://chromium-review.googlesource.com/786094 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#520698}
-
Yixin Wang authored
spdy_servers_map_, alternative_service_map_, server_network_stats_map_, quic_server_info_map_, and broken_alternative_services_.recently_broken_alternative_services_ can no longer take up arbitrary amounts of memory. Bug: 709340 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iaab61d8d982caf83eec0a62f312d6616f0ef0469 Reviewed-on: https://chromium-review.googlesource.com/798397Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Yixin Wang <wangyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#520697}
-
Misha Efimov authored
Notable files: c/c/native/cronet.idl - Cronet API defined as Mojo IDL. c/c/native/generated/cronet.idl_c.h - Cronet C API generated from cronet.idl c/c/native/generated/cronet.idl_impl_interface.* - Abstract interfaces to implement C API generated from cronet.idl c/c/native/generated/cronet.idl_impl_interface_unittest.* - Simple unit tests to cover interfaces in C API generated from cronet.idl c/c/native/generated/cronet.idl_impl_struct.* - Structs to implement C API generated from cronet.idl c/c/native/generated/cronet.idl_impl_struct_unittest.* - Simple unit tests to cover structs in C API generated from cronet.idl c/c/tools/generate_idl_bindings.py - wrapper script to manually generate C API files above. c/c/tools/generators/cronet_bindings_generator.py - Cronet bindings generator script forked from mojo/public/tools/bindings/mojom_bindings_generator.py c/c/tools/generators/cronet_c_generator.py - C API generator script forked from mojo/public/tools/bindings/generators/mojom_cpp_generator.py c/c/tools/generators/c_templates/*.tmpl - C API templates based on mojo/public/tools/bindings/generators/cpp_templates/*.tmpl Bug: 786559 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibf276fffce22021a1153dfdd473983e1e552603d Reviewed-on: https://chromium-review.googlesource.com/590274 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#520696}
-
Maria Khomenko authored
BUG=674712 Change-Id: Iffa6c82bcfbfdec6b27e7340db768997f8b5fbc7 Reviewed-on: https://chromium-review.googlesource.com/755115Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#520695}
-
Victor Costan authored
This CL replaces Blob usage in the value wrapping code with direct construction of the underlying BlobData and BlobDataHandle structures, and removes a SSV data buffer copy. Change-Id: I0c107cd649c60614f6464e4b7587226cfa387893 Reviewed-on: https://chromium-review.googlesource.com/712555 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#520694}
-