- 24 Jan, 2020 40 commits
-
-
Andy Paicu authored
Since we're not using any of the notification permission prompt flavors, this CL cleans up all the code that was introduced to experiment with them. Bug: 1029718 Change-Id: I40e29f1ff5efad30a76b532ff2184561a06d4882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949363 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#734947}
-
Luca Hunkeler authored
Screenshot: https://screenshot.googleplex.com/AUtrErL2i6g.png Bug: b/145898741 Change-Id: I5aa981e76f448738a2cbc78c52cc35c10d598714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019343Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#734946}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5a922e78b53d..e2a36ca29e3d git log 5a922e78b53d..e2a36ca29e3d --date=short --first-parent --format='%ad %ae %s' 2020-01-24 tvanderlippe@chromium.org Migrate heap_snapshot_worker/ to import cross-module 2020-01-24 tvanderlippe@chromium.org Migrate mobile_throttling/ to import cross-module 2020-01-24 tvanderlippe@chromium.org Migrate har_importer/ to import cross-module 2020-01-24 aerotwist@chromium.org [Global] Updates refs to SDK.networkLog 2020-01-24 tvanderlippe@chromium.org Update replace-internal-references to accept multiple folders 2020-01-24 aerotwist@chromium.org [Global] Update refs to Workspace.fileManager Created with: gclient setdep -r src/third_party/devtools-frontend/src@e2a36ca29e3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I38761f7994e37a33af6c8b72358b36802acabc84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019072Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734945}
-
Sebastien authored
Split out GetHighlightedGame API on GamesService to two functions: - SetHighlightedGameCallback - GenerateHub In the future, when we have more feature stores, we'll add more Set*Callback, and hookup the functionalities in the GenerateHub processing function. Bug: 1018201 Change-Id: I18a7eec15cd9b907f0c087aea00bec364e830cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008013Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#734944}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9bac68c0cc44..159c414ff8f6 git log 9bac68c0cc44..159c414ff8f6 --date=short --first-parent --format='%ad %ae %s' 2020-01-24 danilchap@webrtc.org Detach LossNotificationController from RtpGenericFrameDescriptor 2020-01-24 ivoc@webrtc.org Improvements for NetEqControllers Created with: gclient setdep -r src/third_party/webrtc@159c414ff8f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Idb63c193d4bc7428c06b34d1e3462a88c9955fae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019071Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734943}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=gambard@chromium.org Bug: 1042208 Change-Id: I365945a5812c354b0a24f935a0b6b564fd34dceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017222Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734942}
-
Akihiro Ota authored
Change-Id: I9e3ed7d6272b9ee5321e6be76754b41d91ab295d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013620Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#734941}
-
Michael Ludwig authored
Bug: 1045050 Change-Id: I5528ade693cf383553c65fff229663dfc5a13740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019403 Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#734940}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=droger@chromium.org Bug: 1042208 Change-Id: I5ba779b975bc8f784419d1eb7c3b40504a3bffdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017442Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734939}
-
Sean Harrison authored
Some chromeos OS settings pages use elements from the browser settings. However they do not copy the flags from settings_ui.cc, this flag needs to be duplicated over into the chromeos/os_settings_ui.cc file manually. Bug: 1045167 Change-Id: I310b65886bbc6830b2d552085a1c2ab6cdadbc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019342Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#734938}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 1042208 Change-Id: I2ca981b7006701923494747c7cc07e024cb4c627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017223Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734937}
-
Guido Urdaneta authored
Bug: 1040894 Change-Id: Ifbc2521ab0cd6b8308b6b5da81d3f1a4a68a790d TBR: miu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019345Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#734936}
-
behdad authored
This metric was previously reported as Scheduling.Renderer.BeginMainFrameQueueDurationNotCritical. This change adds this under compositor latency as part of blink breakdown. Bug: chromium:976030 Change-Id: I2423f6b67aaf7246c69d7bf1a16b3b4ad39a01a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013461 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#734935}
-
Xida Chen authored
This CL adds a new test for off-screen main thread animations. TBR=sadrul@chromium.org Bug: 1021963 Change-Id: I78bf2eba1c1c5abb63151f26be61daa228bea4fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008351Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#734934}
-
Vasiliy Telezhnikov authored
This CL implements CompositorFrame submission inside HardwareRendererViz to reuse frame delivery over old webview path. Bug: 805739 Change-Id: I7d76016c060e3e3bd174b27f3bcfef6988546925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016326Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#734933}
-
Eric Seckler authored
Switch from Process/ThreadDescriptors to TrackDescriptors and from TrackEvent timestamps to TracePacket timestamps. Async events still continue to use LegacyEvent and its IDs. This also enables emitting process/thread names in the Process/ThreadDescriptors, now that we can detect pid/tid reuse in trace processor during proto2json conversion. Bug: 928738, 1040525, 991126 Change-Id: I8c1fa5b9c8db57d145c6886956b325e7d7e54993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002518 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#734932}
-
Wez authored
This is a partial reland of 4189e014 The original change removed both shadow-call-stack and safestack overrides, which broke Blink heap unit-tests under x64, but was not caught by CQ due to issue 1044935. Fuchsia builds have been orcibly enabling shadow-call-stack in advance of it becoming the toolchain default, to gauge size impact. Enabling shadow-call-stack under x64 is not recommended and breaks code which uses C++ exceptions, which is true of some V8 code & tests. Since the toolchain default for shadow-call-stack should now correctly enable it under ARM64 but not x64, remove the override. Bug: 1028617, 821951 Change-Id: I8784d8fc24d81716e27a53d41f0548343621ad75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014908 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#734931}
-
anina koehler authored
Replacing optparse with argparse since optparse is deprecated. Bug: 1032064 Change-Id: Idf55d7e83f885a3d2e664661eccf33ba671070d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007285 Commit-Queue: Anina Koehler <aninak@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#734930}
-
Koji Ishii authored
When LayoutNGBlockFragmentation is enabled, r718532 <crrev.com/c/1930287> added a branch to use |NGPaintFragment| directly, without using |NGInlineCursor|. This patch fixes to use |NGInlineCursor|. There's no virtual tests for this combination, but tests fail if both of these two flags are enabled. Caught in a manual review. Bug: 982194 Change-Id: Ic22ebc68d6e9d24896c3686d5797ce248c2d0a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016803 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734929}
-
Rushan Suleymanov authored
Untrack entities from ClientTagBasedModelTypeProcessor by client tag hash properly. Removes entity even if it has storage key. Bug: 947044 Change-Id: I820bb173629ccb3d181a8e79d5bf5c9fe3ab9a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015054Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#734928}
-
anina koehler authored
When running tests from device_cloud_policy_manager_chromeos_unittest.cc, GMOCK warnings about uninteresting mock function calls are appearing. Since the mock functions OnDeviceCloudPolicyManagerConnected and OnDeviceCloudPolicyManagerDisconnected are only used in one of the tests, a subclass that contains the mock functions was created for this test. Bug: 654758 Change-Id: Iaf3f8b17b017523b41bb044eacce59de6d4384ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012162 Commit-Queue: Anina Koehler <aninak@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#734927}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=msramek@chromium.org Bug: 1042208 Change-Id: Ib9e10374af72f00ed43e7461190ae717d5471a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017328Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734926}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=mmenke@chromium.org Bug: 1042208 Change-Id: I6f032084a5bfa72b018906ba98cecf096283c878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014918 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734925}
-
Justin Miron authored
This propagates frame's intersections with the main frame document to their respective render frame observers when the intersection changes between renderer updates. This change is followed up by a CL (https://crrev.com/c/1982622/4 ) that propagates these intersections through page load metrics to the browser process. BUG=993453 Change-Id: I52a456b42997a7cae3f23c0d7090c94b05b3cea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980498 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#734924}
-
Jazz Xu authored
This CL add picture-in-picture action to media session for PiP in Global Media Controls. Bug: 1040261 Change-Id: I0e998af7c55f247af93da24ee8b49bfc18283888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992680Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734923}
-
Ioana Pandele authored
Up until now, the CredentialCache was populated only when credentials were ready to be autofilled into the form. The same information is available slightly earlier, right after the credentials are fetched from the store. Bug: 1044930 Change-Id: I64e8135b08014d97da249a189a4c199bf605b661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013286 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#734922}
-
Robbie Gibson authored
When the user clears their browsing data, any zoom levels that are stored in the user prefs should be deleted as well. Bug: 1028938 Change-Id: I70fb95cb2e76fc8e3eba66895de47735c3bd096b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016630Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#734921}
-
Gauthier Ambard authored
Bug: none Change-Id: Ibe47678756108fde935e1d32e8ec744d0860b2af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007283 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#734920}
-
about://flagAaron Tagliaboschi authored
Bug: 955620 Change-Id: I453e9d11f53ae47387a358d33199c3ccae07a243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014122 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#734919}
-
Armando Miraglia authored
Bug: 776327 Change-Id: I2ff847c7a025d067d4cd9cea08f1f710f55c567e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017433 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#734918}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6f088c0566ed..5a922e78b53d git log 6f088c0566ed..5a922e78b53d --date=short --first-parent --format='%ad %ae %s' 2020-01-24 aerotwist@chromium.org [Global] Update refs to SDK.multitargetNetworkManager 2020-01-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-01-24 tvanderlippe@chromium.org Migrate data_grid/ to import cross-module 2020-01-24 tvanderlippe@chromium.org Migrate object_ui/ to import cross-module 2020-01-24 tvanderlippe@chromium.org Migrate inline_editor/ to import cross-module 2020-01-24 tvanderlippe@chromium.org Do not output text coverage when running locally 2020-01-24 tvanderlippe@chromium.org Add script that checks license headers of JavaScript files 2020-01-24 aerotwist@chromium.org [Global] Updates refs to Components.dockController Created with: gclient setdep -r src/third_party/devtools-frontend/src@5a922e78b53d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1032561 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib4db18a6004f431114efb7d768adbd433e50d653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019069Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734917}
-
Hazem Ashmawy authored
Following image optimizing guidelines in[1], performed lossless compression by running optimage script from google specific guidelines. zopflipng is the best compressor for all the images and it yielded the following results: drawable-mdpi: compressed to 2934 bytes (savings: 40 bytes = 1.00%) drawable-hdpi: compressed to 4509 bytes (savings: 30 bytes = 0.00%) drawable-xhdpi: compressed to 6600 bytes (savings: 11 bytes = 0.00%) drawable-xxhdpi: compressed to 11161 bytes (savings: 278 bytes = 2.00%) reduced overall image sizes by 1.4% (25563 -> 25204 bytes) [1] https://chromium.googlesource.com/chromium/src/+/HEAD/docs/speed/binary_size/optimization_advice.md#Optimizing-Images Bug: 1045005 Change-Id: I3440cacf5ec7474ee4c3f166ca1dffd3914c7bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017370Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#734916}
-
Johannes Kron authored
Bug: 1045194 Change-Id: Idb1b70d9d611b71adda69756e44bf86628e6f2c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019024 Auto-Submit: Johannes Kron <kron@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#734915}
-
Hazem Ashmawy authored
Following image optimizing guidelines in[1], performed near-lossless compression using pngquant on icon_webview png files which: reduced drawable-mdpi by 58% (7151 -> 2974 bytes) reduced drawable-hdpi by 68% (13975 -> 4539 bytes) reduced drawable-xhdpi by 70% (21981 -> 6611 bytes) reduced drawable-xxhdpi by 70% (37607 -> 11439 bytes) reduced overall image sizes by 68.33% (80714 -> 25563 bytes) script: ``` $pngquant --version 2.12.2 (January 2018) $pngquant */icon_webview.png -f --ext=.png ``` [1] https://chromium.googlesource.com/chromium/src/+/HEAD/docs/speed/binary_size/optimization_advice.md#Optimizing-Images Bug: 1045005 Change-Id: Ib45dc147fa7668c6b2e4b95132a883e7f50fba73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017469Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#734914}
-
Colin Blundell authored
This componentization is part of the ongoing effort to componentize //chrome's SSLErrorHandler for sharing with WebLayer. It is straightforward following preceding CLs. TBR=jochen@chromium.org Bug: 1030692 Change-Id: I0a727101fa47e65f28b86b8449ffb57f5968ff04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012960 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#734913}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=droger@chromium.org Bug: 1042208 Change-Id: I77d72b14b9e11984192dd9ecb736b39ba41a02a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014939Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734912}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=gambard@chromium.org Bug: 1042208 Change-Id: I0e14f7124e29be264b164c36985bc0d2e5de5ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017505Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734911}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/612949e9d25e..f368925e49f4 git log 612949e9d25e..f368925e49f4 --date=short --first-parent --format='%ad %ae %s' 2020-01-24 lalitm@google.com Merge "tp: fix output of events with empty arg set" Created with: gclient setdep -r src/third_party/perfetto@f368925e49f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I8dc49e8a8364b085e66a21d2c36448e12f9acefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019067Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734910}
-
https://crbug.com/1028577Marc Grimme authored
This adds an integration test that covers a bug that was observed when default_policy_allowed/blocked_hosts were specified but should be different per browser profile. It turned out they were global. This was fixed and the CL:1978680 introduces the test to cover this. R=marcgrimme Bug: 1031179 Change-Id: I6a5a0b10109ed4b358bd4344a56eeac705949198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978737 Commit-Queue: Marc Grimme <marcgrimme@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#734909}
-
Alex Ilin authored
The last step of the browser resolution flow is to make another call to IssueToken with the consent result. This call should actually generate and return the token. If this call fails, an error will be returned to the extension. Bug: 1026237 Change-Id: If350d325492d7d88f0583cc1687da7e5f7474d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017486 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#734908}
-