- 13 Nov, 2018 40 commits
-
-
Mike West authored
Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Ff6Ywg5vnh4/VbDH4X6wBQAJ Explainer: https://github.com/WICG/feature-policy/issues/241 Spec PR: https://github.com/whatwg/html/pull/4170 Bug: 904351 Change-Id: I14c0c3c871a01017f9c2bcbe8ed41c7b26782e71 Reviewed-on: https://chromium-review.googlesource.com/c/1329791 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#607530}
-
Andreas Haas authored
The field trial should be turned on by http://cl/220249819. R=mpearson@chromium.org Change-Id: Ifa0b4c5d7c9850c304bc4d2ce5b4fb44328f85da Reviewed-on: https://chromium-review.googlesource.com/c/1318910 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#607529}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/eb9d3fbd..4fe505da Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I338bb51edb7fd45e953971dbe50e453985088b07 Reviewed-on: https://chromium-review.googlesource.com/c/1333229Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607528}
-
Stephane Zermatten authored
This change improves the scrolling for highlighted elements. Before this change, while scrolling, highlighted elements were updated by the periodic update of the element position, which happens every 100ms. While scrolling, this produces noticeable jumps. After this change, while scrolling, elements position is updated based on the scroll position and the periodic updates are ignored. This means that scrolling of the highlighted area follows the UI scrolling, which is much smoother. Note that there can still be a shift between the highlighted area and the element, as the web page doesn't always scroll exactly at the same speed as the UI elements, but the shift is much smaller and smoother. Bug: 806868 Change-Id: Ide5f9b6f0ba472c93ced2dd26b4cbaf2ee14b59f Reviewed-on: https://chromium-review.googlesource.com/c/1331401 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607527}
-
Andreas Haas authored
eholk left the team. NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=adamk@chromium.org Change-Id: Icef00e5fe48a66388fdb891014c204ad494ea3bc Reviewed-on: https://chromium-review.googlesource.com/c/1331470Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#607526}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/13b099f8982c..1e1ba0e0176f git log 13b099f8982c..1e1ba0e0176f --date=short --no-merges --format='%ad %ae %s' 2018-11-13 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@1e1ba0e0176f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I73b739adba30946c9702c72f53162a1bfa8298a5 Reviewed-on: https://chromium-review.googlesource.com/c/1332831Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607525}
-
Matthew Cary authored
The existing logic is not correct for code that's not word-aligned, which happens frequently with thumb (16-bit) instruction words. Also asserts that no symbols appear before the starting symbol. We expect that the only symbols we have are from text, and that the symbol placed by the linker script occurs not after any symbol. Breaking either of the assumptions may break assumptions made elsewhere. Bug: 893981 Change-Id: I748c9edd0f6a5f49790b4c06d4246ee1cf8f90dc Reviewed-on: https://chromium-review.googlesource.com/c/1329166 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#607524}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c7c538bb4af4..5ff1dec42b3d Created with: gclient setdep -r src-internal@5ff1dec42b3d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie122e4ef711f3c3059a9b25a59536683baf96f94 Reviewed-on: https://chromium-review.googlesource.com/c/1333058Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607523}
-
Yi Su authored
This CL clean up some defects in search_engine.js. Firstly remove those URL links in comments that contain line number as URL args, because they are easy to be broken by change in referred files. Secondly change all "var" to "let" since it's supported in iOS 10 and the presubmit check has been removed. Bug: 433824 Change-Id: I6ba00a95c904c897b3845ddd6a96b29fef639b73 Reviewed-on: https://chromium-review.googlesource.com/c/1329976Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#607522}
-
Mario Sanchez Prada authored
Migrate usage of SigninManagerBase::IsAuthenticated() to the IdentityManager's API. Bug: 903882 Change-Id: Ib452442d5eff692eed54c7c690845005c9b1717c Reviewed-on: https://chromium-review.googlesource.com/c/1331399Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#607521}
-
Gang Wu authored
This CL for Recording user actions in Feed, which were recorded in Zine. Bug: 902126 Change-Id: Ie20f82d5644dd856f350c4ad7729b72946a41601 Reviewed-on: https://chromium-review.googlesource.com/c/1330721 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#607520}
-
Robbie McElrath authored
This reverts commit 1ab94ee7. Reason for revert: crbug.com/904739 Original change's description: > Reland "Get NetworkChangeNotifier working on ChromeOS with network service." > > This reverts commit 0d2550b1. > > Reason for revert: Fixed NetworkContextConfigurationFilePacBrowserTest > > Original change's description: > > Revert "Get NetworkChangeNotifier working on ChromeOS with network service." > > > > This reverts commit 7b0677dd. > > > > Reason for revert: findit says this broke something. I'll revert and see if it's right tomorrow. > > > > Original change's description: > > > Get NetworkChangeNotifier working on ChromeOS with network service. > > > > > > The current NetworkChangeNotifierChromeOS implementation won't work > > > with the network service enabled because it listens for network changes > > > from Shill, which only supports a single client. The browser process > > > has other dependencies on Shill, so it has to be the client for the time > > > being, meaning the network service can't directly listen for network > > > changes and has to be notified of them from the browser process. > > > > > > This CL splits the NetworkChangeNotifierChromeOS into two parts; > > > the first will live in the browser process and listen to Shill, while > > > the second is the actual NetworkChangeNotifierChromeOS implementation > > > which will have an instance in both the browser and network processes. > > > Since NetworkChangeNotifierChromeOS can't actually listen for network > > > changes itself, it just gets notified of changes from part 1 via a new > > > method in NetworkChangeManager. When the thing listening to Shill sees > > > a network change, it notifies its local NetworkChangeNotifierChromeOS > > > instance, and calls the new NetworkChangeManager method, the > > > implementation of which then notifies the network service's > > > NetworkChangeNotifierChromeOS instance. > > > > > > Bug: 882610 > > > Cq-Include-Trybots: luci.chromium.try:linux_mojo > > > Change-Id: Ib220575fbe42f026b1e5cb90d3bb6be9d0345414 > > > Reviewed-on: https://chromium-review.googlesource.com/c/1274445 > > > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > > > Reviewed-by: Will Harris <wfh@chromium.org> > > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#606665} > > > > TBR=stevenjb@chromium.org,jam@chromium.org,pauljensen@chromium.org,wfh@chromium.org,rmcelrath@chromium.org > > > > Change-Id: I1fa2bcabe73082e02e59f7c613d08aec4ac94e57 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 882610 > > Cq-Include-Trybots: luci.chromium.try:linux_mojo > > Reviewed-on: https://chromium-review.googlesource.com/c/1328701 > > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> > > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#606745} > > TBR=stevenjb@chromium.org,jam@chromium.org,pauljensen@chromium.org,wfh@chromium.org,rmcelrath@chromium.org > > Change-Id: Ied0722203a1fa29aa3420bb84c70dee15d47fbb6 > Bug: 882610 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Reviewed-on: https://chromium-review.googlesource.com/c/1329897 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607351} TBR=stevenjb@chromium.org,jam@chromium.org,pauljensen@chromium.org,wfh@chromium.org,rmcelrath@chromium.org Change-Id: Iaf54b01741708b865f8ab5979afc9292babdb1c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882610 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/c/1333248Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#607519}
-
Benoît Lizé authored
|ParkableStringManager::SetRendererBackgrounded()| schedules delayed tasks, but tests were not waiting for the tasks to run, instead directly calling the delayed functions. This adds a test checking for proper task sequencing, and changes other tests to properly wait for tasks. As a consequence, the ParkableStringManager tests no longer need to be friend with ParkableStringManager, provided that |Size()| becomes public. Also fixes a couple "git cl lint" warnings. Bug: 877044 Change-Id: I15ea4285596dc744969e0bce63c5687e6fed023c Reviewed-on: https://chromium-review.googlesource.com/c/1331476Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#607518}
-
Koji Ishii authored
Bug: 635619 Change-Id: I5f2992f95f755e56c34ce5a89c5185ae31b6537f Reviewed-on: https://chromium-review.googlesource.com/c/1333010Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#607517}
-
Christopher Lam authored
This CL makes the optional parts of AppInfo editable, which allows for simpler construction. TBR=jamescook@chromium.org Bug: None Change-Id: I2a94765cdcba253951f802f15bab0e5d0e01a6d0 Reviewed-on: https://chromium-review.googlesource.com/c/1325277Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#607516}
-
Vladislav Kaznacheev authored
Autocomplete breaks several features (see linked bugs) and a correct fix requires investigation. Disabling the feature for now. Bug: 897206, 902558 Test: manual Change-Id: I54a68a88541fab0e2054349c32c1c1892324f67a Reviewed-on: https://chromium-review.googlesource.com/c/1332148Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#607515}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/16bc600d527a..c7c538bb4af4 Created with: gclient setdep -r src-internal@c7c538bb4af4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ieaceefc4d9c8b241aaace92693a8ff48f5bb6277 Reviewed-on: https://chromium-review.googlesource.com/c/1333057Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607514}
-
Takashi Toyoshima authored
Existing implementation uses a single PreflightController for all profiles, but ideally it should be per-profile. This patch makes the controller per-profile for NetworkService, and does it per-factory for legacy code path due to lack of NetworkContext. Bug: 894690 Change-Id: Ief446431e4235bcecd68ba1f50528e721efed96a Reviewed-on: https://chromium-review.googlesource.com/c/1331349Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#607513}
-
Christopher Lam authored
This CL makes the CallbackRouters responsible for removing listeners. This improves ergonomics of removing a list of listeners for different InterfaceCallbackTargets. Bug: 894376 Change-Id: I051857e463257100d667cf78ca8cc2c1d53bcd83 Reviewed-on: https://chromium-review.googlesource.com/c/1301034 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#607512}
-
Koji Ishii authored
Following bot results are included. 11590 11634 11637 11639 11644 11652 11670 11680 11685 11686 11689 11694 11703 11710 11720 11722 11724 11734 11740 11746 11751 11755 2 lines were removed and 9 lines were deflaked by consecutive results since 11689. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: Iba29f6bf95f6025fb6304757e0f1652ac8a13db2 Reviewed-on: https://chromium-review.googlesource.com/c/1327301 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#607511}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f04fb3cacbad..13b099f8982c git log f04fb3cacbad..13b099f8982c --date=short --no-merges --format='%ad %ae %s' 2018-11-13 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@13b099f8982c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I23c1df8e102aeda4c5bb5a0a8ca41535a018461f Reviewed-on: https://chromium-review.googlesource.com/c/1333056Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607510}
-
Yuki Shiino authored
This reverts commit bf9ab045. Reason for revert: This seems like causing "chrome_public_test_apk on Android device Nexus 5X" fail. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3601 https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Android%20CFI/builds/3602 Original change's description: > Android: TabThemeColorHelper > > This is to break the TabObserver present in Tab class down to feature > level and eventually remove it. Theme color used for Tab is managed via > Tab UserData. Relevant Tab methods also got migrated. > > Bug: 877878 > Change-Id: If120beaaa370d07f6855ab666e380cc2318e945a > Reviewed-on: https://chromium-review.googlesource.com/c/1304038 > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607422} TBR=tedchoc@chromium.org,jinsukkim@chromium.org Change-Id: I4bc704a509682873ef9f1a2e4f4fe82ac2a5cac2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 877878 Reviewed-on: https://chromium-review.googlesource.com/c/1333098Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#607509}
-
Jia authored
Default frequency of the sensor is 1hz. As we are not increasing it, we should only read it at the same frequency. Bug: 881215 Change-Id: Id3caa1d5f41177f511e6d0d5559b9da3311b5edf Reviewed-on: https://chromium-review.googlesource.com/c/1333172Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#607508}
-
Alexey Baskakov authored
We will reuse them in WebAppDataRetriever together with WebAppIconDownloader. Unify |SizesToGenerate|: it is {32, 64, 48, 96, 128, 256} preset everywhere. (Matches the old behavior). Bug: 875698 Change-Id: Ifa06136294ab5dfefd1785a143268c6a5379a154 Reviewed-on: https://chromium-review.googlesource.com/c/1331101 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#607507}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/51a60d9d8dca..16bc600d527a Created with: gclient setdep -r src-internal@16bc600d527a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If12294a83b54cd421dadba8064d4148be185cc5c Reviewed-on: https://chromium-review.googlesource.com/c/1332830Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607506}
-
Nektarios Paisios authored
I tried hard, but I wasn't able to make non-text positions work inside a table. The DOM parser collects all the non-white space text nodes between the table cells and places them in a single text node before the table element. This is not part of the accessibility code, but is how the DOM parser works. The alternative, which I implemented in this patch, is to enhance the table test by adding more selections inside text nodes. <table> ^<tr> <td>column</td> </tr>| </table> Becomes in the DOM tree: Body ++#Text "\n^|\n" ++Table ++++Tr ++++++Td R=dmazzoni@chromium.org Change-Id: I99c4a1f14805f9a0ba4addbaaff9bad1b1a0b86b Reviewed-on: https://chromium-review.googlesource.com/c/1332728Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#607505}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/24bad97f..eb9d3fbd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I58bae19089f736c8f54d96929b3a53f0eb10b0a1 Reviewed-on: https://chromium-review.googlesource.com/c/1333125Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607504}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I4a8be4dff14b6921cc2fb04eb34594f759c545df Reviewed-on: https://chromium-review.googlesource.com/c/1333168Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#607503}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0b18583285cb..cd47a379f960 git log 0b18583285cb..cd47a379f960 --date=short --no-merges --format='%ad %ae %s' 2018-11-13 jie.a.chen@intel.com Add SH_INIT_SHARED_VARIABLES flag 2018-11-12 timvp@google.com Fix failing dEQP EGL tests. 2018-11-12 jmadill@chromium.org Whitespace change to cq.cfg. 2018-11-12 jmadill@chromium.org Add missing refs.cfg. 2018-11-12 jmadill@chromium.org Whitespace change to cq.cfg. Created with: gclient setdep -r src/third_party/angle@cd47a379f960 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:898030,chromium:833848,chromium:833848,chromium:833848 TBR=cwallez@chromium.org Change-Id: I5b67d20c08fdeb6614bca9c7e0f451988f836d27 Reviewed-on: https://chromium-review.googlesource.com/c/1333054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607502}
-
Sam McNally authored
Guest mode profiles do not have a valid account ID key so requesting their DriveFS path is invalid. Such accounts never have Drive enabled and the downloads path should not be within Drive if disabled. Update DriveIntegrationService to avoid paths within Drive when disabling Drive with DriveFS enabled so the above assumption is valid with DriveFS enabled. Bug: 904558 Change-Id: Ic8b64609f3657feae4b1f289e3726a51a871b36c Reviewed-on: https://chromium-review.googlesource.com/c/1333091Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#607501}
-
Hayato Ito authored
EventPath: :operator[] can be used. Change-Id: I97a49e26c2903e7966d23594e8283e77b5bd235d Reviewed-on: https://chromium-review.googlesource.com/c/1333170Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#607500}
-
Xiaocheng Hu authored
This patch stops a crash in InlineContents previous/next iteration by terminating the iteration at document boundary, so that subsequent operations don't proceed with invalid parameters. Bug: 903723 Change-Id: Iaed2ac1d5d74d3ab59da3a2f0db2d4f8150fb21b Reviewed-on: https://chromium-review.googlesource.com/c/1331571Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#607499}
-
Adam Rice authored
It turns out to better to create the MessagePort early in C++ and then pass it to ReadableStreamSerialize. Make ReadableStreamSerialize take a second argument instead of creating its own MessageChannel. This also enables us to remove MessageChannel from the binding object. Also add wrapper methods on ReadableStream to abstract out the V8 Extras implementation. No user-visible changes. BUG=894838 Change-Id: I2616855d34a925915919245ec10338463ac5ef37 Reviewed-on: https://chromium-review.googlesource.com/c/1329813Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#607498}
-
Xianzhu Wang authored
We treated only DrawingDisplayItem as cacheable before SlimmingPaintV175 because other display items were all about paint properties which are not feasible to be cached (mostly because they are paired and sometimes don't have unique id). Now we have removed paired display items, thus the remaining types of display items are all eligible to be cached. This prepares for making HitTestDisplayItem not DrawingDisplayItem to reduce its size, etc. Change-Id: I28bd5533d3b85a67fc16e90aea059115b51188e7 Reviewed-on: https://chromium-review.googlesource.com/c/1329805Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#607497}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1ce66d537f0b..51a60d9d8dca Created with: gclient setdep -r src-internal@51a60d9d8dca The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I29cf19fce446ff4a55f6c40d3c4eae4907a4b42c Reviewed-on: https://chromium-review.googlesource.com/c/1332829Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607496}
-
Xianzhu Wang authored
- Combine CullRect::UpdateCullRect() and CullRect::UpdateCullRectForScrollingContents() into CullRect::ApplyTransform() which accepts a TransformPaintPropertyNode. For SPv2, if the transform node has scroll node, we'll expand the cull rect for composited scrolling. - Rename CullRect::IntersectsCullRect() to CullRect::Intersects() - Change CullRect constructor with offset to mutation methods to keep consistent with ApplyTransform(). Bug: 792577 Change-Id: I306f5c7acacf73d97100c6c863b71e0df41c34af Reviewed-on: https://chromium-review.googlesource.com/c/1319650Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#607495}
-
Hiroki Nakagawa authored
To sheriff: Please re-disable the test if it's still flaky. In this test file, some tests start re-registering the second service worker before the first service worker gets activated. In my theory, this sometimes squashes the second registration job into the first registration job, and results in test flakiness. This CL makes sure the second register runs after the first service worker gets activated. Note that it would be the correct behavior that the second registration job isn't squashed when the script type is changed. There is a spec issue about this: https://github.com/w3c/ServiceWorker/issues/1358 Bug: 901317 Change-Id: I7ce379071a35ef9aeb98e4492d651ee6fc4714ec Reviewed-on: https://chromium-review.googlesource.com/c/1328546Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#607494}
-
John Budorick authored
Bug: 861983 Change-Id: Id5cf2ad9525790cc99a0c8da4a8b793bba1e3696 Reviewed-on: https://chromium-review.googlesource.com/c/1317036Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#607493}
-
Hayato Ito authored
- EventPath::GetTreeScopeEventContext(TreeScope&) - Node& NodeEventContext::GetNode() - TouchEventContext& TreeScopeEventContext::EnsureTouchEventContext() They never be nullptr. Bug: 874385 Change-Id: I38167ee25dd01113aae7cbbdb97101fce7a07a2e Reviewed-on: https://chromium-review.googlesource.com/c/1332969Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#607492}
-
Justin Cohen authored
Enables features to stop loading NTP from within ios/web CRWNativeContent. Instead the NTP is presented directly from the BVC. Also disables a failing pdf test that is already flakey on iOS11. Bug: 826369 Test: Any interactions to navigate to or from, hide or show, an NTP. Change-Id: I61cdcb41b2a09955f6cb994a220cd32ea8a0b602 Reviewed-on: https://chromium-review.googlesource.com/c/1332411 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#607491}
-