GitLab

BUG=387159
NOTRY=true

Review URL: https://codereview.chromium.org/348533008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278796 0039d316-1c4b-4281-b951-d872f2087c98

This test is crashing frequently.

BUG=387045
TBR=michaeln@chromium.org

Review URL: https://codereview.chromium.org/341193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278795 0039d316-1c4b-4281-b951-d872f2087c98

This CL enables custom color to be specified for IME composition.
Its Blink counterpart is https://codereview.chromium.org/313233002/ . Details:

- Prerequesite: the Blink change, since we assume WebCore::CompositionUnderline and
blink::WebCompositionUnderline have been updated.
- Prerequesite CL: https://codereview.chromium.org/319553002/ to allow
structures to temporarily mismatch, without triggering compiler assert.
- Adding background_color to ui::CompositionUnderline.
- To pass data from Android to Native C++, using JNI generator with callback: In C++, ImeAdapterAndroid::SetComposingText() calls Java to iterate over spans, then dispatch BackgroundColorSpan and UnderlineSpan data to C++ code and populate list of blink::WebCompositionUnderline.

We'll need to split this CL when we commit.

BUG=135900

Review URL: https://codereview.chromium.org/313053007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278794 0039d316-1c4b-4281-b951-d872f2087c98

Some tests in content_browsertests are broken if --enable-text-input-focus-manager is enabled.  Fix those tests.

Since not all unittests run wm::FocusController::SetFocusedWindow, it turned out that we need WMTestHelper (instead of FocusController) to clear the text input client.

BUG=290701
TEST=Run content_browsertests with --enable-text-input-focus-manager enabled.

Review URL: https://codereview.chromium.org/340413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278793 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381447

Review URL: https://codereview.chromium.org/331793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278792 0039d316-1c4b-4281-b951-d872f2087c98

WebMediaPlayerImpl::seeking_ essentially tracks the same state.

BUG=144683

Review URL: https://codereview.chromium.org/343053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278791 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334602

Review URL: https://codereview.chromium.org/336543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278789 0039d316-1c4b-4281-b951-d872f2087c98

experiment state correctly now that its a multi-valued option.

BUG=386680

Review URL: https://codereview.chromium.org/343023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278788 0039d316-1c4b-4281-b951-d872f2087c98

Designers asked for some final tweaks to polish the interstitials. Small changes to CSS and strings.

BUG=381260
passed all of the bots at least once but cq is dead dead dead:
NOTRY=true

Review URL: https://codereview.chromium.org/344943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278787 0039d316-1c4b-4281-b951-d872f2087c98

Xcode 6 moved the location of the frameworks that iossim depends on and
added a few new dependecies so new header files need to be generated by
the gyp target.

Note that this CL gets iossim to compile but iossim will not launch the
Xcode 6 simulator.

BUG=381213
NOTRY=true
TBR=rohitrao@chromium.org

Review URL: https://codereview.chromium.org/336773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278786 0039d316-1c4b-4281-b951-d872f2087c98

R=sbc@chromium.org

Review URL: https://codereview.chromium.org/348823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278784 0039d316-1c4b-4281-b951-d872f2087c98

 gfx::ImageKia will fetch the ImageSkiaRep based on resource scale factor (supported one) and scale accordingly.

BUG=381601
TEST=covered by test.
R=ananta@chromium.org, pkotwicz@chromium.org, rsesek@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278589

Review URL: https://codereview.chromium.org/340613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278783 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278782 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176539:176561&mode=html
BUG=
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/345153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278781 0039d316-1c4b-4281-b951-d872f2087c98

Include this in the blacklist, since it was just released, so
assume still broken.

R=boliu@chromium.org

Review URL: https://codereview.chromium.org/343183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278780 0039d316-1c4b-4281-b951-d872f2087c98

 And fix a bug found with the tests.
 BindGraphics() does not work for a device which is in the same type with the current bound device.

BUG=374383
R=piman@chromium.org, raymes@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278728

Review URL: https://codereview.chromium.org/324983005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278779 0039d316-1c4b-4281-b951-d872f2087c98

BUG=305852

Review URL: https://codereview.chromium.org/349543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278778 0039d316-1c4b-4281-b951-d872f2087c98

This is an overly-big hammer that will be refined later.

BUG=383043
R=asvitkine@chromium.org, gab@chromium.org, mattm@chromium.org, noms@chromium.org

Review URL: https://codereview.chromium.org/348433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278777 0039d316-1c4b-4281-b951-d872f2087c98

The alternate filename is intended to be the old name of the pref file being read, JsonPrefStore handles the migration if required. JsonPrefStore's FileThreadDeserializer is the best place to do this as it's the only code in the prefs stack running on a thread allowed to do IO (another solution would be to let JsonPrefStore take a PreReadOnFileThreadCallback to abstract the required work away, but the direct approach seemed easier here without breaking encapsulation).

BUG=372547

Review URL: https://codereview.chromium.org/347793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278776 0039d316-1c4b-4281-b951-d872f2087c98

BUG=327641

Review URL: https://codereview.chromium.org/348583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278775 0039d316-1c4b-4281-b951-d872f2087c98

When transmitting 4Mbit over the "bad" udp_proxy profile, this reduces the
amount of data sent from 12Mbit/s to 7Mbit/s, and seems to make it able to
actually send more frames across the wire and recover faster.

Review URL: https://codereview.chromium.org/343523005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278774 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278773 0039d316-1c4b-4281-b951-d872f2087c98

See https://codereview.chromium.org/344903003/
for the actual changes.

BUG=386801
R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/348683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278772 0039d316-1c4b-4281-b951-d872f2087c98

    
The main usage of the keyCode attribute is to supports sending correct
soft key events. On the on-screen keyboard, each key should have the
keyCode attached, e.g. the key on the right side of TAB key, in US
keyboard layout, it has key:'q',code:'KeyQ',keyCode:0x51; while in FR
keyboard layout, it has key:'a',code:'KeyQ',keyCode:0x41.
Another example is for UK extended keyboard layout, the '#' key (at the
backslash key location), it has key:'#',code:'BackSlash',keyCode:0xDE;
while for US keyboard, it has key:'\\',code:'BackSlash',keyCode:0xDC.

A real case that this cl will fix is on FR on-screen keyboard, pressing
Ctrl+A will trigger Ctrl+Q shortcut.

BUG=355261
TEST=None

Review URL: https://codereview.chromium.org/346513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278771 0039d316-1c4b-4281-b951-d872f2087c98

Convert numeric error code from libusb into human readable strings and
log them. Some of these errors should, in addition, be passed up to the
running script.

BUG=

Review URL: https://codereview.chromium.org/344793009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278769 0039d316-1c4b-4281-b951-d872f2087c98

Due to recent Git mirgration on bots, builds are archived using Git hash in filename
instead of SVN revision. Bisects should check for builds either with Git hash or SVN
revisions and download.
Also this CL allows bisect to continue when a revision under test fails to build
(except good or bad revisions).

BUG=385734,385356,380304
NOTRY=true

Review URL: https://codereview.chromium.org/344123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278767 0039d316-1c4b-4281-b951-d872f2087c98

New API which extract a zip entry into a memory buffer.

BUG=359428

Review URL: https://codereview.chromium.org/292443006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278766 0039d316-1c4b-4281-b951-d872f2087c98

> [PPAPI] Add browser tests for compositor API
> 
>  And fix a bug found with the tests.
>  BindGraphics() does not work for a device which is in the same type with the current bound device.
> 
> BUG=374383
> R=piman@chromium.org, raymes@chromium.org
> 
> Review URL: https://codereview.chromium.org/324983005

TBR=penghuang@chromium.org

Review URL: https://codereview.chromium.org/342323006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278765 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379076
NOTRY=true

Review URL: https://codereview.chromium.org/343173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278763 0039d316-1c4b-4281-b951-d872f2087c98

This change fixes a regression from r270325, allowing sign-out events
to fire when the --enable-new-profile-management flag is absent, which
is the default.

The previous change added a check to filter out events related to
non-primary accounts, but the primary account ID is not available
during sign-out. Removing the filter fixes the regression.

BUG=376421

Review URL: https://codereview.chromium.org/346913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278762 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278760 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386324

Review URL: https://codereview.chromium.org/340883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278759 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/9efd66b8451f25465abd1027e09a3bcfa7b9c554..6b8f1ba1ef71a762e961c3a8bc8b344c88990a04

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=reed@google.com
BUG=

Review URL: https://codereview.chromium.org/348043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278757 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386897
TBR=rogerta
NOTRY=true

Review URL: https://codereview.chromium.org/347953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278755 0039d316-1c4b-4281-b951-d872f2087c98

BUG=246844

It fixes the the bug on Linux machines by propagating the window minimization
information to the content window after receiving X event from the platform, so
the render side can update its visibility properly.

Review URL: https://codereview.chromium.org/340783004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278754 0039d316-1c4b-4281-b951-d872f2087c98

Not everything is in the right place yet, but this is the general idea.

NOTRY=true

Review URL: https://codereview.chromium.org/342983005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278753 0039d316-1c4b-4281-b951-d872f2087c98

"showSetDefault" and "allowAdvancedSettings" should not be set
via RegisterCloudPrintValues call since they are not related
to Google Cloud Print.

R=bcwhite@chromium.org

Review URL: https://codereview.chromium.org/263803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278752 0039d316-1c4b-4281-b951-d872f2087c98

TemplateURL should not depend on TemplateURLService.

BUG=386365
TEST=unit_tests
R=pkasting@chromium.org
TBR=profile_resetter, renderer_context_menu}, sky@chromium.org for chrome/browser/{importer

Review URL: https://codereview.chromium.org/343823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278751 0039d316-1c4b-4281-b951-d872f2087c98

1. Allow get_syzygy_binaries to run in cygwin.
2. On cygwin, get_syzygy_binaries makes all of the binaries it unpacks
   executable (to avoid "permission denied" errors during compilation).

BUG=386911

Review URL: https://codereview.chromium.org/341183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278748 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385222
TBR=thakis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/344193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278747 0039d316-1c4b-4281-b951-d872f2087c98