- 31 Oct, 2017 40 commits
-
-
James Cook authored
For go/mustash we're putting code in //ash into a separate process, so code in //chrome/browser cannot call directly into it. Restrict DEPS in //c/b/extensions to make that clearer. Bug: 678705 Test: checkdeps Change-Id: I22c707564930c3dce70f5c2576c3dfacc44c1d22 Reviewed-on: https://chromium-review.googlesource.com/747062Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#512904}
-
Justin Donnelly authored
Bug: 757243 Change-Id: Iba827221e50dea80eeeabb341d1af6067cdb249a Reviewed-on: https://chromium-review.googlesource.com/747046Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#512903}
-
Lalit Maganti authored
Bug: 768373 Change-Id: I1db4191eacb7370afb0abd6c820d52057430fb00 Reviewed-on: https://chromium-review.googlesource.com/705214 Commit-Queue: Lalit Maganti <lalitm@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#512902}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/367e7de07ec3..994f20cfb76f $ git log 367e7de07..994f20cfb --date=short --no-merges --format='%ad %ae %s' 2017-10-31 rharrison Fix FPE in XFACodecFuzzer Created with: roll-dep src/third_party/pdfium BUG=779890 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If2f5607a9e9c06be34cb76b545d74311b076792f Reviewed-on: https://chromium-review.googlesource.com/747070 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#512901}
-
Reza.Zakerinasab authored
This change removes legacy-srgb mode from the code base. Bug: 637288 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ibaee28da77fdc9e216cc055e74e6725255eebc29 Reviewed-on: https://chromium-review.googlesource.com/738534Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#512900}
-
zhuoyu.qian authored
Because ui_devtools_dom_agent.(h|cc) are already in ui_devtools namespace, UIDevToolsDOMAgent class can be simplified as DOMAgent. Dependent files will change accordingly. BUG=752601 R=sadrul@chromium.org, thanhph@chromium.org Signed-off-by:
zhuoyu.qian <zhuoyu.qian@samsung.com> Change-Id: Ide16bd0e4589021deb19d90abacd5437fcb1d589 Reviewed-on: https://chromium-review.googlesource.com/727481 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#512899}
-
Daniel Erat authored
Remove ScreenIsLocked and ScreenIsUnlocked from SessionManagerClient::Observer. Callers should use ash::SessionObserver (in ash) or session_manager::SessionManagerObserver (in the browser) instead. Update the following classes to do that: - ash::PowerEventObserver - chromeos::ExtensionSystemEventObserver - TetherService Bug: 778888 Change-Id: I9792338a8c5cce6f0aeaddb11dad8adfd951683c Reviewed-on: https://chromium-review.googlesource.com/741262 Commit-Queue: Dan Erat <derat@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#512898}
-
Nate Fischer authored
No change to production logic, only WebView shell. This changes a String comparison to use `.equals()` instead of `==`. We were already returning the same String object, so reference comparison was probably technically correct as-written, but this change gets rid of a compile warning from errorprone. Change-Id: Iaa763f9f48173fd39831a17485ae9ac70dc0cf98 Reviewed-on: https://chromium-review.googlesource.com/745244Reviewed-by:
Paul Miller <paulmiller@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#512897}
-
Steven Bennetts authored
Bug: 643565 Change-Id: I3ad3aede53c90ba83f630626a6539daa104ef3a9 Reviewed-on: https://chromium-review.googlesource.com/747042Reviewed-by:
Ben Chan <benchan@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#512896}
-
Fredrik Söderquist authored
We were using the "raw" form of the fragment, meaning that any percent- encoded fragments would not resolve correctly. Bug: 779420 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic091e775589fd59d25ad1878115f2ad2593bc733 Reviewed-on: https://chromium-review.googlesource.com/746885Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#512895}
-
Antoine Labour authored
Translators may be null (e.g. for passthrough, or in case of failure), so only AddRef them if they are valid. Bug: 779954 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8f0039eaf2bdaf76a58e74317af68c13d252bdd5 Reviewed-on: https://chromium-review.googlesource.com/746993Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#512894}
-
Dmitry Skiba authored
On tablets where first run experience activity shows in a dialog, there is a UI glitch (flash of white) when ChromeTabbedActivity (or any similar fillscreen activity) transitions to FRE. CTA transitions to FRE in onCreate(), aborting CTA launch and canceling currently running window animation midway. By the time onCreate() is called, the CTA window is already partially visible, so its removal is perceived as a flash. This CL introduces TabbedModeFRE activity, which has the same background as CTA, but renders its content in a FRE-like dialog on tablets. Because the background is the same, transition from CTA window looks smooth, and since content is laid out as a dialog, the end experience looks like FRE dialog appearing on top of starting CTA activity. Bug: 771545 Change-Id: I4709a83de147e04ce94ba319cfa820a2ec6dea17 Reviewed-on: https://chromium-review.googlesource.com/723725 Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#512893}
-
Xiaohan Wang authored
This partially reverts https://chromium-review.googlesource.com/c/chromium/src/+/739743 that added crash code to investigate the BUG. TBR=dalecurtis@chromium.org,wolenetz@chromium.org BUG=778363,779379 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I246f7f3f82763b8dc6ae5c00eb01714419e5fdec Reviewed-on: https://chromium-review.googlesource.com/742229Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#512892}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/1aada706148c..764d38bb9584 $ git log 1aada7061..764d38bb9 --date=short --no-merges --format='%ad %ae %s' 2017-10-30 simonhatch Pinpoint - Use google-signin component to do clientside oauth2. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: If27f23bf100d587276a00157cbf508965696e5e5 Reviewed-on: https://chromium-review.googlesource.com/747277 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#512891}
-
Istiaque Ahmed authored
Bug: None Test: None, cleanup. Change-Id: I3c93a64cbd5e998487b8aee729860231d44009e5 Reviewed-on: https://chromium-review.googlesource.com/744323Reviewed-by:
catmullings <catmullings@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#512890}
-
Yuwei Huang authored
There are duplicated lines of _autocorrectionType but the second one is supposed to be _keyboardAppearance. UIKeyboardAppearanceDefault is the default value so we weren't seeing bugs before. Change-Id: I3c91a3496e62f778259c13fd6132ffbc28633ebd Reviewed-on: https://chromium-review.googlesource.com/744979Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#512889}
-
Yuke Liao authored
This reverts commit 844a031c. Reason for revert: This CL causes failures when generating Xcode project on iOS platform, please see comments inline. Original change's description: > [GN] Remove a duplication of a source type check > > There was a duplication of the source type checking. It may lead > errors when a type set will be changed for a language. > > R=dpranke@chromium.org > > Bug: None > Change-Id: Ieab8885899446e625cfe20c1650418a085b937ee > Reviewed-on: https://chromium-review.googlesource.com/702414 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506763} TBR=dpranke@chromium.org,vladbelov@yandex-team.ru # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I5dd0a68f9dd9ac1edd6b94e248bdf5959f83b3ab Reviewed-on: https://chromium-review.googlesource.com/747087Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#512888}
-
Mike Klein authored
Should be a handful of trivial layout test changes. By adding and using the srcover_bgra_8888, one of the cc unit test golden images needs to change just a little bit (literally, one bit of one pixel as far as I can tell). This new fused stage does the srcover blend math in [0,255] bias instead of [0,1], so the rounding can change ever so slightly. Change-Id: I5e2d526496b030d06e5820dd9f3dd56a1fc571f6 Reviewed-on: https://chromium-review.googlesource.com/737859Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#512887}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/61050011..540ab10e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I0f337fbe63b7f6435c0965c1fad63e3851122edd Reviewed-on: https://chromium-review.googlesource.com/746376Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#512886}
-
Zoe Clifford authored
Element.BoundsInViewport was applying a viewport transformation that layout_object->AbsoluteBoundingBoxRect was not. This lead to weird inconsistencies in the LayoutTreeNode boundingBox output, such as text in a div with a boundingBox that was completely outside the div's boundingBox. This fix just skips calling BoundsInViewport and instead goes down the AbsoluteBoundingBoxRect path for every node. Bug: Change-Id: I60f7c166658530ee6b57489c1c81fab21ea038fb Reviewed-on: https://chromium-review.googlesource.com/736713 Commit-Queue: Zoe Clifford <zoeclifford@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#512885}
-
Becca Hughes authored
Add a "use-default-poster" CSS class and add it if the video element does not have a video frame or poster to display. As per the spec then hide the controls apart from the play button and display a gradient background. BUG=761308 Change-Id: I579a1be27ecdb375e770b2fbc841593f7ce2abc3 Reviewed-on: https://chromium-review.googlesource.com/733092 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#512884}
-
Wenzhao Zang authored
After applying a default delay to PendingWallpaper, some tests failed (crbug.com/779504) or have memory leak [1]. These tests indirectly called SetUserWallpaper, but they do not care/know about this, so they do not actively wait until wallpaper loading is done, but start the destruction directly. This used to be okay when SetUserWallpaper had zero delay. But when it has the default delay, the timer is still running when the destruction starts, and the timer holds a reference to the shared pointer of PendingWallpaper, which results in memory leak. What's worse, if the WallpaperManager already destructs itself, PendingWallpaper::ProcessRequest does not know it, and it crashes. After changing the shared pointer to a weak pointer, WallpaperManager will be able to completely manage the lifetime of PendingWallpaper. [1] https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/24405 Below are the description of the original CL: 1) All the PendingWallpaper requests are now subject to a delay calculated from average loading time. However, in most cases the delay is still zero, and this change only affects corner cases that multiple requests coming together, which may result in wallpaper being stuck. 2) Add the account_id update in PendingWallpaper. Did not modify the functionality of PendingWallpaper, except for some renaming. TBR=oshima@chromium.org Bug: 779504, 778451 Change-Id: Iae943f88bbe046849c3afab75f35a253934fe75b Reviewed-on: https://chromium-review.googlesource.com/745022Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#512883}
-
Robert Liao authored
Previously, this ran in the Task Scheduler shared worker pool and initialized an STA on its own, which blocks initializing the shared worker pool as an MTA. This change moves the work to the shared COM STA task runner as CLSID_WSCProductList expects to be run in an STA. CLSID_WbemLocator is fine with an STA or MTA. BUG=706479 Change-Id: I834b0fbcda47ea0168f0ce48c5ab3191adbf7f5e Reviewed-on: https://chromium-review.googlesource.com/745317 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#512882}
-
Dominic Mazzoni authored
Bug: 778905 Change-Id: I45125eccc1a68f9f80d485dd32762258bd9466e1 Reviewed-on: https://chromium-review.googlesource.com/746144Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#512881}
-
Max Moroz authored
TBR=metzman@chromium.org Bug: Change-Id: Ibbcf61f59f6cd854344c37c6a968817b5ff2c834 Reviewed-on: https://chromium-review.googlesource.com/746990Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#512880}
-
Scott Graham authored
Bug: 779668 Change-Id: If23ef86c79f73581b3330f8fa5d020212f74c518 Reviewed-on: https://chromium-review.googlesource.com/747201 Commit-Queue: Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#512879}
-
Patrick Noland authored
Currently the default, on-disk impl is used. This CL allows and uses overriding the ModelTypeStore factory via pss init_params in order to specify the use of the InMemoryStore for tests. BUG=776762 R=skym@chromium.org Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie1bf97f93f5f8b4094f7abb157c84514b724a911 Reviewed-on: https://chromium-review.googlesource.com/731677Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Patrick Noland <pnoland@google.com> Cr-Commit-Position: refs/heads/master@{#512878}
-
Yash Malik authored
This CL enters Chrome into VR mode upon receiving a VR intent. It facilitates a smooth transition into VR by having VR intents go through VrMainActivity which has the correct manifest flags to keep the system in VR mode and disabling the window preview feature to hide the system UI on startup. Note that currently, VrMainActivity doesn't have any intent-filters and can only be explicitly targeted. VrMainActivity continues to open a CCT for intents from the Daydream app and opens a CTA otherwise. Follow-up work: - Fix issues with devices that support multiple screen densities Note that this feature is guarded behind the "VrLaunchIntent" runtime flag. Bug: 752200 Change-Id: I7656e0df53c0095ca3a958ede281e2ef7157cd95 Reviewed-on: https://chromium-review.googlesource.com/722456Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#512877}
-
Qiang Xu authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/61a24395b7c1..370839fe525e $ git log 61a24395b..370839fe5 --date=short --no-merges --format='%ad %ae %s' 2017-10-19 dgarrett config_lib: Add 'debug' build config value. 2017-10-27 yueherngl chromeos_config.py: excluding autotest-all from firmware 2017-10-26 yunlian Disable USE=thinlto for profile collecting boards. 2017-10-27 akeshet chromeos_config: mark wizpig, reef, reef-uni experimental 2017-10-27 akeshet chromeos_config: add a disjointness check to paladin board sets 2017-10-05 phobbs merge_logs: Add filename trimming 2017-10-05 phobbs merge_logs: Make more robust to missing logs 2017-10-27 akeshet summarize_build_stats: use nicer pcon queries 2017-10-24 cywang Add support for sending payloads in parallel for reimaging 2017-10-19 pgeorgi portage_util: uprev when subdirs_to_rev is set and -9999 ebuild changed 2017-10-26 laszio afdo: workaround the use flag dependency problem 2017-10-26 armax lassen: fix chromite to exclude simple chrome setup. 2017-10-25 perley image_test: Add homedir exception for dhcp user 2017-10-25 rahulchaudhry cros_setup_toolchains: enable aarch64-cros-linux-gnu/go binary packages. 2017-10-25 vapier image_test: fix error handling with new bad users 2017-10-25 rahulchaudhry cros_setup_toolchains: enable Go cross compiler for aarch64-cros-linux-gnu toolchain. 2017-10-25 laszio kernel_afdo: cast chrome_version to int 2017-10-25 chrome-bot Update config settings by config-updater. 2017-10-24 jkop Replace buildbucket assert with short-circuit. 2017-10-19 dgarrett cbuildbot: Adjust command line parsing for a single build_config. 2017-10-24 vapier image_test: allow multiple shells for root/chronos users 2017-10-18 pprabhu cidb: Fix integration test case failure mode. 2017-10-18 pprabhu 'cros moblabvm create' gains --source-vm-images flag. 2017-10-23 vapier auto_updater: change /var/run paths to /run 2017-10-23 dhaddock [chromite] Error out if the devserver is dead when we try to get hostlog. 2017-10-23 benchan Add 'cros-disks' user to 'avfs' group in usergroup_baseline.py 2017-10-24 chrome-bot Update config settings by config-updater. 2017-10-24 dhaddock Revert "remote_access: enforce shell=True on shell commands" 2017-10-24 dhaddock Revert "deploy_chrome: convert umount logic away from shell=True" 2017-10-19 derat chromite: Improve TastVMTestStage error handling. 2017-09-27 deanliao [cros bisect] Continue bisect when autotest returns error. 2017-10-23 ayatane cbuildbot: Move provision suite from auron to auron_paine 2017-09-22 nxia clactions: include buildbucket_id in GetCLPreCQProgress return value. 2017-10-11 nxia Insert build_requests for retried builds. 2017-09-26 nxia Insert scheduled CQ slaves into buildRequestTable. 2017-10-20 laszio autofdo: try new profiles on falco and peppy when building Chrome 2017-10-23 laszio afdo: switch to text format 2017-10-13 nxia cidb: Fix buildRequestTable build_request_reason typo. 2017-10-17 vapier cros_setup_toolchains: switch to virtual post cross packages fully 2017-10-17 jorgelo Add user/group test to ImageTest. Created with: roll-dep src/third_party/chromite R=stevenjb@chromium.org Bug=762650 Change-Id: Iec36099169b6f33e8a3b13115b174e64eeee894c Reviewed-on: https://chromium-review.googlesource.com/746044Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#512876}
-
Shivani Sharma authored
Bug: 780029 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4130623a8e72803385189f8ce7e2d50bb998ad48 Reviewed-on: https://chromium-review.googlesource.com/746536Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#512875}
-
Kurt Horimoto authored
When safe area inset usage is enabled, the constraint system bypasses |-setFrame:| when updating the view upon rotation, so the omnibox's and buttons' opacities were not updated properly. This CL changes the delegate protocol to wait for layout events rather than frame setting. Bug: 778750 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0cbd3bf66f0c53a156da269ed510fcad71ed87ec Reviewed-on: https://chromium-review.googlesource.com/745723 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#512874}
-
Fernando Serboncini authored
Bug: 722511 Change-Id: I4a8f5eb5c5a4bae215690979f737bbdfb446a449 Reviewed-on: https://chromium-review.googlesource.com/726341Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#512873}
-
Xianzhu Wang authored
Ensure the reflection mask image is loaded before ending the test. Will update TestExpectations later if the test will no longer be flaky. Bug: 777259 Change-Id: I2ed912f650c80a12ac51308799173a54ffe35314 Reviewed-on: https://chromium-review.googlesource.com/744288 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#512872}
-
Fredrik Söderquist authored
SVGLength::SetValueAsString was allowing "" to "reset" the value without signaling an error. Because of how the handling of removeAttribute works we can't shut down this entirely, but still need to handle the null string resulting from that. Convert svg/custom/invalid-length-units.html to testharness.js. (This test had one item for "" and " ".) Bug: 779454 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I055b77b07d833a252b325df8fc1a908271c86005 Reviewed-on: https://chromium-review.googlesource.com/746707Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#512871}
-
Hajime Hoshi authored
This is one step of all replacings at https://chromium-review.googlesource.com/c/chromium/src/+/743663 Bug: 777775 Change-Id: Ifdd45ab27dfbb2fdea8e8ff0dd668e083c1f8244 Reviewed-on: https://chromium-review.googlesource.com/746603Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#512870}
-
Steven Bennetts authored
SIM unlock is now integrated with the internet details dialog. Bug: 777778 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1509aea8356b86c8b887f398f58447c67964efcb For misc. code removal owners: TBR=jamescook@chromium.org,sky@chromium.org Change-Id: I1509aea8356b86c8b887f398f58447c67964efcb Reviewed-on: https://chromium-review.googlesource.com/738854 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#512869}
-
Jay Civelli authored
Relanding "Servicifying ShellHandlerWin.". It was breaking the Windows build due to a left over include for a file that does not exist anymore. This reverts commit c52f5bd4. BUG=777032 TBR=sky@chromium.org,pmonette@chromium.org,tsepez@chromium.org Change-Id: I0f495649aed6091ff287852f813cc10917c4e7f8 Reviewed-on: https://chromium-review.googlesource.com/745984Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#512868}
-
Weidong Guo authored
This CL is a prerequisite CL for supporting mirroring across 3+ displays. Changes: 1. Clean up old code of mirror mode in display manager and make software and hardware mirroring more intuitive. 2. Fix a bug that misuses mirroring destination display as source in display_info_provider_chromeos.cc Design doc: go/multi-display-mirroring BUG=607844 Change-Id: I38a065e2693c1094d9b460dd99ad0b2daabd0215 Reviewed-on: https://chromium-review.googlesource.com/734799Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#512867}
-
Peter Beverloo authored
This matches Chromium's behaviour, part of which (unfortunately) is defined in the //content layer in the form of DCHECKs. BUG= Change-Id: I4ea29bec34eb3348aa2640db55b1cef88443490f Reviewed-on: https://chromium-review.googlesource.com/747222Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#512866}
-
Christopher Grant authored
This CL does not cover generation of suggestions, but rather rendering of suggestions that exist in the UI model. Suggestions are also not yet properly rendered WRT to alignment, sizing, etc. Proper formatting and layout can be added after supporting capabilities are added to the UI. BUG=777542 Change-Id: Ib10b7a1bf05be629322a3db81650324102e2fbfa Reviewed-on: https://chromium-review.googlesource.com/734222Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#512865}
-