GitLab

Change alerts system to not request page info from DevTools each command. Also don't fetch main frame ID each time, since NavigationTracker doesn't really need it.
BUG=none
R=chrisgao@chromium.org

Review URL: https://codereview.chromium.org/15393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202610 0039d316-1c4b-4281-b951-d872f2087c98

This is just some code cleanup and should have no behavior changes.


BUG=239073
For webui/chromeos, browser/geolocation:
TBR=nkostylev@chromium.org,joth@chromium.org

Review URL: https://chromiumcodereview.appspot.com/14729017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202609 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244465
TEST=None
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/16073005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202608 0039d316-1c4b-4281-b951-d872f2087c98

With this change, the responsibility of clearing |pending_input_method_| is
moved to ChangeInputMethodInternal.

BUG=243149
TEST=Manually checked on link device.

Review URL: https://chromiumcodereview.appspot.com/15954008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202607 0039d316-1c4b-4281-b951-d872f2087c98

With Chrome / App Launcher unification, the App Launcher can be installed at system-level. Old DCHECK's to enforce otherwise are creating bogus failures, and should be removed. 

This bug is triggered by https://chromiumcodereview.appspot.com/14711006/ , which adds "shadow" App Launcher Clients/ClientState keys to support 7DA tracking for App Launcher. Unfortunately, these keys are read, and are interpreted as the presence of App Launcher (thus triggering DCHECK).

A separate issue is that installation_validator complains about missing information in the "shadow" registry key. This is less urgent, and hence not part of this CL.

BUG=243432

Review URL: https://chromiumcodereview.appspot.com/15915003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202605 0039d316-1c4b-4281-b951-d872f2087c98

To get the IDB backend off the (deprecated) WebKit thread, remove
intermediate proxying, and let us take advantage of base utilities,
we're moving the code from Blink to Chromium.

This patch is basically a glorified copy/paste of the Blink IDB
backend code, with Chromium coding style applied, WTF dependencies
replaced with STL and base/, redundant classes removed, etc. It
introduces some new temporary proxy classes
(content/browser/webidb*_impl.*) to allow us build both the old and
new backends.

The new backend is currently disabled by default. It can be enabled
using a new (and temporary) command line switch: --new-indexeddb Once
we've done some further cleanup and are confident that the new backend
is stable, and the bots have moved from DumpRenderTree to
content_shell, we'll switch to the new backend by default. Once that
has survived through a dev channel release, we'll delete the Blink
code and eliminate unnecessary proxy classes.

BUG=234278
R=alecflett@chromium.org, dgrogan@chromium.org, piman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202215

Review URL: https://codereview.chromium.org/15564008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202604 0039d316-1c4b-4281-b951-d872f2087c98

It was unreviewed, should not have been TBR'd. Also broke the docserver
so reverting rather than figuring out some kind of follow up.

TBR=hongbo.min@intel.com
BUG=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15891007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202603 0039d316-1c4b-4281-b951-d872f2087c98

Required to avoid duplicating code for upcoming Ash browser_tests on Windows.

Also avoids calling into OpenWithDialogController if the test is already default browser.

BUG=179830

Review URL: https://chromiumcodereview.appspot.com/15755016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202599 0039d316-1c4b-4281-b951-d872f2087c98

The problem was at encrypted_media_browsertest.cc line 167, which is a call to RegisterPepperCdm(), but the right fix is to use ASCII for the constants.

TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/15658009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202598 0039d316-1c4b-4281-b951-d872f2087c98

The Mac policy provider loads policies for the browser. This change makes it
additionally load policies for the extensions described in the PolicyDomainDescriptor
for extensions.

BUG=108992

Review URL: https://chromiumcodereview.appspot.com/15038007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202597 0039d316-1c4b-4281-b951-d872f2087c98

Patch from Joseph Gentle <josephg@gmail.com>

R=jeremya@chromium.org
BUG=243995

Review URL: https://chromiumcodereview.appspot.com/15953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202593 0039d316-1c4b-4281-b951-d872f2087c98

OnConnected/OnDisconnected observer callback is not meaning anything on
chromeos=1 build, so it calles automatically at the begging of input method
initialization.
However it is too early for CandidateWindowController to do initialization in
OnConnected, so do initialization immediately if it is available.

BUG=244322
TEST=Manually checked on ubuntu

Review URL: https://chromiumcodereview.appspot.com/15974003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202592 0039d316-1c4b-4281-b951-d872f2087c98

This splits NotificationDelegate into two interfaces:
* message_center::NotificationDelegate, and
* ::NotificationDelegate.

message_center::NotificationDelegate handles click events, whereas
::NotificationDelegate has a RenderViewHost that can
be used to download images.  This will support adding
message_center::Notification objects directly, including
all the binary bits of their image notifications.

BUG=174164

Review URL: https://chromiumcodereview.appspot.com/15582004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202591 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202590 0039d316-1c4b-4281-b951-d872f2087c98

Suppress flaky memory leak in DeclarativeContentRulesRegistryTest.ActiveRulesDoesntGrow on Chrome OS

BUG=244446
R=timurrrr@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16060003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202589 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151226:151259&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/16092005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202588 0039d316-1c4b-4281-b951-d872f2087c98

In order to do this we moved the FaviconChangeDetails struct into c/b/favicon,
which bookmarks is already allowed to depend on, as well is history.

BUG=144783
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15275004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202587 0039d316-1c4b-4281-b951-d872f2087c98

This is a resubmit of https://codereview.chromium.org/15505003

TBR=avi

BUG=96594

Review URL: https://codereview.chromium.org/15740023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202586 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:133291
TEST=Still compiles.

Review URL: https://chromiumcodereview.appspot.com/15199006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202585 0039d316-1c4b-4281-b951-d872f2087c98

This patch is suspected in making the page_cyclers noisier.

BUG=244189

> [Telemetry] Make telemetry faster on win7.
> 
> This makes unittests run much faster on win7. It is actually bearable now.
> 
> DNS for localhost is slow (ie. 1s per request) when ipv6 is enabled on win7.
> 
> BUG=None
> TEST=python tools\telemetry\run_tests
> NOTRY=True
> 
> Review URL: https://chromiumcodereview.appspot.com/15787005

TBR=tonyg@chromium.org

Review URL: https://codereview.chromium.org/16133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202584 0039d316-1c4b-4281-b951-d872f2087c98

The kDisableThreadedAnimation flag, which actually disables cc-driven animations
regardless of whether we're using a compositor thread, is currently set for all
layout tests. We need to set this flag in single thread mode (which is the default
for layout tests) since, in this mode, cc-driven animations cause never-ending
invalidation, causing tests to fail. However, when threaded compositing is enabled,
cc-driven animations do not cause never-ending invalidation.

This CL makes us only disable cc-driven animations when in single thread mode.
This is a prerequisite for creating a virtual test suite for animations that uses
threaded compositing and threaded animation.

BUG=244266

Review URL: https://chromiumcodereview.appspot.com/15939004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202583 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244231

Review URL: https://chromiumcodereview.appspot.com/15684005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202582 0039d316-1c4b-4281-b951-d872f2087c98

The buffer handling in OpenSL is:
1. enqueue the buffers;
2. wait for a callback;
3. inside the callback, read out the PCM data of current buffer and enqueue one buffer (it's the same buffer in this case).
4. go to step 2.

Current implementation has several problems:
a. When buffer #1 (not buffer #0) is read first time, it doesn't have PCM data recorded by the device. 
b. There are 2 buffer worth of time delay.
c. There are racing condtion since both OpenSL and AudioInputController hold the same buffer.

BUG=243506
R=xians@chromium.org

Review URL: https://codereview.chromium.org/15941002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202581 0039d316-1c4b-4281-b951-d872f2087c98

BUG=240946

Review URL: https://chromiumcodereview.appspot.com/15051011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202580 0039d316-1c4b-4281-b951-d872f2087c98

EnterpriseWebStoreName and EnterpriseWebStoreURL were an attempt at
supporting organization-specific app collections. There are now better
ways to do this that don't require invasive Chrome changes, so retire
the two policies.

BUG=chromium:178938,chromium:240648
TEST=Still compiles and passes tests.
TBR=jochen@chromium.org, estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/14813039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202579 0039d316-1c4b-4281-b951-d872f2087c98

gyp_chromium.py contained a Python 2.6 Windows bug workaround which turns out to be harmful with Python 2.7 since it will just include itself without doing anything.

BUG=
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/14670009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202578 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244437
R=timurrrr@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15658008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202576 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244163
R=bulach@chromium.org, glider@chromium.org, peria@chromium.org

Review URL: https://codereview.chromium.org/15511005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202575 0039d316-1c4b-4281-b951-d872f2087c98

BUG=229762
R=nkostylev@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16091004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202573 0039d316-1c4b-4281-b951-d872f2087c98

The approach is slightly different from my proposal in the bug so that we have more configuration options as well as backwards compatibility with Chrome M25.

This change introduces two new policy lists that allow admins to whitelist URLs to get no-prompt access to capture devices via URLs or URL patterns.
The pattern matching is applied only to the security origin of the URLs.

The behavior of the existing AudioCaptureAllowed and VideoCaptureAllowed is reverted back to how it was prior to r180416.  This means that admins must use the whitelist to allow device access without prompt.

If no match for a URL is found in the whitelists, the default behavior is determined by the [Audio|Video]CaptureAllowed policy value.

BUG=225045

Review URL: https://chromiumcodereview.appspot.com/15738004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202572 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244420
R=timurrrr@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15912008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202567 0039d316-1c4b-4281-b951-d872f2087c98

This is a revert of issue https://chromiumcodereview.appspot.com/14471033/

BUG=234231

Review URL: https://chromiumcodereview.appspot.com/15891005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202566 0039d316-1c4b-4281-b951-d872f2087c98

This was necessary prior to m27, now on stable channel.

BUG=177053

Review URL: https://chromiumcodereview.appspot.com/16000002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202564 0039d316-1c4b-4281-b951-d872f2087c98

This patch now also always calls MakeVirtuallyCurrent during initialize and
MakeCurrent, such that the next context will always restore. The context state is
restored only if the API has changed or the virtually current context has changed,
so we should never skip calling MakeVirtuallyCurrent.

BUG=241188

Review URL: https://chromiumcodereview.appspot.com/15841002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202561 0039d316-1c4b-4281-b951-d872f2087c98

There are situations like running tests where it's not necessary to run envsetup.sh.
However, build/android/pylib requires adb to be in the path.
Rather than requiring envsetup, it can be smart enough to set the path itself.

BUG=242960

Review URL: https://chromiumcodereview.appspot.com/15891002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202558 0039d316-1c4b-4281-b951-d872f2087c98

My CL  https://codereview.chromium.org/15563004 broke this test.

http://build.chromium.org/p/chromium.memory.fyi/
Failure notification for "memory test: media" on "Chromium Mac (valgrind)(1)".
Please see if the failures are related to your commit and take appropriate actions (e.g. revert, update suppressions, notify sheriff, etc.).

http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%281%29/builds/20942

Revision: 202536, 202537, 202538, 202540, 202541, 202542
Blame list: eseidel@chromium.org,glider@chromium.org,henrika@chromium.org,kinuko@chromium.org,mtomasz@chromium.org,tzik@chromium.org

BUG=see details above
TEST=media_unittests --gtest_filter=AudioInputVolumeTest.InputVolumeTest* in Debug mode on device with audio hardware
R=xians@chromium.org

Review URL: https://codereview.chromium.org/15688007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202557 0039d316-1c4b-4281-b951-d872f2087c98

BUG=222876
TBR=bruening
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16151002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202555 0039d316-1c4b-4281-b951-d872f2087c98

BUG=241737

Review URL: https://chromiumcodereview.appspot.com/15738020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202554 0039d316-1c4b-4281-b951-d872f2087c98

This patch aligns the gear menu's top with the horizontal line from the Files.app's window's header.

TEST=Enter Files.app, click on the gear button.
BUG=239300

Review URL: https://chromiumcodereview.appspot.com/16132003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202553 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise, if there's e.g. still a download in flight, we might open a new
window after closing all windows but before starting the next test

BUG=111316
R=marja@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16074003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202552 0039d316-1c4b-4281-b951-d872f2087c98