GitLab

BUG=249038
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16950022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207873 0039d316-1c4b-4281-b951-d872f2087c98

Change ShortcutsProvider so it can assign high relevance scores.
Simultaneously, make ShortcutsProvider explicitly enforce the rule
that it should not return a result with an inlineable score (>=1200).

Finally, create a field trial that will allow the server to specify
the maximum relevance score ShortcutsProvider can assign.  Setting this
to 1199 will maintain current behavior.  Also, if the field trial is
not enabled through the variations server, Chrome will maintain the
current behavior.

BUG=252032
TEST=enter omnibox inputs that you've used before to get places (and hence shortcuts will have data about them) into about:omnibox and look at the resulting scores.  Try again with --force-fieldtrials=OmniboxShortcutsScoring/MaxRelevance_XXX/ (where XXX is a number) and see how the scores change.

Review URL: https://chromiumcodereview.appspot.com/17261012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207872 0039d316-1c4b-4281-b951-d872f2087c98

Minor cleanup to remove the static thread-safe methods on BrowserMainLoop. Initially I thought this would be one getter so it seemed fine, but now it has 3 and more are on the way. Switch to one static getter for this class, and then getters for the member variables. I used dependency injection to allow access to these objects from other threads, which also cleaned up tests a bit.

R=scherkus@chromium.org

Review URL: https://codereview.chromium.org/17508005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207871 0039d316-1c4b-4281-b951-d872f2087c98

Basically three new file block types appear: One for normal
entries, one for deleted entries and one for keeping track
of external files.

BUG=241277
TEST=net_unittests
R=gavinp@chromium.org

Review URL: https://codereview.chromium.org/16837003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207870 0039d316-1c4b-4281-b951-d872f2087c98

Resolves the issue of using a plugin installed through an extension in
more than one profile.

BUG=132894
TEST=Install an extension with plugin in two profiles and observe it works (e.g. Legacy Browser Support)

Review URL: https://chromiumcodereview.appspot.com/17543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207869 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207868 0039d316-1c4b-4281-b951-d872f2087c98

Number of spec conformance fixes. Tighter integration with v8.

TBR=svenpanne@chromium.org
BUG=
TEST=All v8-i18n tests passing.

Review URL: https://chromiumcodereview.appspot.com/17533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207867 0039d316-1c4b-4281-b951-d872f2087c98

It looks like the test was flaky because this test slipped through the cracks.
We weren't initializing the storage monitor, so there was a race where it
might not be fully initialized when the test ran. Switched to using the test
storage monitor as the other API browser tests do (and are not flaky).

R=vandebo@chromium.org
BUG=247336

Review URL: https://chromiumcodereview.appspot.com/17504004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207866 0039d316-1c4b-4281-b951-d872f2087c98

This maps much better to percentages people actually use for
experiments (e.g. 1%) without causing an uneven distribution
and thus a source of non-uniformity.

Re-generates the low entropy source values for users who have
it outside the new range.

BUG=252283

Review URL: https://chromiumcodereview.appspot.com/17499002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207865 0039d316-1c4b-4281-b951-d872f2087c98

This removes the need to construct a temporary graph by
RasterWorkerPool classes. It reduces the number of tasks
created and eliminates the need for a dependencies vector
as part of the internal::WorkerPoolTask class.

This is also a prerequisite to implementing a "ready to activate"
signal as that requires as task graph structure that is not a tree.

BUG=247677

Review URL: https://chromiumcodereview.appspot.com/17244003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207864 0039d316-1c4b-4281-b951-d872f2087c98

This is a continuation of r200100 which did reduce the flakiness of our
tests.

BUG=237917
TEST=None
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/17155016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207863 0039d316-1c4b-4281-b951-d872f2087c98

This puts all dependencies into a inner Delegate class so the test can
mock them out.

BUG=168080

Review URL: https://chromiumcodereview.appspot.com/17481002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207862 0039d316-1c4b-4281-b951-d872f2087c98

This prepares usage of the decoding in NetworkLibrary.
While there, removed redundant namespace qualifiers from onc_utils.*.

BUG=208986

Review URL: https://chromiumcodereview.appspot.com/17471005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207861 0039d316-1c4b-4281-b951-d872f2087c98

* Renaming tokend ID to access token (including the id of the resource).
* Updating Token Id => Access Token in the resource file.

BUG=243143

Review URL: https://chromiumcodereview.appspot.com/17468008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207860 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140037

Review URL: https://chromiumcodereview.appspot.com/17465003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207859 0039d316-1c4b-4281-b951-d872f2087c98

Supports a new method {ui,views}::InputMethod::IsCandidatePopupOpen(),
which returns true if a candidate window is open.

BUG=245578
TEST=Test manually.

Review URL: https://chromiumcodereview.appspot.com/17112021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207858 0039d316-1c4b-4281-b951-d872f2087c98

Revert "Implement WebFrameClient in RenderFrame and proxy all calls to RenderView (for now)." (r207825).

Many failures on layout tests, e.g., fast/animation/request-animation-frame-during-modal.html

BUG=245126
TBR=nasko

Review URL: https://codereview.chromium.org/17068011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207857 0039d316-1c4b-4281-b951-d872f2087c98

Applies to Open, Mkdir, Rmdir and Remove. Previously, these set errno to ENOSYS
or EIO.

BUG=252064

Review URL: https://chromiumcodereview.appspot.com/17450014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207856 0039d316-1c4b-4281-b951-d872f2087c98

BUG=249104
TEST=WebUIResourceBrowserTest

Review URL: https://chromiumcodereview.appspot.com/17450012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207855 0039d316-1c4b-4281-b951-d872f2087c98

Note that I can't reproduce the problem in the linked bug, but based on
your analysis this seems like it should fix it.

BUG=244103

Review URL: https://chromiumcodereview.appspot.com/17449017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207854 0039d316-1c4b-4281-b951-d872f2087c98

When generating/using a crypto::RSAPrivateKey with NSS,
prefer the internal software slot over other modules (such as
any TPMs [ChromeOS] or smart cards [Linux]) if the key being
generated is not marked as a permanent key.

BUG=none
R=wtc

Review URL: https://chromiumcodereview.appspot.com/17447009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207853 0039d316-1c4b-4281-b951-d872f2087c98

BUG=252588
TEST=unit_tests

Review URL: https://chromiumcodereview.appspot.com/17520005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207852 0039d316-1c4b-4281-b951-d872f2087c98

The change in r185359 added the pref for allowing signin to the the pref registrar
previously used only for proxy settings. (Other prefs have since been added on too.)
This, in combination with the use of the registrar's IsManaged() method rather than
the pref's own IsManaged() -- or better still, using IsUserModifiable() for the best
semantic fit -- meant that once supervised users had signin disabled, they also had
proxy changes disabled.

This fix changes the condition to use Preference::IsUserModifiable().

BUG=252426
TEST=create a supervised user; make sure the "Change proxy settings..." button is
   enabled

Review URL: https://chromiumcodereview.appspot.com/17408009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207851 0039d316-1c4b-4281-b951-d872f2087c98

Fix the problem that some stacked panels might not be brought to the top when a collapsed panel is clicked on Linux

BUG=251829
TEST=Manual test by creating stacked panels and collapsing and expanding some of them

Review URL: https://chromiumcodereview.appspot.com/17397006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207850 0039d316-1c4b-4281-b951-d872f2087c98

BUG=179669
R=ygorshenin@chromium.org
TBR=derat@chromium.org
notry=TRUE

Review URL: https://chromiumcodereview.appspot.com/17494004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207849 0039d316-1c4b-4281-b951-d872f2087c98

This CL separates the function to fetch the Translate script from TranslateManager.

TEST=browser_tests, unit_tests

Review URL: https://chromiumcodereview.appspot.com/17390018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207848 0039d316-1c4b-4281-b951-d872f2087c98

There should be no behavior change. It's just moving code
out of RequestRegistry.

BUG=164098

Review URL: https://chromiumcodereview.appspot.com/17379020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207847 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244790

Review URL: https://chromiumcodereview.appspot.com/17368005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Ran image_decoding_measurement on linux
NOTRY=True
TBR=tengs@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17413018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207845 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174296
R=dbeam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17314013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207842 0039d316-1c4b-4281-b951-d872f2087c98

Add ResourceMetadataStorage::opened_existing_db() to trigger cache file scan at appropriate timing.

BUG=234487
TEST=unit_tests

Review URL: https://chromiumcodereview.appspot.com/17249004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207841 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes Chrome-side changes necessary for tracking of
NPObject ownership to out-of-process NPAPI plugin instances.

Ownership information is now included whenever an NPObject
is marshalled across IPC, to be passed when instantiating
NPObjectProxy instances for objects.

In the plugin process each NPObject is tracked to its owning
plugin instance, and browser-owned objects are tracked to a dummy NPP identifier.

This depends upon crrev.com/17220002 and is a prerequisite for crrev.com/17208003.

BUG=152006

Review URL: https://chromiumcodereview.appspot.com/17208003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207840 0039d316-1c4b-4281-b951-d872f2087c98

The behavior in the PNaCl shim layer is the same if there's a struct for an
interface with no wrapper or no struct at all.

This change removes structs where no wrapping is necessary.

BUG=251460

Review URL: https://chromiumcodereview.appspot.com/17153012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207839 0039d316-1c4b-4281-b951-d872f2087c98

To chrome/browser/DEPS and content/browser/DEPS to prevent more
third_party/WebKit includes.

R=jamesr@chromium.org, sky@chromium.org
BUG=237267

Review URL: https://codereview.chromium.org/17261033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207838 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/17198010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207837 0039d316-1c4b-4281-b951-d872f2087c98

 * Add support for file content upload,
 * Fill MD5 on contents update.

Review URL: https://chromiumcodereview.appspot.com/17140009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207836 0039d316-1c4b-4281-b951-d872f2087c98

This allows enterprise-managed Kiosk Apps to mint OAuth2 access tokens
for the device-level robot account via the identity extension API.

BUG=chromium:224594

Review URL: https://chromiumcodereview.appspot.com/17009016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207835 0039d316-1c4b-4281-b951-d872f2087c98

This also changes the layout of some keys to bring the keyboard closer to the v1 spec.

BUG=248525,248226

Review URL: https://chromiumcodereview.appspot.com/16959020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207834 0039d316-1c4b-4281-b951-d872f2087c98

Fixed Profile Reset unit tests.

BUG=235037

Review URL: https://chromiumcodereview.appspot.com/17274006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207833 0039d316-1c4b-4281-b951-d872f2087c98

This adds a boolean (kAppShortcutsEnabled) to user prefs. At startup,
ShortcutManager checks the pref and sets the current value. On a
transition from false to true, ShortcutManager iterates over all
apps and creates shortcuts as if the app is being installed.

BUG=249189
TEST=Delete app shortcuts from the OS applications folder.
Start Chrome, the shortcuts should be created.
Delete the shortcuts again.
Restart Chrome, the shortcuts are not created a second time.

Review URL: https://chromiumcodereview.appspot.com/17261016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207832 0039d316-1c4b-4281-b951-d872f2087c98