- 30 May, 2019 40 commits
-
-
Xiyuan Xia authored
- Fix RlzValueStoreChromeOS::SetRlzPingSent that calls DebugDaemonClient::SetRlzPingSent in a worker thread; - Fix RlzLibTest failure because of missing TestTimeouts init; Bug: 966178 Change-Id: I8c12425d2bc66f7f97fe40e81e9b02e65b894232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635429Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#664735}
-
Mark Yacoub authored
This reverts commit b4fd0cc9. Reason for revert: The Squid app uses SingleOnTop for overlay without changing the resource_id. This revert will undo the fix for the other apps, but they're lower priority. Original change's description: > Skip promoting SingleOnTop Overlay when contents don't change > > If a candidate content has not changed for 3 frames, do not promote it as > Single On Top overlay as it can be just be flattened, allowing other > strategies to kick in if possible. > > Bug: 885180 > Test: SingleOverlayOnTopTest.DoNotPromoteIfPreviouslyPromoted > Change-Id: I516dab628c129fe9fae09c713e2783a6ce889c56 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521591 > Commit-Queue: Mark Yacoub <markyacoub@google.com> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#645367} TBR=dcastagna@chromium.org,markyacoub@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 885180 Change-Id: I799bd22f06a56d86844a63d5ac346f41bcfb8707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635931Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#664734}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0996da26f23c..8dbf318b35d1 Created with: gclient setdep -r src-internal@8dbf318b35d1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: I4a8e89969cb656a8afd2314b9957a28eeb3e2033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636518Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664733}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d6021d92c292..f7446c38416a git log d6021d92c292..f7446c38416a --date=short --no-merges --format='%ad %ae %s' 2019-05-30 khokhlov@google.com Make py_trace_event interface more strict Created with: gclient setdep -r src/third_party/catapult@f7446c38416a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:944418 TBR=sadrul@google.com Change-Id: Ibb19e6e934ebc1794784ddd1319e3f1c6a50a427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636520Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664732}
-
Jeffrey Cohen authored
I hope this makes it easier to find out how to update the tree when sheriffs are in the "sheriffing loop" Change-Id: I8ad02b6286693480f89c4ff7b95e2ae2aab71f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635730 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#664731}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=kylechar@chromium.org Change-Id: I37b6144800fa6aa38d28f699a9810a08508dd963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635818Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#664730}
-
Koji Ishii authored
1px font differences are seen in 305 tests. It looks like there was a change that affects curved glyphs such as O, S, italic fonts, etc. Rebaseline is based on manual review of build 20492. https://test-results.appspot.com/data/layout_results/linux_layout_tests_layout_ng/20492/webkit_layout_tests%20%28retry%20shards%20with%20patch%29/layout-test-results/results.html There are 307 failures, 2 are real failures to be added to FlagExpectations. This CL rebaselines other 305. TBR=eae@chromium.org NOTRY=true Bug: 591099 Change-Id: Ibfa39f01626d93bb84b8d991a2b92237effd3a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637026 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#664729}
-
Chris Hamilton authored
This will allow us to use a single observer interface rather than having public and private versions. BUG=910288 Change-Id: Icd6ace3d79a03de28e947765edd65ec21618e85f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635637Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#664728}
-
jonross authored
conformance2/samplers/multi-context-sampler-test.html has become flaky, reporting and error in SharedImageStub with subsequent context loss. So far this has only been seen on the nvidia mac builds. So only suppressing there for now while the root cause it addressed. TBR=kbr@chromium.org Bug: 965209 Change-Id: I2c7d0ae78b83ee84a03de648e37fe00cb3ea4b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637288Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#664727}
-
Carlos Caballero authored
We will then selectively downgrade tasks to USER_VISIBLE. Eventually we want all task priorities to be either inherited or explicitly set, so no defaults will be used. Roots will need to explicitly set the priority (most likely USER_BLOCKING) thus that is a good default for now. Bug: 863341 Change-Id: I9872976bb944bc78dd43cbb6aff0cb5912043936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634702Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#664726}
-
Simon Que authored
These were migrated in: https://chromium-review.googlesource.com/c/chromium/src/+/1634109 This is generating some compile binary hash mismatch errors: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ARM/115824 The remedy will be to use ATS, but for now let's revert the change to these builders. R=bpastene@chromium.org, jbudorick@chromium.org, tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org Bug: 950413 Change-Id: Iba3ea38f4247b1da15a6295a684087acf170d3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637003 Auto-Submit: Simon Que <sque@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#664725}
-
Mohamed Amir Yosef authored
Before this patch: BookmarkModelTypeProcessor has one weak_ptr_facotry used for both the controller and the worker. This resulted in the worker having a processor ptr while the model error isn't yet propagated. After this patch: The BookmarkModelTypeProcessor has dedicated weak_ptr_factory for the worker such that in case of model error, it gets invalidated directly while leaving the other weak_ptr_factory for the controller intact. Bug: 516866 Change-Id: If0d9759e0cba7e5b00879646f9072522cbdb866f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635511 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#664724}
-
Huanzhong Huang authored
This reverts commit 9223cbe0. Reason for revert: Not getting leadership-full approval before branch point; will rollout with Finch. Original change's description: > [iOS] Enable the new Clear Browsing Data UI flag > > This change is to enable the new-clear-browsing-data-ui flag. > > The new Clear Browsing Data dialog adds the time range selection functionality > and shows browsing data volume details for each data type. > Launch Bug: crbug/627147 > Screenshots: https://drive.google.com/open?id=1q1zJzB1abRsY1zCD4rLewvMxCnMr8WGf > > Bug: 627147 > Change-Id: If2e16f4697a7aac2308a430c48880eb2f0c58c19 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624906 > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Commit-Queue: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662278} TBR=rohitrao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 627147 Change-Id: I26afad9076841353b0210f4537d8842aab9631e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635617Reviewed-by:
Huanzhong Huang <huanzhong@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#664723}
-
Tien Mai authored
desktop. Bug: 960774 Change-Id: I5fbacb88d28d9a2c3414409c82c832ad8e4b647d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625306 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#664722}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d554c5fc. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" d9a6ec05 "[MediaStreamTrack] Remove tests and existing support for the 'volume' property." 0882bebe "Change ICE connection state on transceiver changes" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." 2229f484 "Revert "Change ICE connection state on transceiver changes"" ab94a58b "Add the remaining Client Hints to Feature Policy." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I2ecae78fed71acd1b439402a281fdd679a3ba419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637179Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664721}
-
Lan Wei authored
Bug: 606367 Change-Id: If0f8cc5df6eed1c451451a1b53da2483343b6b0f TBR=nzolghadr@chromium.org Change-Id: If0f8cc5df6eed1c451451a1b53da2483343b6b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636309Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#664720}
-
Juan Antonio Navarro Perez authored
TBR=crouleau@chromium.org Bug: 967125 Change-Id: Ib4b4d10e80ca6a5c752523bd8b903396fd0c6578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635820Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#664719}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87b2fa4bb58f..0996da26f23c Created with: gclient setdep -r src-internal@0996da26f23c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: Iba68057afcfbbe08600565ac8d506c24d668b1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637302Reviewed-by:
-
Gabriel Charette authored
Incorrectly marked the new suffix as obsolete when introducing it in crrev.com/650997 (copy/paste error). TBR=fdoray@chromium.org, mpearson@chromium.org Bug: 951388 Change-Id: I4983d6b70748a34e63227d43565192d2f098fdde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635519Reviewed-by:
-
tzik authored
The previous CL associated Workers and Worklets to finer grained Agents. But, Worklets seems not fully ready for that until a preparation of WorkerScheduler lands. https://crrev.com/c/1605287 This CL switch Worklets back to the global Agent. Bug: 961186 Change-Id: I47dd83aaf737f3de329f7c3d8b744baa497fcdcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631911Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#664716}
-
Alex Clarke authored
When a refcounted object is constructed, it's refcount is initally zero. This is a problem if the constructor can post a task to another thread bacause the scoped_refptr destructor on the other thread might run before the posting thread has had a chance to increment the refcount. This results in a UAF on the posting thread. The work around is to ensure the refcount is not zero before posting. Bug: 966964, 906125 Change-Id: Idf3163f979a49abe39088f5af72e94dee4492833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628758 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#664715}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b2021956d81c..a2ad3619b8cb git log b2021956d81c..a2ad3619b8cb --date=short --no-merges --format='%ad %ae %s' 2019-05-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-headers/src 7f4277e21b52..7ac42f80c0e8 (1 commits) 2019-05-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 66e46037d74f..625eb25d6e80 (1 commits) Created with: gclient setdep -r src/third_party/angle@a2ad3619b8cb The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Change-Id: Iaf399bbe58e66828abbb34ce0a90376e1d2aaf60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637298Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/601317b5ca39..d6021d92c292 git log 601317b5ca39..d6021d92c292 --date=short --no-merges --format='%ad %ae %s' 2019-05-30 perezju@chromium.org [Telemetry] Factor out code for _ShouldRunBenchmark check Created with: gclient setdep -r src/third_party/catapult@d6021d92c292 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866458,chromium:840428 TBR=sadrul@google.com Change-Id: I1dbeb910d8a80246aa3df67844a40f1cdb385611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637297Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8a6d63441aee..87b2fa4bb58f Created with: gclient setdep -r src-internal@87b2fa4bb58f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: Iaa78541ec7303a5f649fdd628e707b0d0d8a5beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636516Reviewed-by:
-
Sergio Villar Senin authored
This is a followup of http://crrev.com/c/1588650. In this CL MemoryInfoTest is moved out of time function overrides. TestMockTimeTaskRunner is used instead. Overriding the time functions is no longer required as the mock clock provided by the test task runner has all the required features, basically moving time forward at will. Bug: 919383 Change-Id: I13ac8b2436d0b07da1374dee189372619ecbfbda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590103 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#664711}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1bf1cfe3. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" d9a6ec05 "[MediaStreamTrack] Remove tests and existing support for the 'volume' property." 0882bebe "Change ICE connection state on transceiver changes" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." 2229f484 "Revert "Change ICE connection state on transceiver changes"" ab94a58b "Add the remaining Client Hints to Feature Policy." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I46548c2ddb0a203f0e79e01339215d77b8232bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636624Reviewed-by:
-
Alex Clarke authored
A large but mostly trivial patch in preparation for removing base::MessageLoop. We introduce SingleThreadTaskExecutor a simple FIFO scheduler, which is intended for non-test code that needs a simple single threaded task environment. Tests should use ScopedTaskEnvironment or TestBrowserThreadBundle instead. This patch also moves MessageLoop::Type to MessagePump::Type and moves the factory method to MessagePump::Create. TBR=gab@chromium.org Change-Id: I9850c4657bb90b62490f4313c420cae025101371 BUG: 891670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632216Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
-
Etienne Pierre-doray authored
This CL fixes a few issues with SequenceLocalStorage: - Supports holding T with disabled copy/move constructor by adding emplace(). - Prevents auto default construction with GetValuePointer. - Query if SequenceLocalStorageSlot currently holds a value with operator bool(). - Update doc to use NoDestructor. This makes it possible to replace in many cases: SequenceLocalStorageSlot<unique_ptr<T>> with SequenceLocalStorageSlot<T> and auto ptr = sls.Get(); if (!ptr) { ptr = make_unique<T>(); sls.Set(ptr); } return *ptr; with return sls.GetOrCreateValue(); TBR=fdoray@chromium.org Change-Id: I0473fbb4eded35177aa32fabb5377b0cad648c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634876 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by: -
Mohamed Amir Yosef authored
Bug: 967424 Change-Id: Ic7ed7f1934357fba85ce0e187298b6508a5e8b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614179 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=sammc@chromium.org Change-Id: I4b3b1b6e59ca65ecdce281818234353955e5ff78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636352Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#664706}
-
Juan Antonio Navarro Perez authored
Underlying issue in crbug.com/962918 has been fixed, let's try re-enabling them now. NOTRY=true TBR=crouleau@chromium.org Bug: 966630 Bug: 966619 Bug: 966631 Change-Id: Ic59ce1d63d6c4b796420fec23002dafa853b35cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636195Reviewed-by:
-
Juan Antonio Navarro Perez authored
Stories fail while trying to DumpMemory. NOTRY=true TBR=crouleau@chromium.org Bug: 964960 Change-Id: I1b806e8fdc71d32e9caf11d124aebf88073e339b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635616Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. DO NOT SUBMMIT BUG=891670 This CL was uploaded by git cl split. R=primiano@chromium.org Change-Id: Ib36c5a18d81596be37e707dae0a6d0879edb28c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635815 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#664703}
-
Carlos Caballero authored
BEST_EFFORT tasks will not run until after startup and only if there is no critical work pending. This patch should not change the current behaviour. Please double check whether the task being posted via BrowserThread::PostAfterStartupTask really cares about being run after startup or just wants to run after any critical work was completed. If you are fine with it just running after critical work has completed LGTM and keep on with your life. If that is not the case let me know and please explain your reasoning in a comment. More details: https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI This CL was uploaded by git cl split. R=chrisha@chromium.org Bug: 887407 Change-Id: I4d98da09939b86c31a04d8b82823f6a0f9b8f8f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631286Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#664702}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I455b2f1cb18ed0fb3543d6517cc0deaeea0559b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636623Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. DO NOT SUBMMIT BUG=891670 This CL was uploaded by git cl split. R=rmcelrath@chromium.org Change-Id: Iccef22a70c2f7465a6a3da5bb717c18922d8065a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635517 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#664700}
-
Carlos Caballero authored
BEST_EFFORT tasks will not run until after startup and only if there is no critical work pending. This patch should not change the current behaviour. Please double check whether the task being posted via BrowserThread::PostAfterStartupTask really cares about being run after startup or just wants to run after any critical work was completed. If you are fine with it just running after critical work has completed LGTM and keep on with your life. If that is not the case let me know and please explain your reasoning in a comment. More details: https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI This CL was uploaded by git cl split. R=chrisha@chromium.org Bug: 887407 Change-Id: Ib35383c1272e2ab649ec2b0d76e2b1c9f5f28d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632221Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0270f5ed3fb2..8a6d63441aee Created with: gclient setdep -r src-internal@8a6d63441aee The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: I661aaa20e32cd8bbc9904f69a15a41032dd6e860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636501Reviewed-by:
-
Sergio Villar Senin authored
This is a followup of http://crrev.com/c/1590101. In this CL WebViewTest is moved out of time function overrides. TestMockTimeTaskRunner is used instead. The migration is far from trivial. Some other classes had to be migrated first, InteractiveDetector (with test) and DocumentLoader among others. In order to simplify a bit the migration, a new attribute was added to WebNavigationParams carrying the clock to be used by DocumentLoader. That clock is precisely the one being used by TestMockTimeTaskRunner. That modifications in DocumentLoader had some side effects in order non directly related tests, in particular CSSAnimationTests. There is a pretty tiny rounding error in TimeTicks <-> double conversions that force us to replace an exact comparison (EXPECT_DOUBLE_EQ) by an approximation (EXPECT_NEAR) with a very tiny margin error. Bug: 919383 Change-Id: Ie1bf2402a9cf55f312ba4cf5f129097e25ed4ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588650 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#664697}
-
Wei-Yin Chen (陳威尹) authored
Measure performance of Grid-to-Tab transition animation in the following use cases: - Back to current tab showing NTP/web page - To another live tab showing NTP/web page - To another frozen tab showing web page Bug: 964406 Change-Id: Ib730ae1bb19f3660f5050e9c04dd588e67425001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636339 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664696}
-
