- 10 May, 2018 40 commits
-
-
Max Morin authored
It checks that the stream is allowed and forwards the request to the relevant ForwardingAudioOutputStreamFactory if so. This will cause the stream to be served by the audio service. The old RenderFrameAudioOutputStreamFactory which creates streams living in content/ is renamed to OldRenderFrameAudioOutputStreamFactory. Since the class was renamed, the files were moved (by adding "old_" to the beginning). No need to review those files. Also note that replacement is diffed against the previous implementation. It's probably best to just ignore the diff and review render_frame_audio_output_stream_factory{.cc,.h,_unittest.cc} as new files. A flag is added to switch between the old factory and the new one. Approximate diagram of stuff: https://docs.google.com/drawings/d/1_ZIKj6lihGKRjq4Mflduitmkn_REqpHFeqVNelBGHHk/edit Tbr since there was a "verbal" LGTM in cl comments. Tbr: nasko Bug: 830493 Change-Id: I38887bb97c817cc9182d71edd89d5ff0193b2504 Reviewed-on: https://chromium-review.googlesource.com/1032751 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#557492}
-
Max Morin authored
We cannot retry anything yet, so make sure the renderer knows we're gone. Drive-by remove handling of navigations, since it was crashing. Bug: 787806, 840345 Change-Id: Icbaf49dda9ca12094ada2e9decc57622cd1feff6 Reviewed-on: https://chromium-review.googlesource.com/1047209 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
Current PreflightController implementation uses an existing error code to report disallowed preflight redirects tentatively, and results in wrong console messages. This change defines a dedicated error code and use GetErrorString() to generate a console message even for legacy code path. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I1af9b8570c2811a9a575e4504b88d6b37db688ea Bug: 803766 Tbr: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1027558Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#557490}
-
Yutaka Hirano authored
This reverts commit 189d1033. Reason for revert: "ParallelDownloadTest.NoPartialResponse" is flaky. See https://crbug.com/841666. Original change's description: > Cancel parallel download request if server doesn't send partial response > > If the server doesn't support partial responses, Chrome should cancel > parallel download requests. > These requests result in the wrong write offset and makes the file larger > than the original > > BUG=838627 > > Change-Id: I1fa878854579a1572e6e2f90f3bb932b59b333ba > Reviewed-on: https://chromium-review.googlesource.com/1048130 > Commit-Queue: Min Qin <qinmin@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557252} TBR=qinmin@chromium.org,xingliu@chromium.org Change-Id: I995c3c48fe39c535275a353130b10204009c5e30 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838627, 841666 Reviewed-on: https://chromium-review.googlesource.com/1053470Reviewed-by:
-
Stuart Langley authored
Some cleanup work for chrome/browser/chromeos/file_manager/ briging it in line with recomended practices/c++ modernization. Modernize clang-tidy checks that were used: -- modernize-use-default -- modernize-make-unique -- modernize-raw-string-literal -- modernize-use-emplace -- modernize-use-nullptr This CL introduces NO logic changes. Bug: 841659 Change-Id: Icb8803941bd7f2230cb0174c8e307d712ed0e10a Reviewed-on: https://chromium-review.googlesource.com/1053668Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#557488}
-
Mohamed Amir Yosef authored
The functionality of handling remote creation of bookmarks has been introduced in this patch https://chromium-review.googlesource.com/c/chromium/src/+/1017201 which supports remote creation of bookmarks as well as folders in the bookmark tree. This CL 1- Enables DownloadBookmarkFolder test for USS. 2- Removes the redudant DownloadBookmark test. It has been recently introduced however it tests the same behavior as InjectedBookmark test case. 3- Enables InjectedBookmark test for USS instead of the removed DownloadBookmark test. Bug: 516866 Change-Id: Ida235e4817fab122448b88f063dbabdbe7ef7712 Reviewed-on: https://chromium-review.googlesource.com/1052247Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#557487}
-
Anita Woodruff authored
- Enables the mojo pathway by default and removes the legacy IPC code path for persistent notifications. - Removes the NotificationsWithMojo feature flag which previously guarded this code-path during incremental development. R=kinuko@chromium.org Bug: 796991 Change-Id: Ia4dac0ab4b98b7a6df342b7df1b424e3af67bf05 Reviewed-on: https://chromium-review.googlesource.com/1027843Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#557486}
-
Mikel Astiz authored
The patch adds a button in chrome://sync-internals that triggers logic to get updates from the sync server, similar to the time-based polls in place (in case invalidations don't work as expected). This is primarily expected to help testing teams. Bug: 839836 Change-Id: I1060026a6e019d0531b4489331294efb6e5aff9c Reviewed-on: https://chromium-review.googlesource.com/1047868 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#557485}
-
Hajime Hoshi authored
We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Task type guideline: https://bit.ly/2vMAsQ4 Bug: 830489 Change-Id: I465769461f4db57031e49c391f0efe715e2dc067 Reviewed-on: https://chromium-review.googlesource.com/1046730 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#557484}
-
Rune Lillesveen authored
Instead of modifying ComputedStyle in place for margins, clone the style if necessary before setting the new margins. UpdateMarginsAndContent() has been modified to call ComputePreferredLogicalWidths() in the case of dirty preferred widths because that method will call UpdateContent() and UpdateMargins(). We had problems with UpdateMargins() being re-entered causing the style member of LayoutObject to change multiple times during the process when MinPreferredLogicalWidth() was called during UpdateMargins(). Bug: 813068 Change-Id: I902de039f6291ca56c47f88b1f69eee06afb18ca Reviewed-on: https://chromium-review.googlesource.com/1051807 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
cathie chen <cathiechen@tencent.com> Cr-Commit-Position: refs/heads/master@{#557483}
-
Hitoshi Yoshida authored
SVGAnimatedProperty::context_element_ and SVGPropertyTearOff::context_element_ were stored as UntracedMember, because they were thought to have a reference cycle involving Persistent. However, SVGInterpolation was removed and the cycle was cut. https://codereview.chromium.org/1607633003 And hence we no longer need to store them as UntracedMember. Bug: 528275 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iefdda45d9d56a7e814be43a871cbaa37d55e3b2a Reviewed-on: https://chromium-review.googlesource.com/1053619Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/baf831d074e7..d31b2f674acc $ git log baf831d07..d31b2f674 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 skia-bookmaker Update markdown files Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I2533641be20a9cce435dfac8c5f6330cbcae6c28 Reviewed-on: https://chromium-review.googlesource.com/1053689 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557481}
-
Rune Lillesveen authored
-webkit-user-modify is not set on the input element by disabled or readonly attributes, but on the inner editor based on the input attributes. The style recalc is triggered from StyleDidChange on LayoutTextControl for the input element. However, if the input element style does not change StyleDidChange is not called, and the inner editor style is not updated. Trigger the style update when readonly and disabled attributes change. Bug: 840833 Change-Id: Iad291b0a079efd197074366e127d1aa3a1f757e7 Reviewed-on: https://chromium-review.googlesource.com/1051236Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#557480}
-
junweifu authored
Add nose landmark enum in the mojom definition and the IDL to match the Spec[1]. Get nose information with Vision Framework on Mac and GMS core on Android platform. Link Mac 10.13 build bots [2] and Face Detection demo[3] here. [1] https://github.com/WICG/shape-detection-api/pull/38 [2] https://ci.chromium.org/buildbot/chromium.fyi/Chromium%20Mac%2010.13/ [3] https://codepen.io/miguelao/pen/PmJWro BUG=835078 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I0818bf817bf047a19ec7b34b232c93e4d08e9fa2 Reviewed-on: https://chromium-review.googlesource.com/1020385Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Junwei Fu <junwei.fu@intel.com> Cr-Commit-Position: refs/heads/master@{#557479}
-
Trent Apted authored
The dialog may outlive the WebContents, but ExternalProtocolDialogDelegate::DoAccept() is missing a check on the result of tab_util::GetWebContentsByID() before dereferencing the WebContents. Add a check and a regression test. In order to achieve coverage of the crashing lines, update the test harness and the static method involved to use a ExternalProtocolHandler::Delegate. This interface already exists and is used for testing, but wasn't in the codepaths invoked from the crashing code in ExternalProtocolDialogDelegate::DoAccept(). Bug: 835216 Change-Id: If7d4593090a1db9a96bc829d1e1c253860d0cf20 Reviewed-on: https://chromium-review.googlesource.com/1049774Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#557478}
-
Ben Wells authored
The CrostiniManager can send multiple error callbacks. Only the first one should be shown to the user. Bug: 841158 Change-Id: If21222f81b609559a462a73af8c5a7bc911592fb Reviewed-on: https://chromium-review.googlesource.com/1051406 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#557477}
-
Felix Ekblom authored
BUG=b:78171027 Change-Id: I08a32e347c103f790e399264d8d045b36848d492 Reviewed-on: https://chromium-review.googlesource.com/1042576 Commit-Queue: Felix Ekblom <felixe@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#557476}
-
https://webrtc.googlesource.com/src.git/+log/e53ac0463daa..b4e0e50a2bbf $ git log e53ac0463..b4e0e50a2 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iea5aada68e7bbfa582f99f9b910aee4704ead592 Reviewed-on: https://chromium-review.googlesource.com/1053587Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557475}
-
Chromium WPT Sync authored
Using wpt-import in Chromium afe927cd. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17225 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: Ia5465a7ed1514f1bc740b2c95b8bca815e707b36 Reviewed-on: https://chromium-review.googlesource.com/1053570 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557474}
-
Matt Falkenhagen authored
Reland "service worker: Make provider hosts for reserved clients first-class members of SWContextCore." Relands 0ce272e0. Original code review: https://chromium-review.googlesource.com/1051145 Reverted in: https://chromium-review.googlesource.com/1053469 The difference is this initializes ServiceWorkerNavigationHandleCore's |provider_id_| to -1. So the dtor won't use unintitialized memory when a provider was never created. Bug: 841070 Change-Id: I2ec537f76f093dd35a99f14c9033d75d50a7313d Reviewed-on: https://chromium-review.googlesource.com/1051145Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#557423} Reviewed-on: https://chromium-review.googlesource.com/1053609 Cr-Commit-Position: refs/heads/master@{#557473}
-
Aleks Totic authored
Bug: 714962 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I94905e3ed6e80663b62dd63cc5f3de5b89317917 Reviewed-on: https://chromium-review.googlesource.com/1053372 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557472}
-
Noel Gordon authored
Bug: 833834 Change-Id: I208207b46af243ce36fc810363b3e727eee41a2d Reviewed-on: https://chromium-review.googlesource.com/1053331 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#557471}
-
Owen Rodley authored
This is a reland of e481b7b5 This broke the index pack because it introduces absolute paths. Now that https://crrev.com/c/1053044 fixes the handling of absolute paths, this should be safe to reland. Original change's description: > Avoid searching the compilation database for every file. > > The compilation database for chromium is ~180MB of JSON. The current > implementation of "run_tool.py --all" reads the whole database, pulls out > only the filenames, and then has the tool rescan the compilation > database for the flags. We can instead extract the flags as well, and > pass them directly to the tool, to avoid the rescanning. > > A local run of translation_unit over the whole repository took 44m15s > before this change, and 17m23s after. > > Change-Id: I373238980654a5586e32f5a516f0953a4eec03c3 > Reviewed-on: https://chromium-review.googlesource.com/1039203 > Commit-Queue: Owen Rodley <orodley@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556653} Change-Id: I28c564fa02d3baf16358170ee4fd5985c44506ba Reviewed-on: https://chromium-review.googlesource.com/1053647Reviewed-by:
-
Xiaohan Wang authored
Bug: 840586 Change-Id: I0d91bde150d6e3755df3a3577862149298eaa61f Reviewed-on: https://chromium-review.googlesource.com/1050934Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#557469}
-
Fumitoshi Ukai authored
release clobber debug clobber debug Bug: 835731 Change-Id: I253025e12c36fe2ee6bad941721bc79658de8062 Reviewed-on: https://chromium-review.googlesource.com/1029569Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#557468}
-
Hiroki Nakagawa authored
According to a recent spec change, this CL changes the default credentials mode on WorkletOptions from 'omit' to 'same-origin'. Spec issue: https://github.com/w3c/css-houdini-drafts/issues/756 Feature dashboard: https://www.chromestatus.com/feature/6383899018002432 Bug: 838540 Change-Id: I341f9c61e11387fe7192d75e616b4003fa36128f Reviewed-on: https://chromium-review.googlesource.com/1051307Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#557467}
-
Adam Rice authored
The http/tests/websocket/workers/no-onmessage-in-sync-op.html layout test had a 2 second busy loop. Reduce it to 0.2 seconds. It would be possible to avoid the busy loop by using sync XHR instead, but this might change the semantics of the test. It is particularly important not to change any semantics as this is a regression test for https://bugs.webkit.org/show_bug.cgi?id=76521. The length of the delay has been removed from the test output so that the expectations won't need to be changed if the delay is changed again. No other changes have been made to the test. In particular, it hasn't been updated to a modern style. BUG=386044 Change-Id: I38c317d89b96e7e3729225603c742d99359959e9 Reviewed-on: https://chromium-review.googlesource.com/1046686 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
This CL makes it so ServiceWorkerSubresourceLoaderFactory uses a factory created from a ChildURLLoaderFactoryBundle rather than the direct network factory for "network fallback" after service worker does not provide a response to a FetchEvent. The direct network factory didn't work in the case of chrome-extension:// URLs, since network service does not understand such URLs. To create the fallback factory, we use the default ChildURLLoaderFactoryBundle of the RenderFrameImpl, except remove the "default factory" from that bundle. The default factory can be something like the AppCache loader factory, which we don't want to hit when performing network fallback. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If6ae1d6fc161cae8ec4574417a0d8954215f878e Bug: 836129 Reviewed-on: https://chromium-review.googlesource.com/1032354 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
- Drops two unnecessary TraceWrappers(). They just call TW() of parent classes. - Add a trace in Trace(). Bug: 581412 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I726fcea1872488ab98541b8a7cce233793815da8 Reviewed-on: https://chromium-review.googlesource.com/1053336Reviewed-by:
-
Maksim Sisov authored
This is a tiny patch, which adds a check if platform_window has already been destroyed by the time ::Close was called. Change-Id: I3413fae38f9574cea4f806755e6738289efda1f5 Reviewed-on: https://chromium-review.googlesource.com/1051827Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#557463}
-
John Abd-El-Malek authored
The FrameTreeNode's initial RenderFrameHost might change during navigations if a cross-origin redirect happens. So caching the initial RPH/RFH IDs would be incorrect. For the navigation case, the only thing that is needed is the BrowserContext so pass that in directly. The security check (AllowExtensionResourceLoad) isn't needed for navigations, as that's done in ExtensionNavigationThrottle per the comment in the file. This makes ExtensionURLLoaderFactory pass in -1 for the procss ID when the network service is running, to match what ExtensionProtocolHandler does for the non-network-service case. Bug: 840600 Change-Id: Ie23ed9e78f69fd4a8bb7a1a4aa964303db2102cf Reviewed-on: https://chromium-review.googlesource.com/1050812 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#557462}
-
Ryo Hashimoto authored
BUG=837161 TEST=build Change-Id: I99299e9f4066dd445458325c264743211e1c6645 Reviewed-on: https://chromium-review.googlesource.com/1051546Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#557461}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/563f26415461..baf831d074e7 $ git log 563f26415..baf831d07 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 angle-skia-autoroll Roll third_party/externals/angle2/ 7348fc5b9..a932b6b51 (4 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I61735a6ac2b8b81878f2bc070734577f1344e5ff Reviewed-on: https://chromium-review.googlesource.com/1053561Reviewed-by:
-
Antonio Gomes authored
Apart from the actual migration, CL also adapts the existing unittests (namely GoogleURLTrackerTest, from components_unittests target) to work with the SimpleURLLoader machinery. Some remarks on the unittests' migration: - GetFetcher calls in the unittests were replaced by handled_request. - MockSearchDomainCheckResponse: rather than calling the URLFetcherDelegate method, it queue a server response to be served upon request. - We call MockSearchDomainCheckResponse before instantiating any request. - RequestServerCheck and FinishSleep both can trigger SimpleURLLoader download. Hence both methods add a loop in order to make sure a request is handled by the server (or failed). Additionally, CL removes the dependency of URLRequestContextGetter from GoogleURLTrackerClient. Derived classes are also updated accordingly. Last, some unittests, namely browser_tests' ErrorPageAutoReloadTest, stared to track additional "google url tracker" loads from its Interceptor. Tests are updated to skip counting such loads. BUG=773295 TBR=treib@chromium.org Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I416c6254876ce6a54ee239ff63cd35fc300d5053 Reviewed-on: https://chromium-review.googlesource.com/1042825 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#557459}
-
Stuart Langley authored
Some cleanup work for components/drive/chromeos/ briging it in line with recomended practices/c++ modernization. - Use ThreadChecker macros. - s/DCHECK(!callback.is_null())/DCHECK(callback)/ - clang tidy: -- modernize-use-default -- modernize-make-unique This CL introduces NO logic changes. Bug: 841659 Change-Id: Ic6f8829a983b14e955c858ed864dcadbc41f9506 Reviewed-on: https://chromium-review.googlesource.com/1053335 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#557458}
-
Matt Falkenhagen authored
Revert "service worker: Make provider hosts for reserved clients first-class members of SWContextCore." This reverts commit 0ce272e0. Reason for revert: Causes crashes on layout tests on MSAN. Original change's description: > service worker: Make provider hosts for reserved clients first-class members of SWContextCore. > > Before this CL, provider hosts for documents that were still undergoing > navigation (i.e., hosts for "reserved clients"), were not owned by > SWContextCore. Instead they were owned by > ServiceWorkerNavigationHandle* and added to SWContextCore after > navigation commit and the renderer ACKs back an OnProviderCreated IPC. > > This CL makes SWContextCore own such provider hosts. This means that > users of SWContextCore will start needing to be aware of reserved vs > ready clients. There are some motivations: > - Sometimes we need to do operations on reserved clients. For example, > the linked bug happens because a new registration can't find reserved > clients. > - SWContextCore already implicitly knows about reserved clients, since > GetProviderByClientUUID can return them. This is a bit of a confusing > inconsistency. > - The spec has evolved to make "reserved clients" a concept, so > it's generally useful to have them clearly defined to more clearly > match the spec algorithms. > > This CL isn't expected to have a behavior change but clears the way > to fixing the linked bug. > > Bug: 841070 > Change-Id: I31ba40029e1b7247f41d69abcf4fa6ef97300a0d > Reviewed-on: https://chromium-review.googlesource.com/1051145 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557423} TBR=falken@chromium.org,kinuko@chromium.org,clamy@chromium.org,shimazu@chromium.org Change-Id: I72b3f4360b764d3d5882582d8ef0f7e07ad96e46 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 841070 Reviewed-on: https://chromium-review.googlesource.com/1053469Reviewed-by:
-
James Cook authored
It just provides backing for ScreenMus; it doesn't really manage displays (and we already have display::DisplayManager). Rename ui::ws2:DisplayManagerMus to ScreenProvider. Leave ui::ws::UserDisplayManager as-is, since it may go away or get refactored soon. TBR=tsepez@chromium.org for renaming an existing mojom BUG=839592 TEST=services_unittests and views_mus_unittests Change-Id: I392f8f8c306e1a0b4497cd3ef455464359acbae5 Reviewed-on: https://chromium-review.googlesource.com/1053170 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
This reverts commit 239d8abb. Reason for revert: Speculative revert for test failures on MSAN bots. https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/7078 Original change's description: > cros: Add fingerprint UI to views lock screen > > This CL adds some basic fingerprint UI to views lock screen to support > fingerprint fishfood. > The detailed specs are not ready and may be subject to change. So it > may need to be polished in the future for adding animation, adjusting > styles etc. > > Current mocks: > https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZdwfnbqy2eSi/files/MCHm5Lyh8lQ6SZ3vjzwd3Uo8wMSJbxAVNpw > > Bug: 835357 > Change-Id: Ifab074ca53bb0a8a5128d9b3da6139d68bb03b09 > Reviewed-on: https://chromium-review.googlesource.com/1047958 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557254} TBR=xiyuan@chromium.org,tsepez@chromium.org,xiaoyinh@chromium.org Change-Id: Ibc27fa0b9eb9807428023af99a3cd98ae8741f0d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835357 Reviewed-on: https://chromium-review.googlesource.com/1053468Reviewed-by:
-
Christopher Lam authored
See go/closure-compile-gn for details. This CL converts the Closure Compilation of print preview from GYP to GN. It also fixes a number of incorrect annotations surfaced by the migration. A local closure compile can be run by setting closure_compile = true in args.gn, and then running ninja -C out/Default webui_closure_compile. A more localized compile may look like: ninja -C out/Default chrome/browser/resources/print_preview:closure_compile Bug: 632206 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifecaf4ac8f9f082060e28acb3eac613a1d98a931 Reviewed-on: https://chromium-review.googlesource.com/1041605Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#557454}
-
Fady Samuel authored
This is no longer used. Bug: 672962 Change-Id: Ib97ca682e2c5eb1252972af9068da5afbff9fb81 TBR: piman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1053588Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#557453}
-
