- 17 Oct, 2018 40 commits
-
-
Daniel Cheng authored
Bug: 891908 Change-Id: If954e2ea4309578b50d987db8a7ce4db31845057 Reviewed-on: https://chromium-review.googlesource.com/c/1283251Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#600370}
-
Jeremy Roman authored
bindings: Drop use of V8CallBoolean in generated dictionary code in favor of a lambda that uses v8::MaybeLocal::To. Bug: 670615 Change-Id: Ib4f1b5674cec44a328b484510b4b197b2afec21d Reviewed-on: https://chromium-review.googlesource.com/c/1281087 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#600369}
-
Sam McNally authored
This is a reland of 5628afcc Original change's description: > Enable the DriveFS experiment in fieldtrial_testing_config.json. > > Bug: 819822, 891197 > Change-Id: Ie8daa2f97af0c0eadd4661ea4b28bbaa6a326839 > Reviewed-on: https://chromium-review.googlesource.com/c/1278431 > Commit-Queue: Sam McNally <sammc@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Sergei Datsenko <dats@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600222} Bug: 819822, 891197 Tbr: holte@chromium.org, dats@chromium.org Change-Id: I26be26774dda39607a10b2b2ba243b9d8fe5480d Reviewed-on: https://chromium-review.googlesource.com/c/1286106Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#600368}
-
Tomasz Moniuszko authored
ListPrefUpdate is used in this file. It fails to compile with some build configurations. Change-Id: Icebb5b6f0ab59d4fad05ce3c1d2b6b64225f77ea Reviewed-on: https://chromium-review.googlesource.com/c/1286467Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#600367}
-
Vadym Doroshenko authored
This CL fixes out of range access, when by some reasons during the phone parsing, libphonenumber returns that national code is longer that the parsed string. Probably the reasons are some incorrect treating of non-ASCII characters. Bug: 895578 Change-Id: I2f0a7622453191778907a8f54e74e35a1484765b Reviewed-on: https://chromium-review.googlesource.com/c/1286136 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#600366}
-
Guido Urdaneta authored
The rewrite simplifies the code and serves as preparation for addition of resizeMode support. The only behavior change is in tie-breaking among candidates that are equally good at satisfying constraints. The new approach uses a single tie braking distance that combines the ideal value and the allowed range, whereas the old code used separate distances for allowed ranges and ideal values. This CL is in preparation for resizeMode support. Bug: 854980 Change-Id: Ie90d5aa8fe029ca1848bf19c232523bab91beadf Reviewed-on: https://chromium-review.googlesource.com/c/1277797Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#600365}
-
Lukasz Suder authored
Bug: 806868 Change-Id: I583c91fbce85ffb0d7a780a2a3adc7c197d59b78 Reviewed-on: https://chromium-review.googlesource.com/c/1283091 Commit-Queue: Lukasz Suder <lsuder@google.com> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#600364}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9ac699ea. With Chromium commits locally applied on WPT: 612705b6 "Only update intrinsic_content_logical_height_ if we don't have an override height" a7da8836 "Convert 'Sec-Metadata' dictionary values to identifiers." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26352 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/encoding NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I75559fb7437a083b730714554c5d7d80975011a0 Reviewed-on: https://chromium-review.googlesource.com/c/1286435 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#600363}
-
Guido Urdaneta authored
This limit is a remnant from the old constraints-processing algorithm. With this change, the minimum aspect ratio will be determined by the capabilities of the devices. This CL serves as preparation for support for the resizeMode constrainable property. Bug: 854980 Change-Id: Ib67bf57a81a780ee6377b9efb5a93c329fd47216 Reviewed-on: https://chromium-review.googlesource.com/c/1276650Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#600362}
-
tzik authored
Unqualified usage of make_optional causes a compile error if: - It's compiler in C++17 mode and <optional> is included. - The parameter of make_optional is in std namespace, such as std::string. As std::make_optional is pulled by ADL rule and conflicts to base::make_optional in this situation. This CL replaces them with qualified base::make_optional, and replaces others for consistency. Change-Id: I2045e9eac0e4466dce266112eab5bf7c8555c2ef Reviewed-on: https://chromium-review.googlesource.com/c/1282512Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#600361}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dbb47b8f7685..4744e5b896a5 git log dbb47b8f7685..4744e5b896a5 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 brandtr@webrtc.org Reland "Remove old video_bitrate_allocator.h" Created with: gclient setdep -r src/third_party/webrtc@4744e5b896a5 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5bc31079f145e13d5bc74b3ff7cf1693c6c3ecc4 Reviewed-on: https://chromium-review.googlesource.com/c/1286474Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600360}
-
Alexander Hendrich authored
This CL handles the scenario of DMServer reporting a 410 status code (missing/unknown/purged client ID) by trying background re-registration. If this fails, the user is marked as requiring an online sign-in. DD: go/handle-purged-user-sessions Bug: 870616 Change-Id: I4a4c2370c36f5464752029d755d23221cd064b0e Reviewed-on: https://chromium-review.googlesource.com/c/1227939 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#600359}
-
Pin-chih Lin authored
InitializeDeprecated should be removed after ToT of ARC-P and ARC-N have upreved to use new Initialize API. BUG=867799 TEST=build and deploy chrome on Grunt Change-Id: I6d2215b9fe735fbb4e1dd4aa179a55187ec908db Reviewed-on: https://chromium-review.googlesource.com/c/1282518Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Pin-chih Lin <johnylin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600358}
-
Sam McNally authored
DriveIntegrationService calls Unmount in its implementation of DriveFsHost::MountObserver::OnMountFailed(). DriveFsHost isn't prepared for this re-entrancy, causing a use-after-free. Unmount first to avoid this problem. Bug: 891197 Change-Id: I61056193847dfdd1dc1ca4c91ccdc80566815744 Reviewed-on: https://chromium-review.googlesource.com/c/1286105Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#600357}
-
Colin Blundell authored
This CL augments IdentityTestEnvironmentProfileAdaptor with a static method that creates and returns a TestingProfile that is configured with the factories that IdentityTestEnvironment requires. This API can be used to convert unittests that use TestingProfile::Builder. It is preferable to use this API if possible rather than the lower-level AppendIdentityTestEnvironmentFactories() as this API is less fragile. That API is still required for tests that do not create the TestingProfile internally but simply supply the list of TestingFactories to configure it (e.g., to some common superclass). This CL converts one unittest as an example and validation. Bug: 882865 Change-Id: Ia7cfa648e0086385f4d1506ca4afda80866240b2 Reviewed-on: https://chromium-review.googlesource.com/c/1280764 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#600356}
-
David Turner authored
This reverts commit da688ad0. Reason for revert: test is flaky. See bug for details. BUG=896198 Original change's description: > [Feed] Add FeedNewTabPageTest#testClickSuggestion > > + Add test on Feed NTP to simulate click on a test card > > Bug: 860055 > Change-Id: Ibf8f4b1ab46ed34dc77346dd19680df876c2d6aa > Reviewed-on: https://chromium-review.googlesource.com/c/1260485 > Commit-Queue: Becky Zhou <huayinz@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600166} TBR=twellington@chromium.org,huayinz@chromium.org Change-Id: I4db05a0448e12ef2c09d296dc9411dd0c83496a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 860055 Reviewed-on: https://chromium-review.googlesource.com/c/1286650Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#600355}
-
Guido Urdaneta authored
This CL: - Removes the restriction of frame rates to no less than 1Hz. This limit is a remnant from the old constraints processing algorithm. There is no reason to keep this restriction, especially because applyConstraints did not have any lower limit. - Use a new minimum frame rate of numeric_limits<float>::min(), equivalent to allowing any positive value and enforce it in both getUserMedia() and applyConstraints(). Prior to this, applyConstraints allowed zero and ideal negative values. Zero was interpreted by VideoTrackAdapter to mean the native frame rate of the source, and negative values caused a renderer crash due to a CHECK in VideoTrackAdapter. This CL also serves as preparation for support for the frameRate constrainable property. Bug: 814131,854980 Change-Id: I7f45fe2862f636100d408a136fe5038fe0994afb Reviewed-on: https://chromium-review.googlesource.com/c/1276506Reviewed-by:
-
Nicolas Capens authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/71e256c..847fc0b BUG=chromium:881334 TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I04a81f1daaa962a3a2510d76784dcb3e0f704e17 Reviewed-on: https://chromium-review.googlesource.com/c/1285480 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#600353}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7740403f4852..4e423c45bcbb Created with: gclient setdep -r src-internal@4e423c45bcbb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie6eeb576a9c5cd85daf93ccd2c84da732fb24502 Reviewed-on: https://chromium-review.googlesource.com/c/1286291Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600352}
-
Christos Froussios authored
This reverts commit 530a1ad5. Reason for revert: Suspected for breaking http/.../slow-loading-image-in-pattern.html on Mac bots Bug: 896205 Original change's description: > Stop using color space xform canvas in Skia's picture backed images > > Change-Id: Ia77210022ac412d00be1fc2f8831eb973e07de62 > Reviewed-on: https://chromium-review.googlesource.com/c/1280786 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Brian Osman <brianosman@google.com> > Cr-Commit-Position: refs/heads/master@{#599979} TBR=fmalita@chromium.org,brianosman@google.com,mtklein@chromium.org Change-Id: I5d1b47b5d15aae0a02058e5b046df32c0a59a00f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1286465Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#600351}
-
Colin Blundell authored
Currently IdentityTestEnvironment only works if it can internally construct the IdentityManager instance that it uses. This is definitely the cleanest mode of operation (and long-term the only targeted one) However, it prevents IdentityTestEnvironment's usage in //chrome-level unittests wherein the IdentityManager instance that the test interacts with must the one constructed via the Profile (i.e., because the production code being tested obtains IdentityManager from the Profile). This CL adds support for using IdentityTestEnvironment in this context. Specifically, it adds a new IdentityTestEnvironment constructor that takes in an IdentityManager instance as well as its dependencies and a //chrome-level adaptor that configures Profile to build the necessary fakes and wraps an IdentityTestEnvironment instance using this new constructor. Bug: 882865 Change-Id: If45f29643fc5a2cacf357ac159c709b068443e9c Reviewed-on: https://chromium-review.googlesource.com/c/1280264 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Jonas Olsson authored
This is part of the onion soup efforts. Bug: chromium:787254 Change-Id: Ic813f3da59aa4621e89fc0802fa779165c4a67d8 Reviewed-on: https://chromium-review.googlesource.com/c/1276565 Commit-Queue: Jonas Olsson <jonasolsson@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/28b6d1d238b8..dbb47b8f7685 git log 28b6d1d238b8..dbb47b8f7685 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d06a979d..c5242283 (600199:600305) 2018-10-17 steveanton@webrtc.org Reland: Modernize rtc::SSLCertificate Created with: gclient setdep -r src/third_party/webrtc@dbb47b8f7685 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic299769db23cc5fb07d57d042554003d9b4517e8 Reviewed-on: https://chromium-review.googlesource.com/c/1286471Reviewed-by:
-
Koji Ishii authored
Text failures that appear in build 10762 were due to the change in the base expectations, but LayoutNG has a separate set of expectations for the space differences. This patch rebaselines them. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic1a0f4b0feb71d91b299225a1aa61d4f961c43ea Reviewed-on: https://chromium-review.googlesource.com/c/1286026 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#600347}
-
Arthur Sonzogni authored
Current state: ============== After a cross-process navigation, content/ swaps the old and the new RenderFrameHost. The old RenderFrameHost goes into pending deletion. Its subframe are immediately deleted. So after a RenderFrameHost swap, WebNavigationAPI stops tracking: * the navigating frame in RenderFrameHostChanged(). * its subframe in FrameDeleted() Future: ====== In a near future, the subframe of |old_host| will go into pending deletion as well. As a result, FrameDeleted() will not be immediately called. See: https://chromium-review.googlesource.com/1122629 What this CL does: ================== Stop tracking the subframes of |old_host| when it goes into pending deletion. Bug: 609963 Change-Id: Ifba038af87a74f3b8e68794b62d3d44055efecad Reviewed-on: https://chromium-review.googlesource.com/c/1278170 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#600346}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f0988af921fb..91f54792a979 git log f0988af921fb..91f54792a979 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 hjd@google.com Merge "perfetto-ui: Fix permalinks" Created with: gclient setdep -r src/third_party/perfetto@91f54792a979 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I6d648b7aae912523d3a6de242a0d7fcaadf05301 Reviewed-on: https://chromium-review.googlesource.com/c/1286472Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 10748 10756 10762 2 lines were removed and 1 lines were deflaked by consecutive results since 10686. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I38f37274c9c777dbec7c11190175121ecda19f7c Reviewed-on: https://chromium-review.googlesource.com/c/1286229 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Sam Zackrisson authored
Bug: webrtc::9535 Change-Id: I5511b6eda21b86028c722b93192f5bcda19e2314 Reviewed-on: https://chromium-review.googlesource.com/c/1286449Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#600343}
-
Javier Fernandez authored
The MoveParagraph function doesn't guarantee the paragraph's style is preserved when the insertOrderedList/insertOnordered list commands are used. Instead, we should use MoveParagraphWithClones. This change implies rebaseline a few tests, since the result tree is different than the one created with MoveParagraph. Bug: 149901 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I01e5a9ade28d3c16e8dc5423bf16dcf0d7e60976 Reviewed-on: https://chromium-review.googlesource.com/c/1216282 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600342}
-
Scott Wu authored
Bug: 865114 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0a7d78359724a4e4cdca350145b55b65e5d4f184 Reviewed-on: https://chromium-review.googlesource.com/c/1250503 Commit-Queue: Scott Wu <scottwu@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#600341}
-
Rune Lillesveen authored
Bug: 895894 Change-Id: I6111fc26cb21ddc3a6db5702cb382fce1e623632 Reviewed-on: https://chromium-review.googlesource.com/c/1286413 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#600340}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0a8faf3f557d..483536c242f3 git log 0a8faf3f557d..483536c242f3 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d633b1569a21..1d8a783c9db2 (2 commits) 2018-10-17 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-10-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@483536c242f3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: Ib0d7f210d7f9a9f1f4e776bc9ef0e56e61cc56c9 Reviewed-on: https://chromium-review.googlesource.com/c/1286290Reviewed-by:
-
Hazem Ashmawy authored
loadUrl(String) has an early return if url == null, this is just adding the same early return to loadUrl(String, Map<String,String>). This should prevent sending null values to AwContents::SetExtraHeadersForUrl and then to ConvertJavaStringToUTF8. Bug: 864708 Change-Id: If169dbc89dfdf745e7fa27921fa7624abed40a84 Reviewed-on: https://chromium-review.googlesource.com/c/1283449Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#600338}
-
Matt Falkenhagen authored
Bug: 715640, 846235 Change-Id: I49ed8a5a3bc5962cd52e24ab734b00fdfdd7b32d Reviewed-on: https://chromium-review.googlesource.com/c/1286238 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#600337}
-
Matt Falkenhagen authored
This fixes ServiceWorkerRequestHandlerTest.InitializeForNavigation_ExternalFileScheme when ServiceWorkerServicification or NetworkService is enabled. It's the same fix as the non-servicification path, done in r528590. Bug: 895187,896157 Change-Id: I8949c0bf002b329a01b1755913d16634dd80e7cd Reviewed-on: https://chromium-review.googlesource.com/c/1286021Reviewed-by:
-
Jan Wilken Doerrie authored
This change makes use of the updated semantics of PasswordUiEntry.id to simplify the update list behavior of passwords_section.js. Bug: 892260 Change-Id: Icfde6048049edd6e418580660b34928db798764d Reviewed-on: https://chromium-review.googlesource.com/c/1283013 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#600335}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/api/gcm. This CL was uploaded by git cl split. R=jianli@chromium.org Bug: 809610 Change-Id: I2467157d104d74299ab12f1ced3bbe0245a48b68 Reviewed-on: https://chromium-review.googlesource.com/c/1258905Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#600334}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/safe_browsing. This CL was uploaded by git cl split. R=nparker@chromium.org Bug: 809610 Change-Id: I95c33ffc6a6d7699e0c1813ea7f760b7a9654d83 Reviewed-on: https://chromium-review.googlesource.com/c/1259043 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#600333}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/chrome_content_browser_client_unittest.cc. This CL was uploaded by git cl split. R=<anyone> Bug: 809610 Change-Id: I845dacbc5ee28e89ab69bf2bebaf5700f931b6fb Reviewed-on: https://chromium-review.googlesource.com/c/1258170Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#600332}
-
A Olsen authored
Get rid of CrosSettings::Get()->Set...() usage in tests. This CL changes all such calls to ScopedCrosSettingsTestHelper::Set. This call does the same thing as before, but it means there is only one call to CrosSettings->Set that will need to be changed in order to separate the read and write APIs. This is part of an ancient bug to make CrosSettings read-only - the equivalent API for writing is OwnerSettingsService. It will also be useful for moving CrosSettings out of chrome/browser without having to move all of OwnerSettingsService. Another minor clean up: There are two different ways to have a test setup CrosSettings - one way is to use ScopedCrosSettingsTestHelper, which sets up InstallAttributes, DeviceSettings, and CrosSettings. The other way to set them all up using individual helper classes, including ScopedDeviceSettingsTestHelper. What is not obvious, is that the first way sets up a real session manager, but the second way sets up a fake session manager. This CL also changes existing_user_controller_auto_login_unittest.cc to use the first way for consistency, and adds the call "SetFakeSessionManager()" which is more explicit, instead of having different helper classes set things up in subtly different ways. BUG=433840 Change-Id: I0c84af93d446ce8f82d1aabbf070195abea24dd4 Reviewed-on: https://chromium-review.googlesource.com/c/1256966 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#600331}
-
