- 13 Nov, 2020 40 commits
-
-
Kelvin Jiang authored
"The associated user script. Owned by the UserScriptInjector that created this object." ^Should be UserScriptSet. Bug: NONE Change-Id: I5a080c33b74a22b8af3b824234a0a89aff8fa9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537410Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827397}
-
Ahmed Mehfooz authored
We need to use opaque colors to make sure the stroke on the outside of the icon doesn't look like it's overlapping with the background color. Bug: 1117581 Change-Id: Id33595d5250327cf07c97f4b737fec7d6785e6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533846 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827396}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1f7a8206536e..be466dc7ac2c 2020-11-13 aerotwist@chromium.org [eslint] Change es_modules_import rule to also check unit test files 2020-11-13 patrick.brosset@microsoft.com Flex: Draw correct separators around flex lines and items 2020-11-13 aerotwist@chromium.org [unit type] Update ValueType 2020-11-13 petermarshall@chromium.org tests: Add final changes for parallel e2e tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101784,chromium:1139949,chromium:1148296 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3686edebcbc805a70aa8cd5053ce690b68153a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537176Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827395}
-
Xi Han authored
StartSurfaceTest#testShow_SingleAsHomepage{V2}_VoiceSearchButtonShown__Instant_Return are failed/flaky on M/L bots. The failing tests are due to the check of the voice_search_button is too soon. Adding more events to wait. Bug: 1148352 Change-Id: If6780547a089295a47634a3c1489bd77b2496bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533545Reviewed-by:Filip Gorski <fgorski@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#827394}
-
Trevor Perrier authored
This CL disables the test: - TranslateManagerBrowserTest.PageLanguageDetectionConflict It was reported as flaky and appears to timeout the first time it is run but succeed the second. Bug: 1148703 Change-Id: I2e14df16d8b42fc6acab49212adf5020d426b54b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538093 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#827393}
-
Matt Wolenetz authored
Drops a couple obsolete TODOs which previously tracked changing EncodedAudioChunk and EncodedVideoChunk to IDL dictionary types. This doesn't preclude adding parallel dictionary types that the APIs can consume later, if needed. For the MSE case, keeping them as non-IDL dictionaries retains the current ability for the bindings generator to precisely disambiguate them (for example in matching to an overload or union). This CL intends to increase certainty that that disambiguation capability will remain; otherwise new API shapes depending on it might need to change. Note that keeping them as non-dictionary types is nice for webcodecs; it better retains their immutability and enables potential for reduced/zero-copy scenarios (sandersd@ mentioned this, along with mentioning improved implementation control over behavior like construction and transferring). BUG=1144908 Change-Id: Ib9fb6bcd50b6fe2900908c3380b75b798c71b667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535735Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#827392}
-
Etienne Bergeron authored
This reverts commit 4718f57e. Reason for revert: Study is over Original change's description: > Add detailed memory dump provider URLIndexPrivateData > > This CL is adding the code to dump memory usage for inner-structures > used by URLIndexPrivateData. > > The purpose of this CL is to estimate the size/count of the pathological > cases and to see which inner strucutures required limits. > > NOTE: This CL need to be reverted before the M88 branch point on Nov 12. > > Bug: 1068883 > Change-Id: I5c4709d7ce7b634aa2ccf5b40bc19d6bff2e77eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504278 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822249} TBR=tommycli@chromium.org,jdonnelly@chromium.org,etienneb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1068883 Change-Id: I8b7523bf4cbda4d0fc92cd3d8e18b00fcca0d828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537137Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#827391}
-
Pavol Marko authored
In onc to shill translation, set IPAddressConfigType and NameServersConfigType to "DHCP" in the resulting ONC data if no value is provided by shill. The default of "DHCP" is consistent with go/onc and with shill behavior. This is important so that these values always have a value when policy decoration happens (the shill -> onc translated ONC is an input to policy_util::CreateManagedONC invoked in ManagedNetworkConfigurationHandlerImpl). The UI can then depend on these always having an ActiveValue, so cros_network_config.mojom has been changed to set the corresponding {ip_address,name_servers}_config_type fields as mandatory. Bug: 1108922, 1109660, 1109670 Test: unit tests + manual on DuT (network settings) Change-Id: I6111a3c7f6af64fac22ea33347dd17774bbda4c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530330Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#827390}
-
Salvador Guerrero authored
This CL updates the background tracing metrics provider to include antivirus data on uploaded traces, this only applies to windows traces. Bug: 1126192 Change-Id: I909bf8dbe7fe12514d707b9006dcf295f2d5a4fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532902 Commit-Queue: Salvador Guerrero <salg@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#827389}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8bf9368130b8..f1f7c370eb0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ifa5e93f1c8b73ba33944473c474e19e1979a2175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538049Reviewed-by:
-
Clark DuVall authored
All major crashes have been fixed and numbers look good. M88 branch was just cut, so should be safe to enable now. Bug: 1126301 Change-Id: I351d565e68f14af2411c71fa80f34852bab5455a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529729Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#827387}
-
Clark DuVall authored
This reverts commit 858c31cc. Reason for revert: Forgot to update TelemetryActivity.java Original change's description: > Use weblayerStartupMetric for system_health.weblayer_startup > > The metric was split out of the WebView version, so we should use this > now for WebLayer startup tests. > > Pinpoint job running: > https://pinpoint-dot-chromeperf.appspot.com/job/104b30a9520000 > > Bug: 1146438 > Change-Id: I9938614b94740a3222fb832ab994427b136bf1d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536797 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827339} TBR=johnchen@chromium.org,cduvall@chromium.org Change-Id: Ib36049acdd6f285f2c7f6760a8a951816c23e120 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1146438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536844Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#827386}
-
Evan Stade authored
I couldn't reproduce or understand the flakiness, but hopefully rewriting the test to use TestWebLayer#crashTab instead of navigating to chrome://crash will resolve the problem. FWIW, in the old version of the test, the navigation itself seemed to fail, in that the post-test screenshot still showed about:blank in the url bar. Bug: 1143788 Change-Id: I35cbca4368f7215fd173692c1d2a24ed34fe8e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535218Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#827385}
-
Matt Jones authored
This patch checks if the grid is showing for the top toolbar's overlay as the visual logic in that class is for the stack. This should be a temporary measure until each layout has its own type. Bug: 1147801 Change-Id: I2a61c992febe6307c64ea3a9462fce955a7c9027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535811Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#827384}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605268075-beb915b3939660700cb86662fda8b7247e8e8c87.profdata to chrome-linux-master-1605290311-c0a8bccef266e50cf7d2fe9fae22d951549688a8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I75c3ee90f996a4ddb3025f97b58cc8f0c1edd7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537293Reviewed-by:
-
Ted Meyer authored
Cleaning up the field trial config here: cl/341906454 Change-Id: I8082c282de63c441e5c6c8e3875f365b1f295571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535628Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#827382}
-
adoneria authored
Until the test framework is stable, run it on updater specific builders and testers. Bug: 1147588 Change-Id: Id12ce00b509b311de575103b3a3dbebc8f890c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535911Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#827381}
-
Alexander Cooper authored
The XRWebGLBinding is defined in the WebXR Layers spec (https://immersive-web.github.io/layers/); however, it is also required by both the Lighting Estimation and Raw Camera Access specs. We are not actively working on the layers spec; however, we want to Origin Trial both Lighting Estimationa nd Raw Camera Access. This change simplifies these cross-spec dependencies by shipping the empty XRWebGLBinding interface. I2S: https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/6J0yfRuMmSU Bug: 1070819 Change-Id: I8626fa854d892171542cec06a0befac76187fd84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519938 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#827380}
-
Filip Gorski authored
Moves OSDDelegate into OmniboxSuggestionsDropdown (patchset 1) and flattens things out to a single class (patchset 2). Bug: 1075602 Change-Id: I71322c03538879ba1bac587f24c590f28813e14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530954Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#827379}
-
Leonard Grey authored
Adds commands for opening bookmarks: - A composite command labeled "Open Bookmarks..." that allows searching bookmarks when selected. - If user input is "long enough" (currently two characters, will be tuned), "noun first" bookmarks will begin to surface at top level. Bug: 1014639 Change-Id: I910e9ba4992e7705cce2f8c5e23104c8ba6f408e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535677Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#827378}
-
Mason Freed authored
The getInnerHTML API is relatively new, and was not added to the ShadowRoot object. This CL fixes that gap, and adds testing for both getInnerHTML and setInnerHTML on ShadowRoot. Bug: 1042130 Change-Id: Ibae20d7c0e9f44b92932499234e493ba798e06b0 Fixed: 1147752 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536372 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#827377}
-
Roman Arora authored
Reverting the use of afterNextRender in favor for setTimeout causing the Tab Search bubble to not show consistently on Mac. Bug: 1148767 Change-Id: I69157b7b9c7eabbe9e73d36f177f226fdb31c795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537921Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#827376}
-
Gayane Petrosyan authored
1. Reset range counters when new generation is requested. 2. Use ranges when selection starts and ends in the same block which has nested block 3. Fix crash when selection starts or ends with a non text node which has children. Crash is because using length of text content to find last position is incorrect when there are nested children. We should use Position::LastPositionInNode(*node) instead. Bug: 1129650 Change-Id: I13e305f67c28aca7643903f96e258be8fbf8e9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533123 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827375}
-
Leonard Grey authored
The original design for this was that when the user selected a composite command, a specialized CommanderBackend object was created, and CommanderController would delegate to it to allow the user to enter details. In practice the impedance was wrong. We need extra information for the composite command (how to prompt the user), *don't* need a lot of other things in the CommanderBackend interface, need to duplicate logic re: command execution and risk lifetime issues with nested composite commands. In this change, composite commands are represented by a pair of prompt text and a lambda with a signature similar to CommandSource::GetCommands. All other logic is is handled by the controller. For a worked example, see the dependent CL https://chromium-review.googlesource.com/c/chromium/src/+/2535677 Bug: 1014639 Change-Id: I07c172584afcf4288a460362099dbd73b412daa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536050Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#827374}
-
Patrick Monette authored
Bug: 971272 Change-Id: I1fd11d59ede2883b06a7a4104947419676323810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521950 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#827373}
-
Peter Kotwicz authored
This CL adds com.google.guava:guava:25.1-android to //third_party/android_deps/build.gradle and makes Chromium code use the new target. BUG=1144019 Change-Id: I680ea49ae986aa33766716cae6d883b9adaa1253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519762Reviewed-by:
-
Darwin Huang authored
Make ClipboardWriter keep FileReaderLoader alive until it's done reading a Blob, by using SelfKeepAlive<T>. Previously, ClipboardWriter could be garbage collected unexpectedly (ex. when the frame detaches). This could cause a use after poison in the FileReaderLoader, where: (1) A ClipboardWriter's FileReaderLoader starts reading the input blob as an async task. (2) The ClipboardWriter is destroyed (garbage collected). (3) The FileReaderLoader completes its async task of reading the input blob, and calls ClipboardWriter::StartWrite on the destroyed, owning ClipboardWriter. Additionally, add a "context destroyed" error message when a context detaches. Bug: 1142331 Change-Id: I427cd6dc02e773b2d235d45bd9ad8935b575ff71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509033 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#827371}
-
Yicheng Li authored
The platform side may want to close the in-session auth dialog (for example in WebAuthn when the browser issues a timeout). Expose a DBus API for dismissing the dialog. This will have the same effect as if the user clicks the Cancel button. Change-Id: I9ab2456967d08c382302ee528b0aa6cc2a0d01c5 Bug: b/167574666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499180Reviewed-by:
-
Mason Freed authored
This convers the prior DCHECKs to CHECKs, and adds a more informative comment in case these are hit. To be left in for ~2 weeks just to be sure. Bug: 937746 Change-Id: I40e5da27815c9156d0d26a22d89909b8de4665d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538045 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#827369}
-
Jeroen Dhollander authored
This service does not own/do anything right now, but it runs on the background thread and will be fleshed out in the (many) follow up CLs. Bug: b/171748795 Test: chromeos_unittest --gtest_filter="AssistantManagerServiceTest.*" Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: Ica3d227a223ea9678b5a6a0e29580907835956dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518254Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#827368}
-
Tommy Martino authored
This feature is launching to 95% soon. Enabling by default; cleanup CLs to remove the flag will follow once that reaches 100%. Bug: 1098328 Change-Id: Iac5c5aa8ba592c6785af0f5b1c1be4f6ea0303c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535876Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#827367}
-
Alexander Surkov authored
formatter Keep tree formatters generic: command line setup is used for testing only and thus the logic should be moved to where appropriate. DumpTestHelper class already handles all test related logic, thus move command line setup logic there Bug: 1133330 Change-Id: I330788c1b263447f4882f92dbce5c62581a6352e AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533905 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#827366}
-
Julian Pastarmov authored
This is a reland of b53e31ad Original change's description: > Merge old and new list policies that were renamed > > This change moves migrating of renamed policies from the PolicyHandler > to a PolicyMigrator that happens right after the PolicyMerger has run. > This guarantees that list policies can be properly merged between > sources even if different sources provide different naming. > > BUG=1138572 > TEST=browser_tests:PolicyPrefsTest.PolicyToPrefsMapping > > Change-Id: Ibe335176ef52dabbe09c076ba57ae04d1c67c1c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507771 > Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Yann Dago <ydago@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826903} Bug: 1138572 Change-Id: I410d65abdbcf81a07ca578bec619fcbcd933fce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536880Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#827365}
-
chinsenj authored
This CL adds metrics for counting the number of consecutive screenshots a user takes. Visit go/capture-mode-metrics to see other planned metrics. Test: manual + added Bug: 1140182 Change-Id: Ic1b39e3601fd890ad42b9d9e18678b60793cd7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532997 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#827364}
-
David Roger authored
This is a reland of CL 2523185 Patch Set 1 is the version that was reverted. The flaky test has been moved to password_manager_interactive_uitest.cc Bug: 1076880 Fixed: 1147433 Change-Id: If419787c95fbc740e5fc825a222576a9abf4e716 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532563 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#827363}
-
Fredrik Söderqvist authored
At this point we will have resolved the type and any CSS property that 'attributeName' maps to, so we can use the (stricter) test IsAnimatingCSSProperty() instead of IsTargetAttributeCSSProperty(). Similarly we can drop the AnyQName() test because it shouldn't map to a proper type/CSS property. Remove IsTargetAttributeCSSProperty() since it is now unused. Bug: 1017723 Change-Id: I12d231718b335e1c21cff98247fe4869fd3232c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537837Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#827362}
-
Thomas Tellier authored
Bug: 1104336 Change-Id: I7da10e535330b0f583d9998b334e41061fe0cd1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536437Reviewed-by:
Thomas Tellier <tellier@google.com> Reviewed-by:
-
Mohamed Adel authored
Add metrics for: Notification Permission Level: enabled/disabled Notification Display Style: alerts/banners Bug: 1148276 Change-Id: Icafd8859fa975d2207e047232f403859fc670a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532566 Commit-Queue: Mohamed Adel <adelm@google.com> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#827360}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ea4e9a46. With Chromium commits locally applied on WPT: 4a941689 "Add WPT and fix logic for XRWebGlBinding constructor" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I9f5825c8f8b3957e6ec5a8033fd96d34ef18826b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538012Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827359}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c43088c6dc01..f46e6201b40b 2020-11-13 jmadill@chromium.org Revert "Roll glslang from 142cb87f803d to beec2e4a7c4d (12 revisions)" 2020-11-13 cnorthrop@google.com Tests: Add Real Commando Secret Mission trace If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: angle_perftests --gtest_filter="*real_commando_secret_mission*" Change-Id: I2671838524c0a2e055ffab6f46c8f3940e87a225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538031Reviewed-by:
-
