- 12 Apr, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bd29f6f75209..db58954c8cb3 git log bd29f6f75209..db58954c8cb3 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 dpranke@chromium.org Use the same git-cache bucket for authenticated and unauthenticated repos. Created with: gclient setdep -r src/third_party/depot_tools@db58954c8cb3 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:935084 TBR=agable@chromium.org Change-Id: I3f938ab6e8d069b141840451422300838ea632e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566279Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650465}
-
Xiyuan Xia authored
UIPerformanceTest::SetUpOnMainThread() needs to be called to start tracing. Otherwise, it hangs on exit when trying to stop trace. Bug: 942599 Change-Id: I13045ea5244bc20db8387c11972b2274e4d90f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566364Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#650464}
-
Tommy Steimel authored
This CL adds a MprisNotifier to connect to the Media Session service and update the MprisService with the metadata of the active media session. Bug: 951584 Change-Id: Idf8f5db3197783e27495e6f70779c3157bfb8e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562628 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
-
Daniel Cheng authored
Bug: 842296 Change-Id: I43f6a5ebe7de228483072aab92b796f34ab81ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566158 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#650462}
-
Brian White authored
Putting the export=false on the <enumeration> tag ends up just being ignored. Local-metric aggregation works fine but the key-metric ends up being also aggregated and stored in the output tables. Change-Id: I3a061f14af847bb55bbd49d5fe0c8a918a4017cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566390Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#650461}
-
Henrique Ferreiro authored
As advised in [1], this CL ports calls to Foo::Create() factory functions to use MakeGarbageCollected<Foo> from classes in //third_party/blink/renderer/core/svg. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ibe056e0972447afcb54db2209f3977ec42ec094c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564073 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#650460}
-
Dominik Röttsches authored
For unique local font matching, on Windows 10, we do not need to scan fonts and build a lookup structure but instead we can perform lookups directly against IDWriteFontSet using GetMatchingFonts() API. This API is only available where IDWriteFactory3 is available, which means on Windows 10. Add a method to DWriteFontProxy to perform a single font lookup using this API. Also add a method to dermine which mode should be used on the current machine: single lookups or retrieving the shared-memory lookup table that we built for Windows 7 and 8. See the design document [1] for more details. [1] https://docs.google.com/document/d/1yCZwVIF39S8WOgCUraT5OuUUaLSqWrxoG3mqdtnHnhs/edit#heading=h.s74lqnekmr53 Bug: 951978 Change-Id: I833139238a47ba9e72f643656a75c2e78c069343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565310 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Ben Wagner <bungeman@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#650459}
-
Ryan Hansberry authored
These logs will allow developers in the future to understand if an unexpected situation (crbug.com/943761) was hit when examining feedback reports. Bug: 943761 Change-Id: Ice7054acb8dd13c3f405195f8919b08c8312c007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566416 Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#650458}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b727c7b27557..5b353de6daa9 git log b727c7b27557..5b353de6daa9 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 rmhasan@google.com [Telemetry] Allow test paths to be used as test names Created with: gclient setdep -r src/third_party/catapult@5b353de6daa9 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:698902 TBR=crouleau@chromium.org Change-Id: I0154e3f2b8c922c7c3e11c3d01871a7ae84e0b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566450Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/249b32178539..330fbee5d870 git log 249b32178539..330fbee5d870 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 jonaso@webrtc.org Make ExtraICEPing send slightly fewer extras Created with: gclient setdep -r src/third_party/webrtc@330fbee5d870 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I63035de4776e64a840f8a69d5a7b7dab9d79e27c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566274Reviewed-by:
-
Charlene Yan authored
Change-Id: I13e40a605cd1c891a533e4d2a4d9a62c3ccbe3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566020 Auto-Submit: Charlene Yan <cyan@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#650455}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/81880ac0f676..e7d286efc876 git log 81880ac0f676..e7d286efc876 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 treehugger-gerrit@google.com Merge "Talk about sampling in docs." Created with: gclient setdep -r src/third_party/perfetto@e7d286efc876 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I4e6b9d2e6b7a6ec546998dd18e19c2c843720567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566277Reviewed-by:
-
Andrey Kosyakov authored
This reverts commit a00b988e. Reason for revert: speculative revert as a possible cause of android build failures (https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8916352597455843616/+/steps/compile/0/stdout) Original change's description: > Android: Link against apk_under_test resources for test apks > > Test apks are allowed to reference resources that live in the apk_under_test. > We've previous supported such references via R.java constants, but this > CL also adds the ability for resources in the test apk to directly > reference resources in the apk_under_test (e.g. via xml @references). > > The need for this has come with the latest version of the support > library. > > To accomplish this: > 1. Adds a "-I UnderTest.ap_" flag when compiling test apks resources > 2. Sets the test apk's arsc package name to match the apk_under_test's > package name. > 3. Uses --emit-ids / --stable-ids to avoid collisions between the > test apk and the apk_under_test. > 4. Updates incremental install manifest logic to do the same trick. > > Some other small tweaks to related resource code: > * Removes incremental AndroidManifest.xml as an explicit build output > * Moves most uses of "aapt dump" to "aapt2 dump" > * Removes --check-resources-pkg-id in favor of always enabling it > * Removes --optimize-resources in favor of having it implicitly set by > --optimized-resources-path > > Bug: 896775 > Change-Id: I6ea2d1ec8d1109bede4e0701eb4c7aeaa2a67503 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556395 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#650427} TBR=agrieve@chromium.org,estevenson@chromium.org,tiborg@chromium.org Change-Id: Ie70c31177c5b5e33d830a9d4fc57f10613fc5d30 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566365Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#650453}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/485dd5e5..8042513e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I42086b21a2f8e620cd3d08e4bceb74e1e18c3d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565728Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650452}
-
Toni Barzic authored
Bug: None Change-Id: Id6caf41b9f355a2100b4660cd6c53e3440c56610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565111 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#650451}
-
Matt Mueller authored
The WebSocketChannel and URLRequest will be destroyed if the connection is aborted, so the |out_headers| and |callback| in these methods would not be safe to access. Also use weakptr on URLRequestHttpJob::NotifyBeforeStartTransactionCallback. This avoids an issue where the callback is run while the URLRequest is cancelled but not yet destroyed, similar to https://crrev.com/be9d8e81e8c3ac82d25597e653d929dfff2d8ec1 Bug: 947407 Change-Id: I7d4e16859fa9f9c17ce4264eb78a9c4224a686b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559493 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#650450}
-
Lily Chen authored
If the sampling rate is 0.0 or 1.0, there is no need to generate a random number to see whether we should sample or not. In most cases, this eliminates a file read to /dev/urandom which may be slow. Bug: None Change-Id: I6ed8302574d45ddd1437610c8c5b03de187f8c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566112Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#650449}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1de3cd440cf8..bd29f6f75209 git log 1de3cd440cf8..bd29f6f75209 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 nodir@google.com Roll bb to 080c945efd74d45e9edac5d5b6cc598bbe106593 Created with: gclient setdep -r src/third_party/depot_tools@bd29f6f75209 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I768cdac6aad31967aa5fa079af5a1b409ff23e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566140Reviewed-by:
-
Vlad Tsyrklevich authored
Test the higher-level AnalyzeCrashAllocator() function and have it check deallocation stack traces as well. Bug: 951410 Change-Id: I2755c1e08de386290cd2ddc710269f7f60553e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566115 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#650447}
-
Robert Liao authored
This is a run of clang-tidy with the existing .clang-tidy config on //ui/views including modernize-use-default-member-init and readability-redundant-member-init. BUG=940732 TBR=sky@chromium.org Change-Id: I9f14648a041bbdb799b94642126483441cdf39c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542062Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#650446}
-
Ethan Jimenez authored
1. Introducing support for `TextUnit_Word` and `TextUnit_Line` in `AXPlatformNodeTextRangeProviderWin::MoveEndpointByUnit`. Similar to `MoveEndpointByCharacter`, this change introduces methods `MoveEndpointByWord` and `MoveEndpointByLine`. Since these last three methods basically followed the same code path, a new method `MoveEndpointByUnitHelper` generalizes how to move an endpoint given which `AXPositionInstance` method is relevant to a particular unit, i.e. `CreateNextCharacterPosition` and `CreatePreviousCharacterPosition` for the character unit. With such generalization, methods to move by character, word and line have been refactored to use `MoveEndpointByUnitHelper`. 2. Refactoring a big chunk of `AXPlatformNodeTextRangeProviderTest` in order to reduce code repetition and improve readability. 3. Adding unit tests for `MoveEndpointByWord` and `MoveEndpointByLine`. Bug: 928948 Change-Id: I3d323ff483407bb50a8d678ef0fe6677591f71e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563434Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#650445}
-
Mehran Mahmoudi authored
This calls TouchlessUiController::addModelToQueue and TouchlessUicontroller::removeModelFromQueue when a dialog is shown and dismissed, respectively. It also renames AppHooks::createTouchlessMenuCoordinator() Bug: 944512 Change-Id: I1f8b6ea6c2f411e04b2c24d4022399b05930527c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564558Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#650444}
-
Alexandre Frechette authored
Also adds doc and test around s2langquadtree's unique face constraint. Bug: 850947 Change-Id: Ie8a48040bddeb011b59a8e3be230f1fdfa0d3406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553586 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#650443}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1f7039a6c177..82eb22e297f5 git log 1f7039a6c177..82eb22e297f5 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 capn@google.com Propagate descriptor decorations to access-chain and load results Created with: gclient setdep -r src/third_party/swiftshader@82eb22e297f5 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Iae52dd8695bb25cb98b7792a73ed2ec1d92afdcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564644Reviewed-by:
-
Collin Baker authored
ViewObserver::OnViewVisibilityChanged is currently only called when the observed view's visible() state changes. This is different than View::VisibilityChanged, which is called whenever SetVisible() is called on the observed view or any of its ancestors, or whenever the parent widget's visibility changes. This makes OnViewVisibilityChanged's behavior and interface match VisibilityChanged. In doing so, this fixes an InkDrop bug where InkDrop state incorrectly remained after a view was no longer drawn. This bug resulted from switching to the ViewObserver interface. Bug: 943979, 949067 Change-Id: I35cb4db5625060e2564f6c295dd047ca57c7a8ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553708 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#650441}
-
Christian Dullweber authored
Some deletions are very slow or don't finish at all. To identify which tasks of a deletion are causing this, record a histogram after 180s with the task ids from BrowsingDataRemoverImpl. Bug: 927474 Change-Id: I9499f5ae4a36c400b8524bd0d9e1f6b44bc34122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559950Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#650440}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/157a60421da8..35c44ec01176 Created with: gclient setdep -r src-internal@35c44ec01176 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org,caseq@chromium.org Change-Id: Ibb1926810b9aacdd2c3063722076ab8cc1ed7d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566138Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650439}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e8d8f2d2. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" adc34f41 "Fix web_test pointerevent_coordinates_when_locked on wpt" e525003f "Do not resume a suspended BaseAudioContext when AudioWorklet starts" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I9160d57061b8ffffecaefb0599aa8361f912398a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565723Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650438}
-
Yuly Novikov authored
Linux FYI SkiaRenderer Vulkan (NVIDIA) Linux FYI Release (NVIDIA) TBR=kbr Bug: 940723 Change-Id: I43f71450a49fe2ab93d4f04895325c4d6d3f3dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565991Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#650437}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/095babf0273a..b727c7b27557 git log 095babf0273a..b727c7b27557 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 benjhayden@chromium.org Migrate cp-checkbox to es6 module. Created with: gclient setdep -r src/third_party/catapult@b727c7b27557 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011 TBR=crouleau@chromium.org Change-Id: Iec54df07ad17261bb7f00d41ed3dd43f343fd7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566139Reviewed-by:
-
John Lee authored
When focusing into a cr-radio-button, the focus should be moved to the actual button where the paper-ripple focus indicator is visible. The host element still needs disabled/checked attributes so that parent cr-radio-groups can still access and modify them. Bug: 949456 Change-Id: I972065e3c5c6ce4344e34971c1d7d0e542a63262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564536Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#650435}
-
Anupam Snigdha authored
This change has the initial implementation of GetActiveComposition & GetConversionTarget APIs. Unit tests are also added for these APIs. Bug: 928948 Change-Id: I7b21d85f0262c033acc07ad0df8f01bc706960bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544572 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#650434}
-
Devlin Cronin authored
Remove the unused method ExtensionActionManager::GetBestFitAction(). The method was defined and tested, but never called in production. Remove it and the associated unit test. Bug: None Change-Id: I2dc19b7166cd6095e9e7fdb640c75b570f957dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564884Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#650433}
-
Benoît Lizé authored
Per the results of the beta experiment, it reduces memory footprint on desktop and Android, doesn't regress responsiveness, and doesn't cause crashes. From the current dev/beta Finch experiment (full results here, google internal: https://docs.google.com/document/d/13mLZCzn8tcu3HzLClHT5PZ13GZ3R1a1qyo5fTHMPZmo/edit) - Windows: 1.3MB median PrivateMemoryFootprint savings, 8.8MB @95th percentile - Android: 0.7MB @median, 4.4MB @95th percentile In both cases, foreground CPU cost is <0.1% @95th percentile. Savings above are per renderer, for all renderers. On popular websites, savings are higher, e.g. 15MB median PMF savings on facebook.com, desktop. As a consequence, enabling it by default. Bug: 924164, 951773 Change-Id: I4742cbf053b08a259774c453b555e22ebc44de1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556852 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
-
Lucas Furukawa Gadani authored
This CL fixes the PortalActivateEvent to throw an exception if it tries to adopt the predecessor while it is not associated with a predecessor browsing context. Bug: 942286 Change-Id: Iefd7b8612330300d3bed00daff7d2ae17cd45d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565994 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#650431}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4877ef358434..6c85037d35b5 git log 4877ef358434..6c85037d35b5 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 jmadill@chromium.org Move ANGLE CQ to linux-angle-rel and mac-angle-rel. Created with: gclient setdep -r src/third_party/angle@6c85037d35b5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:822310 TBR=ynovikov@chromium.org Change-Id: Ib91cf9b609ce0b130864ab220bf1d4dd08151b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566273Reviewed-by:
-
Gayane Petrosyan authored
Before fix, normal font size https://screenshot.googleplex.com/zkBbPrdicmG.png Before fix, large font size https://screenshot.googleplex.com/75ZKUz1CBnV.png After fix, normal font size https://screenshot.googleplex.com/UcrSRs3moZr.png After fix, large font size https://screenshot.googleplex.com/9dwWd58nDBJ.png Bug: 952165 Change-Id: Ief8a5aa5266cbd85661bd55bf94df2c2ca715a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566210Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#650429}
-
Yining Wang authored
Follow up on refactor hosted_app_browser_controller, which creates a base class (web_app_browser_controller) for it. IsForExperimentalHostedAppBrowser is checking if the PWA UI is enabled, and it could be moved to the base class. So we rename it to IsForExperimentalWebAppBrowser and move it to WebAppBrowserController class. Change-Id: Ic4e74f7abd5bfd9deff927ebd8670424706cec9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562623 Commit-Queue: Yining Wang <yiningwang@google.com> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#650428}
-
Andrew Grieve authored
Test apks are allowed to reference resources that live in the apk_under_test. We've previous supported such references via R.java constants, but this CL also adds the ability for resources in the test apk to directly reference resources in the apk_under_test (e.g. via xml @references). The need for this has come with the latest version of the support library. To accomplish this: 1. Adds a "-I UnderTest.ap_" flag when compiling test apks resources 2. Sets the test apk's arsc package name to match the apk_under_test's package name. 3. Uses --emit-ids / --stable-ids to avoid collisions between the test apk and the apk_under_test. 4. Updates incremental install manifest logic to do the same trick. Some other small tweaks to related resource code: * Removes incremental AndroidManifest.xml as an explicit build output * Moves most uses of "aapt dump" to "aapt2 dump" * Removes --check-resources-pkg-id in favor of always enabling it * Removes --optimize-resources in favor of having it implicitly set by --optimized-resources-path Bug: 896775 Change-Id: I6ea2d1ec8d1109bede4e0701eb4c7aeaa2a67503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556395 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#650427}
-
Daniel Cheng authored
Miscellaneous cleanups: - convert to a scoped enum, which reviews some additional static_casts to read/write from a bitfield - explicitly make the enum's underlying type unsigned to match the type of the bitfield - use a switch instead of an if to make it harder to forget to update IsValidPropertyInScope Bug: 842296 Change-Id: I7a6c968e7d16668d0cfbb6897d2ddfb3e7c70a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565713 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
