- 06 Mar, 2020 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 727f2393. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I3dd6f09f7b03fd9589eefb2d3e5a9f602a86ce92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090513Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747602}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/35cb0b3a4697..93a2a6b8badb git log 35cb0b3a4697..93a2a6b8badb --date=short --first-parent --format='%ad %ae %s' 2020-03-06 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c55fbc4064aa..9acaf6626042 (5 commits) 2020-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 7c474dc8..da581c3b (457 commits) Created with: gclient setdep -r src/third_party/skia@93a2a6b8badb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: I9f6bd9d0aa93ed5df8ded06320a6a0932622cf93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091036Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747601}
-
Kenichi Ishibashi authored
The fix (crrev.com/c/2078521) seems to be working. Enable the test. Bug: 946719 Change-Id: Idc66d61775eabb5867df6a00eb3998547fe9cdb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091096Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#747600}
-
Hitoshi Yoshida authored
- Define NativeValueTraits<IDLNullable<DOMArrayBuffer>>'s body - Use NativeValueTraits to convert IDL dictionaries in tests - Replace a setXxxToNull to setXxx - Define V8SetReturnValue for bindings::DictionaryBase Bug: 839389 Change-Id: I672bdf0bd9b5bf6e6a0b8d3b910d5712f4476cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087243Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#747599}
-
Ye Kuang authored
This is to roll https://crrev.com/8803e5127f5b83ecc4bfb9ad86a28abeaa4ef443 Fixed: 1058286 Change-Id: I56aaf35bc93932294f4f18b51924669142f3f9e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089556Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Ye Kuang <yekuang@google.com> Cr-Commit-Position: refs/heads/master@{#747598}
-
Stephen Martinis authored
I found this while looking at the #include dependency graph for browser_tests. I would guess these all got added when they got de-virtualized; https://crrev.com/c/854747 was one such CL, and it looks like they copy pasted a lot of the code, which probably meant the self includes were accidentally added. Change-Id: Ib0556461c118ce2d3698953955735391484616b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090911Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#747597}
-
Xinghui Lu authored
Metrics added in this CL: SafeBrowsing.RT.GetToken.Time SafeBrowsing.RT.HasTokenFromFetcher SafeBrowsing.RT.HasTokenInRequest SafeBrowsing.RT.IsLookupSuccessful Bug: 1041912 Change-Id: I34a0d9cc07f54f76f441e2ff130c59da0b070813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088683 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#747596}
-
Maggie Cai authored
This reverts commit b6bd9b54. Reason for revert: This CL is likely causes the build failure for https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/100478 and https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/64768 Original change's description: > Raw Clipboard: Add Linux platform specific test. > > Bug: 897289 > Change-Id: I26335e58672e915a452dc6ae04dac6d712ccac6b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090914 > Auto-Submit: Darwin Huang <huangdarwin@chromium.org> > Commit-Queue: Victor Costan <pwnall@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747546} TBR=pwnall@chromium.org,huangdarwin@chromium.org Change-Id: Ie15cb8a2f8e9f41b5c392ca25b557a2e34b1ab10 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091097Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#747595}
-
Domenic Denicola authored
This parses the "ids" member according to the spec at https://wicg.github.io/origin-policy/#parse-a-string-into-an-origin-policy, and stores the result in the OriginPolicyContents structure. The results are not yet used by any part of the system, and as such this is not yet web exposed. That will be done in a follow-on patch, which exposes them as self.originPolicyIds after plumbing them through Blink. Bug: 1057123 Change-Id: I66637945486b5bd554605094a0e26b62c44558de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087986Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#747594}
-
David Munro authored
Bug: chromium:858815 Test: Unit tests, manually call and check disk size changes Change-Id: I68bacf5d6865e35f6280ee3e8e8fabeb27a52de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081722 Auto-Submit: David Munro <davidmunro@google.com> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#747593}
-
Ken Rockot authored
This allows out-of-process Storage Service to be sandboxed when a new StorageServiceSandbox feature flag is enabled (disabled by default). The service uses a tight "utility" sandbox which can effectively only operate on chromium's user data dir via an IPC interface to the browser. Bug: 1052045 Change-Id: Iaaf7796f0a9f3fdf252ddec3ad4e247e06760385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079642 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#747592}
-
Henrique Nakashima authored
Bug: 1041473 Change-Id: I864fbe7b072f3095ee688d2cf6f6aed99ea1114a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088731 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#747591}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b26fbdde1b2d..b2d7afd7f7c6 Created with: gclient setdep -r src-internal@b2d7afd7f7c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:976428 Tbr: jbudorick@google.com Change-Id: Iccd8e08ca0f4089ebebad888394c489f4ed5e24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090650Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747590}
-
Jiajun Ou authored
Bug: 1045254 Change-Id: I797f1107a84bd235d0ffd7f69c7d46f11ee1f79a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087232 Commit-Queue: Jiajun Ou <garzonou@google.com> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#747589}
-
My Nguyen authored
Bug: 1049826 Change-Id: Id78d5d9b22f8534588e2adbfa3aa174d27559853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089446 Commit-Queue: My Nguyen <myy@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: My Nguyen <myy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#747588}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8c1ae63310cb..35cb0b3a4697 git log 8c1ae63310cb..35cb0b3a4697 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a095711c5d77..51b2800bb317 (1 commits) 2020-03-05 csmartdalton@google.com Migrate the GPU tessellator to the new bind/draw GrOpsRenderPass API Created with: gclient setdep -r src/third_party/skia@35cb0b3a4697 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: Ide8452a5b829a95966665ebbfe6a9a202a078e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091033Reviewed-by:
-
Kent Tamura authored
Bug: 1052232 Change-Id: Ib5d57aaabaf78d97007d31b8b9a3e3c123f0dea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089437 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#747586}
-
Eugene Zemtsov authored
* MediaMemoryDumper - simple wrapper over MemoryDumpProvider that takes care of registering/unregestering and calling a external callback. * Two instances of MediaMemoryDumper inside of WebMediaPlayerImpl. One runs on the media thread and counts Demuxer's memory, the other runs on the main thread and handles everything else (video, audio, data source). * The fact that demuxers need to be createad and destroyed on the main thread, but used only on the media thread makes things interesting. Bug: 1056839 Change-Id: I9a3386626789ddd1079d4d6759243d7622dea39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084083 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#747585}
-
Ken Rockot authored
This rewrites ChromiumEnv to use the storage::FilesystemProxy API for all filesystem access. By default it will use unrestricted instances with direct filesystem access, effectively equivalent to the status quo. No interesting behavioral or performance changes are expected here. This will allow a follow-up CL to implement sandboxing support for LevelDB by constructing a ChromiumEnv instance over a restricted FilesystemProxy instance. Bug: 1052045 Change-Id: Ic23726b3f5abd3f1a322b49827e80dbf424c3de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080673 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#747584}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/add000e1e5a5..9cabb00b3261 git log add000e1e5a5..9cabb00b3261 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@9cabb00b3261 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I42fae8eb50bf47c45149d83f6368463205555f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091032Reviewed-by:
-
chrome://flagsAvery Musbach authored
Both ash::features::kDragToSnapInClamshellMode and ash::features::kMultiDisplayOverviewAndSplitView shall be exposed in chrome://flags. Bug: 961170, 970013 Change-Id: I5907116012c2527935b29a15f139ed12baac0f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090752Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#747582}
-
Fergal Daly authored
- record whether the main render frame host is being found and is equal to the one we just created (this seems impossible). - record whether the view-host's widget is already initialized. Either of these could cause us to return early from InitRenderFrame without calling SetRenderFrameCreated(true) (full details in the bug). This adds RenderViewHostImpl::GetMainFrameWithoutFallback to get access to the main RFH as seen by the RVH. The naming is not great. This also removed the URL capturing as Android Webview is more strict about PII and strips out strings from the minidump. Our crash key will be whitelisted in separate CL. Bug: 1006814 Change-Id: Ie65ee912533c54a63ad7398290b97a5395b21d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081730 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#747581}
-
Karan Bhatia authored
r744448 added logic to ensure allowAllRequests were always applied to srcdoc frames. That said, the added test is flaky. It seems the fetch can be aborted when the frame unloads causing flakiness. However, waiting for onload event before the fetch causes the request to arrive in the browser after the corresponding navigation commit, defeating the purpose of the test. Since there doesn't seem to be a reliable way to reproduce requests from a frame arriving before a navigation commit, simply delete the test. BUG=1056031 Change-Id: I23fc2fdfe5719a0f10bdce025cf3556840f0c3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088346Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#747580}
-
Zain Afzal authored
This Cl adds a delegate to the guest iframe which is used by the backlight app to call privileged WebUI functions. The only function on the delegate at the present moment is "openFeedbackDialog" which allows the backlight app to send a message to the parent webUI asking it to open the chromeos native feedback dialog. The delegate itself is nothing more then a wrapper over some message pipe calls but by defining the delegate in receiver.js we have a easy way to audit all of the privileged functionality we are exposing to the unprivileged guest iframe. This CL also adds the message pipe end point for opening a feedback dialog and the relevant bootstrap code used to initialize backlight with the WebUI delegate. The actual code which uses this delegate can be seen at cl/298246716 Bug: 996088 Change-Id: Ic2df6fa691cab0fbdaa6639de652e202733466da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082731 Commit-Queue: Zain Afzal <zafzal@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#747579}
-
Andrew Xu authored
The API which fetches the scrollable shelf information is generalized to provide the shelf information, including scrollable shelf and hotseat. Note that the old API getScrollableShelfInfoForState is kept for now. Otherwise, the tast test will fail. The old API will be removed in the following CL. Bug: 1056880 Change-Id: Ie6f3e74db6a1751a515732edb6f6bcae401b045d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079842Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747578}
-
Hiroshige Hayashizaki authored
There were multiple `spec.src.json` for each project directories that have many things in common, e.g. lists of subresources, source contexts, etc. This CL introduces `common/security-features/tools/spec.src.json` that works as the default `spec.src.json`, and moves common things into the default `spec.src.json`. By doing this, we can ensure uniform test coverage across projects (e.g. the same set of subresource requests are covered in `referrer-policy` and `mixed-content` tests) more easily. To keep the generated tests the same, this CL adds exclusion rules named "... not yet tested". This CL doesn't affect test behavior nor generated results. Bug: 906850 Change-Id: Id06bc6e311a482f50531cd36e6da57b2e6df22ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049953 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#747577}
-
Raul Tambre authored
itervalues() no longer exists in Python 3. values() works on both. Traceback (most recent call last): File "../../headless/lib/browser/devtools_api/client_api_generator.py", line 525, in <module> InitializeDomainDependencies(json_api) File "../../headless/lib/browser/devtools_api/client_api_generator.py", line 425, in InitializeDomainDependencies GetDomainDepsFromRefs(domain['domain'], domain) File "../../headless/lib/browser/devtools_api/client_api_generator.py", line 413, in GetDomainDepsFromRefs for value in json.itervalues(): AttributeError: 'dict' object has no attribute 'itervalues' Bug: 941669 Change-Id: I24a888b95ead33b9a9abfdd84f08ac5fc10b4136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089862 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:Johannes Henkel <johannes@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#747576}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/45affde3a9c5..5415e4d9aec4 git log 45affde3a9c5..5415e4d9aec4 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4ea51a0a..70eb5f7c (747324:747482) Created with: gclient setdep -r src/third_party/webrtc@5415e4d9aec4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I442d92d18f4f7a2e4e9e7d7c0c071cee67f1415c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090647Reviewed-by:
-
Maggie Cai authored
This reverts commit 5b257115. Reason for revert: This CL is likely the cause of the failure of build https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81830. Original change's description: > Roll src/third_party/perfetto da7fe17f810a..b583290a6d81 (1 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/da7fe17f810a..b583290a6d81 > > git log da7fe17f810a..b583290a6d81 --date=short --first-parent --format='%ad %ae %s' > 2020-03-05 skyostil@google.com Merge "TrackEvent: Add TrackEvent::GetTraceTimeNs()" > > Created with: > gclient setdep -r src/third_party/perfetto@b583290a6d81 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Tbr: perfetto-bugs@google.com > Change-Id: I36c1e8f1b949e51434368b3f13b66a86ef48166a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089270 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#747228} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: Ib8fe9560dc126eb24e8ffc90d8e47b4ac34d5856 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090563Reviewed-by:
-
Oksana Zhuravlova authored
This change adds more tracing statements to the WebView startup code. Bug: 1019793 Test: trace output has new blocks Change-Id: Ic401ace0999f15456d62e69cc13bdabca05241b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083740Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#747573}
-
Maggie Cai authored
This reverts commit ecfd097c. Reason for revert: Revert this CL because a previous roll is likely to cause the build failure for https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81830. Original change's description: > Roll src/third_party/perfetto b583290a6d81..652ee37df0e7 (1 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/b583290a6d81..652ee37df0e7 > > git log b583290a6d81..652ee37df0e7 --date=short --first-parent --format='%ad %ae %s' > 2020-03-05 ddrone@google.com Merge "Add more fields to ChromeLatencyInfo" > > Created with: > gclient setdep -r src/third_party/perfetto@652ee37df0e7 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Tbr: perfetto-bugs@google.com > Change-Id: I5a366cd53c3adb2bfe781e7d7bc192bb962b6689 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089575 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#747260} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: Ib3ae8e6fee33198df5d3a7b274cfae262b458ff0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089535Reviewed-by:
-
Maggie Cai authored
This reverts commit 2d444bf7. Reason for revert: Revert this CL because a previous roll is likely to cause the build failure for https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81830. Original change's description: > Roll src/third_party/perfetto 652ee37df0e7..7c0409aa3814 (2 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/652ee37df0e7..7c0409aa3814 > > git log 652ee37df0e7..7c0409aa3814 --date=short --first-parent --format='%ad %ae %s' > 2020-03-05 ilkos@google.com Add anon RSS + swap to the java heap stats metric > 2020-03-05 hjd@google.com Merge "Add AndroidProcessMetadata to startup metrics" > > Created with: > gclient setdep -r src/third_party/perfetto@7c0409aa3814 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: chromium:150675972 > Tbr: perfetto-bugs@google.com > Change-Id: I859d8150d98acafb058dd4c348920d39556dc8ac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089584 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#747299} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: I8eb43cc90a4fa6cb19abd49b27965c0952027391 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:150675972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090564Reviewed-by:
-
Luciano Pacheco authored
Bug: 1035691 Change-Id: I5519ac9227cdfd1b57646c943936d338ad23dc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090561 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#747570}
-
Maggie Cai authored
This reverts commit e73d07f9. Reason for revert: Revert this CL because a previous roll is likely to cause the build failure for https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81830. Original change's description: > Roll src/third_party/perfetto 7c0409aa3814..f365c53a18b1 (1 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/7c0409aa3814..f365c53a18b1 > > git log 7c0409aa3814..f365c53a18b1 --date=short --first-parent --format='%ad %ae %s' > 2020-03-05 taylori@google.com Merge "perfetto-ui: Fix counter quantization" > > Created with: > gclient setdep -r src/third_party/perfetto@f365c53a18b1 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Tbr: perfetto-bugs@google.com > Change-Id: I9f1496de8f76cf68115b362d70f759719d2ea452 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090074 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#747341} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: I68933f50c422786b6a219c5cdf0468c895171012 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089448Reviewed-by:
-
Chris Cunningham authored
//services/viz/public/mojom:mojom_blink is multiply included when building blink_unittests. A) it's built into the blink_unittests executable B) it's built into the blink_platform component, which is a dep of blink_unittests This multiple inclusion lead to double definition errors[1] when I tried to add a new test[2] in blink_unittests. The test uses media/mojo/mojom/video_decode_perf_history.mojom-blink.h, generated by //media/mojo/mojom:mojom_blink. //media/mojo/mojom:mojom_blink is *already* a dep of blink_unittests via this chain through blink_platform (component) //third_party/blink/renderer/controller:blink_unittests //third_party/blink/renderer/controller:blink_unittests_sources //third_party/blink/renderer/platform:platform //third_party/blink/renderer/platform:blink_platform_public_deps //third_party/blink/public/mojom:mojom_platform_blink //media/mojo/mojom:mojom_blink //media/mojo/mojom:mojom_blink is *also* a dep of //services/viz/public/mojom:mojom_blink, which is built directly into blink_unittests as a source_set. //third_party/blink/renderer/controller:blink_unittests //third_party/blink/renderer/controller:blink_unittests_sources //third_party/blink/renderer/modules:unit_tests //services/viz/public/mojom:mojom_blink //media/mojo/mojom:mojom_blink This explains the error[1] FAILED: blink_unittests.exe ninja -t msvc ... lld-link: error: duplicate symbol: public: __thiscall media::mojom::blink::PredictionFeatures::PredictionFeatures(void) >defined at obj/media/mojo/mojom/mojom_blink/media_types.mojom-blink.obj >defined at blink_platform.dll Hence, this CL removes multiple inclusion by deleting rules that cause //services/viz/public/mojom:mojom_blink to be directly built into the blink_unittests executable. The blink_platform component is now the sole provider of //services/viz/public/mojom:mojom_blink to blink_unittests. This also required small export_* additions to the viz BUILD.gn to give the viz mojom symbols visibility outside the blink_platform component. Those changes were also made to gpu's BUILD.gn because blink_unittests had come to rely on the viz dependency to provide unexported gpu symbols. [1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8886718386427952624/+/steps/compile__with_patch_/0/stdout [2] https://chromium-review.googlesource.com/c/chromium/src/+/2088494 Change-Id: I1a7cd262f09a08c532479e44572f50360a6ebc40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088493Reviewed-by:Khushal <khushalsagar@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#747568}
-
Maggie Cai authored
This reverts commit e5632385. Reason for revert: Revert this CL because a previous roll is likely to cause the build failure for https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81830. Original change's description: > Roll src/third_party/perfetto f365c53a18b1..0c6dfdbceb9e (1 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/f365c53a18b1..0c6dfdbceb9e > > git log f365c53a18b1..0c6dfdbceb9e --date=short --first-parent --format='%ad %ae %s' > 2020-03-05 ddrone@google.com Merge "Reusing one ProtoToArgsTable instance" > > Created with: > gclient setdep -r src/third_party/perfetto@0c6dfdbceb9e > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Tbr: perfetto-bugs@google.com > Change-Id: Ieff5c397bd14f619342cb0bc10669bd93a970b34 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090217 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#747382} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: Ia980fae75236c001d504f8cb7ed5582f236ef731 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091093Reviewed-by:
-
Maggie Cai authored
This reverts commit fc011bb6. Reason for revert: Revert this CL because a previous roll is likely to cause the build failure for https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81830. Original change's description: > Roll src/third_party/perfetto 0c6dfdbceb9e..7e47609cf293 (1 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/0c6dfdbceb9e..7e47609cf293 > > git log 0c6dfdbceb9e..7e47609cf293 --date=short --first-parent --format='%ad %ae %s' > 2020-03-05 pmuetschard@google.com Adds a LAST_NON_NULL window function to the trace processor. > > Created with: > gclient setdep -r src/third_party/perfetto@7e47609cf293 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Tbr: perfetto-bugs@google.com > Change-Id: I04128556754d1670bd6635b503b300ff5391631f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090228 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#747468} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: I0be90c7070bad2c73d195bb50b43173596363bae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089447Reviewed-by:
-
nancy authored
When the app doesn't exist in AppService, if the PauseApp is called, the app is added to AppService with the app type Unknown, then later when the app is added, the app type is changed to Web or Arc. In theory, the app type should not be changed, so add the app type checking when pause or unpause an app. BUG=1055937 Change-Id: Iafd4befb6f7369977a3693d84994f3453876af7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089445Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747565}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I485710020f44f1135a2ffb659a21d3baec1ebad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089728Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747564}
-
Frank Tang authored
CherryPick fractional second bugs from ICU. https://chromium.googlesource.com/chromium/deps/icu.git/+log/9f4020916..0b6134378 Including the following changes 0b61343 Fix fractional second bug by Frank Tang · 16 minutes ago master 49ee7b1 Make it able to optionally disable thin_archive by Honglin Yu · 9 days ago f9a6fc2 Revert "Add flag for compiling into shared libraries." by Honglin Yu · 9 days ago eb405d8 Add flag for compiling into shared libraries. by Honglin Yu · 4 weeks ago BUG=chromium:1020393, v8:9284, v8:9612, v8:10273 Change-Id: I94692734fe29e783293ec7c98b69ccd8d879b804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090002Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747563}
-
