- 08 Jul, 2020 40 commits
-
-
Luke Sorenson authored
Bug: 1099420 Test: Not necessary. Change-Id: I384df5ad2f2775484138fff11bc98b7a01b8bc27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268200Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#786164}
-
Curtis McMullan authored
The resizable vk metrics will expire in the next few months. This CL is simply extending their expiry date by one year. Bug: 1102475 Change-Id: Iea55442a5a6230e37e8ac4a964c4b9befa1aa630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282544Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Cr-Commit-Position: refs/heads/master@{#786163}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I71bd5a231eaa46cbd30a67ac84a05f8dccb8f244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286463Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786162}
-
Trent Apted authored
Currently, when opening files from the ChromeOS file manager, users see an error trying if the file is from an MTP device or an ARC++ "document provider" mount under the media virtual folder (e.g. "Pictures"). See https://crbug.com/895479 for details about document provider. An approach added in r778183 was to check for a "/provided" path prefix, but this only works for some non-native filesystem types on ChromeOS. Generalise it by asking storage::ExternalMountPoints to lookup the "virtual" path, which contains the path components necessary to extract the filesystem type. Use remains restricted to chrome:// WebUIs on ChromeOS. The code is still covered by tests added in r778183 (i.e. SystemWebAppManagerLaunchDirectoryFileSystemProviderBrowserTest.*). https://crbug.com/1102287 tracks making testing of android volumes possible outside of the files app. Bug: 1099474 Change-Id: I37a0239dec4d9b7c6bba866302db00b5d84941b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279413Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#786161}
-
Tsuyoshi Horo authored
This reverts commit 3557d7dd. Reason for revert: Caused failing on builder "linux-chromeos-chrome" Bug: 1103100 Original change's description: > Assistant: ensure single generic error message > > Assistant processing v2 introduced a situation that allowed > multiple error messages to flush to the screen due to > AssistantInteractionControllerImpl::OnTtsStarted being > called multiple times. > > Add AssistantResponse::ContainsUiElement to check if duplicate > error elements already exist before adding more. > > Bug: b/158499400 > Change-Id: Ia90199ef8b733132fd5433ca47bb7905926b2f6e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258196 > Commit-Queue: Jeffrey Young <cowmoo@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: David Black <dmblack@google.com> > Cr-Commit-Position: refs/heads/master@{#785935} TBR=xiaohuic@chromium.org,dmblack@google.com,updowndota@chromium.org,wutao@chromium.org,meilinw@chromium.org,jeroendh@chromium.org,cowmoo@chromium.org Change-Id: I596b799de09518816642de2c86398849939f5d99 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/158499400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286531Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#786160}
-
Liquan (Max) Gu authored
Before: PaymentRequestImpl implements PaymentRequest After: ComponentPaymentRequestImpl implements PaymentRequest, and delegate the implementation to PaymentRequestImpl. Bug: 1102522 Change-Id: I3e3ea0b6a0abb12f4efa983dc8ee697117f40095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285243 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#786159}
-
Hazem Ashmawy authored
WebViewCollectNonEmbeddedMetrics feature flag has been removed in crrev.com/c/2252082 and there is no need to test this config any more. Bug: 1001185, b/157911640 Test: N/A Change-Id: I1c94b1c24f8b8a488eef94f4ccd5697ca2043643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283210 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#786158}
-
Toby Huang authored
This CL adds browser tests to parent_permission_dialog_view_ browsertest.cc for the Parent Permission and the Extension Install Blocked By Parent dialogs launching from the extension Management API. This CL also adds unit tests to management_api_unittest.cc for the same two dialogs launching from a background page, where there's no active web contents. Bug: 1083275 Change-Id: I34db7aee30d5153b8dbc348572522e0f16555d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220816 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786157}
-
jchen10 authored
This takes into account the color spaces of pixel data from ImageBitmap being encoded into VideoFrame. Bug: 897297 Change-Id: I5ee5b77eb067ce8f5cec91dbd584a1553f6e91f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272134 Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#786156}
-
Mansi Awasthi authored
Original CL: http://crrev.com/c/2275981 Revert: http://crrev.com/c/2284446 Reason for revert: Builder: Linux ChromiumOS MSan Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/b8875468439609281712 The failures were caused as |push_button.is_read_only| was not initialized in TestButtonNodeCreation before usage. This CL fixes this issue. Original description: This CL creates button nodes using PdfAccessibilityButtonInfo sent from plugin process and inserts them in the PdfAccessibilityTree. This CL also includes test to validate the creation of button nodes in PdfAccessibilityTree. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_chromeos_msan_rel_ng Bug: 1030242 Change-Id: Id821ea02f92c20b5f5eb3190e4d878c6bd52edea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284505Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Cr-Commit-Position: refs/heads/master@{#786155} -
mhasank authored
Introducing cloud dpc error enum values to be used for showing helpful error messages on the UI BUG=b:62613791 TEST=deploy to dut, disable playstore, re-enable playstore, successfully finish the authorization flow Change-Id: I8bb83f7366260f1a09223e2791e5cfab7e94ca68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268468 Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Auto-Submit: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I030e23a8532cc0ce73ca1f0b73893a0c717a2676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286469Reviewed-by:
-
Victor Costan authored
Change-Id: I94dbcfd3e5114b23433900397ec023c5d7513545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281551 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#786152}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8c11a5b522cd68c7cce8ccbf30a146a9459cbbbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286460Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5e2efe33ef0e..90b0c9e859ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC horo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1075380,chromium:1090060,chromium:1090397,chromium:1093366,chromium:1094282,chromium:1102355,chromium:1102832 Tbr: horo@google.com Change-Id: I68f907df94425a06e5ae137922a747d99d6fe3ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286409Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786150}
-
Ryo Hashimoto authored
Move arc-related D-Bus clients to a new directory chromeos/dbus/arc BUG=None TEST=build Change-Id: Ica5aed4e46fc2350f238eb8227c089e84988e1cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280806Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#786149}
-
Tom Anderson authored
Since we never initialize the libxrandr (by calling XRRQueryVersion), Xlib cannot decode the incoming randr notify events. This causes a crash in XRRUpdateConfiguration. This CL solves the issue by removing all calls to XRRUpdateConfiguration, which updates the XDisplay screen dimensions. This data is only used in the following APIs: XDisplayWidth XDisplayHeight XDisplayCells XDisplayWidthMM XDisplayHeightMM XWidthOfScreen XHeightOfScreen XWidthMMOfScreen XHeightMMOfScreen DisplayWidth DisplayHeight DisplayCells DisplayWidthMM DisplayHeightMM WidthOfScreen HeightOfScreen WidthMMOfScreen HeightMMOfScreen Therefore, this CL also adds a PRESUBMIT check to ensure they aren't being used. Since this is the last usage of libxrandr, the build config for it is removed. R=nickdiego,sky Bug: 1102059 Change-Id: Ib60811259ae23ffa8af9c50e0bb3d4ac2158e5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285068 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#786148}
-
Kunihiko Sakamoto authored
In follow-up CLs, this factory will be created by LinkWebBundle, and will be used to load subresources from Web Bundles. Bug: 1082020 Change-Id: I231e8c85f740e3588c2ba4c518378cd26a36a79d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275986Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#786147}
-
Angela Yoeurng authored
The vague BUTTON_FOCUSED selection state was refactored into the more descriptive FOCUSED_BUTTON_FOO states. MaybeTriggerSecondaryButton is also deprecated and unit tests updated. Bug: 1099043 Change-Id: Ib79b829a51552c55349f204fa1702a85317bb803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284384 Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#786146}
-
Jia authored
Our upcoming client has code in src/chromeos/components and cannot depend on local search service that's in src/chrome. Hence we need to move local search service to src/chromeos/components. Some library functions used by local search service are in src/chrome/common/string_matching. This cl moves these functions to src/chromeos/components/string_matching. The next cl will move local search service itself. Bug: 1102232 Change-Id: I3d17b22b918cd3d1c55d40ef4aa6509da6b28957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281798 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
testTabNavigationHistoryDoNotLeakBetweenActivities__INCOGNITO_CCT_REGULAR_TAB is flaky TBR=roagarwal@chromium.org,roagarwal@chromium.org,peconn@chromium.org,bsazonov@chromium.org,rhalavati@chromium.org Bug: 1102755 Change-Id: I8deda3ce5feeef1ef07492c099ce7394dbead235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286250 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
TBR=asvitkine@chromium.org,treib@chromium.org,caitlinfischer@chromium.org,vincb@chromium.org Bug: 1102747,1102746 Change-Id: I0a778f226ee3ea9ac31c13fcb7dba88019881c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286529 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
Peter Kasting authored
This was the only consumer of it, so this scopes the usage more narrowly. Bug: none Change-Id: I200653b423e6538ee8d0b42a28ea7195853a6c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283401 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#786142}
-
Christopher Cameron authored
TBR=kbr@chromium.org Bug: 1098311 Change-Id: Ib0d18ff93b075e80f63668716a9469dc98e3f183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286050Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#786141}
-
Maggie Chen authored
This reverts commit 14ce0d3e. Reason for revert: <We are going to DumpWithoutCrashing() again and see if we can fix the magic signature at the same time.> Original change's description: > Revert "Update the GPU process termination code in the GPU watchdog." > > This reverts commit d2e5eb35. > > Reason for revert: <This CL changes the magic signatures in the crash report. Now [GPU hang] becomes [Dump without crash]. Also all signatures that used to show in the hanging functions are now combined into one watchdog function DeliberatelyTerminateToRecoverFromHang(). This is not what it is supposed to be in the crash reports.> > > Original change's description: > > Update the GPU process termination code in the GPU watchdog. > > > > Remove the old code "*((volatile int*)0) = 0x1337" so the crash is > > separated from other EXCEPTION_ACCESS_VIOLATION buckets for UMA analysis. > > Use DumpWithoutCrashing() then TerminateProcess instead. > > > > Bug: 949839 > > Change-Id: I29c735aea2d2063043e6a5da80842d62dddf2e34 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940552 > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Will Harris <wfh@chromium.org> > > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > > Commit-Queue: Maggie Chen <magchen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#723219} > > TBR=jam@chromium.org,zmo@chromium.org,wfh@chromium.org,magchen@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 949839 > Change-Id: Ief563313ec634a45f5710ab6ebfa5dacfcf11c72 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962981 > Reviewed-by: Maggie Chen <magchen@chromium.org> > Commit-Queue: Maggie Chen <magchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#724102} TBR=jam@chromium.org,zmo@chromium.org,wfh@chromium.org,magchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1102672 Change-Id: I4b4b0307181620dff8ca5c8535a1bfb3da53a8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285769Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786140}
-
Pavel Yatsuk authored
PrivacyWall requested to update their assets (tracked in crbug.com/1100408). This CL makes corresponding changes. BUG=1100408 R=orinj@chromium.org Change-Id: I3e410933c3996fff795ac6230e9bd17e644686a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285871Reviewed-by:
Orin Jaworski <orinj@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#786139}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I2f77959e8b6a961fb6e57d7907488e8b9b605925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286570Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786138}
-
Ovidio Henriquez authored
This change adds a tab indicator that is visible when a Bluetooth scan session is active. A scan session may be started through the Web Bluetooth API's watchAdvertisements() method or through the Web Bluetooth Scanning API's requestLEScan() method. Design Doc: https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM Bug: 1099914 Change-Id: Ieb1bc385b5da6d2c8a98bdf263751fe549c097a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270815 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Carlos Pizano <cpu@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786137}
-
Peter Kasting authored
This eliminates a virtual method from NonClientFrameView and a dedicated call to it, as well as a WidgetObserver subclass just to monitor this signal. This will be useful in refactoring how Button notifies interested parties of state changes. Bug: None Change-Id: I133f8e6521f33710b6b622f21406abea3693d524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280721Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#786136}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/c9336155e045..09cdba8cd4a6 2020-07-08 mfoltz@chromium.org [Open Screen] Style guide update. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I23569b4c2189b2f1532f39e0a2c9bdefa596d6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285893Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bb61fe324575..473c9f4cd9b2 2020-07-08 dmazzoni@chromium.org Tagged PDF annotations must appear in the Parent Tree as well. 2020-07-07 nifong@google.com Move frame measurement code into shared location 2020-07-07 bungeman@google.com Mark SkGetThreadID SK_SPI in debug. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1100712 Tbr: mtklein@google.com Change-Id: I877d35949175da79f729aa8cc2f13eb4781f5446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285891Reviewed-by:
-
Yi Xu authored
Added some perf tests to measure speed of clearRect. Bug: 1054666 Change-Id: Id902281ca2c85c2d1ebc89bac05ea4d85d756969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240348Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#786133}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ibd331c6d125bbc684ff5e14d61724aac6f06dd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286049Reviewed-by:
-
Tsuyoshi Horo authored
This reverts commit 72158dea. Reason for revert: Caused build failure on builder "WebKit Linux Leak" Bug: 1103082 Original change's description: > Fix UAF in SelectType > > This fixes the UAF detected by ClusterFuzz in [1], caused by [2]. > The test case added here is a minimized version of the clusterfuzz > case, and I verified that it crashes (ASAN UAF) before this patch > and no longer crashes after. > > [1] https://clusterfuzz.com/testcase-detail/6224868955193344 > [2] https://chromium-review.googlesource.com/c/chromium/src/+/1912682 > > Fixed: 1102408 > Change-Id: Ieb6a9582ff5b9676596048920bbcff881fdc2eb2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283901 > Commit-Queue: Mason Freed <masonfreed@chromium.org> > Auto-Submit: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#785970} TBR=tkent@chromium.org,masonfreed@chromium.org Change-Id: I5fe02886b22a278ac7ae33b9e63542ec7b3bb10c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286432Reviewed-by:
-
Jing Wang authored
Some details: - Suggestions/settings link will be highlighted when using down/up to navigate - Tab/Right no longer commits suggestions. - If user keeps typing after a suggestion is highlighted, we cancel the highlight. Test: add unit test and tested with Chrome on Linux Bug: 1099498 Change-Id: If890b9d39fa86e55398841c2a8038922d59488f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269157Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#786130}
-
Jarryd authored
Change-Id: I164a3e7233fe2e7d07fc6e5b05adc68b04022ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285909 Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786129}
-
Rakina Zata Amni authored
The new values for ShouldSwapBrowsingInstance are added in crrev.com/c/2121522, so we need to update the label for the corresponding metric values. See https://source.chromium.org/chromium/chromium/src/+/master:content/browser/frame_host/should_swap_browsing_instance.h;l=14;drc=50d126fbc5e2629e3f2eaf69c2da37b57e118532 Bug: 977562 Change-Id: I1ba5d97d7ea3be23e0ce886f57616d1c1be0cb54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282736Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#786128}
-
Michael Crouse authored
This change prevents LiteVideos from being attempted when the navigation is a reload or forward-back page transition. It also adds an entry for host of the navigation to the user blocklist to allow users to soft opt-out of the optimization if they reload frequently on a host. A future change will clear the blocklist when the browser history is wiped. Bug: 1096796 Change-Id: I687d4c9cd0844d7475f6a3baedacebcf73a48845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276681 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#786127}
-
Josh Simmons authored
Also renaming PerformanceHintsRewriteHandler to RewriteHandler, since the namespace already disambiguates. Change-Id: I9a1575b6990fa9736f47d237a71309fa3a6c55a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276765 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#786126}
-
Nate Fischer authored
This extends Safe Browsing histograms. We still use these histograms periodically to compare WebView and Chrome Safe Browsing behavior, so this extends the histograms one year. This adds WebView team as a second owner. Fixed: 1089421, 1089441 Test: N/A Change-Id: I6ed05b4d1b586a5d210190d6c7f615c6bafb4ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285481 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
